tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: clang/test/Driver/hip-fpie-option.hip:34
+
+// DEV-DAG: {{".*clang.*".* "-triple" "amdgcn-amd-amdhsa".*
"-mrelocation-model" "pic" "-pic-level" "[1|2]" "-mframe-pointer=all"}}
+// HOST-STATIC-DAG: {{".*clang.*".* "-triple" "x86_64-unknown-linux-gnu".*
"-mrelocation-model" "static"}}
----------------
Should there be some sort of `DEV-NOT: -pic-is-pie` instead? This line seems to
implicitly rely on -pic-is-pie` would come before `-mframe-pointer` and it's
not at all obvious that the key is the absence of `-pic-is-pie`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88425/new/
https://reviews.llvm.org/D88425
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
