sammccall added inline comments.
================
Comment at: clang-tools-extra/clangd/support/MemoryTree.cpp:28
+ size_t ChildrenSize = 0;
+ for (const auto &C : Children) {
+ C.traverseTree(CollapseDetails,
----------------
Here the detailed nodes are entirely collapsed. This isn't quite as powerful as
collapsing the detail *edges* only, which is worth considering.
e.g. consider TUScheduler. The natural accounting of resources is (IMO)
```
clangd.TUScheduler.<filename>.AST
clangd.TUScheduler.<filename>.Preamble.InMemory
clangd.TUScheduler.<filename>.Preamble.Inputs
```
or something like that.
Instead of aggregating to `clangd.TUScheduler` only, collapsing the
`<filename>` edges mean you get `clangd.TUScheduler.AST` etc.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88411/new/
https://reviews.llvm.org/D88411
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
