[PATCH] D85502: [clangd] Add more error details on the remote index server side

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monore

[PATCH] D85417: [clangd] Fix crash in bugprone-bad-signal-to-kill-thread clang-tidy check.

ArcsinX added a comment. In D85417#2199830 , @ArcsinX wrote: > In D85417#2199694 , @hokein wrote: > >> Looks like NotNullTerminatedResultCheck.cpp also has this pattern, we may >> want to fix that as well. > > Yes,

[PATCH] D85417: [clangd] Fix crash in bugprone-bad-signal-to-kill-thread clang-tidy check.

hokein added a comment. In D85417#2201953 , @ArcsinX wrote: > In D85417#2199830 , @ArcsinX wrote: > >> In D85417#2199694 , @hokein wrote: >> >>> Looks like NotNullTerminatedR

[PATCH] D85503: [clangd] Have template template arguments target their referenced template decl

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. nridge requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. As part of this change, DynTypedNode is enhanced to allow storing

[PATCH] D85500: [clangd] Highlight structured bindings at local scope as LocalVariable

nridge updated this revision to Diff 283827. nridge added a comment. Fix clang-tidy warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85500/new/ https://reviews.llvm.org/D85500 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp clang

[clang-tools-extra] 57f9518 - [clangd] Highlight structured bindings at local scope as LocalVariable

Author: Nathan Ridge Date: 2020-08-07T03:23:10-04:00 New Revision: 57f9518bf032d773c35c86ec99983a47849fd322 URL: https://github.com/llvm/llvm-project/commit/57f9518bf032d773c35c86ec99983a47849fd322 DIFF: https://github.com/llvm/llvm-project/commit/57f9518bf032d773c35c86ec99983a47849fd322.diff

[PATCH] D85500: [clangd] Highlight structured bindings at local scope as LocalVariable

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG57f9518bf032: [clangd] Highlight structured bindings at local scope as LocalVariable (authored by nridge). Repository: rG LLVM Github Monorepo CH

[PATCH] D85417: [clangd] Fix crash in bugprone-bad-signal-to-kill-thread clang-tidy check.

hokein added a comment. Thinking more about this, > Inside clangd, clang-tidy checks don't see preprocessor events in the > preamble. > This leads to Token::PtrData == nullptr for tokens that the macro is defined > to. > E.g. #define SIGTERM 15: > > Token::Kind == tok::numeric_constant (Token::

[clang] f3cc4df - Revert "[CMake] Simplify CMake handling for zlib"

Author: Christian Kühnel Date: 2020-08-07T09:36:49+02:00 New Revision: f3cc4df51da4331b170065e01a6a80ee05ed0c23 URL: https://github.com/llvm/llvm-project/commit/f3cc4df51da4331b170065e01a6a80ee05ed0c23 DIFF: https://github.com/llvm/llvm-project/commit/f3cc4df51da4331b170065e01a6a80ee05ed0c23.di

[PATCH] D85503: [clangd] Have template template arguments target their referenced template decl

hokein added a comment. The code looks good. I think we'd better to have some sort of tests in clang (rather than relying on clangd test). It seems that the only way to test it in clang is through ASTMatcher. Do you mind adding a `templateArgumentLoc` matcher as well? and add a test in `unitt

[PATCH] D85417: [clangd] Fix crash in bugprone-bad-signal-to-kill-thread clang-tidy check.

ArcsinX added a comment. In D85417#2201973 , @hokein wrote: > Thinking more about this, > >> Inside clangd, clang-tidy checks don't see preprocessor events in the >> preamble. >> This leads to Token::PtrData == nullptr for tokens that the macro is defined

[PATCH] D85507: [VE] Remove obsoleted getVEAsmModeForCPU function

kaz7 created this revision. kaz7 added reviewers: simoll, k-ishizaka. kaz7 added projects: clang, VE. Herald added a subscriber: cfe-commits. kaz7 requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D85507 Files: clang/lib/Driver/ToolChains/Arch/VE

[PATCH] D85507: [VE] Remove obsoleted getVEAsmModeForCPU function

simoll accepted this revision. simoll added a comment. This revision is now accepted and ready to land. Feel free to commit something like this without review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85507/new/ https://reviews.llvm.org/D85507

[PATCH] D85367: [clang, test, Darwin] Fix tests expecting Darwin target

This revision was automatically updated to reflect the committed changes. Closed by commit rG6dc863cd858f: [clang, test, Darwin] Fix tests expecting Darwin target (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85367/new/ https:/

[clang] 6dc863c - [clang, test, Darwin] Fix tests expecting Darwin target

Author: Thomas Preud'homme Date: 2020-08-07T09:21:31+01:00 New Revision: 6dc863cd858f32ef0060c46edda2ab56a3cf76b4 URL: https://github.com/llvm/llvm-project/commit/6dc863cd858f32ef0060c46edda2ab56a3cf76b4 DIFF: https://github.com/llvm/llvm-project/commit/6dc863cd858f32ef0060c46edda2ab56a3cf76b4.

[PATCH] D85473: [Clang] Add option to allow marking pass-by-value args as noalias.

fhahn updated this revision to Diff 283837. fhahn added a comment. Thanks for taking a look! I adjusted the LangOpts description and added the flag to f_Group, as suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85473/new/ https://reviews.

[PATCH] D84600: [Analyzer] Support note tags for smart ptr checker

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LGTM, thanks! I think all the problems that left should be solved in a separate patch or even out of the scope for the GSoC. Comment at: clang/lib/StaticAnalyzer/Chec

[PATCH] D85319: [analyzer][RFC] Get info from the LLVM IR for precision

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Frontend/FrontendActions.cpp:30 + // markers which are used by some LLVM analysis (e.g. AliasAnalysis). + CGO.OptimizationLevel = 2; // -O2 + TODO overwrite ALL optimization related config. Ar

[PATCH] D85319: [analyzer][RFC] Get info from the LLVM IR for precision

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Frontend/FrontendActions.cpp:30 + // markers which are used by some LLVM analysis (e.g. AliasAnalysis). + CGO.OptimizationLevel = 2; // -O2 + martong wrote: > TODO overwrite ALL optimization

[PATCH] D74054: [clangd] Include the underlying decls in go-to-definition.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:997 +)cpp", +R"cpp( + class Foo {}; this is basically the same as th

[PATCH] D85427: [SyntaxTree][NFC] remove redundant namespace-specifiers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGba41a0f7339c: [SyntaxTree][NFC] remove redundant namespace-specifiers (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] ba41a0f - [SyntaxTree][NFC] remove redundant namespace-specifiers

Author: Eduardo Caldas Date: 2020-08-07T08:45:29Z New Revision: ba41a0f7339c8cbd065f032cc5f8c1d87a74e124 URL: https://github.com/llvm/llvm-project/commit/ba41a0f7339c8cbd065f032cc5f8c1d87a74e124 DIFF: https://github.com/llvm/llvm-project/commit/ba41a0f7339c8cbd065f032cc5f8c1d87a74e124.diff LOG

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

theraven added a comment. This feature looks generally useful. A few small suggestions: - This is really a way of transforming a formal protocol into an informal protocol. Objective-C has had a convention of informal protocols since the '80s, but they're implemented as categories on the root

[PATCH] D85282: [Concepts] Dump template arguments for immediately declared constraint.

hokein updated this revision to Diff 283841. hokein added a comment. address review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85282/new/ https://reviews.llvm.org/D85282 Files: clang/include/clang/AST/ASTNodeTraverser.h clang/lib/A

[PATCH] D85485: Fix quiet mode in git-clang-format

serge-sans-paille accepted this revision. serge-sans-paille added inline comments. This revision is now accepted and ready to land. Comment at: clang/tools/clang-format/git-clang-format:151 if not changed_lines: -print('no modified files to format') +if opts.verbose >=

[PATCH] D85282: [Concepts] Dump template arguments for immediately declared constraint.

hokein added a comment. In D85282#2198737 , @nridge wrote: > This patch has helped me understand the difference between the two > `ConceptReference`s in the AST (the `TypeConstraint` and the > `ConceptSpecializationExpr`). > > Given that > > `template R

[clang] 6717476 - [AST][RecoveryExpr] Fix the missing type when rebuilding RecoveryExpr in TreeTransform.

Author: Haojian Wu Date: 2020-08-07T11:15:19+02:00 New Revision: 67174765db527ed1911f33109a34026f3913601d URL: https://github.com/llvm/llvm-project/commit/67174765db527ed1911f33109a34026f3913601d DIFF: https://github.com/llvm/llvm-project/commit/67174765db527ed1911f33109a34026f3913601d.diff LO

[PATCH] D85423: [AST][RecoveryExpr] Fix the missing type when rebuilding RecoveryExpr in TreeTransform.

This revision was automatically updated to reflect the committed changes. Closed by commit rG67174765db52: [AST][RecoveryExpr] Fix the missing type when rebuilding RecoveryExpr in… (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8

[PATCH] D85507: [VE] Remove obsoleted getVEAsmModeForCPU function

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3ac1eb6358b1: [VE] Remove obsoleted getVEAsmModeForCPU function (authored by kaz7). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 3ac1eb6 - [VE] Remove obsoleted getVEAsmModeForCPU function

Author: Kazushi (Jam) Marukawa Date: 2020-08-07T18:20:34+09:00 New Revision: 3ac1eb6358b172f54788def4125f80ddd9170d8e URL: https://github.com/llvm/llvm-project/commit/3ac1eb6358b172f54788def4125f80ddd9170d8e DIFF: https://github.com/llvm/llvm-project/commit/3ac1eb6358b172f54788def4125f80ddd9170

[clang-tools-extra] 01bc708 - [NFC] Replace hasName in loop for hasAnyName

Author: Nathan James Date: 2020-08-07T10:22:45+01:00 New Revision: 01bc708126c55c94495d0b55cb2003f67b9b24bf URL: https://github.com/llvm/llvm-project/commit/01bc708126c55c94495d0b55cb2003f67b9b24bf DIFF: https://github.com/llvm/llvm-project/commit/01bc708126c55c94495d0b55cb2003f67b9b24bf.diff

[PATCH] D74054: [clangd] Include the underlying decls in go-to-definition.

hokein updated this revision to Diff 283851. hokein marked 2 inline comments as done. hokein added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74054/new/ https://reviews.llvm.org/D74054 Files: clang-tools-extra/clan

[PATCH] D74054: [clangd] Include the underlying decls in go-to-definition.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa70161808bcd: [clangd] Include the underlying decls in go-to-definition. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang-tools-extra] a701618 - [clangd] Include the underlying decls in go-to-definition.

Author: Haojian Wu Date: 2020-08-07T11:39:49+02:00 New Revision: a70161808bcd6560e268aecf90138ff68f41fe54 URL: https://github.com/llvm/llvm-project/commit/a70161808bcd6560e268aecf90138ff68f41fe54 DIFF: https://github.com/llvm/llvm-project/commit/a70161808bcd6560e268aecf90138ff68f41fe54.diff LO

[PATCH] D85426: [clangd] Implement FileFilter for the indexer

sammccall added a comment. In D85426#2199501 , @kbobyrev wrote: > @sammccall This is the change I was talking about during the standup: the > code looks legit, but `BackgroundIndexTests.IndexTwoFiles` fails because with > the following code path in `Back

[PATCH] D84520: [Analyzer] Improve invalid dereference bug reporting in DereferenceChecker.

balazske updated this revision to Diff 283856. balazske added a comment. Herald added a subscriber: whisperity. NFC changes, added some tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84520/new/ https://reviews.llvm.org/D84520 Files: clang/

[PATCH] D85157: [Sema] Add casting check for fixed to fixed point conversions

vabridgers updated this revision to Diff 283858. vabridgers added a comment. address Bjorn's comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85157/new/ https://reviews.llvm.org/D85157 Files: clang/lib/Sema/SemaCast.cpp clang/test/Sema/wa

[PATCH] D85157: [Sema] Add casting check for fixed to fixed point conversions

vabridgers marked an inline comment as done. vabridgers added inline comments. Comment at: clang/test/Sema/warn-bad-function-cast.c:49 +#ifdef FIXED_POINT + (void)(_Fract) if1(); // no warning +#endif bjope wrote: > bjope wrote: > > vabridgers wrote: > > > bjope

[PATCH] D85157: [Sema] Add casting check for fixed to fixed point conversions

vabridgers marked 4 inline comments as done. vabridgers added a comment. All comments marked as done. ok to land? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85157/new/ https://reviews.llvm.org/D85157

[clang] 24cca30 - Remove unreachable return (PR47026)

Author: Simon Pilgrim Date: 2020-08-07T11:23:43+01:00 New Revision: 24cca30f7f0de49e77af7e8c7719680daec2418e URL: https://github.com/llvm/llvm-project/commit/24cca30f7f0de49e77af7e8c7719680daec2418e DIFF: https://github.com/llvm/llvm-project/commit/24cca30f7f0de49e77af7e8c7719680daec2418e.diff

[PATCH] D81930: [AArch64] Add -mmark-bti-property flag.

chill requested changes to this revision. chill added inline comments. This revision now requires changes to proceed. Herald added a subscriber: dang. Comment at: llvm/lib/Target/AArch64/AArch64.td:352 +def FeatureEmitNoteBTIProperty : SubtargetFeature<"markbtiproperty", "Mark

[PATCH] D85009: [Sema][BFloat] Forbid arithmetic on vectors of bfloat.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1d782942500b: [Sema][BFloat] Forbid arithmetic on vectors of bfloat. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85009/new/ ht

[clang] 1d78294 - [Sema][BFloat] Forbid arithmetic on vectors of bfloat.

Author: Simon Tatham Date: 2020-08-07T11:25:19+01:00 New Revision: 1d782942500b2cbc9765ccf16264bb498850cefb URL: https://github.com/llvm/llvm-project/commit/1d782942500b2cbc9765ccf16264bb498850cefb DIFF: https://github.com/llvm/llvm-project/commit/1d782942500b2cbc9765ccf16264bb498850cefb.diff

[clang] ffd258f - Remove unreachable return (PR47028)

Author: Simon Pilgrim Date: 2020-08-07T11:33:23+01:00 New Revision: ffd258f7bbba2a65800970fcea6648fb285d95f4 URL: https://github.com/llvm/llvm-project/commit/ffd258f7bbba2a65800970fcea6648fb285d95f4 DIFF: https://github.com/llvm/llvm-project/commit/ffd258f7bbba2a65800970fcea6648fb285d95f4.diff

[clang] 18212cb - Remove duplicate/unreachable break (PR47029)

Author: Simon Pilgrim Date: 2020-08-07T11:48:48+01:00 New Revision: 18212cbcdadd130e5b2d1bc2bb38e4396ef8a46f URL: https://github.com/llvm/llvm-project/commit/18212cbcdadd130e5b2d1bc2bb38e4396ef8a46f DIFF: https://github.com/llvm/llvm-project/commit/18212cbcdadd130e5b2d1bc2bb38e4396ef8a46f.diff

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

lxfind added a comment. @phosek, Under this change, now when I build LLVM (with a basic config `cmake -G Ninja --LLVM_ENABLE_PROJECTS="clang" ../llvm`), in file `build_dir/lib/cmake/llvm/LLVMExports.cmake`, I see this: set_target_properties(LLVMSupport PROPERTIES INTERFACE_LINK_LIBRARIES

[PATCH] D82317: [Clang/Test]: Update tests where `noundef` attribute is necessary

jdoerfert added a comment. In D82317#2200789 , @rjmccall wrote: > Are you seriously adding an attribute to literally every argument and return > value? Why is this the right representation? As far as I understand, this should not be literally every argu

[PATCH] D82317: [Clang/Test]: Update tests where `noundef` attribute is necessary

guiand added a comment. In D82317#2200789 , @rjmccall wrote: > Are you seriously adding an attribute to literally every argument and return > value? Why is this the right representation? This adds an attribute to every argument and return value where th

[PATCH] D82317: [Clang/Test]: Update tests where `noundef` attribute is necessary

eugenis added a comment. In D82317#2200789 , @rjmccall wrote: > Are you seriously adding an attribute to literally every argument and return > value? Why is this the right representation? We've discussed quite a few options in D81678

[PATCH] D82317: [Clang/Test]: Update tests where `noundef` attribute is necessary

guiand added a comment. In D82317#2200809 , @jrtc27 wrote: > At the very least, make whatever script you used to update these public, as I > don't want to have to recreate it from scratch when merging this in. I had > enough "fun" with the LLD mass-renam

[PATCH] D82317: [Clang/Test]: Update tests where `noundef` attribute is necessary

rjmccall added a comment. In D82317#2200964 , @guiand wrote: > In D82317#2200789 , @rjmccall wrote: > >> Are you seriously adding an attribute to literally every argument and return >> value? Why is this the right

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek added a comment. How can I test this change on pre-merge bots? I haven't seen any builds posted on this change before. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews.llvm.org/D79219 ___

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

kuhnel added a comment. In D79219#2202048 , @phosek wrote: > How can I test this change on pre-merge bots? I haven't seen any builds > posted on this change before. You can just look at the mlir-windows buildbot, this also showed the failing build: http

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

kuhnel added a comment. This patch broke the Windows compilation on buildbot and pre-merge testing . So I'll revert it to get pre-merge testing back online. Otherwise th

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek added a comment. In D79219#2201109 , @lxfind wrote: > @phosek, Under this change, now when I build LLVM (with a basic config `cmake > -G Ninja --LLVM_ENABLE_PROJECTS=clang ../llvm`), in file > `build_dir/lib/cmake/llvm/LLVMExports.cmake`, I see th

[PATCH] D82317: [Clang/Test]: Update tests where `noundef` attribute is necessary

guiand added a comment. Most of the discussion has been in https://reviews.llvm.org/D81678 (implementing the attribute in clang) and https://reviews.llvm.org/D82316 (adding the attribute to langref). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek added a comment. In D79219#2201994 , @kuhnel wrote: > This patch broke the Windows compilation on buildbot > and pre-merge > testing

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

kuhnel added a comment. > Looking at the error, it seems like you have a 32-bit version of zlib > installed and in your search path on a 64-bit version of Windows. I'm not > quite sure how to handle that in CMake. For mlir-windows buildbot: I have no clue on what is installed there. For pre-me

[PATCH] D55307: [analyzer] MoveChecker Pt.6: Suppress the warning for the few move-safe STL classes.

RKSimon added inline comments. Herald added subscribers: steakhal, ASDenysPetrov, martong, Charusso. Comment at: lib/StaticAnalyzer/Checkers/MoveChecker.cpp:81 + "optional", + "packaged_task" + "promise", @NoQ https://bugs.llvm.org/show_bug.cgi?id=

[PATCH] D85157: [Sema] Add casting check for fixed to fixed point conversions

bjope accepted this revision. bjope added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85157/new/ https://reviews.llvm.org/D85157 ___ cf

[PATCH] D85312: [ADT] Move FixedPoint.h from Clang to LLVM.

ebevhan updated this revision to Diff 283873. ebevhan added a comment. Fix some formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85312/new/ https://reviews.llvm.org/D85312 Files: clang/include/clang/AST/APValue.h clang/include/clang/A

[PATCH] D84348: WIP: Add complete id-expression support to syntax trees

eduucaldas updated this revision to Diff 283875. eduucaldas added a comment. rebase to add this commit from a further patch - [SyntaxTree] Fix crash on name specifier. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84348/new/ https://reviews.llvm.o

[PATCH] D84781: [SyntaxTree] Use PointerUnion instead of inheritance for alternative clauses in NNS

eduucaldas updated this revision to Diff 283876. eduucaldas added a comment. Remove Fix crash on name specifier commit from patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84781/new/ https://reviews.llvm.org/D84781 Files: clang/include/clang

[PATCH] D85417: [clangd] Fix crash in bugprone-bad-signal-to-kill-thread clang-tidy check.

hokein added a comment. In D85417#2202046 , @ArcsinX wrote: > In D85417#2201973 , @hokein wrote: > >> Thinking more about this, >> >>> Inside clangd, clang-tidy checks don't see preprocessor events in the >>> pream

[clang] 351aac0 - [Sema] Add casting check for fixed to fixed point conversions

Author: Vince Bridgers Date: 2020-08-07T07:58:53-05:00 New Revision: 351aac09854399dfb3abb581ef1762a9cd2e4991 URL: https://github.com/llvm/llvm-project/commit/351aac09854399dfb3abb581ef1762a9cd2e4991 DIFF: https://github.com/llvm/llvm-project/commit/351aac09854399dfb3abb581ef1762a9cd2e4991.diff

[PATCH] D85157: [Sema] Add casting check for fixed to fixed point conversions

This revision was automatically updated to reflect the committed changes. Closed by commit rG351aac098543: [Sema] Add casting check for fixed to fixed point conversions (authored by vabridgers, committed by einvbri ). Changed prior to commit: https://reviews.llvm

[clang-tools-extra] 90d1c66 - [clangd] Fix a typo, NFC.

Author: Haojian Wu Date: 2020-08-07T15:02:06+02:00 New Revision: 90d1c66c7ce48fdaabd842786034e301fdd40fff URL: https://github.com/llvm/llvm-project/commit/90d1c66c7ce48fdaabd842786034e301fdd40fff DIFF: https://github.com/llvm/llvm-project/commit/90d1c66c7ce48fdaabd842786034e301fdd40fff.diff LO

[PATCH] D85439: [SyntaxTree] Expand support for `NestedNameSpecifier`

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:227-254 +namespace llvm { +template <> struct DenseMapInfo { + using FirstInfo = DenseMapInfo; + using Second

[clang] aa0d19a - [Fixed Point] Add fixed-point shift operations and consteval.

Author: Bevin Hansson Date: 2020-08-07T15:09:24+02:00 New Revision: aa0d19a0c8f5ebccb5768411dfc4feddff7bed08 URL: https://github.com/llvm/llvm-project/commit/aa0d19a0c8f5ebccb5768411dfc4feddff7bed08 DIFF: https://github.com/llvm/llvm-project/commit/aa0d19a0c8f5ebccb5768411dfc4feddff7bed08.diff

[PATCH] D83212: [Fixed Point] Add fixed-point shift operations and consteval.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaa0d19a0c8f5: [Fixed Point] Add fixed-point shift operations and consteval. (authored by ebevhan). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D34654: Allow passing a regex for headers to exclude from clang-tidy

saimusdev added a comment. Hello, Any news on accepting this feature? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D34654/new/ https://reviews.llvm.org/D34654 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D84534: [AIX] Static init frontend recovery and backend support

jasonliu accepted this revision. jasonliu added a comment. This revision is now accepted and ready to land. Thanks. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84534/new/ https://reviews.llvm.org/D84534 ___ cfe-commits mailing list cf

[PATCH] D85523: [clang-tidy] Fix a crash in bugprone-not-null-terminated-result check when `__STDC_WANT_LIB_EXT1__` was undefined after definition.

ArcsinX created this revision. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. ArcsinX requested review of this revision. PP->getMacroInfo() returns nullptr for undefined macro, so we need to check this return value before dereference. Stack dump: #0 0x

[PATCH] D85525: [clang-tidy] Fix a crash in bugprone-not-null-terminated-result check when `__STDC_WANT_LIB_EXT1__` is not a literal.

ArcsinX created this revision. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. ArcsinX requested review of this revision. If `__STDC_WANT_LIB_EXT1__` is not a literal (e.g. `#define __STDC_WANT_LIB_EXT1__ ((unsigned)1)`) bugprone-not-null-terminated-result check

[PATCH] D85525: [clang-tidy] Fix a crash in bugprone-not-null-terminated-result check when `__STDC_WANT_LIB_EXT1__` is not a literal.

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/bugprone/NotNullTerminatedResultCheck.cpp:806 const auto &T = MI->tokens().back(); -StringRef ValueStr = String

[PATCH] D85523: [clang-tidy] Fix a crash in bugprone-not-null-terminated-result check when `__STDC_WANT_LIB_EXT1__` was undefined after definition.

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-not-null-terminated-result-undef-stdc-want-lib-ext1.c:3 +// RUN: -- -std=c11 -I %S/Inputs/bugprone-not-nu

[clang] 4a7aedb - [OPENMP]Simplify representation for atomic, critical, master and section

Author: Alexey Bataev Date: 2020-08-07T09:58:23-04:00 New Revision: 4a7aedb843a591900b419e86dcf46d9bec4c5526 URL: https://github.com/llvm/llvm-project/commit/4a7aedb843a591900b419e86dcf46d9bec4c5526 DIFF: https://github.com/llvm/llvm-project/commit/4a7aedb843a591900b419e86dcf46d9bec4c5526.diff

[PATCH] D85144: [clang] Improve Dumping of APValues

riccibruno added inline comments. Comment at: clang/include/clang/AST/PrettyPrinter.h:222 + /// Whether null pointers should be printed as nullptr or as NULL. + unsigned UseNullptr : 1; + riccibruno wrote: > This seems to be unrelated. And anyway shouldn't this

[PATCH] D85525: [clang-tidy] Fix a crash in bugprone-not-null-terminated-result check when `__STDC_WANT_LIB_EXT1__` is not a literal.

ArcsinX added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/NotNullTerminatedResultCheck.cpp:806 const auto &T = MI->tokens().back(); -StringRef ValueStr = StringRef(T.getLiteralData(), T.getLength()); -llvm::APInt IntValue; -

[PATCH] D85525: [clang-tidy] Fix a crash in bugprone-not-null-terminated-result check when `__STDC_WANT_LIB_EXT1__` is not a literal.

ArcsinX added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-not-null-terminated-result-stdc-want-lib-ext1-not-a-literal.c:3 +// RUN: -- -std=c11 -I %S/Inputs/bugprone-not-null-terminated-result + +#include "not-null-terminated-result-c.h" -

[PATCH] D85528: [analyzer] Fix cast evaluation on scoped enums in ExprEngine

steakhal created this revision. steakhal added reviewers: NoQ, Szelethus, baloghadamsoftware, vsavchenko, xazax.hun, martong, ASDenysPetrov. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, whisperity. Herald added a project: clang

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

Szelethus added a comment. In D72705#2199333 , @balazske wrote: > Test results for tmux are available here >

[PATCH] D85429: [OpenCL] Allow for variadic macros in C++ for OpenCL

olestrohm updated this revision to Diff 283909. olestrohm added a comment. I have amended the relevant test to validate this behaviour in C++ for OpenCL. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85429/new/ https://reviews.llvm.org/D85429 Files: clang/lib/Lex/PPDirectives.cpp c

[PATCH] D85528: [analyzer] Fix cast evaluation on scoped enums in ExprEngine

vsavchenko added a comment. Good catch! Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h:98-104 +const auto IsIntegralOrUnscopedCompleteEnumerationType = [](QualType Ty) { + const Type *CanonicalType = Ty.getCanonicalType().getTypePtr();

[PATCH] D85282: [Concepts] Dump template arguments for immediately declared constraint.

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. Ok, sounds reasonable to me. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85282/new/ https://reviews.llvm.org/D85282 _

[PATCH] D85431: [analyzer] Implement a new checker ThreadPrimitivesChecker

ASDenysPetrov updated this revision to Diff 283916. ASDenysPetrov added a comment. @vsavchenko Made changes due to your remarks. Thanks you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85431/new/ https://reviews.llvm.org/D85431 Files: clang/include/clang/StaticAnalyzer/Checkers/Ch

[PATCH] D85324: [z/OS] Add z/OS Target and define macros

abhina.sreeskantharajan marked 2 inline comments as done. abhina.sreeskantharajan added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:732 +Builder.defineMacro("_OPEN_DEFAULT"); +Builder.defineMacro("_UNIX03_WITHDRAWN"); +Builder.defineMacro("__370__

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ErrorReturnChecker.cpp:55-60 + /// Test if an encountered binary operator where the return value is involved + /// is a valid check statement. The return val

[PATCH] D85532: Correctly set CompilingPCH in PrecompilePreambleAction.

adamcz created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, mgorny. Herald added a project: clang. adamcz requested review of this revision. Herald added a subscriber: ilya-biryukov. This fixes a crash bug in clangd when used with modules. ASTWrite

[PATCH] D85532: Correctly set CompilingPCH in PrecompilePreambleAction.

adamcz updated this revision to Diff 283922. adamcz added a comment. This time the fix is included ;-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85532/new/ https://reviews.llvm.org/D85532 Files: clang-tools-extra/clangd/unittests/CMakeLists.

[PATCH] D82081: [z/OS] Add binary format goff and operating system zos to the triple

MaskRay added a comment. Added the tie breaker when progress cannot be made:) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82081/new/ https://reviews.llvm.org/D82081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D85528: [analyzer] Fix cast evaluation on scoped enums in ExprEngine

steakhal planned changes to this revision. steakhal added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h:98-104 +const auto IsIntegralOrUnscopedCompleteEnumerationType = [](QualType Ty) { + const Type *CanonicalType = Ty

[PATCH] D85528: [analyzer] Fix cast evaluation on scoped enums in ExprEngine

whisperity added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h:98-104 +const auto IsIntegralOrUnscopedCompleteEnumerationType = [](QualType Ty) { + const Type *CanonicalType = Ty.getCanonicalType().getTypePtr(); +

[PATCH] D85528: [analyzer] Fix cast evaluation on scoped enums in ExprEngine

whisperity added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h:98-104 +const auto IsIntegralOrUnscopedCompleteEnumerationType = [](QualType Ty) { + const Type *CanonicalType = Ty.getCanonicalType().getTypePtr(); +

[PATCH] D85532: Correctly set CompilingPCH in PrecompilePreambleAction.

kadircet added a comment. Regarding tests, it feels like we can also test this in ASTUnitTests which is directly in clang, as it is also using PrecompiledPreamble::Build. What about moving the test there instead? Comment at: clang-tools-extra/clangd/unittests/ModulesTests.cpp

[PATCH] D82081: [z/OS] Add binary format goff and operating system zos to the triple

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. I confirm that I have reviewed the Clang part of this change, which is entirely consistent with the status quo for XCOFF. I'm not seeing any outstanding comments, and I do not believe that the changes are cont

[PATCH] D82081: [z/OS] Add binary format goff and operating system zos to the triple

tahonermann accepted this revision. tahonermann added a comment. I'm not a regular Clang reviewer. But for what it is worth, the changes look correct, clear, and appropriate from my lens (though I disagree slightly with some of the lint recommendations in the cases where the recommendation devi

[PATCH] D85536: [clang] Add a matcher for template template parameters.

riccibruno created this revision. riccibruno added reviewers: aaron.ballman, klimek, njames93. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. riccibruno requested review of this revision. There are already matchers for type template parameters and non-type template par

[PATCH] D85528: [analyzer] Fix cast evaluation on scoped enums in ExprEngine

steakhal updated this revision to Diff 283936. steakhal added a comment. - Moved the FIXME closer to the subject. - Added tests for covering incomplete enums as well. - Added `REQUIRES: z3`. This will mark the test case `unsupported` on every buildbots. See my notes about this behavior at D83677

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

rjmccall added a comment. In D75574#2202136 , @theraven wrote: > This feature looks generally useful. A few small suggestions: > > - This is really a way of transforming a formal protocol into an informal > protocol. Objective-C has had a convention of

  1   2   >