chill requested changes to this revision. chill added inline comments. This revision now requires changes to proceed. Herald added a subscriber: dang.
================ Comment at: llvm/lib/Target/AArch64/AArch64.td:352 +def FeatureEmitNoteBTIProperty : SubtargetFeature<"markbtiproperty", "MarkBTIProperty", + "true", "Emit .note.gnu.property for Branch Target Identification" >; ---------------- No, this is an abuse of subtarget features. Subtarget features represent characteristics of the chip, they shouldn't be used to pass arbitrary bits of information. Possible alternatives - `TargetOptions` (cf. `BackendUtil.cpp:initTargetOptions()`) or LLVM command-line arguments (cf. `BackendUtil.cpp:setCommandLineOpts()`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81930/new/ https://reviews.llvm.org/D81930 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
