guiand added a comment. In D82317#2200809 <https://reviews.llvm.org/D82317#2200809>, @jrtc27 wrote:
> At the very least, make whatever script you used to update these public, as I > don't want to have to recreate it from scratch when merging this in. I had > enough "fun" with the LLD mass-renaming (UpperCamel -> lowerCamel) and that > was _with_ a supposedly-working script (it didn't quite do the right thing > and I seem to recall there being two refactoring commits, only one of which > had a script); I do not want a repeat of that experience. That's totally fair, and I can try and prepare a more polished version of the script I was using to get started with these changes. But the script isn't perfect, unfortunately, and follows roughly the 80-20 rule. The tests aren't written in a regular language so there are lots of places where manual intervention was necessary. Sadly I think you're right in that this will cause headaches for downstream forks. Maybe this is another good reason to have `noundef` turned off by default, at least for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82317/new/ https://reviews.llvm.org/D82317 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
