[PATCH] D81407: [Analyzer][StreamChecker] Add note tags for file opening.

balazske added a comment. In D81407#2080273 , @Szelethus wrote: > > If there are multiple resource leak paths for the same stream, only one wil > > be reported. > > What is the rationale behind this? Do all leaks from the same opening > describe the same

[clang] e87e55e - Make ASTFileSignature an array of 20 uint8_t instead of 5 uint32_t

Author: Daniel Grumberg Date: 2020-06-11T09:12:29+01:00 New Revision: e87e55edbc798c1c73963151f114df775b1ec460 URL: https://github.com/llvm/llvm-project/commit/e87e55edbc798c1c73963151f114df775b1ec460 DIFF: https://github.com/llvm/llvm-project/commit/e87e55edbc798c1c73963151f114df775b1ec460.dif

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

balazske added a comment. After running the checker I could observe the following problems: time_t now = time(NULL); if (now > 0) { ... } Here only `now == EOF` would be correct for the checker, so this case is reported (false positive). It may be better if the checker finds any "now > //x

[PATCH] D81347: Make ASTFileSignature an array of 20 uint8_t instead of 5 uint32_t

This revision was automatically updated to reflect the committed changes. Closed by commit rGe87e55edbc79: Make ASTFileSignature an array of 20 uint8_t instead of 5 uint32_t (authored by dang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81347/new/

[PATCH] D81567: [analyzer] SATest: Introduce a single entrypoint for regression scripts

vsavchenko updated this revision to Diff 270059. vsavchenko added a comment. Change script modes as the shouldn't be used as executables now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81567/new/ https://reviews.llvm.org/D81567 Files: clang/ut

[clang] 5cc1851 - [analyzer] On-demand parsing capability for CTU

Author: Endre Fülöp Date: 2020-06-11T10:56:59+02:00 New Revision: 5cc18516c4839fccc64b54eaa5aa447a8e1ed8fa URL: https://github.com/llvm/llvm-project/commit/5cc18516c4839fccc64b54eaa5aa447a8e1ed8fa DIFF: https://github.com/llvm/llvm-project/commit/5cc18516c4839fccc64b54eaa5aa447a8e1ed8fa.diff L

[clang] afa42e4 - [NFC] Make formatting changes to ASTBitCodes.h ahead of a functional change

Author: Daniel Grumberg Date: 2020-06-11T10:25:04+01:00 New Revision: afa42e4c9253ca111fdcb6238a0da34129475911 URL: https://github.com/llvm/llvm-project/commit/afa42e4c9253ca111fdcb6238a0da34129475911 DIFF: https://github.com/llvm/llvm-project/commit/afa42e4c9253ca111fdcb6238a0da34129475911.dif

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 added a comment. In D75665#2084889 , @thakis wrote: > This breaks check-clang on mac: http://45.33.8.238/mac/15258/step_7.txt > > Please take a look, and revert for now if it takes a while to fix. Thanks for reporting this, i think the output i

[PATCH] D78477: [profile] Don't crash when forking in several threads

rovka added a comment. Ping! https://bugs.llvm.org/show_bug.cgi?id=46092 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78477/new/ https://reviews.llvm.org/D78477 ___ cfe-commits mailing list cfe-commit

[PATCH] D81474: Handle delayed-template-parsing functions imported into a non-dtp TU

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Looking at this some more, it looks like whenever clang is building a TU prefix(preamble), the assumption is that any delayed templates will be parsed at the end of the TU. That is unfortu

[PATCH] D80383: Add AST_SIGNATURE record to unhashed control block of PCM files

dang updated this revision to Diff 270077. dang marked 3 inline comments as done. dang added a comment. Rebase on top of latest master that has needed NFC changes to calm down clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80383/new/

[PATCH] D81642: [analyzer] CmpRuns.py: Fix error due to statistics differences

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. vsavchenko added a parent

[PATCH] D81169: [clangd] Improve hover on arguments to function call

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:695 + const PrintingPolicy &Policy) { + if (!N) +return; nit: this is already checked before entering the func

[PATCH] D81641: [SYCL] Implement thread-local storage restriction

Fznamznon added a subscriber: ABataev. Fznamznon added a comment. @jdoerfert , @ABataev , if OpenMP needs same diagnostic as well, I can generalize it between SYCL and OpenMP. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81641/new/ https://review

[PATCH] D81641: [SYCL] Implement thread-local storage restriction

Fznamznon created this revision. Herald added subscribers: cfe-commits, sstefan1, Anastasia, ebevhan, yaxunl. Herald added a reviewer: jdoerfert. Herald added a project: clang. Fznamznon added reviewers: erichkeane, bader. Fznamznon added a subscriber: ABataev. Fznamznon added a comment. @jdoerfer

[PATCH] D81407: [Analyzer][StreamChecker] Add note tags for file opening.

Szelethus added a reviewer: xazax.hun. Szelethus added a comment. Herald added a subscriber: rnkovacs. Alright, I'm sold. How about we add a checker option for it? I don't actually insist, just an idea. @xazax.hun, how has this feature played out? Comment at: clang/lib/StaticA

[clang] 0418005 - [clang][NFC] Various NFCs in CheckDefaultArgumentVisitor

Author: Bruno Ricci Date: 2020-06-11T12:19:45+01:00 New Revision: 0418005c0e2f280f0cdab9ad7b5a1a7bd03d9c10 URL: https://github.com/llvm/llvm-project/commit/0418005c0e2f280f0cdab9ad7b5a1a7bd03d9c10 DIFF: https://github.com/llvm/llvm-project/commit/0418005c0e2f280f0cdab9ad7b5a1a7bd03d9c10.diff L

[clang] 5951ff4 - [clang] CWG 2082 and 2346: loosen the restrictions on parameters and local variables in default arguments.

Author: Bruno Ricci Date: 2020-06-11T12:41:08+01:00 New Revision: 5951ff4512332fff9d191da8661143a883d3b8aa URL: https://github.com/llvm/llvm-project/commit/5951ff4512332fff9d191da8661143a883d3b8aa DIFF: https://github.com/llvm/llvm-project/commit/5951ff4512332fff9d191da8661143a883d3b8aa.diff L

cfe-commits@lists.llvm.org

stuij added inline comments. Comment at: llvm/test/CodeGen/AArch64/aarch64-bf16-ldst-intrinsics.ll:264 +; Function Attrs: argmemonly nounwind readonly +declare { <8 x bfloat>, <8 x bfloat> } @llvm.aarch64.neon.ld2lane.v8bf16.p0i8(<8 x bfloat>, <8 x bfloat>, i64, i8*) #3 + --

[PATCH] D81615: [clang] CWG 2082 and 2346: loosen the restrictions on parameters and local variables in default arguments.

riccibruno updated this revision to Diff 270100. riccibruno marked an inline comment as done. riccibruno added a comment. Add the example in `clang/test/CXX/dcl.decl/dcl.meaning/dcl.fct.default/p9.cpp` as requested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D81455: [clang][NFC] Generate the {Type,ArrayType,UnaryExprOrType,Expression}Traits enumerations from TokenKinds.def...

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, your choice on hiding in TokenKinds.def. Comment at: clang/lib/Basic/ExpressionTraits.cpp:29-34 + assert(T <= ET_Last && "invalid enum value!"); + retur

[PATCH] D81615: [clang] CWG 2082 and 2346: loosen the restrictions on parameters and local variables in default arguments.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5951ff451233: [clang] CWG 2082 and 2346: loosen the restrictions on parameters and local… (authored by riccibruno). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[clang] 40ea01f - [clang] Convert a default argument expression to the parameter type...

Author: Bruno Ricci Date: 2020-06-11T13:18:45+01:00 New Revision: 40ea01f6543d0d4aa2701d1b27a6c5413340e7d5 URL: https://github.com/llvm/llvm-project/commit/40ea01f6543d0d4aa2701d1b27a6c5413340e7d5 DIFF: https://github.com/llvm/llvm-project/commit/40ea01f6543d0d4aa2701d1b27a6c5413340e7d5.diff L

[PATCH] D81455: [clang][NFC] Generate the {Type,ArrayType,UnaryExprOrType,Expression}Traits enumerations from TokenKinds.def...

riccibruno marked 6 inline comments as done. riccibruno added a comment. In D81455#2087286 , @aaron.ballman wrote: > LGTM, your choice on hiding in TokenKinds.def. > Oh! I see now what's going on and that's clever; I was misunderstanding the > second

[PATCH] D78933: [analyzer] RangeConstraintManager optimizations in comparison expressions

ASDenysPetrov added a comment. @vsavchenko I've compiled some performance stats using //csa-testbench//. The result are within the margin of error. | Project| Before | After | Delta | | libWebM| 0:00:32 | 0:00:34 | 6,25% | | Memcached | 0:00:25 | 0:00:26 | 4,00% | | OpenSSL| 0

[PATCH] D81616: [clang] Convert a default argument expression to the parameter type before checking that the default argument is valid with CheckDefaultArgumentVisitor.

This revision was automatically updated to reflect the committed changes. Closed by commit rG40ea01f6543d: [clang] Convert a default argument expression to the parameter type... (authored by riccibruno). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[clang] acb8922 - [clang][NFC] Fix a Wdocumentation warning in Basic/TargetInfo.h

Author: Bruno Ricci Date: 2020-06-11T13:30:26+01:00 New Revision: acb892233d4c51579c350ad632a1f391ba13bac2 URL: https://github.com/llvm/llvm-project/commit/acb892233d4c51579c350ad632a1f391ba13bac2 DIFF: https://github.com/llvm/llvm-project/commit/acb892233d4c51579c350ad632a1f391ba13bac2.diff L

[clang] f529c0a - Fix unused variable warning. NFCI.

Author: Simon Pilgrim Date: 2020-06-11T13:48:42+01:00 New Revision: f529c0a8a149ce6d027400a12a1637eda19e03b5 URL: https://github.com/llvm/llvm-project/commit/f529c0a8a149ce6d027400a12a1637eda19e03b5 DIFF: https://github.com/llvm/llvm-project/commit/f529c0a8a149ce6d027400a12a1637eda19e03b5.diff

[clang] 948b206 - Add missing lambda capture from rGf529c0a8a149.

Author: Simon Pilgrim Date: 2020-06-11T13:57:39+01:00 New Revision: 948b206fc236502caa20e51cf39b9d4d0fda00b6 URL: https://github.com/llvm/llvm-project/commit/948b206fc236502caa20e51cf39b9d4d0fda00b6 DIFF: https://github.com/llvm/llvm-project/commit/948b206fc236502caa20e51cf39b9d4d0fda00b6.diff

[PATCH] D78933: [analyzer] RangeConstraintManager optimizations in comparison expressions

vsavchenko accepted this revision. vsavchenko added a comment. This revision is now accepted and ready to land. In D78933#2087386 , @ASDenysPetrov wrote: > @vsavchenko I've compiled some performance stats using //csa-testbench//. The > result are within

[PATCH] D81641: [SYCL] Implement thread-local storage restriction

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Give @ABataev and @jdoerfert a day or two to review before committing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81641/new/ https://

[clang] fb80e67 - [OPENMP50]Codegen for scan directive in simd loops.

Author: Alexey Bataev Date: 2020-06-11T09:01:23-04:00 New Revision: fb80e67f10eea7177b0ff9c618c8231363b6f2fc URL: https://github.com/llvm/llvm-project/commit/fb80e67f10eea7177b0ff9c618c8231363b6f2fc DIFF: https://github.com/llvm/llvm-project/commit/fb80e67f10eea7177b0ff9c618c8231363b6f2fc.diff

[clang] bb8c7e7 - Add AST_SIGNATURE record to unhashed control block of PCM files

Author: Daniel Grumberg Date: 2020-06-11T14:09:07+01:00 New Revision: bb8c7e756c51bb3dc05b30671fa4c64f48e41c39 URL: https://github.com/llvm/llvm-project/commit/bb8c7e756c51bb3dc05b30671fa4c64f48e41c39 DIFF: https://github.com/llvm/llvm-project/commit/bb8c7e756c51bb3dc05b30671fa4c64f48e41c39.dif

[PATCH] D81420: Fix size for _ExtInt types with builtins

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Feel free to simplify the error message on commit. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7940 +def err_overflow_builtin_ext_int_max_size : Erro

[PATCH] D80383: Add AST_SIGNATURE record to unhashed control block of PCM files

dang added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:3706 unsigned LocalBaseMacroID = Record[1]; - F.MacroOffsetsBase = Record[2]; + F.MacroOffsetsBase = Record[2] + F.ASTBlockStartOffset; F.BaseMacroID = getTotalNumMacros(); -

cfe-commits@lists.llvm.org

stuij accepted this revision. stuij added a comment. LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80752/new/ https://reviews.llvm.org/D80752 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D81641: [SYCL] Implement thread-local storage restriction

riccibruno added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:216 + if (getLangOpts().SYCLIsDevice) +if (auto VD = dyn_cast(D)) + if (VD->getTLSKind() != VarDecl::TLS_None) Nit: The convention is `auto *VD`. Repository: rG LLVM Github Mo

[PATCH] D78232: [OPENMP50]Codegen for scan directive in simd loops.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfb80e67f10ee: [OPENMP50]Codegen for scan directive in simd loops. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78232/new/ https://re

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

dang updated this revision to Diff 270117. dang added a comment. This addresses the usability concern with having to specify fully scoped definitions for normalized values in the TableGen files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79796/n

[PATCH] D80383: Add AST_SIGNATURE record to unhashed control block of PCM files

This revision was automatically updated to reflect the committed changes. Closed by commit rGbb8c7e756c51: Add AST_SIGNATURE record to unhashed control block of PCM files (authored by dang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80383/new/ h

[clang] 78e636b - [clang][NFC] Generate the {Type,ArrayType,UnaryExprOrType,Expression}Traits...

Author: Bruno Ricci Date: 2020-06-11T14:35:52+01:00 New Revision: 78e636b3f2f0b0487130b31fade4f95ab179a18c URL: https://github.com/llvm/llvm-project/commit/78e636b3f2f0b0487130b31fade4f95ab179a18c DIFF: https://github.com/llvm/llvm-project/commit/78e636b3f2f0b0487130b31fade4f95ab179a18c.diff L

[PATCH] D81455: [clang][NFC] Generate the {Type,ArrayType,UnaryExprOrType,Expression}Traits enumerations from TokenKinds.def...

This revision was automatically updated to reflect the committed changes. Closed by commit rG78e636b3f2f0: [clang][NFC] Generate the {Type,ArrayType,UnaryExprOrType,Expression}Traits... (authored by riccibruno). Changed prior to commit: https://reviews.llvm.org/D81455?vs=269467&id=270121#toc R

[clang] 90b54fa - [OPENMP50]Codegen for use_device_addr clauses.

Author: Alexey Bataev Date: 2020-06-11T09:54:51-04:00 New Revision: 90b54fa045e3f8711e0bfb2d22626b28fd3b131f URL: https://github.com/llvm/llvm-project/commit/90b54fa045e3f8711e0bfb2d22626b28fd3b131f DIFF: https://github.com/llvm/llvm-project/commit/90b54fa045e3f8711e0bfb2d22626b28fd3b131f.diff

[PATCH] D80730: [OPENMP50]Codegen for use_device_addr clauses.

This revision was automatically updated to reflect the committed changes. Closed by commit rG90b54fa045e3: [OPENMP50]Codegen for use_device_addr clauses. (authored by ABataev). Changed prior to commit: https://reviews.llvm.org/D80730?vs=269618&id=270131#toc Repository: rG LLVM Github Monorep

[PATCH] D81641: [SYCL] Implement thread-local storage restriction

Fznamznon updated this revision to Diff 270135. Fznamznon added a comment. Fixed code style. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81641/new/ https://reviews.llvm.org/D81641 Files: clang/lib/Sema/SemaDecl.cpp clang/lib/Sema/SemaExpr.cp

[PATCH] D81311: [RFC] LangRef: Define inmem parameter attribute

jdoerfert added a comment. In D81311#2086326 , @rjmccall wrote: > In D81311#2086227 , @jdoerfert wrote: > > > Do we allow `inmem` to be used for other purposes? I would assume the > > answer is yes, as we do not fo

[PATCH] D81641: [SYCL] Implement thread-local storage restriction

Fznamznon marked 2 inline comments as done. Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:216 + if (getLangOpts().SYCLIsDevice) +if (auto VD = dyn_cast(D)) + if (VD->getTLSKind() != VarDecl::TLS_None) riccibruno wrote: > Nit:

[PATCH] D81407: [Analyzer][StreamChecker] Add note tags for file opening.

balazske updated this revision to Diff 270140. balazske added a comment. - Report every path of resource leak. - Do not report if non-returning function was encountered. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81407/new/ https://reviews.llvm.

[PATCH] D79945: [Sema] Comparison of pointers to complete and incomplete types

pestctrl marked an inline comment as done. pestctrl added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:6451 + "%1 is %select{|in}3complete">, + InGroup; def ext_typecheck_ordered_comparison_of_function_pointers : ExtWarn< rsmit

[PATCH] D79945: [Sema] Comparison of pointers to complete and incomplete types

pestctrl updated this revision to Diff 270139. pestctrl added a comment. Moved the extension to C11 group Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79945/new/ https://reviews.llvm.org/D79945 Files: clang/include/clang/Basic/DiagnosticSemaKin

[PATCH] D81658: [OPENMP50]Codegen for scan directive in for simd regions.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: sstefan1, guansong, yaxunl. Herald added a project: clang. Added codegen for scan directives in parallel for regions. Emits the code for the directive with inscan reductions. Original code: #pragma o

[PATCH] D75169: [ARM] Supporting lowering of half-precision FP arguments and returns in AArch32's backend

pratlucas updated this revision to Diff 270143. pratlucas added a comment. Fixing failure on CodeGen/ARM/GlobalISel/arm-unsupported.ll and making clang-format happy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75169/new/ https://reviews.llvm.org

[PATCH] D81223: Size LTO (1/3): Standardizing the use of OptimizationLevel

rcorcs added a comment. The way I see it, with size level for LTO, we could have a different LTO optimization pipeline for size or runtime performance. For example, we could have a different tuning for inlining, vectorization, etc. We could also use the size level to automatically enable optim

[clang] fac7259 - Revert "[OPENMP50]Codegen for scan directive in simd loops."

Author: Alexey Bataev Date: 2020-06-11T11:22:51-04:00 New Revision: fac7259c81671c37140374f3e6ec1fc7472c677c URL: https://github.com/llvm/llvm-project/commit/fac7259c81671c37140374f3e6ec1fc7472c677c DIFF: https://github.com/llvm/llvm-project/commit/fac7259c81671c37140374f3e6ec1fc7472c677c.diff

[PATCH] D81428: [ARM] Moving CMSE handling of half arguments and return to the backend

pratlucas updated this revision to Diff 270149. pratlucas added a comment. Rebasing and simplifying function attributes on test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81428/new/ https://reviews.llvm.org/D81428 Files: llvm/lib/Target/ARM/

[PATCH] D81428: [ARM] Moving CMSE handling of half arguments and return to the backend

pratlucas updated this revision to Diff 270160. pratlucas added a comment. Addressing review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81428/new/ https://reviews.llvm.org/D81428 Files: llvm/lib/Target/ARM/ARMISelLowering.cpp llvm/

[PATCH] D81223: Size LTO (1/3): Standardizing the use of OptimizationLevel

tejohnson added a comment. Sorry I haven't had a chance to review this yet. Added @mtrofin who recently added the OptimizationLevel class that this is leveraging, and @yamauchi who has also been looking at size optimizations in llvm. At a first glance it isn't clear to me how much of this is NF

[PATCH] D81428: [ARM] Moving CMSE handling of half arguments and return to the backend

pratlucas marked 4 inline comments as done. pratlucas added inline comments. Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:2267 +// Mask f16 arguments if this is a CMSE nonsecure call +auto ArgVT = Outs[realArgIdx].ArgVT; ostannard wrote: > Could

[PATCH] D78122: [analyzer][Nullability] Don't emit under the checker name NullabilityBase

Szelethus added a comment. @NoQ Have you unearthed anything on this matter? Do I need to step in/revert? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78122/new/ https://reviews.llvm.org/D78122 ___ cfe

[PATCH] D81407: [Analyzer][StreamChecker] Add note tags for file opening.

balazske updated this revision to Diff 270161. balazske added a comment. - Added tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81407/new/ https://reviews.llvm.org/D81407 Files: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp clang/t

[PATCH] D78024: [FileCheck] - Fix the false positive when -implicit-check-not is used with an unknown -check-prefix.

Higuoxing added a comment. Herald added a project: LLVM. > btw, do you know why FileCheck seems intentionally allows the case when > --check-prefixes=KNOWN,UNKNOWN? > I've mentioned in the description of D78110 > that there are about 1000 tests that have > thi

[PATCH] D81223: Size LTO (1/3): Standardizing the use of OptimizationLevel

mtrofin added inline comments. Comment at: llvm/include/llvm/IR/PassManager.h:413 +/// LLVM-provided high-level optimization levels. +/// I think this change - moving OptimizationLevel out - should be in its own patch, to avoid noise. Commen

[PATCH] D80730: [OPENMP50]Codegen for use_device_addr clauses.

MaskRay added a comment. Hi, you can drop `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` with the following script arcfilter () { arc amend git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed By:|Differential Revision:/{p=0} !p && !/^Summary

[PATCH] D81223: Size LTO (1/3): Standardizing the use of OptimizationLevel

mehdi_amini added a comment. In D81223#2087660 , @rcorcs wrote: > The way I see it, with size level for LTO, we could have a different LTO > optimization pipeline for size or runtime performance. So this is the important point to settle before going on

[PATCH] D75169: [ARM] Supporting lowering of half-precision FP arguments and returns in AArch32's backend

SjoerdMeijer added inline comments. Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:524 + CallConv)) +return; EVT ValueVT = Val.getValueType(); efriedma wrote: > pratlucas wrote: > > efriedma wrote: >

[PATCH] D81407: [Analyzer][StreamChecker] Add note tags for file opening.

Szelethus added a comment. In D81407#2087624 , @balazske wrote: > - Report every path of resource leak. I thought we agreed on the uniqueing being great? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81407

[PATCH] D81670: [TTI] Expose isNoopAddrSpaceCast from TLI.[SROA] Teach SROA to recognize no-op addrspacecast.

hliao created this revision. hliao added reviewers: arsenm, chandlerc. Herald added subscribers: llvm-commits, cfe-commits, kerbowa, dexonsmith, steven_wu, hiraditya, nhaehnle, wdng, jvesely. Herald added projects: clang, LLVM. So far, SROA could only handle convertible pointer pairs if they are

[PATCH] D80450: [CUDA][HIP] Fix implicit HD function resolution

tra added a comment. Reproducer for the regression. https://gist.github.com/Artem-B/183e9cfc28c6b04c1c862c853b5d9575 It's not particularly small, but that's as far as I could get it reduced. With the patch, an attempt to instantiate `ag` on line 36 (in the reproducer sources I linked to above)

[PATCH] D81670: [TTI] Expose isNoopAddrSpaceCast from TLI.[SROA] Teach SROA to recognize no-op addrspacecast.

arsenm added a comment. We should instead allow bitcast to perform no-op addrspacecasts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81670/new/ https://reviews.llvm.org/D81670 ___ cfe-commits mailing

[PATCH] D81670: [TTI] Expose isNoopAddrSpaceCast from TLI.[SROA] Teach SROA to recognize no-op addrspacecast.

hliao updated this revision to Diff 270177. hliao added a comment. Revise the formatting. Updating D81670: [TTI] Expose isNoopAddrSpaceCast from TLI. === [SROA] Teach SROA to recognize no-op addrspacecast. Repository: rG LLVM Github Mon

[PATCH] D81672: [Driver] When forcing a crash call abort to get the correct diagnostic

john.brawn created this revision. john.brawn added reviewers: gbreynoo, jhenderson, probinson. Herald added a project: clang. Commit a945037e8fd0c30e250a62211469eea6765a36ae moved the printing of the "PLEASE submit a bug repor

[clang] 95d7ccb - [PCH] Support writing BuiltinBitCastExprs to PCHs

Author: hyd-dev Date: 2020-06-11T13:37:01-04:00 New Revision: 95d7ccb70b9cbd53f1f137c0b2411852c42c122b URL: https://github.com/llvm/llvm-project/commit/95d7ccb70b9cbd53f1f137c0b2411852c42c122b DIFF: https://github.com/llvm/llvm-project/commit/95d7ccb70b9cbd53f1f137c0b2411852c42c122b.diff LOG:

[PATCH] D72781: [Matrix] Add __builtin_matrix_column_load to Clang.

fhahn added a comment. In D72781#2084077 , @rjmccall wrote: > LGTM. Thank you very much again John! This patch is pending on a few smallish improvements to the load/store intrinsics (D81472 ) and I'll land once that one

[PATCH] D80360: [PCH] Support writing BuiltinBitCastExprs to PCHs

This revision was automatically updated to reflect the committed changes. Closed by commit rG95d7ccb70b9c: [PCH] Support writing BuiltinBitCastExprs to PCHs (authored by hyd-dev, committed by erik.pilkington). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v8.3.1

atrosinenko created this revision. atrosinenko added reviewers: broadwaylamb, sepavloff. Herald added subscribers: s.egerton, dexonsmith, simoncook, emaste. Herald added a reviewer: espindola. Herald added a project: clang. atrosinenko edited the summary of this revision. This patch updates the to

[PATCH] D81552: [ASTMatchers] Added hasDirectBase and hasClass Matchers

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3537 AST_POLYMORPHIC_MATCHER_P_OVERLOAD( -hasType, -AST_POLYMORPHIC_SUPPORTED_TYPES(Expr, FriendDecl, ValueDecl, -CXXBaseSpecifier), +ha

[PATCH] D81311: [RFC] LangRef: Define inmem parameter attribute

rjmccall added a comment. In D81311#2087592 , @jdoerfert wrote: > In D81311#2086326 , @rjmccall wrote: > > > In D81311#2086227 , @jdoerfert > > wrote: > > > > > Do we allow

[clang] 43101d1 - [OPENMP50]Codegen for scan directive in simd loops.

Author: Alexey Bataev Date: 2020-06-11T14:48:43-04:00 New Revision: 43101d10dbd58d48df732f974e078fd82376039e URL: https://github.com/llvm/llvm-project/commit/43101d10dbd58d48df732f974e078fd82376039e DIFF: https://github.com/llvm/llvm-project/commit/43101d10dbd58d48df732f974e078fd82376039e.diff

[PATCH] D80450: [CUDA][HIP] Fix implicit HD function resolution

tra added a comment. In D80450#2087938 , @tra wrote: > Reproducer for the regression. > https://gist.github.com/Artem-B/183e9cfc28c6b04c1c862c853b5d9575 > It's not particularly small, but that's as far as I could get it reduced. > > With the patch, an at

[PATCH] D81392: [clang] Rename Decl::isHidden() to isUnconditionallyVisible()

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. I think renaming the flag in the AST dump output would be a good idea, though it'll be a lot of churn in the tests. I would prefer that we continue to dump a marker only if the declaration is

[PATCH] D81552: [ASTMatchers] Added hasDirectBase and hasClass Matchers

jkorous added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3621 +/// \endcode +AST_MATCHER_P(CXXBaseSpecifier, hasClassOrClassTemplate, + internal::Matcher, InnerMatcher) { I think we should just use `eachOf` matcher for

[PATCH] D81552: [ASTMatchers] Added hasDirectBase and hasClass Matchers

jkorous added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3553 +/// \endcode +AST_MATCHER_P(CXXBaseSpecifier, hasClass, internal::Matcher, + InnerMatcher) { aaron.ballman wrote: > jkorous wrote: > > Nit: while "[base sp

[PATCH] D81627: [HIP] Do not call opt/llc for -fno-gpu-rdc

tra added a comment. Looks OK in general. I'm happy to see reduced opt/llc use. You may want to get someone more familiar with the AMD GPU compilation process to double-check that the compilation pipeline still does the right thing. Comment at: clang/lib/Driver/Driver.cpp:272

[PATCH] D79155: [CodeGen] Increase applicability of ffine-grained-bitfield-accesses for targets with limited native integer widths

efriedma added a comment. Please add a comment explaining what OffsetInRecord means; then LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79155/new/ https://reviews.llvm.org/D79155 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] a06f000 - [clang][NFC] Remove two hard-coded lists of ArrayTypeTrait and ExpressionTrait

Author: Bruno Ricci Date: 2020-06-11T20:27:40+01:00 New Revision: a06f000326e3362ffb5634957447dd434abab0f9 URL: https://github.com/llvm/llvm-project/commit/a06f000326e3362ffb5634957447dd434abab0f9 DIFF: https://github.com/llvm/llvm-project/commit/a06f000326e3362ffb5634957447dd434abab0f9.diff L

[clang] a9250c2 - [clang] TextNodeDumper: Dump the trait spelling of {Type,ArrayType,Expression}TraitExpr

Author: Bruno Ricci Date: 2020-06-11T20:27:40+01:00 New Revision: a9250c281a875d91fb5dd1c8f4ad8ee4ff61b75d URL: https://github.com/llvm/llvm-project/commit/a9250c281a875d91fb5dd1c8f4ad8ee4ff61b75d DIFF: https://github.com/llvm/llvm-project/commit/a9250c281a875d91fb5dd1c8f4ad8ee4ff61b75d.diff L

[clang] efb0413 - [clang][NFC] Assert that the enumerator value of {Type,ArrayType,UnaryExprOrType,Expression}Traits

Author: Bruno Ricci Date: 2020-06-11T20:27:40+01:00 New Revision: efb0413a5cf9b1481c9b6169c8685f8d71f6de84 URL: https://github.com/llvm/llvm-project/commit/efb0413a5cf9b1481c9b6169c8685f8d71f6de84 DIFF: https://github.com/llvm/llvm-project/commit/efb0413a5cf9b1481c9b6169c8685f8d71f6de84.diff L

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7327-7330 + bool IsNonContiguous = false, + MapNonContiguousArrayTy *const Offsets = nullptr, + MapNonContiguousArrayTy *const Counts = nullptr, + MapNonContiguousArrayTy *const S

[PATCH] D80301: [yaml][clang-tidy] Fix new line YAML serialization

DmitryPolukhin updated this revision to Diff 270206. DmitryPolukhin added a comment. Fix single new line handling, it should be replace with space Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80301/new/ https://reviews.llvm.org/D80301 Files: cl

[PATCH] D78122: [analyzer][Nullability] Don't emit under the checker name NullabilityBase

NoQ added a comment. Nope, false alarm! Our buildbot configuration change was at fault. Sorry for forgetting to follow up >.< Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78122/new/ https://reviews.llvm.org/D78122 _

[PATCH] D80947: Add to the Coding Standard our that single-line bodies omit braces

This revision was automatically updated to reflect the committed changes. Closed by commit rGc08ea0771682: Add to the Coding Standard our that single-line bodies omit braces (authored by erichkeane). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8094

[PATCH] D81670: [TTI] Expose isNoopAddrSpaceCast from TLI.[SROA] Teach SROA to recognize no-op addrspacecast.

hliao added a comment. In D81670#2087974 , @arsenm wrote: > We should instead allow bitcast to perform no-op addrspacecasts That may be a little bit challenging as so far no-op `addrspacecast` is target-specific. There may be no TTI available when `bitc

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

NoQ added a comment. In D72705#1871996 , @Szelethus wrote: > @NoQ, @xazax.hun, @baloghadamsoftware, how do you like this patch? I think > the high level idea is correct. I still don't understand how do we enable this checker, i.e. for whom and how ofte

[PATCH] D81407: [Analyzer][StreamChecker] Add note tags for file opening.

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:376-377 +std::string operator()(PathSensitiveBugReport &BR) const { + if (BR.isInteresting(StreamSym)) +return Message; + Another thing you might want to c

[libunwind] 96e6cbb - [libc++] Allow specifying arbitrary custom executors with the new format

Author: Louis Dionne Date: 2020-06-11T16:24:29-04:00 New Revision: 96e6cbbf941d0f937b7e823433d4c222967a1817 URL: https://github.com/llvm/llvm-project/commit/96e6cbbf941d0f937b7e823433d4c222967a1817 DIFF: https://github.com/llvm/llvm-project/commit/96e6cbbf941d0f937b7e823433d4c222967a1817.diff

[PATCH] D80952: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support.

kpn updated this revision to Diff 270219. kpn retitled this revision from "[FPEnv][Clang][Driver][WIP] Disable constrained floating point on targets lacking support." to "[FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support.". kpn added a comment. Herald added a s

[PATCH] D81688: [WebAssembly] WebAssembly doesn't support "protected" visibility

sunfish created this revision. Herald added subscribers: llvm-commits, aheejin, jgravelle-google, sbc100, dschuff. Herald added projects: clang, LLVM. mplement the `hasProtectedVisibility()` hook to indicate that, like Darwin, WebAssembly doesn't support "protected" visibility. On ELF, "protecte

[PATCH] D81608: Fix incorrect call to ExprResult::get()

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Great spot! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81608/new/ https://reviews.llvm.org/D81608

[PATCH] D81691: [clangd] Set CWD in semaCodeComplete

kadircet created this revision. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D81691 Files: clang-tools-extra/clangd/CodeComplete.cpp Index: clang-too

[PATCH] D81641: [SYCL] Implement thread-local storage restriction

jdoerfert added a comment. OpenMP has the same restriction (no surprise I guess). Thanks for the ping! I think we do not emit diagnosis right now: https://godbolt.org/z/srDkXZ I think we also should diagnose this the same way, though it might be beyond the scope of this patch: https://godbolt.or

  1   2   >