riccibruno marked 6 inline comments as done. riccibruno added a comment. In D81455#2087286 <https://reviews.llvm.org/D81455#2087286>, @aaron.ballman wrote:
> LGTM, your choice on hiding in TokenKinds.def. > Oh! I see now what's going on and that's clever; I was misunderstanding the > second macro usage (which makes me wonder if it would make more sense to hide > the Last fields at the bottom of TokenKinds.def rather than use the current > approach, but I don't insist). Thank you for the clarification. Ah, I admit I was grinning for a few minutes when I came up with this :) Yay for macros... I think I will leave the `XX_Last`s in the enumeration since they are not really a trait but a structural feature of the enumerations. I will however add a comment next to each `XX_Last` explaining this trick. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81455/new/ https://reviews.llvm.org/D81455 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
