[PATCH] D80784: [clangd][NFC] Explode ReceivedPreamble into a CV

sammccall added inline comments. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:661 +std::unique_lock Lock(Mutex); +RequestsCV.wait(Lock, [this] { + // Block until we reiceve a preamble request, unless a preamble already kadircet wrote: > sammc

[PATCH] D81173: [clangd] Change ParseInputs to store FSProvider rather than VFS

sammccall added a comment. Let's land this and do further refactoring/renames later. As you mentioned, it's not possible to inline some of the cases where raw pointers are e.g. stored in structs due to lifetime issues. I expect many of these to go away once we use FSProvider more pervasively.

[PATCH] D80961: Ignore template instantiations if not in AsIs mode

sammccall added a comment. Yeah, I think this is consistent with the naming/doc of IgnoreUnlessSpelledInSource, and the concerns are more about the implications of making a less-powerful, more conservative version of matchers the default. Which isn't really what *this* patch is about, but it's r

[PATCH] D81263: [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits

yvvan added a comment. I'm not a big objC expert here. The idea looks fine to me and won't affect my workflow. So let's take this patch if nobody comments against it here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81263/new/ https://reviews.ll

[PATCH] D81154: [AST][RecoveryExpr] Populate the dependence bits from CompoundStmt result expr to StmtExpr.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/AST/ComputeDependence.cpp:131 ExprDependence clang::computeDependence(StmtExpr *E, unsigned TemplateDepth) { // FIXME: why is unexpanded-p

[PATCH] D81263: [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:5153 - auto DoCompletion = [&](Expr *Base, bool IsArrow, + auto DoCompletion = [&](Expr *Base, bool IsArrow, boo

[clang] c6ec352 - Revert "[KernelAddressSanitizer] Make globals constructors compatible with kernel"

Author: Marco Elver Date: 2020-06-08T10:34:03+02:00 New Revision: c6ec352a6bde1995794c523adc2ebab802ccdf0a URL: https://github.com/llvm/llvm-project/commit/c6ec352a6bde1995794c523adc2ebab802ccdf0a DIFF: https://github.com/llvm/llvm-project/commit/c6ec352a6bde1995794c523adc2ebab802ccdf0a.diff L

[PATCH] D81280: (Incomplete)Add support for id-expression

eduucaldas updated this revision to Diff 269127. eduucaldas added a comment. Add support for DeclRefExpr in SyntaxTree, by generating IdExpression Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81280/new/ https://reviews.llvm.org/D81280 Files: cl

[PATCH] D81366: Recognize *.hxx as a C++ header extension, like *.hpp.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D81366 Files: clang/lib/Driver/Types.cpp clang/lib/Frontend/FrontendOptions.cpp Index

[PATCH] D81346: [KernelAddressSanitizer] Ensure global array size remains multiple of type-size

melver abandoned this revision. melver added a comment. With an allmodconfig, mostpost still isn't happy because it expects the device_id info to be a certain size. Revert everything while we figure out how to make modpost happy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80961: Ignore template instantiations if not in AsIs mode

klimek added a comment. In D80961#2076242 , @aaron.ballman wrote: > In D80961#2073049 , @klimek wrote: > > > Without jumping into the discussion whether it should be the default, I > > think we should be able to c

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/test/CodeGen/debug-info-codeview-buildinfo.c:3 +// RUN: llvm-pdbutil dump --types %t.obj | FileCheck %s +// RUN: %clang_cl /c /Z7 %s /Fo%t.obj -fdebug-comp

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

eduucaldas updated this revision to Diff 269129. eduucaldas added a comment. cleanup for upstreaming Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81168/new/ https://reviews.llvm.org/D81168 Files: clang/include/clang/Tooling/Syntax/Nodes.h cla

[PATCH] D81304: [llvm][SveEmitter] Emit the bfloat version of `svld1ro`.

sdesmalen added a comment. Thanks @fpetrogalli, the changes look good to me. Just added some minor comments. Comment at: clang/include/clang/Basic/AArch64SVEACLETypes.def:63 -SVE_VECTOR_TYPE("__SVFloat16_t", SveFloat16, SveFloat16Ty, 8, 16, true, true) -SVE_VECTOR_TYPE("__SV

[clang] 9c39095 - Recognize *.hxx as a C++ header extension, like *.hpp.

Author: Sam McCall Date: 2020-06-08T11:50:34+02:00 New Revision: 9c3909556b31e1ca5c63ba0a54db69e298b08b1a URL: https://github.com/llvm/llvm-project/commit/9c3909556b31e1ca5c63ba0a54db69e298b08b1a DIFF: https://github.com/llvm/llvm-project/commit/9c3909556b31e1ca5c63ba0a54db69e298b08b1a.diff LO

[PATCH] D81366: Recognize *.hxx as a C++ header extension, like *.hpp.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c3909556b31: Recognize *.hxx as a C++ header extension, like *.hpp. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81366/new/ https

[clang] abca3b7 - Revert "[clang] Implement VectorType logic not operator."

Author: Nico Weber Date: 2020-06-08T06:45:21-04:00 New Revision: abca3b7b2ce539ce22c9d3ebdd3cb6c02bb4c009 URL: https://github.com/llvm/llvm-project/commit/abca3b7b2ce539ce22c9d3ebdd3cb6c02bb4c009 DIFF: https://github.com/llvm/llvm-project/commit/abca3b7b2ce539ce22c9d3ebdd3cb6c02bb4c009.diff LO

[PATCH] D81315: [Draft] [Prototype] warning for default constructed unique pointer dereferences

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:72-76 + // STL smart pointer methods which resets to null + const llvm::StringSet<> ResetMethods = {"reset", "release", "swap"}; + + // STL smart pointer methods which resets to null

[PATCH] D80383: Add AST_SIGNATURE record to unhashed control block of PCM files

dang updated this revision to Diff 269155. dang marked an inline comment as done. dang added a comment. Address some code review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80383/new/ https://reviews.llvm.org/D80383 Files: clang/inclu

[PATCH] D80979: [clang] Implement VectorType logic not operator.

thakis added a comment. Reverted in abca3b7b2ce539ce22c9d3ebdd3cb6c02bb4c009 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80979/new/ https://reviews.llvm.org/D80979 ___

[PATCH] D80383: Add AST_SIGNATURE record to unhashed control block of PCM files

dang marked an inline comment as done. dang added a comment. See D81347 for the parent revision that makes ASTFileSignature a `std::array`. Adding the abbreviation doesn't make that much sense at the moment because of how the `IMPORTS` record is structured as d

[PATCH] D81173: [clangd] Change ParseInputs to store FSProvider rather than VFS

kadircet updated this revision to Diff 269161. kadircet added a comment. - Rebase - Move GetFSProvider to a lambda inside scanPreamble with a FIXME. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81173/new/ https://reviews.llvm.org/D81173 Files:

[PATCH] D80210: [analyzer] Turn off reports in system headers

Szelethus added a comment. Sounds nice. @bruntib, would this be sufficient for the user's request? Are we sure that the actual request makes sense in light of the analyzer's viewpoint? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80210/new/ https

[clang-tools-extra] f693ce4 - [clangd] Change ParseInputs to store FSProvider rather than VFS

Author: Kadir Cetinkaya Date: 2020-06-08T13:23:55+02:00 New Revision: f693ce4aa97e7afe34a3f41609ffbbaf32b571de URL: https://github.com/llvm/llvm-project/commit/f693ce4aa97e7afe34a3f41609ffbbaf32b571de DIFF: https://github.com/llvm/llvm-project/commit/f693ce4aa97e7afe34a3f41609ffbbaf32b571de.dif

[PATCH] D81173: [clangd] Change ParseInputs to store FSProvider rather than VFS

kadircet updated this revision to Diff 269168. kadircet marked 2 inline comments as done. kadircet added a comment. - Inline VFS uses in ClangdServer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81173/new/ https://reviews.llvm.org/D81173 Files:

[PATCH] D80905: [analyzer] Introduce weak dependencies to express *preferred* checker callback evaluation order

Szelethus marked 2 inline comments as done. Szelethus added a comment. Gentle ping Comment at: clang/include/clang/StaticAnalyzer/Checkers/CheckerBase.td:141-142 +/// Describes preferred registration and evaluation order in between checkers. +/// Unlike strong dependencies, thi

[PATCH] D80928: [BFloat] Add convert/copy instrinsic support

ostannard added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsARM.td:789 +def int_arm_neon_vcvtfp2bf +: Intrinsic<[llvm_anyvector_ty], [llvm_anyvector_ty], [IntrNoMem]>; I only see this being used for f32 -> bf16 conversion, so could this have

[PATCH] D81380: [clangd] Don't produce snippets when completion location is followed by parenthesis

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Prevent a second pair of parenthesis from being added when there already is one right after c

[PATCH] D81173: [clangd] Change ParseInputs to store FSProvider rather than VFS

This revision was automatically updated to reflect the committed changes. Closed by commit rGf693ce4aa97e: [clangd] Change ParseInputs to store FSProvider rather than VFS (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81173/new

[clang] 615673f - [Preamble] Invalidate preamble when missing headers become present.

Author: Sam McCall Date: 2020-06-08T14:03:08+02:00 New Revision: 615673f3a10e98f33e2db64512be0452145236fe URL: https://github.com/llvm/llvm-project/commit/615673f3a10e98f33e2db64512be0452145236fe DIFF: https://github.com/llvm/llvm-project/commit/615673f3a10e98f33e2db64512be0452145236fe.diff LO

[PATCH] D80961: Ignore template instantiations if not in AsIs mode

aaron.ballman added a comment. In D80961#2079044 , @klimek wrote: > In D80961#2076242 , @aaron.ballman > wrote: > > > In D80961#2073049 , @klimek wrote: > > > > > Without ju

[PATCH] D80210: [analyzer] Turn off reports in system headers

NoQ added a comment. (if we agree to do this, the next obvious experiment would be to cut out the beginning of the path from the report we *do* emit - i.e., everything until our first interesting stack frame) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D80366: [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent`

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Great, thank you! Comment at: clang/lib/StaticAnalyzer/Core/CallEvent.cpp:543 + + const StackFrameContext *StackFrame = Call.getCalleeStackFrame(BlockCount); + if (!StackFrame) -

[PATCH] D80905: [analyzer] Introduce weak dependencies to express *preferred* checker callback evaluation order

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/CheckerBase.td:141-142 +/// Describes preferred registration and evaluation order in between checkers. +/// Unlike strong dependencies, this expresses dependencies in between +/// diagnostics, and

[PATCH] D80522: [Analyzer] [NFC] Parameter Regions

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:404-407 /// Returns memory location for a parameter variable within the callee stack /// frame. May fail; returns null on failure. - const VarRegion *getParameterLocat

[PATCH] D81380: [clangd] Don't produce snippets when completion location is followed by parenthesis

sammccall added a comment. Thanks, this is nice! Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1228 + // extra parenthesis. + bool HasParenthesisAfter = false; // Counters for logging. I'd suggest rather storing the token kind as `NextToken`, and t

[PATCH] D77942: [Preamble] Invalidate preamble when missing headers become present.

This revision was automatically updated to reflect the committed changes. Closed by commit rG615673f3a10e: [Preamble] Invalidate preamble when missing headers become present. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D77942?vs=266868&id=269185#toc Repository:

[clang] a679499 - [clang-format] treat 'lock' as a keyword for C# code

Author: Jonathan Coe Date: 2020-06-08T13:31:22+01:00 New Revision: a67949913a6b19860fdc616da2fad00bf7beb3f8 URL: https://github.com/llvm/llvm-project/commit/a67949913a6b19860fdc616da2fad00bf7beb3f8 DIFF: https://github.com/llvm/llvm-project/commit/a67949913a6b19860fdc616da2fad00bf7beb3f8.diff

[PATCH] D81315: [analyzer][Draft] [Prototype] warning for default constructed unique pointer dereferences

Szelethus added a comment. Best of luck on your GSoC! I don't have much else to add to your patch, but you seem to have made good progress already! In D81315#2078043 , @xazax.hun wrote: > some folks have automated scripts based on that tag to add themsel

[PATCH] D80905: [analyzer] Introduce weak dependencies to express *preferred* checker callback evaluation order

Szelethus marked 3 inline comments as done. Szelethus added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/CheckerBase.td:141-142 +/// Describes preferred registration and evaluation order in between checkers. +/// Unlike strong dependencies, this expres

[PATCH] D81061: [Analyzer][VLASizeChecker] Fix problem with zero index assumption.

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/VLASizeChecker.cpp:130-131 +// At least check for zero again. +// Assume that this is a more exact fact than the previous assumptions +// (in checkVLAIndexSize), so report error too.

[PATCH] D81332: Thread safety analysis: Support deferring locks

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Should we update the public docs for this change as well? Specifically, I am wondering if we should update https://clang.llvm.org/docs/ThreadSafetyAnalysis.html#mutexheader

[PATCH] D81384: [AST] Fix a clang crash on an invalid for-range statement.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. crash stack: llvm-project/clang/lib/AST/ASTContext.cpp:2248: clang::TypeInfo clang::ASTContext::getTypeInfoImpl(const clang::Type *) const: Assertion `!A->getDeducedType().isNull() && "cannot requ

[PATCH] D81263: [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits

dgoldman updated this revision to Diff 269189. dgoldman added a comment. Check AccessOpFixIt.hasValue() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81263/new/ https://reviews.llvm.org/D81263 Files: clang/lib/Sema/SemaCodeComplete.cpp clang/t

[PATCH] D81255: [clang-format] treat 'lock' as a keyword for C# code

This revision was automatically updated to reflect the committed changes. Closed by commit rGa67949913a6b: [clang-format] treat 'lock' as a keyword for C# code (authored by Jonathan Coe ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D81263: [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits

dgoldman updated this revision to Diff 269192. dgoldman marked 4 inline comments as done. dgoldman added a comment. Remove stale comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81263/new/ https://reviews.llvm.org/D81263 Files: clang/lib/Se

[PATCH] D81263: [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits

dgoldman added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:5153 - auto DoCompletion = [&](Expr *Base, bool IsArrow, + auto DoCompletion = [&](Expr *Base, bool IsArrow, bool IncludeObjC, Optional AccessOpFixIt) -> bool {

[PATCH] D81384: [AST] Fix a clang crash on an invalid for-range statement.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:2437 if (RequireCompleteType(RangeLoc, RangeType, -diag::err_for_range_incomplete_type)) +diag::err_for_rang

[PATCH] D81352: Thread safety analysis: Add note for double unlock

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a nit. Comment at: clang/include/clang/Analysis/Analyses/ThreadSafety.h:111 /// \param Loc -- The SourceLocation of the Unlock + /// \param

[PATCH] D69987: [RISCV] Assemble/Disassemble v-ext instructions.

rogfer01 added a comment. The patch as it stands now LGTM and I think it can be committed. Is there any objection remaining? Any further comments @simoncook @asb? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69987/new/ https://reviews.llvm.org/D

[PATCH] D80905: [analyzer] Introduce weak dependencies to express *preferred* checker callback evaluation order

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Thank you Kristof for working on this. Looks good to me as it is! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80905/new/ https://reviews.llv

[PATCH] D81385: Fix libdl linking for libclang in standalone mode

thieta created this revision. thieta added reviewers: mstorsjo, beanz, lebedev.ri. thieta added a project: clang. Herald added subscribers: cfe-commits, mgorny. As noted in https://reviews.llvm.org/D80492 that change broke standalone builds of clang. This reverts the old behavior of libdl linking

[PATCH] D81154: [AST][RecoveryExpr] Populate the dependence bits from CompoundStmt result expr to StmtExpr.

hokein updated this revision to Diff 269197. hokein marked 5 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81154/new/ https://reviews.llvm.org/D81154 Files: clang/lib/AST/Compute

[PATCH] D80492: Avoid linking libdl unless needed

thieta added a comment. @lebedev.ri fix for your issue posted here: https://reviews.llvm.org/D81385 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80492/new/ https://reviews.llvm.org/D80492 ___ cfe-comm

[PATCH] D81154: [AST][RecoveryExpr] Populate the dependence bits from CompoundStmt result expr to StmtExpr.

hokein added inline comments. Comment at: clang/lib/AST/ComputeDependence.cpp:132 // FIXME: why is unexpanded-pack not propagated? auto D = toExprDependence(E->getType()->getDependence()) & ~ExprDependence::UnexpandedPack; sammccall wrote: > I w

[clang] 28ccd09 - [AST][RecoveryExpr] Populate the dependence bits from CompoundStmt result expr to StmtExpr.

Author: Haojian Wu Date: 2020-06-08T15:31:08+02:00 New Revision: 28ccd09d700311f0d1ce3828a614aad231bdbb22 URL: https://github.com/llvm/llvm-project/commit/28ccd09d700311f0d1ce3828a614aad231bdbb22 DIFF: https://github.com/llvm/llvm-project/commit/28ccd09d700311f0d1ce3828a614aad231bdbb22.diff LO

[PATCH] D81154: [AST][RecoveryExpr] Populate the dependence bits from CompoundStmt result expr to StmtExpr.

This revision was automatically updated to reflect the committed changes. Closed by commit rG28ccd09d7003: [AST][RecoveryExpr] Populate the dependence bits from CompoundStmt result expr… (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D81388: [TEST] TreeTest.cpp - Add a comma to avoid build error with -werror

skan created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. skan added reviewers: gribozavr, hlopko, eduucaldas. The macro `INSTANTIATE_TEST_CASE_P` is defined as \# define INSTANTIATE_TEST_CASE_P(prefix, test_case_name, generator, ...) \ ... If we buil

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

gribozavr2 added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:190 +return N->kind() == NodeKind::NameSpecifier; + } +}; Should there be getters for various parts of the specifier? Comment at: clang/include/clang/

[PATCH] D69987: [RISCV] Assemble/Disassemble v-ext instructions.

fpallares added a comment. I'm not a reviewer but the patch LGTM, thanks for all the changes @HsiangKai. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69987/new/ https://reviews.llvm.org/D69987 ___ cfe

[PATCH] D81390: [KernelAddressSanitizer] Make globals constructors compatible with kernel

melver created this revision. melver added a reviewer: glider. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, aprantl. Herald added a reviewer: aaron.ballman. Herald added projects: clang, LLVM. [ The first version of this feature was reverted due to modpost causing failures. T

[PATCH] D81392: [clang] Rename Decl::isHidden() to isUnconditionallyVisible()

mboehme created this revision. mboehme added a reviewer: rsmith. mboehme added a project: clang. Herald added a subscriber: cfe-commits. Also invert the sense of the return value. As pointed out by the FIXME that this change resolves, isHidden() wasn't a very accurate name for this function. I

[PATCH] D81395: [AST][RecoveryExpr] Preserve the invalid "undef_var" initializer.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang/include/clang/Sema/Sema.h:3900 + /// Rebuild the given Expr with the TypoExpr degraded to RecoveryExpr. + ExprResult rebuildTypoExprs(Expr *TypoExpr); /// Attempts to produce a RecoveryE

[PATCH] D81395: [AST][RecoveryExpr] Preserve the invalid "undef_var" initializer.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. hokein marked an inline comment as done. hokein added inline comments. Comment at: clang/include/clang/Sema/Sema.h:3900 + /// Rebuild the given Expr with the TypoExpr degraded to Rec

[PATCH] D73951: [Clang] [Driver]Add logic to search for flang frontend

CarolineConcatto abandoned this revision. CarolineConcatto added a comment. I'll close this PR as we believe we will not need this flag for Flang driver. There are some development happening in: https://github.com/banach-space/llvm-project for now. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D73951: [Clang] [Driver]Add logic to search for flang frontend

CarolineConcatto added a comment. I'll close this PR as we believe we will not need this flag for Flang driver. There are some development happening in: https://github.com/banach-space/llvm-project for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D81388: [TEST] TreeTest.cpp - Add a comma to avoid build error with -werror

skan added a comment. Related revision: D80822 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81388/new/ https://reviews.llvm.org/D81388 ___ cfe-commits mailing list cf

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

dang marked 3 inline comments as done. dang added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:137-142 +.Case("static", llvm::Reloc::Static) +.Case("pic", llvm::Reloc::PIC_) +.Case("ropi", llvm::Reloc::ROPI

[PATCH] D81352: Thread safety analysis: Add note for double unlock

aaronpuchert marked 2 inline comments as done. aaronpuchert added inline comments. Comment at: clang/include/clang/Analysis/Analyses/ThreadSafety.h:111 /// \param Loc -- The SourceLocation of the Unlock + /// \param LocPreviousUnlock -- Optionally the location of a previous U

[PATCH] D81332: Thread safety analysis: Support deferring locks

aaronpuchert added a comment. In D81332#2079489 , @aaron.ballman wrote: > LGTM! Should we update the public docs for this change as well? Specifically, > I am wondering if we should update > https://clang.llvm.org/docs/ThreadSafetyAnalysis.html#mutexhea

[PATCH] D81396: [clang-tidy] New util `Aliasing` factored out from `bugprone-infinite-loop`

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: aaron.ballman, gribozavr2, JonasToth, alexfh, hokein. baloghadamsoftware added a project: clang-tools-extra. Herald added subscribers: martong, steakhal, gamesh411, Szelethus, dkrupp, rnkovacs, xazax.hun, whisperity, mg

[PATCH] D81272: [clang-tidy] New check `misc-redundant-condition`

baloghadamsoftware marked 11 inline comments as done. baloghadamsoftware added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/RedundantConditionCheck.cpp:39 + declRefExpr(hasDeclaration(varDecl().bind("cond_var"))), + binaryOperator

[PATCH] D81272: [clang-tidy] New check `misc-redundant-condition`

baloghadamsoftware updated this revision to Diff 269222. baloghadamsoftware added a comment. Updated according to the comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81272/new/ https://reviews.llvm.org/D81272 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt clang-too

[clang] 1850f56 - Thread safety analysis: Support deferring locks

Author: Aaron Puchert Date: 2020-06-08T17:00:29+02:00 New Revision: 1850f56c8abae637c2cc1b8d27b8577c5700101a URL: https://github.com/llvm/llvm-project/commit/1850f56c8abae637c2cc1b8d27b8577c5700101a DIFF: https://github.com/llvm/llvm-project/commit/1850f56c8abae637c2cc1b8d27b8577c5700101a.diff

[clang] f70912f - Thread safety analysis: Add note for double unlock

Author: Aaron Puchert Date: 2020-06-08T17:00:29+02:00 New Revision: f70912f885f991d5af11d8ecb10b703f3cbed982 URL: https://github.com/llvm/llvm-project/commit/f70912f885f991d5af11d8ecb10b703f3cbed982 DIFF: https://github.com/llvm/llvm-project/commit/f70912f885f991d5af11d8ecb10b703f3cbed982.diff

[PATCH] D81272: [clang-tidy] New check `misc-redundant-condition`

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/misc-redundant-condition.rst:6 + +Finds condition variables in nested `if` statements that were also checked in +the outer `if` statement and were not changed. Please use

[PATCH] D81390: [KernelAddressSanitizer] Make globals constructors compatible with kernel

melver updated this revision to Diff 269229. melver added a comment. Also ignore non-alias globals prefixed by __. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81390/new/ https://reviews.llvm.org/D81390 Files: clang/test/CodeGen/asan-globals.cp

[PATCH] D80944: Add begin source location for the attributed statement created from PragmaLoopHint decorated loop

jdenny accepted this revision. jdenny added a comment. This revision is now accepted and ready to land. LGTM except for the nit I put in a comment. However, I have little experience with these particular pragmas. Before pushing, please give others a few more days in case they want to review.

[PATCH] D81384: [AST] Fix a clang crash on an invalid for-range statement.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/SemaCXX/for-range-crash.cpp:6 + Bar *variables_to_modify; + foo() { // expected-error {{C++ requires a type specifier for all declaratio

[PATCH] D79945: [Sema] Comparison of pointers to complete and incomplete types

pestctrl added a comment. @efriedma Any more comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79945/new/ https://reviews.llvm.org/D79945 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D81395: [AST][RecoveryExpr] Preserve the invalid "undef_var" initializer.

sammccall added a comment. Very nice! Just want to give some thought to what these callsites look like. Comment at: clang/include/clang/Sema/Sema.h:3899 + /// Rebuild the given Expr with the TypoExpr degraded to RecoveryExpr. + ExprResult rebuildTypoExprs(Expr *TypoExpr); -

[PATCH] D81098: [OpenMP] Upgrade default version of OpenMP to 5.0

saiislam updated this revision to Diff 269239. saiislam added a comment. Fixed 25 out of 75 failing test cases by marking all old default cases as omp4 tests, and new tests as omp5. All these tests are now specific to the version of openmp, so that we don't run into similar problem during next v

[PATCH] D81388: [TEST] TreeTest.cpp - Add a comma to avoid build error with -werror

This revision was automatically updated to reflect the committed changes. Closed by commit rG2c63ea6eded3: [TEST] TreeTest.cpp - Add a comma to avoid build error with -werror (authored by skan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81388/new

[clang] 2c63ea6 - [TEST] TreeTest.cpp - Add a comma to avoid build error with -werror

Author: Shengchen Kan Date: 2020-06-08T23:14:16+08:00 New Revision: 2c63ea6eded3eed4018306363c28b7f63d7b5898 URL: https://github.com/llvm/llvm-project/commit/2c63ea6eded3eed4018306363c28b7f63d7b5898 DIFF: https://github.com/llvm/llvm-project/commit/2c63ea6eded3eed4018306363c28b7f63d7b5898.diff

[PATCH] D81352: Thread safety analysis: Add note for double unlock

This revision was automatically updated to reflect the committed changes. aaronpuchert marked an inline comment as done. Closed by commit rGf70912f885f9: Thread safety analysis: Add note for double unlock (authored by aaronpuchert). Changed prior to commit: https://reviews.llvm.org/D81352?vs=26

[PATCH] D81332: Thread safety analysis: Support deferring locks

This revision was automatically updated to reflect the committed changes. Closed by commit rG1850f56c8aba: Thread safety analysis: Support deferring locks (authored by aaronpuchert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81332/new/ https://r

[PATCH] D81404: [AArch64] Add clang command line support for -mharden-sls=

kristof.beyls created this revision. kristof.beyls added a reviewer: ostannard. Herald added subscribers: cfe-commits, danielkiss. Herald added a project: clang. The accepted options to -mharden-sls= are: - all: enable all mitigations against Straight Line Speculation that are implemented. - non

[clang-tools-extra] 806342b - [clangd] Resolve driver symlinks, and look up unknown relative drivers in PATH.

Author: Sam McCall Date: 2020-06-08T17:24:52+02:00 New Revision: 806342b8ef54ec07511d0ce5d3d1335451e952da URL: https://github.com/llvm/llvm-project/commit/806342b8ef54ec07511d0ce5d3d1335451e952da DIFF: https://github.com/llvm/llvm-project/commit/806342b8ef54ec07511d0ce5d3d1335451e952da.diff LO

[clang] 936ec89 - [AST] Fix a clang crash on an invalid for-range statement.

Author: Haojian Wu Date: 2020-06-08T17:32:10+02:00 New Revision: 936ec89e91e2dda8b6110b1fd1f9920509d7a17b URL: https://github.com/llvm/llvm-project/commit/936ec89e91e2dda8b6110b1fd1f9920509d7a17b DIFF: https://github.com/llvm/llvm-project/commit/936ec89e91e2dda8b6110b1fd1f9920509d7a17b.diff LO

[PATCH] D81263: [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits

sammccall accepted this revision. sammccall added a comment. LG, thanks! Comment at: clang/lib/Sema/SemaCodeComplete.cpp:5199 + // Objective-C property reference. Bail if we're performing fix-it code + // completion since we don't handle forwarding the fix-it for Obje

[PATCH] D72781: [Matrix] Add __builtin_matrix_column_load to Clang.

fhahn updated this revision to Diff 269249. fhahn added a comment. Ping. Applied feedback from D72778 to this patch, improved tests, support conversions/placeholders. One thing I am not sure is how to properly handle template substitutions for the pointer expr

[PATCH] D81384: [AST] Fix a clang crash on an invalid for-range statement.

hokein marked 2 inline comments as done. hokein added inline comments. Comment at: clang/test/SemaCXX/for-range-crash.cpp:6 + Bar *variables_to_modify; + foo() { // expected-error {{C++ requires a type specifier for all declarations}} +for (auto *c : *variables_to_modify

[PATCH] D81098: [OpenMP] Upgrade default version of OpenMP to 5.0

ABataev added a comment. Need to update few other places. CompilerInvocation.cpp:3082 and CompilerInvocation.cpp:3085, which sets the default version to 45 in the presense of the target option or simd option. Most probably, need to remove this check. It was used to use 45 as the default version

[PATCH] D75044: [AArch64] __builtin_return_address for PAuth.

danielkiss added a comment. patch for gcc: https://gcc.gnu.org/pipermail/gcc-patches/2020-June/547404.html CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75044/new/ https://reviews.llvm.org/D75044 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D81396: [clang-tidy] New util `Aliasing` factored out from `bugprone-infinite-loop`

gribozavr2 added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/Aliasing.cpp:59 + +/// Return whether `Var` has a pointer or reference in `Func`. +bool hasPtrOrReferenceInFunc(const FunctionDecl *Func, const VarDecl *Var) { Please don't duplicate

[PATCH] D75414: [clangd] Resolve driver symlinks, and look up unknown relative drivers in PATH.

This revision was automatically updated to reflect the committed changes. Closed by commit rG806342b8ef54: [clangd] Resolve driver symlinks, and look up unknown relative drivers in PATH. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D75414?vs=266861&id=269258#toc R

[PATCH] D81384: [AST] Fix a clang crash on an invalid for-range statement.

This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rG936ec89e91e2: [AST] Fix a clang crash on an invalid for-range statement. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D81384?vs=269188

[PATCH] D81407: [Analyzer][StreamChecker] Add note tags for file opening.

balazske created this revision. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: clang. Bug reports of

[PATCH] D81315: [analyzer][Draft] [Prototype] warning for default constructed unique pointer dereferences

vsavchenko added a comment. Great start! I think you are on the right track, so maybe this code won't be thrown away at all :-) Try to work on tests and get familiar with `lit`. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:31 namespace { -class SmartPtrM

[clang] 8b529e3 - [ObjC] Fix AST serialization for pseudo-strong parameters

Author: David Goldman Date: 2020-06-08T11:54:01-04:00 New Revision: 8b529e311a9052ee7a0676a1b517728efa44a3ba URL: https://github.com/llvm/llvm-project/commit/8b529e311a9052ee7a0676a1b517728efa44a3ba DIFF: https://github.com/llvm/llvm-project/commit/8b529e311a9052ee7a0676a1b517728efa44a3ba.diff

  1   2   3   >