hokein marked 2 inline comments as done.
hokein added inline comments.
================
Comment at: clang/test/SemaCXX/for-range-crash.cpp:6
+ Bar<int> *variables_to_modify;
+ foo() { // expected-error {{C++ requires a type specifier for all
declarations}}
+ for (auto *c : *variables_to_modify)
----------------
sammccall wrote:
> What's the significance of the missing return type here? Can we add void)
>
> Can we move this function out of the class?
>
> (In both cases just to remove any confusion about what the problematic
> pattern actually is)
I tried both at the very beginning and failed, the crash needs both.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81384/new/
https://reviews.llvm.org/D81384
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
