aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
LGTM aside from a nit. ================ Comment at: clang/include/clang/Analysis/Analyses/ThreadSafety.h:111 /// \param Loc -- The SourceLocation of the Unlock + /// \param LocPreviousUnlock -- Optionally the location of a previous Unlock. virtual void handleUnmatchedUnlock(StringRef Kind, Name LockName, ---------------- The parameter itself isn't optional, so the "optionally" seems a bit strange to me. I think it should say, `If the source location is valid, it represents the location of a previous Unlock`, or rework the interface to use an `llvm::Optional`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81352/new/ https://reviews.llvm.org/D81352 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
