[clang] ca46754 - [CMake] Pass CLANG_VENDOR variables into later stages

Author: Sylvestre Ledru Date: 2020-05-29T09:13:08+02:00 New Revision: ca467542eecfc621eea7fefb3c7e3849c6b43ac7 URL: https://github.com/llvm/llvm-project/commit/ca467542eecfc621eea7fefb3c7e3849c6b43ac7 DIFF: https://github.com/llvm/llvm-project/commit/ca467542eecfc621eea7fefb3c7e3849c6b43ac7.dif

[libclc] a341863 - libclc: update website url

Author: davidak Date: 2020-05-29T09:18:37+02:00 New Revision: a3418631e8aa0941b8b57ec2fc3b8d0c7db493be URL: https://github.com/llvm/llvm-project/commit/a3418631e8aa0941b8b57ec2fc3b8d0c7db493be DIFF: https://github.com/llvm/llvm-project/commit/a3418631e8aa0941b8b57ec2fc3b8d0c7db493be.diff LOG:

[PATCH] D80712: [SVE] Add checks for no warnings in SVE tests

david-arm added a comment. Hi @efriedma, at least amongst all the tests in llvm/test/CodeGen/AArch64/sve-* there are still 66 with warnings. @sdesmalen and I discussed this and our reason for adding checks for warnings is mainly to do with the fact we are still fixing up cases and implementing

[clang] 82bb57c - [AST][RecoveryExpr] Make DeduceAutoType fail if the auto is deduced from recovery exprs.

Author: Haojian Wu Date: 2020-05-29T09:54:28+02:00 New Revision: 82bb57c11d8ccb4e1b0f420f4388dd6553bbc57a URL: https://github.com/llvm/llvm-project/commit/82bb57c11d8ccb4e1b0f420f4388dd6553bbc57a DIFF: https://github.com/llvm/llvm-project/commit/82bb57c11d8ccb4e1b0f420f4388dd6553bbc57a.diff LO

[PATCH] D80279: [libclang] Extend clang_Cursor_Evaluate().

nik added a comment. @jkorous: Please submit. I can't as my svn account is still not ported to github... :/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80279/new/ https://reviews.llvm.org/D80279 ___

[PATCH] D80221: [AST][RecoveryExpr] Make DeduceAutoType fail if the auto is deduced from recovery exprs.

This revision was automatically updated to reflect the committed changes. Closed by commit rG82bb57c11d8c: [AST][RecoveryExpr] Make DeduceAutoType fail if the auto is deduced from… (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8

[PATCH] D80369: [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'

djtodoro marked an inline comment as done. djtodoro added inline comments. Comment at: clang/test/Modules/ModuleDebugInfo.m:46-47 -// The forward declaration should not be in the module scope. -// CHECK: !DICompositeType(tag: DW_TAG_structure_type, name: "OpaqueData", file - --

[PATCH] D80221: [AST][RecoveryExpr] Make DeduceAutoType fail if the auto is deduced from recovery exprs.

hokein updated this revision to Diff 267137. hokein marked 2 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80221/new/ https://reviews.llvm.org/D80221 Files: clang/lib/Sema/SemaSt

[PATCH] D79710: [clang][BFloat] add create/set/get/dup intrinsics

dmgreen added inline comments. Comment at: clang/include/clang/Basic/arm_neon.td:1860 + + def VGET_HIGH_BF : NoTestOpInst<"vget_high", ".Q", "b", OP_HI>; + def VGET_LOW_BF : NoTestOpInst<"vget_low", ".Q", "b", OP_LO>; Do you know what InstName = "vmov" does, a

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

sammccall added a comment. Random thoughts from the peanut gallery: - `clang-format` *is* the place I'd expect/want this feature, as a user. It's way more similar to `int *x` -> `int* x` than it is to e.g. typical clang-tidy rewrites. My only concern is whether we can give it the safety users e

[PATCH] D77148: [analyzer] ApiModeling: Add buffer size arg constraint with multiplier involved

martong updated this revision to Diff 267141. martong marked an inline comment as done. martong added a comment. - Rebase to D77066 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77148/new/ https://reviews.llvm.org/

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 updated this revision to Diff 267143. gamesh411 marked 6 inline comments as done. gamesh411 added a comment. Fix documentation and commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665 Fi

[PATCH] D80740: [SveEmitter] Add SVE ACLE for svld1ro.

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80740/new/ https://reviews.llvm.org/D80740

[PATCH] D80781: [clang] Always allow including builtin headers in [no_undeclared_headers] modules.

mboehme created this revision. mboehme added a project: clang. Herald added a subscriber: cfe-commits. mboehme added a reviewer: rsmith. Previously, this would fail if the builtin headers had been "claimed" by a different module that wraps these builtin headers. libc++ does this, for example. T

[PATCH] D80627: [clang-format] Create a python documentation tool to generate a summary of the clang-format status for the whole of the LLVM project

curdeius added a comment. @MyDeveloperDay , I know it's a strange request, but could you change (or remove) the background color for 100% case. I'm partially color-blind and having red and green background in the same table is really hard to distinguish. I guess I'm not alone. I'd suggest using

[PATCH] D80627: [clang-format] Create a python documentation tool to generate a summary of the clang-format status for the whole of the LLVM project

MyDeveloperDay added a comment. In D80627#2062332 , @curdeius wrote: > @MyDeveloperDay , I know it's a strange request, but could you change (or > remove) the background color for 100% case. > I'm partially color-blind and having red and green background

[PATCH] D80293: [clangd] Run PreambleThread in async mode behind a flag

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:724 std::move(Req.WantDiags)); +// Set it after notifying ASTPeer about the pre

[PATCH] D79835: [Fuchsia] Rely on linker switch rather than dead code ref for profile runtime

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:1037 bool InstrProfiling::emitRuntimeHook() { // We expect the linker to be invoked with -u flag f

[PATCH] D80627: [clang-format] Create a python documentation tool to generate a summary of the clang-format status for the whole of the LLVM project

curdeius added a comment. @MyDeveloperDay, I've played around with the script, you can take as much as you judge useful from here: https://github.com/mkurdej/llvm-project/tree/arcpatch-D80627. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80627/new/ https://reviews.llvm.org/D80627

[PATCH] D79400: [CMAKE] Fix build failure when source directory is read only

pdhaliwal updated this revision to Diff 267153. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79400/new/ https://reviews.llvm.org/D79400 Files: llvm/cmake/modules/AddLLVM.cmake llvm/include/llvm/Support/CMakeLists.txt Index: llvm/include/llvm/

[PATCH] D80293: [clangd] Run PreambleThread in async mode behind a flag

kadircet updated this revision to Diff 267156. kadircet added a comment. - Move notification from PreambleThread to ASTWorker Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80293/new/ https://reviews.llvm.org/D80293 Files: clang-tools-extra/clang

[PATCH] D77658: [analyzer] StdLibraryFunctionsChecker: Add sanity checks for constraints

balazske added a comment. The code looks basically good to me, some documentations can be improved. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:697 if (auto *FD = dyn_cast(D)) { - if (S.matchesSignature(FD)) { + if (S.

[PATCH] D80784: [clangd][NFC] Explode ReceivedPreamble into a CV

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, javed.absar, ilya-biryukov. Herald added a project: clang. Instead of a notification, we make use of a CV and store the boolean on LatestPreamble by

[PATCH] D80293: [clangd] Run PreambleThread in async mode behind a flag

kadircet updated this revision to Diff 267157. kadircet marked 3 inline comments as done. kadircet added a comment. - Add comment explaining why we block on ASTWorker::update rather than consumers of a preamble Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

martong accepted this revision. martong added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665 ___ cfe-commits mailing list cfe-commits@lists.ll

[clang-tools-extra] 478f6fb - [clangd] Add buildPreamble to TestTU

Author: Kadir Cetinkaya Date: 2020-05-29T12:20:23+02:00 New Revision: 478f6fb2001698eb102ddce9500ff0885eaaeaab URL: https://github.com/llvm/llvm-project/commit/478f6fb2001698eb102ddce9500ff0885eaaeaab DIFF: https://github.com/llvm/llvm-project/commit/478f6fb2001698eb102ddce9500ff0885eaaeaab.dif

[clang-tools-extra] b742eaa - [clangd] Handle additional includes while parsing ASTs

Author: Kadir Cetinkaya Date: 2020-05-29T12:20:23+02:00 New Revision: b742eaa321219fa3444e3bcd33eda441bea6b73a URL: https://github.com/llvm/llvm-project/commit/b742eaa321219fa3444e3bcd33eda441bea6b73a DIFF: https://github.com/llvm/llvm-project/commit/b742eaa321219fa3444e3bcd33eda441bea6b73a.dif

[clang-tools-extra] 1772adb - [clangd] Preserve extra args in PreambleTests::IncludeParsing to fix windows build bots

Author: Kadir Cetinkaya Date: 2020-05-29T12:35:25+02:00 New Revision: 1772adb0594bf0d8684fe8b63609352ad4a1ccf0 URL: https://github.com/llvm/llvm-project/commit/1772adb0594bf0d8684fe8b63609352ad4a1ccf0 DIFF: https://github.com/llvm/llvm-project/commit/1772adb0594bf0d8684fe8b63609352ad4a1ccf0.dif

[PATCH] D80697: [clang-tidy] Reworked TransformerClangTidyCheck to simplify usage of Options

njames93 added a comment. There are a few reasons for using the virtual method: - It keeps everything contained in the one class. - In the case where options are needed it avoid extra work in the derived class. - It's consistent with how all base class checks handle the specifics of derived chec

[PATCH] D80697: [clang-tidy] Reworked TransformerClangTidyCheck to simplify usage of Options

njames93 updated this revision to Diff 267161. njames93 marked 3 inline comments as done. njames93 added a comment. - Add back old constructors, one being deprecated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80697/new/ https://reviews.llvm.org/

[PATCH] D79930: [clangd] Add buildPreamble to TestTU

This revision was automatically updated to reflect the committed changes. Closed by commit rG478f6fb20016: [clangd] Add buildPreamble to TestTU (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79930/new/ https://reviews.llvm.org

[PATCH] D80786: Rename APIs in unittests/AST/Language.h in preparation to share them

gribozavr created this revision. Herald added subscribers: cfe-commits, martong. Herald added a reviewer: shafik. Herald added a reviewer: rengolin. Herald added a project: clang. Declaring these helpers in the ast_matcher namespace in the clangAST library seems inappropriate -- neither these help

[PATCH] D77644: [clangd] Handle additional includes while parsing ASTs

This revision was automatically updated to reflect the committed changes. Closed by commit rGb742eaa32121: [clangd] Handle additional includes while parsing ASTs (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77644/new/ https:

[clang-tools-extra] fcde3d5 - [clangd] Patch PP directives to use stale preambles while building ASTs

Author: Kadir Cetinkaya Date: 2020-05-29T12:46:53+02:00 New Revision: fcde3d5b04b612ebc4164fe8f3e83f93cd1fce53 URL: https://github.com/llvm/llvm-project/commit/fcde3d5b04b612ebc4164fe8f3e83f93cd1fce53 DIFF: https://github.com/llvm/llvm-project/commit/fcde3d5b04b612ebc4164fe8f3e83f93cd1fce53.dif

[clang-tools-extra] 538c275 - [clangd] locateMacroAt handles patched macros

Author: Kadir Cetinkaya Date: 2020-05-29T12:46:54+02:00 New Revision: 538c2753f3ec818eae57a5c5dfbe1f05af57ee37 URL: https://github.com/llvm/llvm-project/commit/538c2753f3ec818eae57a5c5dfbe1f05af57ee37 DIFF: https://github.com/llvm/llvm-project/commit/538c2753f3ec818eae57a5c5dfbe1f05af57ee37.dif

[PATCH] D43002: Emit S_OBJNAME symbol in CodeView

aganea added a comment. In D43002#2061162 , @echristo wrote: > First question: > > Since split dwarf has to do some similar things can we not use the same > support? This seems to be a lot of changes for this. > > Second question: > > and if we can't use

[PATCH] D43002: Emit S_OBJNAME symbol in CodeView

aganea updated this revision to Diff 267111. aganea added a comment. Simplified. Now using `CodeGenOptions` to pass the object filename around. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43002/new/ https://reviews.llvm.org/D43002 Files: clang

[PATCH] D80786: Rename APIs in unittests/AST/Language.h in preparation to share them

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Agree with the rationale about moving the names out of `clang::ast_matchers`, and the names not being safe to put into `clang::` as-is. The names are a bit unwieldy though, and I wonder

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

aaron.ballman added a comment. In D80753#2061565 , @njames93 wrote: > It may be worth verifying that the fix-its are identical too, multiple > versions of a check could be running with differing options resulting in > different fix-its generated, in that

[PATCH] D80627: [clang-format] Create a python documentation tool to generate a summary of the clang-format status for the whole of the LLVM project

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added a comment. Would something like this be easier to read? F12027905: image.png Comment at: clang/docs/tools/generate_formatted_state.py:52 +path = os.path.relpath(r

[PATCH] D80198: [clangd] locateMacroAt handles patched macros

This revision was automatically updated to reflect the committed changes. Closed by commit rG538c2753f3ec: [clangd] locateMacroAt handles patched macros (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80198/new/ https://reviews

[PATCH] D79992: [clangd] Patch PP directives to use stale preambles while building ASTs

This revision was automatically updated to reflect the committed changes. Closed by commit rGfcde3d5b04b6: [clangd] Patch PP directives to use stale preambles while building ASTs (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7

[clang-tools-extra] 1f4ba66 - [clangd] Run PreambleThread in async mode behind a flag

Author: Kadir Cetinkaya Date: 2020-05-29T13:20:46+02:00 New Revision: 1f4ba66ecc877562e75059e32d4c95a67e1fd483 URL: https://github.com/llvm/llvm-project/commit/1f4ba66ecc877562e75059e32d4c95a67e1fd483 DIFF: https://github.com/llvm/llvm-project/commit/1f4ba66ecc877562e75059e32d4c95a67e1fd483.dif

[PATCH] D77658: [analyzer] StdLibraryFunctionsChecker: Add sanity checks for constraints

martong updated this revision to Diff 267177. martong marked 8 inline comments as done. martong added a comment. - Add comments, remove auto from 'for' loops, matches -> matchesAndSet Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77658/new/ https:/

[PATCH] D80786: Rename APIs in unittests/AST/Language.h in preparation to share them

martong added a comment. Thank you for working on this. > moving into a clang::test namespace instead of prefixing the names +1 for this. We could go even further: `clang::test::ast` or `clang::unittest::ast`. Comment at: clang/unittests/AST/Language.h:23 + +enum UnittestLan

[PATCH] D80786: Rename APIs in unittests/AST/Language.h in preparation to share them

martong added a comment. Just out of curiosity. In what way do you prepare to share these test? For which component are you planning to reuse this test infrastructure? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80786/new/ https://reviews.llvm.o

[PATCH] D80293: [clangd] Run PreambleThread in async mode behind a flag

This revision was automatically updated to reflect the committed changes. Closed by commit rG1f4ba66ecc87: [clangd] Run PreambleThread in async mode behind a flag (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80293/new/ https

[clang-tools-extra] 20b2af3 - [clangd][NFC] Add traces for PreamblePatch::create

Author: Kadir Cetinkaya Date: 2020-05-29T14:00:08+02:00 New Revision: 20b2af3e5559e50d1b5279311c6e5034a2d1928d URL: https://github.com/llvm/llvm-project/commit/20b2af3e5559e50d1b5279311c6e5034a2d1928d DIFF: https://github.com/llvm/llvm-project/commit/20b2af3e5559e50d1b5279311c6e5034a2d1928d.dif

[clang] ac1f7ab - [clang] [Darwin] Add reverse mappings for aarch64/aarch64_32 to darwin arch names

Author: Martin Storsjö Date: 2020-05-29T15:23:14+03:00 New Revision: ac1f7ab007e347dc4a542aa3415e6378289480f4 URL: https://github.com/llvm/llvm-project/commit/ac1f7ab007e347dc4a542aa3415e6378289480f4 DIFF: https://github.com/llvm/llvm-project/commit/ac1f7ab007e347dc4a542aa3415e6378289480f4.diff

[clang] ab4d02c - [clang] [MinGW] Fix libunwind extension

Author: Mateusz Mikuła Date: 2020-05-29T15:23:14+03:00 New Revision: ab4d02cf265982d4c03123d2f52b9d5ee8df575d URL: https://github.com/llvm/llvm-project/commit/ab4d02cf265982d4c03123d2f52b9d5ee8df575d DIFF: https://github.com/llvm/llvm-project/commit/ab4d02cf265982d4c03123d2f52b9d5ee8df575d.diff

[PATCH] D77066: [analyzer] ApiModeling: Add buffer size arg constraint

Szelethus accepted this revision. Szelethus added a subscriber: balazske. Szelethus added a comment. This revision is now accepted and ready to land. LGTM! I think you could remove the extra parameter, but I don't think this warrants another round of review on my end. However, the dynamic size ch

[PATCH] D78933: [analyzer] RangeConstraintManager optimizations in comparison expressions

ASDenysPetrov updated this revision to Diff 267185. ASDenysPetrov added a comment. Updated. Rebased with D79232 . @vsavchenko, @NoQ, @xazax.hun please look. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78933/new/ https://reviews.llvm.org/D78933 Files:

[PATCH] D80786: Rename APIs in unittests/AST/Language.h in preparation to share them

gribozavr updated this revision to Diff 267187. gribozavr added a comment. Addressed review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80786/new/ https://reviews.llvm.org/D80786 Files: clang/unittests/AST/ASTImporterFixtures.cpp c

[PATCH] D80786: Rename APIs in unittests/AST/Language.h in preparation to share them

gribozavr2 added a comment. In D80786#2062557 , @sammccall wrote: > - Unittest -> Test (shorter, and unit test is two words, and llvm naming > conventions notwithstanding many gtests are not unit tests) Done. > - UnitTestClangArgs --> `std::vector` it'

[PATCH] D80786: Rename APIs in unittests/AST/Language.h in preparation to share them

gribozavr updated this revision to Diff 267188. gribozavr added a comment. Changed description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80786/new/ https://reviews.llvm.org/D80786 Files: clang/unittests/AST/ASTImporterFixtures.cpp clang/u

[PATCH] D79995: [clang] [MinGW] Fix libunwind extension

This revision was automatically updated to reflect the committed changes. Closed by commit rGab4d02cf2659: [clang] [MinGW] Fix libunwind extension (authored by mati865, committed by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79995/new/

[PATCH] D80786: Rename APIs in unittests/AST/Language.h in preparation to share them

gribozavr2 added a comment. In D80786#2062634 , @martong wrote: > Just out of curiosity. In what way do you prepare to share these test? For > which component are you planning to reuse this test infrastructure? Tests in clang/unittests/Tooling/Syntax/Tr

[PATCH] D79117: [clang] [Darwin] Add reverse mappings for aarch64/aarch64_32 to darwin arch names

This revision was automatically updated to reflect the committed changes. Closed by commit rGac1f7ab007e3: [clang] [Darwin] Add reverse mappings for aarch64/aarch64_32 to darwin arch… (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[clang] d4ef654 - Rename APIs in unittests/AST/Language.h in preparation to share them

Author: Dmitri Gribenko Date: 2020-05-29T14:25:20+02:00 New Revision: d4ef654673a921878ba5aedb9725b2ac32681f01 URL: https://github.com/llvm/llvm-project/commit/d4ef654673a921878ba5aedb9725b2ac32681f01 DIFF: https://github.com/llvm/llvm-project/commit/d4ef654673a921878ba5aedb9725b2ac32681f01.dif

[PATCH] D80781: [clang] Always allow including builtin headers in [no_undeclared_headers] modules.

mboehme added a comment. Temporarily retracting from review as I've realized there's another case I need to take care of. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80781/new/ https://reviews.llvm.org/D80781 _

[PATCH] D80366: [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent`

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:112 +Optional ExprEngine::retrieveFromConstructionContext( +ProgramStateRef State, const LocationContext *LCtx, baloghadamsoftware wrote: > martong wrote: > > baloghadams

[PATCH] D80791: [AArch64] Generate .note.gnu.property based on module flags.

danielkiss created this revision. danielkiss added reviewers: tamas.petz, chill. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. Generate .note.gnu.property for PAC and BTI if the compile unit is compiled with -mbranch-protection.

[PATCH] D80792: Move unittest helpers to a shared location

gribozavr updated this revision to Diff 267204. gribozavr added a comment. Removed some refactoring leftovers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80792/new/ https://reviews.llvm.org/D80792 Files: clang/include/clang/Testing/CommandLin

[PATCH] D78933: [analyzer] RangeConstraintManager optimizations in comparison expressions

xazax.hun added a comment. In D78933#2054195 , @ASDenysPetrov wrote: > @xazax.hun, any thoughts? I think we should check it on some more projects. We saw vastly different analyzer behavior on other projects in the past. I think you should be able to r

[PATCH] D79330: [Analyzer][VLASizeChecker] Check for VLA size overflow.

NoQ added a comment. https://bugs.llvm.org/show_bug.cgi?id=46128 looks like a crash caused by this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79330/new/ https://reviews.llvm.org/D79330 ___ c

[PATCH] D80792: Move unittest helpers to a shared location

gribozavr created this revision. Herald added subscribers: cfe-commits, martong, mgorny. Herald added a project: clang. gribozavr updated this revision to Diff 267204. gribozavr added a comment. Removed some refactoring leftovers. unittests/AST/Language.h defines some helpers that we would like

[PATCH] D80757: [PowerPC] Add clang option -m[no-]pcrel

lei marked an inline comment as done. lei added inline comments. Comment at: clang/test/Driver/ppc-pcrel.cpp:1 +// RUN: %clang -target powerpc64-unknown-linux-gnu %s -### -mcpu=pwr10 -mpcrel -o %t.o 2>&1 | FileCheck -check-prefix=CHECK-PCREL %s +// RUN: %clang -target powerpc64-

[PATCH] D80786: Rename APIs in unittests/AST/Language.h in preparation to share them

This revision was automatically updated to reflect the committed changes. Closed by commit rGd4ef654673a9: Rename APIs in unittests/AST/Language.h in preparation to share them (authored by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D807

[PATCH] D79587: [CodeGen][SVE] Legalisation of extends with scalable types

kmclaughlin updated this revision to Diff 267183. kmclaughlin edited the summary of this revision. kmclaughlin added a comment. - Removed ReplaceExtensionResults and instead try to use extract_subvector as much as possible to legalise the result - Added ReplaceExtractSubVectorResults, which repla

[PATCH] D80786: Rename APIs in unittests/AST/Language.h in preparation to share them

martong added a comment. Thanks! LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80786/new/ https://reviews.llvm.org/D80786 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D80781: [clang] Always allow including builtin headers in [no_undeclared_headers] modules.

mboehme updated this revision to Diff 267210. mboehme added a comment. When testing with the real libc++ and glibc, I realized that I was still getting a cyclic dependency between the two modules because the builtin stddef.h that glibc was including was still being ascribed to libc++. This modi

[PATCH] D78933: [analyzer] RangeConstraintManager optimizations in comparison expressions

vsavchenko added a comment. Sorry for postponing this review. I'll get to it right away! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78933/new/ https://reviews.llvm.org/D78933 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D77066: [analyzer] ApiModeling: Add buffer size arg constraint

martong updated this revision to Diff 267216. martong marked 2 inline comments as done. martong added a comment. - Remove SValBuilder param Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77066/new/ https://reviews.llvm.org/D77066 Files: clang/inc

[PATCH] D78933: [analyzer] RangeConstraintManager optimizations in comparison expressions

ASDenysPetrov added a comment. @xazax.hun > I think we should check it on some more projects. We saw vastly different > analyzer behavior on other projects in the past. I completely agree with you. But, unfortunately, vim-proj is the only I could squeeze from that bunch. > I think you should

[PATCH] D80792: Move unittest helpers to a shared location

gribozavr updated this revision to Diff 267214. gribozavr added a comment. Added a modulemap entry for the new Clang library. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80792/new/ https://reviews.llvm.org/D80792 Files: clang/include/clang/Tes

[PATCH] D77066: [analyzer] ApiModeling: Add buffer size arg constraint

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:237 + SVal BufDynSize = + getDynamicSizeWithOffset(State, BufV, C.getSValBuilder()); + Szelethus wrote: > You can retrieve `SValBuilder` from

[PATCH] D79587: [CodeGen][SVE] Legalisation of extends with scalable types

david-arm added a comment. Hi Kerry, just a couple of comments about the use of getVectorNumElements() - we're trying to remove calls to this function so it would be good if you could use getVectorElementCount() instead. Thanks! Comment at: llvm/lib/Target/AArch64/AArch64ISe

Re: Bug in QualTypeNames.cpp and adding an option to prepend "::" to fully qualified names.

Sorry about ignoring this, I didn't really have an opinion - clang is fairly full of helper functions that don't quite do what you expect. This does look like a bug though. Generally for printing types, PrettyPrinter is the way to go. So I'm supportive of any of: - adding the option to explicitly

[clang] bd03ef1 - [analyzer] ApiModeling: Add buffer size arg constraint

Author: Gabor Marton Date: 2020-05-29T16:13:57+02:00 New Revision: bd03ef19beb8a3476d5cd9f744c5fba5ca287c51 URL: https://github.com/llvm/llvm-project/commit/bd03ef19beb8a3476d5cd9f744c5fba5ca287c51 DIFF: https://github.com/llvm/llvm-project/commit/bd03ef19beb8a3476d5cd9f744c5fba5ca287c51.diff

[clang] 41928c9 - [analyzer] ApiModeling: Add buffer size arg constraint with multiplier involved

Author: Gabor Marton Date: 2020-05-29T16:24:26+02:00 New Revision: 41928c97b6a17264938fc765a6a0656d8b6e86ed URL: https://github.com/llvm/llvm-project/commit/41928c97b6a17264938fc765a6a0656d8b6e86ed DIFF: https://github.com/llvm/llvm-project/commit/41928c97b6a17264938fc765a6a0656d8b6e86ed.diff

[PATCH] D80800: Add an option to fully qualify classes and structs.

jblespiau created this revision. jblespiau added a reviewer: sammccall. jblespiau edited the summary of this revision. sammccall added a comment. This should really have a test - NamedDeclPrinterTest.cpp seems like the right place. Comment at: clang/lib/AST/TypePrinter.cpp:326

[PATCH] D79587: [CodeGen][SVE] Legalisation of extends with scalable types

david-arm added a comment. Sorry I forgot to mention I think we have an existing test file for extends: llvm/test/CodeGen/AArch64/sve-sext-zext.ll It might be worth adding these cases to that file instead of creating a new one? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79587/new/

[PATCH] D80237: [hip] Ensure pointer in struct argument has proper `addrspacecast`.

arsenm added a comment. In D80237#2058108 , @rjmccall wrote: > In D80237#2055902 , @arsenm wrote: > > > In D80237#2051933 , @rjmccall > > wrote: > > > > > Okay. Can you exp

[PATCH] D80800: Add an option to fully qualify classes and structs.

sammccall added a comment. This should really have a test - NamedDeclPrinterTest.cpp seems like the right place. Comment at: clang/lib/AST/TypePrinter.cpp:326 + if (Policy.FullyQualifiedName && Policy.GlobalScopeQualifiedName && + T->isStructureOrClassType()) { +OS <

[PATCH] D77066: [analyzer] ApiModeling: Add buffer size arg constraint

This revision was automatically updated to reflect the committed changes. Closed by commit rGbd03ef19beb8: [analyzer] ApiModeling: Add buffer size arg constraint (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77066/new/ https:/

[PATCH] D80784: [clangd][NFC] Explode ReceivedPreamble into a CV

sammccall added inline comments. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:661 +std::unique_lock Lock(Mutex); +RequestsCV.wait(Lock, [this] { + // Block until we reiceve a preamble request, unless a preamble already Does LatestPreamble sig

[PATCH] D77148: [analyzer] ApiModeling: Add buffer size arg constraint with multiplier involved

This revision was automatically updated to reflect the committed changes. Closed by commit rG41928c97b6a1: [analyzer] ApiModeling: Add buffer size arg constraint with multiplier involved (authored by martong). Changed prior to commit: https://reviews.llvm.org/D77148?vs=267141&id=267232#toc Rep

[PATCH] D79400: [CMAKE] Fix build failure when source directory is read only

This revision was automatically updated to reflect the committed changes. Closed by commit rG16fef6d0b46f: Fix build failure when source is read only (authored by pdhaliwal, committed by sameerds). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79400/

[clang] 16506d7 - [analyzer] StdLibraryFunctionsChecker: Add sanity checks for constraints

Author: Gabor Marton Date: 2020-05-29T16:38:45+02:00 New Revision: 16506d789084fd037fc61d442da43dd5242872b7 URL: https://github.com/llvm/llvm-project/commit/16506d789084fd037fc61d442da43dd5242872b7 DIFF: https://github.com/llvm/llvm-project/commit/16506d789084fd037fc61d442da43dd5242872b7.diff

[clang] 0e265e3 - Move unittest helpers to a shared location

Author: Dmitri Gribenko Date: 2020-05-29T16:47:33+02:00 New Revision: 0e265e315784b4e47f984f8ed9fb7586130bacdc URL: https://github.com/llvm/llvm-project/commit/0e265e315784b4e47f984f8ed9fb7586130bacdc DIFF: https://github.com/llvm/llvm-project/commit/0e265e315784b4e47f984f8ed9fb7586130bacdc.dif

[clang] cf6cc66 - [OpenMP][SYCL] Improve diagnosing of unsupported types usage

Author: Mariya Podchishchaeva Date: 2020-05-29T18:00:48+03:00 New Revision: cf6cc6622b1416430f517850be9032788e39 URL: https://github.com/llvm/llvm-project/commit/cf6cc6622b1416430f517850be9032788e39 DIFF: https://github.com/llvm/llvm-project/commit/cf6cc6622b1416430f517850be9032788e

[PATCH] D78933: [analyzer] RangeConstraintManager optimizations in comparison expressions

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:32 +BO_GE < BO_EQ && BO_EQ < BO_NE, +"This class relies on operators order. Rework it otherwise."); + +1 for this static ass

[PATCH] D80792: Move unittest helpers to a shared location

gribozavr updated this revision to Diff 267237. gribozavr added a comment. Fixed a clang-tidy warning about header guard format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80792/new/ https://reviews.llvm.org/D80792 Files: clang/include/clang/

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

stuij marked 9 inline comments as done. stuij added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:74 + BFloat16Width = BFloat16Align = 16; + BFloat16Format = &llvm::APFloat::BFloat(); + SjoerdMeijer wrote: > stuij wrote: > > SjoerdMeijer wrot

[PATCH] D80802: [RISCV] Upgrade RVV MC to v0.9.

HsiangKai updated this revision to Diff 267239. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80802/new/ https://reviews.llvm.org/D80802 Files: clang/lib/Driver/ToolChains/Arch

[PATCH] D80627: [clang-format] Create a python documentation tool to generate a summary of the clang-format status for the whole of the LLVM project

curdeius added a comment. That looks nicer indeed. Thanks. Just some minor nitty-gritty comments. Comment at: clang/docs/tools/generate_formatted_state.py:52 +path = os.path.relpath(root, LLVM_DIR) +if "/test/" in path: +continue MyD

[PATCH] D80016: [analyzer] StdLibraryFunctionsChecker: Add support to lookup types

balazske accepted this revision. balazske added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:739 + Optional FileTy = lookupType("FILE", ACtx); + Optional FilePtrTy, FilePtrRestri

[PATCH] D80804: [AMDGPU] Expose llvm atomic inc/dec instructions as clang builtins for AMDGPU target

saiislam created this revision. saiislam added reviewers: arsenm, sameerds, JonChesterfield, jdoerfert. Herald added subscribers: cfe-commits, kerbowa, jfb, t-tye, tpr, dstuttard, yaxunl, nhaehnle, wdng, jvesely, kzhuravl. Herald added a project: clang. saiislam added parent revisions: D75917: Exp

[PATCH] D80627: [clang-format] Create a python documentation tool to generate a summary of the clang-format status for the whole of the LLVM project

curdeius added inline comments. Comment at: clang/docs/tools/generate_formatted_state.py:54 + +table_row = """ * - {path} + - {count} Another nit: I prefer writing `"""\` as it nicely aligns with subsequent lines. CHANGES SINCE LAST ACTION https://revie

[PATCH] D77658: [analyzer] StdLibraryFunctionsChecker: Add sanity checks for constraints

This revision was automatically updated to reflect the committed changes. Closed by commit rG16506d789084: [analyzer] StdLibraryFunctionsChecker: Add sanity checks for constraints (authored by martong). Changed prior to commit: https://reviews.llvm.org/D77658?vs=267177&id=267243#toc Repository

  1   2   3   >