david-arm added a comment. Hi Kerry, just a couple of comments about the use of getVectorNumElements() - we're trying to remove calls to this function so it would be good if you could use getVectorElementCount() instead. Thanks!
================ Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:13837 + + if (InVT.getVectorNumElements() != (VT.getVectorNumElements()*2)) + return; ---------------- I think we want to move away from calling getVectorNumElements(), so might need to change this to something like ElementCount ResEC = VT.getVectorElementCount(); if (InVT.getVectorElementCount() != (ResEC * 2)) ================ Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:13845 + unsigned Index = CIndex->getZExtValue(); + if ((Index != 0) && (Index != VT.getVectorNumElements())) + return; ---------------- And here you could then change this to: if ((Index != 0) && (Index != ResEC.Min)) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79587/new/ https://reviews.llvm.org/D79587 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
