[PATCH] D78374: [Analyzer][StreamChecker] Added evaluation of fread and fwrite.

balazske added a comment. The indeterminate position is mentioned only at fread and fwrite. I do not know if it is reasonable to make the indeterminate position in other cases. Th indeterminate position is separate from error flags because of "clearerr" that clears the error flag but not the in

[PATCH] D78374: [Analyzer][StreamChecker] Added evaluation of fread and fwrite.

balazske added a comment. We can assume that size of a file does not change by external (to the analyzed program) events so the **EOF** state can not disappear. (Is this true for `stdin`, or it has never an **EOF**?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D78374: [Analyzer][StreamChecker] Added evaluation of fread and fwrite.

balazske added a comment. Adding a state chart may help something but does not tell the full picture because conditions on the transitions are not trivial to indicate and follow. And the state chart is too complex to draw it in ASCII-art format. Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D79923: [clangd] Only emit default error/fatal diagnostices from included files.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This would avoid adding too much noise when there is a "-Wall" in the compile command. Repository: rG LLVM

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

llunak added a subscriber: aganea. llunak added a comment. In D69778#2035318 , @dblaikie wrote: > Do you have a sense of the larger testing that PR44953 was reduced from? Have > you tried compiling a non-trivial codebase (I assume you might've tested it

[PATCH] D79117: [clang] [Darwin] Add reverse mappings for aarch64/aarch64_32 to darwin arch names

mstorsjo added a comment. Ping @t.p.northover Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79117/new/ https://reviews.llvm.org/D79117 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D79923: [clangd] Only emit default error/fatal diagnostices from included files.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang-tools-extra/clangd/Diagnostics.cpp:127 // We only report diagnostics with at least error severity from headers. - if (D.Severity < Diagnos

[PATCH] D79330: [Analyzer][VLASizeChecker] Check for VLA size overflow.

balazske added a comment. In D79330#2033990 , @Szelethus wrote: > > Variable-length array (VLA) should have a size that fits into a size_t > > value. At least if the size is queried with sizeof, but it is better (and > > more simple) to check it always >

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

martong added a comment. I think this is a useful concept and it can nicely complement the ongoing summary based work in `StdLibraryFunctionsChecker`. Still, in my opinion, there are more discussions and work to be done here before we get to the final implementation. Our analyzer does not reas

[clang-tools-extra] dbc9e1c - [clangd] Only emit default error/fatal diagnostices from included files.

Author: Haojian Wu Date: 2020-05-14T11:09:06+02:00 New Revision: dbc9e1c39aed43e6faa6b29caeed7bc5b43569f1 URL: https://github.com/llvm/llvm-project/commit/dbc9e1c39aed43e6faa6b29caeed7bc5b43569f1 DIFF: https://github.com/llvm/llvm-project/commit/dbc9e1c39aed43e6faa6b29caeed7bc5b43569f1.diff LO

[PATCH] D79639: [SveEmitter] Builtins for SVE matrix multiply `mmla`.

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_mmla.c:17 + // CHECK: ret %[[RET]] + return SVE_ACLE_FUNC(svmmla, _s32, , )(x, y, z); +} ---

[PATCH] D79923: [clangd] Only emit default error/fatal diagnostices from included files.

hokein updated this revision to Diff 263945. hokein marked an inline comment as done. hokein added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79923/new/ https://reviews.llvm.org/D79923 Files: clang-tools-extra/cla

[PATCH] D79704: [Analyzer] [NFC] Parameter Regions

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:1051 + + const Expr *OriginExpr; + unsigned Index; baloghadamsoftware wrote: > NoQ wrote: > > baloghadamsoftware wrote: > > > We do not use this at all. Ho

[PATCH] D79923: [clangd] Only emit default error/fatal diagnostices from included files.

This revision was automatically updated to reflect the committed changes. Closed by commit rGdbc9e1c39aed: [clangd] Only emit default error/fatal diagnostices from included files. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79

[PATCH] D79770: [RISCV] Fix passing two floating-point values in complex separately by two GPRs on RV64

asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. Good catch, thanks for the fix! The logic was incorrectly written assuming `isFloatingType` would return false for complex values which is of course incorrect. Comment at: clang/

[PATCH] D79930: [clangd] Add buildPreamble to TestTU

kadircet created this revision. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Depends on D77644 . Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D79930 Files: clang

[PATCH] D79918: [clangd] Don't create as much garbage while building Dex index.

sammccall updated this revision to Diff 263961. sammccall added a comment. Address comments, add more docs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79918/new/ https://reviews.llvm.org/D79918 Files: clang-tools-extra/clangd/benchmarks/Index

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

balazske added a comment. Probably we have different pre-conceptions about this checker. One thing is to discover the error by finding a violated precondition or other bug that is caused by the wrong return value of the called and failed function. This is case (1) above if I am correct. Other w

[PATCH] D79932: [analyzer] Modernize analyzer's Python scripts

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. vsavchenko updated this re

[PATCH] D79932: [analyzer] Modernize analyzer's Python scripts

vsavchenko updated this revision to Diff 263963. vsavchenko added a comment. Add more 'super' clean-ups Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79932/new/ https://reviews.llvm.org/D79932 Files: clang/utils/analyzer/CmpRuns.py clang/utils

[PATCH] D79935: [clang-format] [PR44345] Long namespace closing comment is duplicated endlessly

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, JakeMerdichAMD, mitchell-stellar, sammccall, curdeius. MyDeveloperDay added projects: clang, clang-format. https://bugs.llvm.org/show_bug.cgi?id=44345 When namespaces get long the namespace end comment wraps onto the

[PATCH] D79921: [OpenMP] Fix omp and clang pragmas

hishiguro updated this revision to Diff 263964. hishiguro added a comment. Fix clang-format error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79921/new/ https://reviews.llvm.org/D79921 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp Index: clang/

[PATCH] D79704: [Analyzer] [NFC] Parameter Regions

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added a comment. Good news: I executed an analysis with all open-source checks enabled for several open-source projects: //BitCoint//, //CURL//, //OpenSSL//, //PostGreS//, //TMux//, //Xerces// using the patched and the non-p

[PATCH] D79918: [clangd] Don't create as much garbage while building Dex index.

sammccall updated this revision to Diff 263967. sammccall added a comment. Use a faster hash function, which seems to be worth something in the neighbourhood of 4%. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79918/new/ https://reviews.llvm.org/

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

balazske added a comment. It is a way of find some of the cases with the mentioned way of tracking what operations are allowed after what operations with or without error check, on a specific stream. Instead of a stream a symbol that is passed to the function at a specific argument can be used

[PATCH] D79918: [clangd] Don't create as much garbage while building Dex index.

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LGTM, thank you for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79918/new/ https://reviews.llvm.org/D79918 _

[clang-tools-extra] 2045189 - [clangd] Setting recovery-ast flag in buildCompilerInvocation, NFC.

Author: Haojian Wu Date: 2020-05-14T13:16:59+02:00 New Revision: 2045189043d4e2748ed82915dd7bdf3e96728738 URL: https://github.com/llvm/llvm-project/commit/2045189043d4e2748ed82915dd7bdf3e96728738 DIFF: https://github.com/llvm/llvm-project/commit/2045189043d4e2748ed82915dd7bdf3e96728738.diff LO

[PATCH] D79916: Map -O to -O1 instead of -O2

hans added a reviewer: echristo. hans added a comment. Actually it was http://llvm.org/r82131 that mapped -O to -O2 (I just refactored it). Originally it seems it was mapped to -O1. Because this seems to have done quite intentionally, I'm a little vary of changing it back. I'm not sure who woul

[clang-tools-extra] 735ab46 - [clangd] Don't create as much garbage while building Dex index.

Author: Sam McCall Date: 2020-05-14T13:35:44+02:00 New Revision: 735ab46cb4148c92d636c912832a32509252b579 URL: https://github.com/llvm/llvm-project/commit/735ab46cb4148c92d636c912832a32509252b579 DIFF: https://github.com/llvm/llvm-project/commit/735ab46cb4148c92d636c912832a32509252b579.diff LO

[clang-tools-extra] 17ba631 - [clangd] Remove extra qualification

Author: Sam McCall Date: 2020-05-14T14:06:05+02:00 New Revision: 17ba631d1317f294460036cc430dd158ad3d URL: https://github.com/llvm/llvm-project/commit/17ba631d1317f294460036cc430dd158ad3d DIFF: https://github.com/llvm/llvm-project/commit/17ba631d1317f294460036cc430dd158ad3d.diff LO

[clang-tools-extra] 0e5706d - [clangd] Correct the elog message, NFC.

Author: Haojian Wu Date: 2020-05-14T14:15:21+02:00 New Revision: 0e5706d018762f4ab4d895ba268bb6444ae04884 URL: https://github.com/llvm/llvm-project/commit/0e5706d018762f4ab4d895ba268bb6444ae04884 DIFF: https://github.com/llvm/llvm-project/commit/0e5706d018762f4ab4d895ba268bb6444ae04884.diff LO

[PATCH] D79754: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 1

saiislam marked 5 inline comments as done. saiislam added inline comments. Comment at: clang/lib/AST/Decl.cpp:3224 + if (Context.getTargetInfo().getTriple().isAMDGCN() && + Context.BuiltinInfo.isPredefinedLibFunction(BuiltinID) && jdoerfert wrote: > samee

[PATCH] D75169: [ARM] Enforcing calling convention for half-precision FP arguments and returns for big-endian AArch32

dnsampaio added a comment. In D75169#1952159 , @pratlucas wrote: > > Why not just make half as an argument do the right thing for that case? > > That would be the ideal approach, but currently there's a limitation on the > backend's calling convention low

[PATCH] D79938: [clangd] Add a flag to preserve type for recovery expression.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. hokein marked an inline comment as done. hokein added inline comments. Comment at: clang-too

[PATCH] D79378: PR34581: Don't remove an 'if (p)' guarding a call to 'operator delete(p)' under -Oz.

dnsampaio accepted this revision. dnsampaio added a comment. This revision is now accepted and ready to land. LGTM, as far @rjmccall 's concern about documentation is addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79378/new/ https://revie

[PATCH] D79754: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 1

saiislam updated this revision to Diff 263972. saiislam marked an inline comment as done. saiislam added a comment. Added test cases. Added a wrapper isGPU() for isNVPTX()/isAMDGCN(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79754/new/ https:/

[PATCH] D79704: [Analyzer] [NFC] Parameter Regions

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/MemRegion.cpp:191 +const ParmVarDecl *ParamRegion::getDecl() const { + const Decl *D = getStackFrame()->getDecl(); + baloghadamsoftware wrote: > NoQ wrote: > > This doesn't work when the callee

[PATCH] D79938: [clangd] Add a flag to preserve type for recovery expression.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1072 ParseInput.Contents = std::string(Input.Contents); + // FIXME: setup the recoveryAST and recoveryASTType in ParseInput properly. ---

[PATCH] D79932: [analyzer] Modernize analyzer's Python scripts

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks!! Note that there are no tests for these scripts. It's probably not too bad because these scripts *are* the tests but we might as well benefit from some quicker LIT tests that'll respond to

[PATCH] D78280: [Analyzer][StreamChecker] Track streams that were not found to be opened.

baloghadamsoftware added a comment. I like this idea, except the word `OpenEncountered`, but that might be a matter of taste. Please try this patch on several open-source projects, such as //BitCoin//, //CURL//, //OpenSSL//, //PostGreS//, //TMux// and //Xerces//. Then compare the results whethe

[PATCH] D79918: [clangd] Don't create as much garbage while building Dex index.

This revision was automatically updated to reflect the committed changes. Closed by commit rG735ab46cb414: [clangd] Don't create as much garbage while building Dex index. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79918/ne

[clang] cb1eeb4 - [Analyzer][VLASizeChecker] Check VLA size in typedef and sizeof.

Author: Balázs Kéri Date: 2020-05-14T14:30:05+02:00 New Revision: cb1eeb42c03c31d4dadd00dbaec693e6d7516099 URL: https://github.com/llvm/llvm-project/commit/cb1eeb42c03c31d4dadd00dbaec693e6d7516099 DIFF: https://github.com/llvm/llvm-project/commit/cb1eeb42c03c31d4dadd00dbaec693e6d7516099.diff L

[PATCH] D79754: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 1

yaxunl added inline comments. Comment at: llvm/include/llvm/ADT/Triple.h:700 return getArch() == Triple::r600 || getArch() == Triple::amdgcn; } sameerds wrote: > yaxunl wrote: > > jdoerfert wrote: > > > What's the difference between an AMDGPU and AMDGCN

[PATCH] D79921: [OpenMP] Fix omp and clang pragmas

ABataev added a comment. Tests? Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1736 + const AttributedStmt *AS = nullptr; + if (auto *OMPD = dyn_cast(&S)) { +const CapturedStmt *CS = OMPD->getCapturedStmt(OMPD_parallel); 1. Cast it to `OMPExecutableDirect

[PATCH] D79072: [Analyzer][VLASizeChecker] Check VLA size in typedef and sizeof.

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb1eeb42c03c: [Analyzer][VLASizeChecker] Check VLA size in typedef and sizeof. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79072/ne

[clang] c98872e - [analyzer] Modernize analyzer's Python scripts

Author: Valeriy Savchenko Date: 2020-05-14T15:55:37+03:00 New Revision: c98872e3a3c0fc4390e0892866d7e844df929179 URL: https://github.com/llvm/llvm-project/commit/c98872e3a3c0fc4390e0892866d7e844df929179 DIFF: https://github.com/llvm/llvm-project/commit/c98872e3a3c0fc4390e0892866d7e844df929179.d

[clang] 7b8e306 - [clang] Fix bug in #pragma float_control(push/pop)

Author: Melanie Blower Date: 2020-05-14T05:58:11-07:00 New Revision: 7b8e3065606cb555e7528e3b59d5e164ecf008fa URL: https://github.com/llvm/llvm-project/commit/7b8e3065606cb555e7528e3b59d5e164ecf008fa DIFF: https://github.com/llvm/llvm-project/commit/7b8e3065606cb555e7528e3b59d5e164ecf008fa.diff

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

ABataev added a comment. Do you have the tests for static locals and static data members with `default(firstprivate)`? Comment at: clang/lib/Parse/ParseOpenMP.cpp:2787 + if (getLangOpts().OpenMP < 51 && Kind == OMPC_default && + static_cast(Val.getValue().Type) == +

[PATCH] D79932: [analyzer] Modernize analyzer's Python scripts

This revision was automatically updated to reflect the committed changes. Closed by commit rGc98872e3a3c0: [analyzer] Modernize analyzer's Python scripts (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79932/new/ https://revi

[clang] d061685 - [analyzer] Make NonNullParamChecker as dependency for StdCLibraryFunctionsChecker

Author: Gabor Marton Date: 2020-05-14T15:28:40+02:00 New Revision: d061685a8304eb0b6adacd24f8dd2c2ef6dfee39 URL: https://github.com/llvm/llvm-project/commit/d061685a8304eb0b6adacd24f8dd2c2ef6dfee39 DIFF: https://github.com/llvm/llvm-project/commit/d061685a8304eb0b6adacd24f8dd2c2ef6dfee39.diff

[clang] ff4492c - [analyzer] StdLibraryFunctionsChecker: Add option to display loaded summaries

Author: Gabor Marton Date: 2020-05-14T15:40:58+02:00 New Revision: ff4492c89feb54e6ddfd6edaea59c98776963208 URL: https://github.com/llvm/llvm-project/commit/ff4492c89feb54e6ddfd6edaea59c98776963208 DIFF: https://github.com/llvm/llvm-project/commit/ff4492c89feb54e6ddfd6edaea59c98776963208.diff

[clang] 7c37684 - [analyzer] Improve PlacementNewChecker

Author: Gabor Marton Date: 2020-05-14T15:50:39+02:00 New Revision: 7c3768495e8c1599dc30986f7bd47d5e91f303f2 URL: https://github.com/llvm/llvm-project/commit/7c3768495e8c1599dc30986f7bd47d5e91f303f2 DIFF: https://github.com/llvm/llvm-project/commit/7c3768495e8c1599dc30986f7bd47d5e91f303f2.diff

[PATCH] D79942: [clang] Add an API to retrieve implicit constructor arguments.

mboehme created this revision. mboehme added a project: clang. Herald added a subscriber: cfe-commits. This is needed in Swift for C++ interop. As part of this change, I've had to make some changes to the interface of CGCXXABI to return the additional parameters separately rather than adding the

[PATCH] D79330: [Analyzer][VLASizeChecker] Check for VLA size overflow.

balazske added a comment. Is it worth to improve the checker by emitting a warning only if a `sizeof` is used on a `typedef`-ed VLA type where the size is too large (and at a VLA declaration with size overflow)? Or can this be done in a later change? Repository: rG LLVM Github Monorepo CHAN

[PATCH] D69520: [libc++] Disallow dynamic -> static span conversions

ldionne commandeered this revision. ldionne edited reviewers, added: jdoerrie; removed: ldionne. ldionne added a comment. Herald added subscribers: broadwaylamb, jkorous. In D69520#1878360 , @miscco wrote: > I believe this is superseded by the implementati

[PATCH] D79704: [Analyzer] [NFC] Parameter Regions

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/MemRegion.cpp:191 +const ParmVarDecl *ParamRegion::getDecl() const { + const Decl *D = getStackFrame()->getDecl(); + NoQ wrot

[PATCH] D76996: [analyzer] Improve PlacementNewChecker

martong added a comment. Thanks, just committed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76996/new/ https://reviews.llvm.org/D76996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D79420: [analyzer] Make NonNullParamChecker as dependency for StdCLibraryFunctionsChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rGd061685a8304: [analyzer] Make NonNullParamChecker as dependency for… (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79420/new/ https:/

[PATCH] D78118: [analyzer] StdLibraryFunctionsChecker: Add option to display loaded summaries

This revision was automatically updated to reflect the committed changes. Closed by commit rGff4492c89feb: [analyzer] StdLibraryFunctionsChecker: Add option to display loaded summaries (authored by martong). Changed prior to commit: https://reviews.llvm.org/D78118?vs=260930&id=263992#toc Repos

[PATCH] D76996: [analyzer] Improve PlacementNewChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rG7c3768495e8c: [analyzer] Improve PlacementNewChecker (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76996/new/ https://reviews.llvm.or

[clang] 5f1f4a5 - Prohibit capture of _ExtInt in inline assembly.

Author: Erich Keane Date: 2020-05-14T07:21:09-07:00 New Revision: 5f1f4a5d0157c11e0a88d9a273f49c8f866b01ef URL: https://github.com/llvm/llvm-project/commit/5f1f4a5d0157c11e0a88d9a273f49c8f866b01ef DIFF: https://github.com/llvm/llvm-project/commit/5f1f4a5d0157c11e0a88d9a273f49c8f866b01ef.diff L

[PATCH] D79903: FastMathFlags.allowContract should be init from FPFeatures.allowFPContractAcrossStatement

mibintc marked 2 inline comments as done. mibintc added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2943 + if (Opts.FastRelaxedMath) +Opts.setDefaultFPContractMode(LangOptions::FPM_Fast); Opts.HexagonQdsp6Compat = Args.hasArg(OPT_mqdsp6_compat);

[PATCH] D79423: [analyzer][NFC] StdLibraryFunctionsChecker: Add empty Signatures

martong planned changes to this revision. martong added a comment. We had a separate discussion with @xazax.hun. Let me summarize the outcome. We agreed that we should try our best to provide signatures for all functions (this affects child patches, particularly the POSIX related D79433

[PATCH] D78280: [Analyzer][StreamChecker] Track streams that were not found to be opened.

NoQ added inline comments. Comment at: clang/test/Analysis/stream.c:11-13 +void check_feread_noopen(FILE *fp) { + fread(0, 0, 0, fp); +} What do these tests test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7828

[PATCH] D79433: [analyzer] StdLibraryFunctionsChecker: Add summaries for POSIX

martong planned changes to this revision. martong added a comment. With @xazax.hun we agreed that we should try our best to provide signatures for all functions. This includes two major changes: 1. Add signatures to each summary here, possibly with `Irrelevant` types. 2. Add the ability to looku

[PATCH] D74813: Function block naming - add hash of parameter type to end of block name

erik.pilkington added a comment. In D74813#2035051 , @alexbdv wrote: > Could I please get a review on this ? Thanks :) ! I still think it makes more sense to directly encode the type instead of hashing it. I'm happy to make the demangler changes for wha

[PATCH] D78280: [Analyzer][StreamChecker] Track streams that were not found to be opened.

balazske marked an inline comment as done. balazske added a comment. Currently priority of this change is lower than D78374 . If a similar change is done a "escaped" stream state will be needed too. Comment at: clang/test/Analysis/stream.c:11-1

[clang] 0c5db3e - Fix test from 5f1f4a5

Author: Erich Keane Date: 2020-05-14T08:22:08-07:00 New Revision: 0c5db3e4aa197bab6e4d9f8c02ca0edf4fa9dce3 URL: https://github.com/llvm/llvm-project/commit/0c5db3e4aa197bab6e4d9f8c02ca0edf4fa9dce3 DIFF: https://github.com/llvm/llvm-project/commit/0c5db3e4aa197bab6e4d9f8c02ca0edf4fa9dce3.diff L

[PATCH] D79693: [test][ARM][CMSE] Use -ffreestanding for arm_cmse.h tests

hubert.reinterpretcast added a comment. Ping, @chill. It seems you checked these files in under D70817 . The way they were written has issues as indicated by the patch description. Please take a look; thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D79945: [Sema] Comparison of pointers to complete and incomplete types

pestctrl created this revision. pestctrl added a reviewer: rsmith. pestctrl added a project: clang. Clang is missing one of the conditions for C99 6.5.9p2, where comparison between pointers must either both point to incomplete types or both point to complete types. This patch adds an extra check

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

majnemer added inline comments. Comment at: clang/include/clang-c/Index.h:3254 CXType_FirstBuiltin = CXType_Void, CXType_LastBuiltin = CXType_ULongAccum, Should this be: CXType_LastBuiltin = CXType_BFloat16, Comment at: clang/lib/AST

[PATCH] D79675: [OpenMP][OMPBuilder] Adding Privatization Requirements to OMPIRBuilder

fghanim marked 7 inline comments as done. fghanim added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:101 +extern Type *IntPtrTy; +extern Type *SizeTy; + jdoerfert wrote: > jdoerfert wrote: > > I can totally see why we need `int` a

[PATCH] D79675: [OpenMP][OMPBuilder] Adding Privatization Requirements to OMPIRBuilder

fghanim updated this revision to Diff 264006. fghanim marked an inline comment as done. fghanim added a comment. - removed many Definitions from OMPKinds.def due to being added in D79739 - made changes based on reviewer comments - added unit test for `CreateCopyi

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

SjoerdMeijer added inline comments. Comment at: clang/docs/LanguageExtensions.rst:518 +Clang supports three half-precision (16-bit) floating point types: ``__fp16``, +``_Float16`` and ``__bf16``. These types are supported in all language modes. Not my field of

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

Xiangling_L updated this revision to Diff 264009. Xiangling_L added a comment. Clean `clang-tidy` warnings and `clang-format` errors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74166/new/ https://reviews.llvm.org/D74166 Files: clang/include/cl

[PATCH] D79704: [Analyzer] [NFC] Parameter Regions

Szelethus added a comment. In D79704#2034571 , @NoQ wrote: > In D79704#2032947 , @Szelethus wrote: > > > In D79704#2032271 , @NoQ wrote: > > > > > Blanket reply! `ParamRegion

[PATCH] D79693: [test][ARM][CMSE] Use -ffreestanding for arm_cmse.h tests

chill added a comment. I'm sorry, I don't understand the issue. Certainly it's the compiler (driver) responsibility to setup include paths according to the selected target. How do you trigger a problem? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D70351: [clang][WIP][clang-scan-deps] Add an experimental C API.

kousikk added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70351/new/ https://reviews.llvm.org/D70351 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D79715: [clang-format] Update GoogleStyle for C# code to match Google's internal C# style guide

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Assuming you either work for google and understand their style or are qualified to say this is their style then this LGTM What I couldn't see from the link was where the google

[PATCH] D79465: [clang-format] Fix line lengths w/ comments in align

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/WhitespaceManager.cpp:417 +LineLengthAfter += Changes[j].TokenLength; +} unsigned ChangeMaxColumn = Style.ColumnLimit - LineLengthAfter; could you help us here with a comment, I d

[PATCH] D34252: Add arbitrary file/path support to clang-format style file selection

MyDeveloperDay added a comment. I think we can abandon this revision now we support --style=file: CHANGES SINCE LAST ACTION https://reviews.llvm.org/D34252/new/ https://reviews.llvm.org/D34252 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D79000: [clang-format] C# property formatting can be controlled by config options

MyDeveloperDay added a comment. I'm ok with your suggestion if you want to land this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79000/new/ https://reviews.llvm.org/D79000 ___ cfe-commits mailing li

[clang] 235fb7d - AMDGPU/OpenCL: Accept -nostdlib in place of -nogpulib

Author: Matt Arsenault Date: 2020-05-14T12:33:31-04:00 New Revision: 235fb7dc24b1cf7034dfc76bb853ffb4ac5dec5d URL: https://github.com/llvm/llvm-project/commit/235fb7dc24b1cf7034dfc76bb853ffb4ac5dec5d DIFF: https://github.com/llvm/llvm-project/commit/235fb7dc24b1cf7034dfc76bb853ffb4ac5dec5d.diff

[PATCH] D79676: [Clang][OpenMP][OMPBuilder] Moving OMP allocation and cache creation code to OMPBuilderCBHelpers

fghanim marked 4 inline comments as done. fghanim added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:878 + [this, VDInit, OriginalAddr, VD, ThisFirstprivateIsLastprivate, + OrigVD, &Lastprivates, IRef, &OMPBuilder]() {

[PATCH] D79676: [Clang][OpenMP][OMPBuilder] Moving OMP allocation and cache creation code to OMPBuilderCBHelpers

fghanim updated this revision to Diff 264012. fghanim marked an inline comment as done. fghanim added a comment. updating in response to review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79676/new/ https://reviews.llvm.org/D79676 Files

[PATCH] D79948: [OPENMP50]Codegen for inscan reductions in worksharing directives.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: arphaman, guansong, yaxunl. Herald added a project: clang. Implemented codegen for reduction clauses with inscan modifiers in worksharing constructs. Emits the code for the directive with inscan reductio

[PATCH] D79693: [test][ARM][CMSE] Use -ffreestanding for arm_cmse.h tests

hubert.reinterpretcast added a comment. In D79693#2036599 , @chill wrote: > How do you trigger a problem? If your build was configured with `DEFAULT_SYSROOT` to a toolchain path that has a `/include` directory, then the contents of that directory would

[PATCH] D79754: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 1

arsenm added inline comments. Comment at: llvm/include/llvm/ADT/Triple.h:699 + /// Tests whether the target is a GPU i.e. NVPTX or AMDGCN + bool isGPU() const { return isNVPTX() || isAMDGCN(); } + This is skipping out r600, and probably should leave this in cla

[PATCH] D79677: [clang][OpenMP][OMPIRBuilder] Adding some Privatization clauses to OpenMP `parallel` Directive

fghanim marked 2 inline comments as done. fghanim added a comment. In D79677#2032942 , @jdoerfert wrote: > Generally you copied the existing Clang logic, correct? Well, Yes and no. I tried to keep as much as I can of the original implementation, however

[PATCH] D79788: AMDGPU/OpenCL: Accept -nostdlib in place of -nogpulib

arsenm closed this revision. arsenm added a comment. 235fb7dc24b1cf7034dfc76bb853ffb4ac5dec5d CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79788/new/ https://reviews.llvm.org/D79788 __

[clang-tools-extra] 10b4931 - [test] NFC, add missing declarations and include to test files to avoid 'implicit-function-declaration' diagnostics in the tests

Author: Alex Lorenz Date: 2020-05-14T10:01:50-07:00 New Revision: 10b49315faa6338eaf52bb782e7c53644ad17dab URL: https://github.com/llvm/llvm-project/commit/10b49315faa6338eaf52bb782e7c53644ad17dab DIFF: https://github.com/llvm/llvm-project/commit/10b49315faa6338eaf52bb782e7c53644ad17dab.diff L

[PATCH] D79035: [clang][AIX] Implement ABIInfo and TargetCodeGenInfo for AIX

ZarkoCA added a comment. I'm ok with this now. I will let @Xiangling_L approve if she's ok with it since she had the last few comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79035/new/ https://reviews.llvm.org/D79035 ___ cfe-commit

[PATCH] D79693: [test][ARM][CMSE] Use -ffreestanding for arm_cmse.h tests

chill added a comment. I see. I can also count (`grep -rn '#include.*https://reviews.llvm.org/D79693/new/ https://reviews.llvm.org/D79693 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D79257: [OPENMP50]Codegen for uses_allocators clause.

ABataev updated this revision to Diff 264020. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79257/new/ https://reviews.llvm.org/D79257 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOpenMPRunti

[PATCH] D79919: [Driver] Pass -plugin-opt=O2 for -Os -Oz and -plugin-opt=O1 for -Og

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/Driver/lto.c:52 +// RUN: %clang -target x86_64-unknown-linux-gnu --sysroot %S/Inputs/basic_cross_linux_tree %s \ +// RUN: -fuse-ld=lld -flto -O -###

[PATCH] D79715: [clang-format] Update GoogleStyle for C# code to match Google's internal C# style guide

jbcoe planned changes to this revision. jbcoe added a comment. I will get the Google Style guide uploaded and update this patch with a link. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79715/new/ https://reviews.llvm.org/D79715 ___

[clang] 5ecb514 - [Driver] Pass -plugin-opt=O2 for -Os -Oz and -plugin-opt=O1 for -Og

Author: Fangrui Song Date: 2020-05-14T10:37:33-07:00 New Revision: 5ecb51414637402b0f89a96924ac7b015d23bcfa URL: https://github.com/llvm/llvm-project/commit/5ecb51414637402b0f89a96924ac7b015d23bcfa DIFF: https://github.com/llvm/llvm-project/commit/5ecb51414637402b0f89a96924ac7b015d23bcfa.diff

[PATCH] D79950: [clangd] Avoid wasteful data structures in RefSlab::Builder

sammccall created this revision. sammccall added a reviewer: kbobyrev. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, mgrang, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This is worth another 10% or so on InedxBenchmark.DexBuild. Repository: rG LLVM

[PATCH] D76420: Prevent IR-gen from emitting consteval declarations

Tyker updated this revision to Diff 264023. Tyker added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76420/new/ https://reviews.llvm.org/D76420 Files: clang/include/clang/AST/Expr.h clang/lib/AST/Expr.cpp clang/lib/AST/Ex

[PATCH] D79257: [OPENMP50]Codegen for uses_allocators clause.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. FWIW, we should directly add new runtime functions we emit into OMPKinds.def. That saves us the trouble of searching for the ones we missed later. Repository: rG LLVM Github Mo

  1   2   >