baloghadamsoftware added a comment.

I like this idea, except the word `OpenEncountered`, but that might be a matter 
of taste. Please try this patch on several open-source projects, such as 
//BitCoin//, //CURL//, //OpenSSL//, //PostGreS//, //TMux// and //Xerces//. Then 
compare the results whether we have more or less true and false positives.



================
Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:36
+  /// (False if the stream was first encountered in a non-opening function.)
+  bool OpenEncountered;
 
----------------
Maybe `SawOpened` or `ExplicitlyOpened`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78280/new/

https://reviews.llvm.org/D78280



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to