[clang-tools-extra] 72439b6 - [clangd] Add a flag to turn on recovery-expr.

Author: Haojian Wu Date: 2020-04-01T09:03:56+02:00 New Revision: 72439b6b9557d5c58ec7f95a14722ef581906a17 URL: https://github.com/llvm/llvm-project/commit/72439b6b9557d5c58ec7f95a14722ef581906a17 DIFF: https://github.com/llvm/llvm-project/commit/72439b6b9557d5c58ec7f95a14722ef581906a17.diff LO

[PATCH] D77066: [analyzer] ApiModeling: Add buffer size arg constraint

Charusso added a comment. In D77066#1953280 , @Charusso wrote: > getDynamicSizeWithOffset(State, MR, SVB) { > Offset = State->getStoreManager().getStaticOffset(MR, SVB); > ... > } > Hm, the MemRegion's offset should be great. I was thinking a

[PATCH] D77142: [clangd] Add a flag to turn on recovery-expr.

hokein updated this revision to Diff 254097. hokein added a comment. mention C++ only. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77142/new/ https://reviews.llvm.org/D77142 Files: clang-tools-extra/clangd/ClangdServer.cpp clang-tools-extra/

[PATCH] D75181: [AArch64] Handle BTI/PAC in case of generated functions.

chill added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1828 + if (CodeGenOpts.BranchTargetEnforcement) { +FuncAttrs.addAttribute("branch-target-enforcement", "true"); + } danielkiss wrote: > chill wrote: > > I would really prefer to not set v

[PATCH] D77142: [clangd] Add a flag to turn on recovery-expr.

This revision was automatically updated to reflect the committed changes. Closed by commit rG72439b6b9557: [clangd] Add a flag to turn on recovery-expr. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77142/new/ https://reviews.l

[clang] 57fd86d - [AVR] Fix function pointer address space

Author: Vlastimil Labsky Date: 2020-04-01T21:08:37+13:00 New Revision: 57fd86de879cf2b4c7001b6d0a09df60877ce24d URL: https://github.com/llvm/llvm-project/commit/57fd86de879cf2b4c7001b6d0a09df60877ce24d DIFF: https://github.com/llvm/llvm-project/commit/57fd86de879cf2b4c7001b6d0a09df60877ce24d.di

[PATCH] D77194: [clang] Persist Attr::IsPackExpansion into the serialized AST

kadircet added a comment. oh wow! thanks for looking into this. Looking at the history, it seems like an oversight. The patch that introduced packexpansion bit: https://github.com/llvm/llvm-project/commit/44c247f0f009eec70a193335c8a353d6f8602bfd. it didn't add that field to pchattr serializat

[PATCH] D77194: [clang] Persist Attr::IsPackExpansion into the serialized AST

kadircet added a comment. also please update the commit message to mention "PCH" rather than "serialized ast". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77194/new/ https://reviews.llvm.org/D77194

[PATCH] D70411: [analyzer] CERT: STR31-C

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/cert/StrChecker.cpp:55 + // they can cause a not null-terminated string. In this case we store the + // string is being not null-terminated in the 'NullTerminationMap'. + // The func

[PATCH] D77119: [AVR] Fix function pointer address space

This revision was automatically updated to reflect the committed changes. Closed by commit rG57fd86de879c: [AVR] Fix function pointer address space (authored by vlastik, committed by dylanmckay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77119/ne

[PATCH] D77131: [clang] Move branch-protection from CodeGenOptions to LangOptions

tamas.petz added a comment. Tests pass, however, I am not sure ParseLangArgs is called in all the necessary cases (see the occurrences in the code). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77131/new/ https://reviews.llvm.org/D77131 __

[PATCH] D77199: [clang-tidy] Address false positive in modernize-use-default-member-init

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, gribozavr2. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Fixes incorrect warning emitted by "modernize-use-default-member-init" (new to 10.0.0)

[PATCH] D75171: [Analyzer] Fix for incorrect use of container and iterator checkers

sylvestre.ledru added a comment. @baloghadamsoftware @Szelethus it would be great to have the name of the checkers in the error message The error is "error: checker cannot be enabled with analyzer option 'aggressive-binary-operation-simplification' == false" and I had to look at this patch to un

[PATCH] D77193: [X86] Add SERIALIZE instruction.

tianqing updated this revision to Diff 254114. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77193/new/ https://reviews.llvm.org/D77193 Files: clang/docs/ClangCommandLineReference.rst clang/include/clang/Basic/BuiltinsX86.def clang/include/clang/Driver/Options.td clang/lib/Basic/

[clang] 08a53db - [clang] Minor cleanup in CloneDetectionTest

Author: Raphael Isemann Date: 2020-04-01T10:48:50+02:00 New Revision: 08a53dba93389a9859c12e948d8281a839cffbdb URL: https://github.com/llvm/llvm-project/commit/08a53dba93389a9859c12e948d8281a839cffbdb DIFF: https://github.com/llvm/llvm-project/commit/08a53dba93389a9859c12e948d8281a839cffbdb.dif

[clang-tools-extra] 038f03c - [clangd] Force delayed-template-parsing off in code completion.

Author: Sam McCall Date: 2020-04-01T11:09:15+02:00 New Revision: 038f03cb5ef5d44676cbde06560ed2668f4a7acc URL: https://github.com/llvm/llvm-project/commit/038f03cb5ef5d44676cbde06560ed2668f4a7acc DIFF: https://github.com/llvm/llvm-project/commit/038f03cb5ef5d44676cbde06560ed2668f4a7acc.diff LO

[PATCH] D77131: [clang] Move branch-protection from CodeGenOptions to LangOptions

chill added a reviewer: efriedma. chill added a subscriber: efriedma. chill added a comment. Following @efriedma comment here http://lists.llvm.org/pipermail/cfe-dev/2020-March/065017.html LGTM. Comment at: clang/include/clang/Basic/TargetInfo.h:18 #include "clang/Basic/Addr

[PATCH] D77176: [clangd] Force delayed-template-parsing off in code completion.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77176/new/ https://reviews.llvm.org/D77176 __

[PATCH] D77176: [clangd] Force delayed-template-parsing off in code completion.

This revision was automatically updated to reflect the committed changes. Closed by commit rG038f03cb5ef5: [clangd] Force delayed-template-parsing off in code completion. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77176/ne

[PATCH] D77041: [AST] Fix a crash on invalid constexpr Ctorinitializer when building RecoveryExpr.

hokein marked 2 inline comments as done. hokein added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:1688 CheckConstexprKind Kind) { + assert(!NewFD->isInvalidDecl()); const CXXMethodDecl *MD = dyn_cast(NewFD); ---

[PATCH] D75171: [Analyzer] Fix for incorrect use of container and iterator checkers

Szelethus added a comment. In D75171#1954279 , @sylvestre.ledru wrote: > @baloghadamsoftware @Szelethus it would be great to have the name of the > checkers in the error message > The error is "error: checker cannot be enabled with analyzer option > 'a

[PATCH] D75561: Remove const qualifier from Modules returned by ExternalASTSource. (NFC)

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. I seems quite a lot of APIs in Clang are already requiring non-const Modules so I think this is fine to make D75488 possible. Let's ship it CHANGES SI

[PATCH] D77204: [clangd] Run semaCodeComplete only with a preamble

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. It is used by code completion and signature help. Code completion already uses a special no-compile mod

[PATCH] D77041: [AST] Fix a crash on invalid constexpr Ctorinitializer when building RecoveryExpr.

sammccall added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:5005 +if (Member->getInit() && Member->getInit()->containsErrors()) + Constructor->setInvalidDecl(); if (Member->isBaseInitializer()) hokein wrote: > rsmith wrote: > > rsmit

[PATCH] D77205: [X86] Add TSXLDTRK instructions.

tianqing created this revision. tianqing added reviewers: craig.topper, RKSimon, LuoYuanke. Herald added subscribers: cfe-commits, hiraditya, mgorny. Herald added a project: clang. For more details about these instructions, please refer to the latest ISE document: https://software.intel.com/en-u

[PATCH] D77134: [clang][AARCH64] Add __ARM_FEATURE_{PAC, BTI}_DEFAULT defines

chill accepted this revision. chill added a comment. This revision is now accepted and ready to land. LGTM, conditional on the dependent patch. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77134/new/ https://reviews.llvm.org/D77134

[PATCH] D75181: [AArch64] Handle BTI/PAC in case of generated functions.

danielkiss added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1828 + if (CodeGenOpts.BranchTargetEnforcement) { +FuncAttrs.addAttribute("branch-target-enforcement", "true"); + } chill wrote: > danielkiss wrote: > > chill wrote: > > > I would re

[PATCH] D77206: [clangd] Don't send semanticHighlights to clients that support semanticTokens.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This allows the standard mechanism to gracefully displace the old one. Repository: rG LLVM

[PATCH] D76238: [SveEmitter] Implement builtins for contiguous loads/stores

sdesmalen added a comment. @SjoerdMeijer are you happy with the changes I've made to the tests? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76238/new/ https://reviews.llvm.org/D76238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D76617: [SveEmitter] Fix encoding/decoding of SVETypeFlags

sdesmalen updated this revision to Diff 254148. sdesmalen marked an inline comment as done. sdesmalen added a comment. - Made Flags `uint64_t` instead of `unsigned`. - Simplified encoding of flags in SveEmitter and moved encoding of properties into the `Flags` variable to the constructor of Intri

[PATCH] D76238: [SveEmitter] Implement builtins for contiguous loads/stores

SjoerdMeijer added a comment. Thanks for the ping, hadn't noticed the updates. I may have also missed why you need the SVE_ACLE_FUNC macro. Can you quickly comment why you need that? Just asking because in my opinion it doesn't really make it more pleasant to read (so it's there for another rea

[clang-tools-extra] 43aa04e - [clangd] Run semaCodeComplete only with a preamble

Author: Kadir Cetinkaya Date: 2020-04-01T13:02:47+02:00 New Revision: 43aa04eb7a617ee75dfcbbe2d395b8208e66c0e0 URL: https://github.com/llvm/llvm-project/commit/43aa04eb7a617ee75dfcbbe2d395b8208e66c0e0 DIFF: https://github.com/llvm/llvm-project/commit/43aa04eb7a617ee75dfcbbe2d395b8208e66c0e0.dif

[PATCH] D76679: [SveEmitter] Add more immediate operand checks.

sdesmalen marked an inline comment as done. sdesmalen added a comment. (sorry, I wrote the comments earlier but forgot to click 'submit' :) ) Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/negative/acle_sve_ext.c:1 +// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -targ

[PATCH] D77048: [Clang][CodeGen] Fixing mismatch between memory layout and const expressions for oversized bitfields

pratlucas marked 2 inline comments as done. pratlucas added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:613 + + // Add padding bits in case of over-sized bit-field. + // "The first sizeof(T)*8 bits are used to hold the value of the bit-field, -

[PATCH] D76678: [SveEmitter] Add range checks for immediates and predicate patterns.

sdesmalen marked 3 inline comments as done. sdesmalen added inline comments. Comment at: clang/include/clang/Basic/arm_sve.td:153 +} +def ImmCheckPredicatePattern: ImmCheckType<0>; // 0..31 +def ImmCheck1_16: ImmCheckType<1>; // 1..16 Sjoerd

[PATCH] D77209: [Syntax] Add mapping from spelled to expanded tokens for TokenBuffer

hlopko created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Same restrictions apply as in the other direction: macro arguments are not supported yet, only full macro expansions can be mapped. Taking over from https://reviews.llvm.org/D72581. Repository:

[PATCH] D77048: [Clang][CodeGen] Fixing mismatch between memory layout and const expressions for oversized bitfields

pratlucas updated this revision to Diff 254156. pratlucas added a comment. Removing unecessary handling of padding bits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77048/new/ https://reviews.llvm.org/D77048 Files: clang/lib/CodeGen/CGExprCons

[PATCH] D76238: [SveEmitter] Implement builtins for contiguous loads/stores

sdesmalen added a comment. In D76238#1954585 , @SjoerdMeijer wrote: > Thanks for the ping, hadn't noticed the updates. > > I may have also missed why you need the SVE_ACLE_FUNC macro. Can you quickly > comment why you need that? Just asking because in my

[PATCH] D77204: [clangd] Run semaCodeComplete only with a preamble

This revision was automatically updated to reflect the committed changes. Closed by commit rG43aa04eb7a61: [clangd] Run semaCodeComplete only with a preamble (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D77204?vs=254133&id=254165#toc Repository: rG LLVM Github Mo

[PATCH] D76432: [clangd] Add a tweak for adding "using" statement.

adamcz added a comment. In D76432#1952798 , @sammccall wrote: > Still LG, should I land this? Yes please :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76432/new/ https://reviews.llvm.org/D76432

[clang-tools-extra] db3d64e - [clangd-vscode] NFC; Improve wording in documentation and update VSCode tasks

Author: Kirill Bobyrev Date: 2020-04-01T14:16:55+02:00 New Revision: db3d64eebbe0aad87631c6fada01b06753377a44 URL: https://github.com/llvm/llvm-project/commit/db3d64eebbe0aad87631c6fada01b06753377a44 DIFF: https://github.com/llvm/llvm-project/commit/db3d64eebbe0aad87631c6fada01b06753377a44.diff

[PATCH] D76679: [SveEmitter] Add more immediate operand checks.

SjoerdMeijer added a comment. Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/negative/acle_sve_ext.c:1 +// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sve -fallow-half-arguments-and-returns -fsyntax-only -verify -D__ARM_FEATURE_SVE %s +

[PATCH] D77077: [clang] CodeGen: Make getOrEmitProtocol public for Swift

aschwaighofer updated this revision to Diff 254171. aschwaighofer added a comment. - Implement for the GNU runtimes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77077/new/ https://reviews.llvm.org/D77077 Files: clang/include/clang/CodeGen/CodeG

[PATCH] D76595: [clangd-vscode] NFC; Improve wording in documentation and update VSCode tasks

This revision was automatically updated to reflect the committed changes. Closed by commit rGdb3d64eebbe0: [clangd-vscode] NFC; Improve wording in documentation and update VSCode tasks (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D77041: [AST] Fix a crash on invalid constexpr Ctorinitializer when building RecoveryExpr.

hokein updated this revision to Diff 254170. hokein added a comment. refine the fix based on the comment: now constexpr ctor with error initializers is still a valid decl but not constant-evaluate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7704

[PATCH] D77077: [clang] CodeGen: Make getOrEmitProtocol public for Swift

aschwaighofer marked an inline comment as done. aschwaighofer added inline comments. Comment at: clang/lib/CodeGen/CGObjCRuntime.h:217 + /// ProtocolPtrTy. + virtual llvm::Constant *GetOrEmitProtocol(const ObjCProtocolDecl *PD) = 0; + rjmccall wrote: > aschwaig

[PATCH] D77131: [clang] Move branch-protection from CodeGenOptions to LangOptions

tamas.petz updated this revision to Diff 254174. tamas.petz added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77131/new/ https://reviews.llvm.org/D77131 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Basic/CodeGenOption

[PATCH] D77148: [analyzer] ApiModeling: Add buffer size arg constraint with multiplier involved

balazske added inline comments. Comment at: clang/test/Analysis/std-c-library-functions-arg-constraints.c:155 + __buf_size_arg_constraint_mul(buf, s, sizeof(short)); + clang_analyzer_eval(s * sizeof(short) <= 6); // \ + // report-warning{{TRUE}} \ `s <= 3` is

[clang-tools-extra] 43eca88 - Fix "control reaches end of non-void function" warning. NFCI.

Author: Simon Pilgrim Date: 2020-04-01T14:08:48+01:00 New Revision: 43eca880c6eda10fd191c4e9e04bf04830c9c6f2 URL: https://github.com/llvm/llvm-project/commit/43eca880c6eda10fd191c4e9e04bf04830c9c6f2 DIFF: https://github.com/llvm/llvm-project/commit/43eca880c6eda10fd191c4e9e04bf04830c9c6f2.diff

[PATCH] D76679: [SveEmitter] Add more immediate operand checks.

sdesmalen marked an inline comment as done. sdesmalen added a subscriber: rsandifo-arm. sdesmalen added inline comments. Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/negative/acle_sve_ext.c:1 +// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sve -fallo

[PATCH] D72581: [Syntax] Add mapping from spelled to expanded tokens for TokenBuffer

hlopko marked 5 inline comments as done. hlopko added a comment. I'm submitting this patch at https://reviews.llvm.org/D77209 (with Ilya's permission). Let's continue the review there. Comment at: clang/include/clang/Tooling/Syntax/Tokens.h:228 + /// multiple times and this f

[PATCH] D77209: [Syntax] Add mapping from spelled to expanded tokens for TokenBuffer

hlopko updated this revision to Diff 254188. hlopko added a comment. Adding comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77209/new/ https://reviews.llvm.org/D77209 Files: clang/include/clang/Tooling/Syntax/Tokens.h clang/lib/Tooling

[PATCH] D77148: [analyzer] ApiModeling: Add buffer size arg constraint with multiplier involved

martong marked 2 inline comments as done. martong added inline comments. Comment at: clang/test/Analysis/std-c-library-functions-arg-constraints.c:155 + __buf_size_arg_constraint_mul(buf, s, sizeof(short)); + clang_analyzer_eval(s * sizeof(short) <= 6); // \ + // report-warnin

[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX

ZarkoCA updated this revision to Diff 254193. ZarkoCA added a comment. Fixed test cases that were breaking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76130/new/ https://reviews.llvm.org/D76130 Files: llvm/lib/Target/PowerPC/PPCISelLowering.c

[clang] e3033c0 - [llvm][clang][IFS] Enhancing the llvm-ifs yaml format for symbol lists.

Author: Puyan Lotfi Date: 2020-04-01T10:49:06-04:00 New Revision: e3033c0ce5517efddbf92a079ad1e0ca4868591f URL: https://github.com/llvm/llvm-project/commit/e3033c0ce5517efddbf92a079ad1e0ca4868591f DIFF: https://github.com/llvm/llvm-project/commit/e3033c0ce5517efddbf92a079ad1e0ca4868591f.diff L

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

jasonliu added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:10019 + return SetCGInfo( + new PPCAIX32TargetCodeGenInfo(Types, CodeGenOpts.FloatABI == "soft")); return SetCGInfo( ZarkoCA wrote: > jasonliu wrote: > > Does AIX hav

[PATCH] D76979: [clang][llvm] Interface Stubs new yaml file format changes.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGe3033c0ce551: [llvm][clang][IFS] Enhancing the llvm-ifs yaml format for symbol lists. (authored by plotfi). Repository:

[PATCH] D76790: [analyzer] StdLibraryFunctionsChecker: fix bug with arg constraints

martong added a comment. Ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76790/new/ https://reviews.llvm.org/D76790 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D77219: UBSan ␇ runtime

jfb created this revision. Herald added subscribers: Sanitizers, cfe-commits, ributzka, dexonsmith, jkorous, cryptoad, mgorny. Herald added projects: clang, Sanitizers. jfb edited the summary of this revision. Yes, this is April 1st and the patch isn't particularly serious. There is a ␇ UBSan ru

[clang-tools-extra] c6a65bb - clagn-tidy/doc: Add a link to readability-static-accessed-through-instance from readability-convert-member-functions-to-static

Author: Sylvestre Ledru Date: 2020-04-01T17:01:48+02:00 New Revision: c6a65bb93f218dbdec98f51952a309afda5608ea URL: https://github.com/llvm/llvm-project/commit/c6a65bb93f218dbdec98f51952a309afda5608ea DIFF: https://github.com/llvm/llvm-project/commit/c6a65bb93f218dbdec98f51952a309afda5608ea.dif

[PATCH] D76679: [SveEmitter] Add more immediate operand checks.

SjoerdMeijer added inline comments. Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/negative/acle_sve_ext.c:1 +// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sve -fallow-half-arguments-and-returns -fsyntax-only -verify -D__ARM_FEATURE_SVE %s + -

[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX

jasonliu added inline comments. Comment at: llvm/test/CodeGen/PowerPC/aix32-cc-abi-vaarg.ll:8 + + target datalayout = "E-m:e-p:32:32-i64:64-n32" + target triple = "powerpc-ibm-aix-xcoff" minor nit: I don't think these target datalayout and triple are necessary.

[PATCH] D70265: [clang-tidy] Add CppCoreGuidelines I.2 "Avoid non-const global variables" check

vingeldal added a comment. After looking more closely at the code I think the issue is within hasLocalStorage() which is called in hasGlobalStorage(). My expectation would be that anything inside of function scope would be considered local but I'm not very certain. Any thoughts on whether hasLo

[PATCH] D77221: [AVR] Rework MCU family detection to support more AVR MCUs

vlastik created this revision. vlastik added a reviewer: dylanmckay. Herald added subscribers: cfe-commits, Jim, hiraditya, mgorny. Herald added a project: clang. AVR port now supports only ATmega328. This patch makes more MCUs work with clang Repository: rG LLVM Github Monorepo https://revie

[clang] 3500cc8 - [analyzer] RetainCountChecker: Add a suppression for OSSymbols.

Author: Artem Dergachev Date: 2020-04-01T18:16:44+03:00 New Revision: 3500cc8d891bb3825bb3275affe6db8b12f2f695 URL: https://github.com/llvm/llvm-project/commit/3500cc8d891bb3825bb3275affe6db8b12f2f695 DIFF: https://github.com/llvm/llvm-project/commit/3500cc8d891bb3825bb3275affe6db8b12f2f695.dif

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

ZarkoCA marked 4 inline comments as done. ZarkoCA added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:10019 + return SetCGInfo( + new PPCAIX32TargetCodeGenInfo(Types, CodeGenOpts.FloatABI == "soft")); return SetCGInfo( jasonliu

[PATCH] D76140: [InlineFunction] update attributes during inlining

anna requested review of this revision. anna added a comment. fixed buildbot failure. see above comments and added testcase `test8`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76140/new/ https://reviews.llvm.org/D76140 ___

[PATCH] D76140: [InlineFunction] update attributes during inlining

anna updated this revision to Diff 254213. anna added a comment. This revision is now accepted and ready to land. whitelist valid return attributes and only add those. Added testcase for signext. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76140/

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

ZarkoCA updated this revision to Diff 254214. ZarkoCA marked an inline comment as done. ZarkoCA added a comment. Set isSoftFloat to return false for AIX. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76360/new/ https://reviews.llvm.org/D76360 Files: clang/lib/Basic/Targets/PPC.h cl

[PATCH] D77219: UBSan ␇ runtime

regehr added a comment. Sorry but I don't think this can land until it has options for sending sanitizer output to Slack channels and SMS numbers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77219/new/ https://reviews.llvm.org/D77219

[PATCH] D77222: [clangd] Fix an assertion crash in ReferenceFinder.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. The assertion is almost correct, but it fails on refs from non-preamble Repository: rG LLVM Github Monorep

[PATCH] D77077: [clang] CodeGen: Make getOrEmitProtocol public for Swift

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77077/new/ https://reviews.llvm.org/D77077 __

[PATCH] D70366: Add new 'flatten' LLVM attribute to fix clang's 'flatten' function attribute

LevitatingLion updated this revision to Diff 254217. LevitatingLion added a comment. Herald added a reviewer: sstefan1. I rebased my changes onto 49d00824bbb , renamed the attribute to 'alwaysinline_recursively', and added some

[clang] 153dadf - [clang] CodeGen: Make getOrEmitProtocol public for Swift

Author: Arnold Schwaighofer Date: 2020-04-01T08:55:56-07:00 New Revision: 153dadf3a3ca3c47f8c0fb718ec96616a05e42fd URL: https://github.com/llvm/llvm-project/commit/153dadf3a3ca3c47f8c0fb718ec96616a05e42fd DIFF: https://github.com/llvm/llvm-project/commit/153dadf3a3ca3c47f8c0fb718ec96616a05e42fd

[PATCH] D76679: [SveEmitter] Add more immediate operand checks.

sdesmalen marked an inline comment as done. sdesmalen added inline comments. Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/negative/acle_sve_ext.c:1 +// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sve -fallow-half-arguments-and-returns -fsyntax-only -

[PATCH] D77219: UBSan ␇ runtime

lebedev.ri added inline comments. Comment at: compiler-rt/lib/ubsan_bel/ubsan_bel_handlers.cpp:40-42 +static std::random_device r; +static std::default_random_engine e(r()); +static std::uniform_int_distribution d(0, sizeof(quips) / sizeof(quips[0]) - 1); ---

[PATCH] D77077: [clang] CodeGen: Make getOrEmitProtocol public for Swift

This revision was automatically updated to reflect the committed changes. Closed by commit rG153dadf3a3ca: [clang] CodeGen: Make getOrEmitProtocol public for Swift (authored by aschwaighofer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77077/new/

[PATCH] D76140: [InlineFunction] update attributes during inlining

anna updated this revision to Diff 254222. anna added a comment. fixed missing code left out during rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76140/new/ https://reviews.llvm.org/D76140 Files: llvm/lib/Transforms/Utils/InlineFunction.

[PATCH] D77225: [clangd] Support textDocument/semanticTokens/edits

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, mgrang, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This returns incremental highlights as a set of edits against the previous highlights.

[PATCH] D77062: [analyzer] Added check for unaccaptable equality operation between Loc and NonLoc types

ASDenysPetrov updated this revision to Diff 254225. ASDenysPetrov edited the summary of this revision. ASDenysPetrov added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Reworked solution. Simplified CStringChecker::assumeZero. Added test (taken from the bug).

[PATCH] D77219: UBSan ␇ runtime

jfb marked an inline comment as done. jfb added inline comments. Comment at: compiler-rt/lib/ubsan_bel/ubsan_bel_handlers.cpp:40-42 +static std::random_device r; +static std::default_random_engine e(r()); +static std::uniform_int_distribution d(0, sizeof(quips) / siz

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

erichkeane added a comment. Trying to help Melanie respond to the comments, so I ran through the patch and came up with the following comments/responses. Sorry for the 'surprise hit' :) Comment at: clang/include/clang/AST/Expr.h:3474 + static unsigned sizeOfTrailingObjects(b

[clang] 6593360 - AMDGPU: Fix consistently backwards logic for default denormal mode

Author: Matt Arsenault Date: 2020-04-01T12:36:22-04:00 New Revision: 6593360ee760c0c98cf7fb05be70aa4ea455a42a URL: https://github.com/llvm/llvm-project/commit/6593360ee760c0c98cf7fb05be70aa4ea455a42a DIFF: https://github.com/llvm/llvm-project/commit/6593360ee760c0c98cf7fb05be70aa4ea455a42a.diff

[clang] 4ea3650 - HIP: Link correct denormal mode library

Author: Matt Arsenault Date: 2020-04-01T12:36:22-04:00 New Revision: 4ea3650c212ae471657d3a253cd424ce9d1316ac URL: https://github.com/llvm/llvm-project/commit/4ea3650c212ae471657d3a253cd424ce9d1316ac DIFF: https://github.com/llvm/llvm-project/commit/4ea3650c212ae471657d3a253cd424ce9d1316ac.diff

[clang] 95fac2e - [WebAssembly] Rename SIMD min/max/avgr intrinsics for consistency

Author: Thomas Lively Date: 2020-04-01T09:38:41-07:00 New Revision: 95fac2e46b73c67495dbdb43ef178d33281c05ec URL: https://github.com/llvm/llvm-project/commit/95fac2e46b73c67495dbdb43ef178d33281c05ec DIFF: https://github.com/llvm/llvm-project/commit/95fac2e46b73c67495dbdb43ef178d33281c05ec.diff

[PATCH] D76791: [Matrix] Implement matrix index expressions ([][]).

fhahn updated this revision to Diff 254228. fhahn added a comment. Use placeholder type for incomplete matrix index expressions, as suggested by @rjmccall Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76791/new/ https://reviews.llvm.org/D76791 Fi

[PATCH] D76950: HIP: Link correct denormal mode library

arsenm closed this revision. arsenm marked an inline comment as done. arsenm added a comment. 4ea3650c212ae471657d3a253cd424ce9d1316ac CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76950/new/ https://reviews.llvm.org

[PATCH] D59321: AMDGPU: Teach toolchain to link rocm device libs

arsenm added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:264 def err_drv_invalid_malign_branch_EQ : Error< "invalid argument '%0' to -malign-branch=; each element must be one of: %1">; yaxunl wrote: > could you please reb

[PATCH] D59321: AMDGPU: Teach toolchain to link rocm device libs

arsenm updated this revision to Diff 254229. arsenm marked an inline comment as done. arsenm added a comment. Rebase again CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59321/new/ https://reviews.llvm.org/D59321 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/includ

[PATCH] D77185: [WebAssembly] Rename SIMD min/max/avgr intrinsics for consistency

This revision was automatically updated to reflect the committed changes. Closed by commit rG95fac2e46b73: [WebAssembly] Rename SIMD min/max/avgr intrinsics for consistency (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77185/ne

[PATCH] D77048: [Clang][CodeGen] Fixing mismatch between memory layout and const expressions for oversized bitfields

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77048/new/ https://reviews.llvm.org/D77048 ___

[PATCH] D76679: [SveEmitter] Add more immediate operand checks.

SjoerdMeijer added inline comments. Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/negative/acle_sve_ext.c:1 +// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sve -fallow-half-arguments-and-returns -fsyntax-only -verify -D__ARM_FEATURE_SVE %s + -

[clang] f08df46 - [OPENMP50]Add initial support for OpenMP 5.0 iterator.

Author: Alexey Bataev Date: 2020-04-01T12:53:55-04:00 New Revision: f08df464ae89972a777c0a7e299a2c153a9829d8 URL: https://github.com/llvm/llvm-project/commit/f08df464ae89972a777c0a7e299a2c153a9829d8 DIFF: https://github.com/llvm/llvm-project/commit/f08df464ae89972a777c0a7e299a2c153a9829d8.diff

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

rnk added a comment. It's unsurprising that the Linux kernel's own Fortify implementation is incompatible with Clang. The whole feature should never have been implemented in the library to begin with, but here we are. I think the Linux kernel folks would prefer it if we can fix forward and find

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

rjmccall added inline comments. Comment at: clang/include/clang/AST/StmtVisitor.h:146 + RetTy VisitBin##NAME(PTR(BinaryOperator) S, ParamTys... P) { \ +DISPATCH(BinAssign, BinaryOperator); \ } erichk

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

rjmccall added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:394 + return true; + } + rjmccall wrote: > erichkeane wrote: > > rjmccall wrote: > > > The problem with having both functions that take `ASTContext`s and > > > functions tha

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

DmitryPolukhin updated this revision to Diff 254238. DmitryPolukhin added a comment. Use options priority instead of overriding local options by global Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75184/new/ https://reviews.llvm.org/D75184 Files:

[PATCH] D77168: Add a flag to debug automatic variable initialization

jcai19 updated this revision to Diff 254242. jcai19 added a comment. Remove an unnecessary line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77168/new/ https://reviews.llvm.org/D77168 Files: clang/include/clang/AST/ASTContext.h clang/include

[PATCH] D77168: Add a flag to debug automatic variable initialization

jcai19 updated this revision to Diff 254240. jcai19 added a comment. Address some of the concerns. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77168/new/ https://reviews.llvm.org/D77168 Files: clang/include/clang/AST/ASTContext.h clang/inclu

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

erichkeane added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:394 + return true; + } + rjmccall wrote: > rjmccall wrote: > > erichkeane wrote: > > > rjmccall wrote: > > > > The problem with having both functions that take `ASTContext`

  1   2   3   >