lebedev.ri added inline comments.

================
Comment at: compiler-rt/lib/ubsan_bel/ubsan_bel_handlers.cpp:40-42
+    static std::random_device r;
+    static std::default_random_engine e(r());
+    static std::uniform_int_distribution<int> d(0, sizeof(quips) / 
sizeof(quips[0]) - 1);
----------------
I'm not sure we should be introducing randomness into UB handler.
I think what this instead should do, is attach gdb to the process and fix the 
UB-invoking instructions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77219/new/

https://reviews.llvm.org/D77219



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to