[PATCH] D76497: [Syntax] Test both the default and windows target platforms in unittests

2020-03-20 Thread Marcel Hlopko via Phabricator via cfe-commits
hlopko updated this revision to Diff 251649. hlopko added a comment. .equals -> == :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76497/new/ https://reviews.llvm.org/D76497 Files: clang/unittests/Tooling/Syntax/TreeTest.cpp Index: clang/unit

[PATCH] D76497: [Syntax] Test both the default and windows target platforms in unittests

2020-03-20 Thread Marcel Hlopko via Phabricator via cfe-commits
hlopko updated this revision to Diff 251646. hlopko added a comment. Polish Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76497/new/ https://reviews.llvm.org/D76497 Files: clang/unittests/Tooling/Syntax/TreeTest.cpp Index: clang/unittests/Tool

[PATCH] D76323: [AST] Fix handling of long double and bool in __builtin_bit_cast

2020-03-20 Thread Louis Dionne via Phabricator via cfe-commits
ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. LGTM at high level, but I'm not really familiar with the code. Comment at: clang/lib/AST/ExprConstant.cpp:6365 +const llvm::fltSemantics &Semantics = Info.Ctx.getFloatT

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

2020-03-20 Thread Gabor Marton via Phabricator via cfe-commits
martong updated this revision to Diff 251648. martong marked an inline comment as done. martong added a comment. - Use prefixes for -verify to check different things in the same test file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73898/new/ htt

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

2020-03-20 Thread Gabor Marton via Phabricator via cfe-commits
martong marked an inline comment as done. martong added a comment. Thanks for the review guys! Comment at: clang/test/Analysis/std-c-library-functions-arg-constraints.c:1-7 +// RUN: %clang_analyze_cc1 %s \ +// RUN: -analyzer-checker=core \ +// RUN: -analyzer-checker=apiMode

[PATCH] D76491: [ARM,MVE] Add ACLE intrinsics for the vaddv/vaddlv family.

2020-03-20 Thread Dave Green via Phabricator via cfe-commits
dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Sounds great, from what I can see. The predicated lowering looks useful when/if we try and get predicated vecreduce's working. We'll have to do the same for VMLA at some point. LGTM Reposi

[PATCH] D76504: [clang] Fix crash during template sema checking

2020-03-20 Thread Guillaume Chatelet via Phabricator via cfe-commits
gchatelet added a comment. Buggy trace here Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76504/new/ https://reviews.llvm.org/D76504 __

[PATCH] D73245: Depend stddef.h to provide max_align_t for C++11 and provide better fallback in

2020-03-20 Thread Louis Dionne via Phabricator via cfe-commits
ldionne requested changes to this revision. ldionne added a comment. This revision now requires changes to proceed. I think the direction works, but I have questions about some thing I don't understand (mostly in the tests). Comment at: libcxx/include/stddef.h:58 !defined

[PATCH] D76504: [clang] Fix crash during template sema checking

2020-03-20 Thread Guillaume Chatelet via Phabricator via cfe-commits
gchatelet created this revision. gchatelet added reviewers: efriedma, courbet. Herald added a project: clang. Herald added a subscriber: cfe-commits. gchatelet added a subscriber: abrachet. gchatelet added a comment. Buggy trace here

[PATCH] D75661: Remove SequentialType from the type heirarchy.

2020-03-20 Thread Christopher Tetreault via Phabricator via cfe-commits
ctetreau added inline comments. Herald added a reviewer: aartbik. Comment at: clang/lib/CodeGen/CGDecl.cpp:1059 +llvm::Type *ElemTy = ArrayTy->getElementType(); +bool ZeroInitializer = constant->isNullValue(); llvm::Constant *OpValue, *PaddedOp; I as

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

2020-03-20 Thread Gabor Marton via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG94061df6e5f2: [analyzer] StdLibraryFunctionsChecker: Add argument constraints (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73898/new/

[PATCH] D76497: [Syntax] Test both the default and windows target platforms in unittests

2020-03-20 Thread Dmitri Gribenko via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGeddede9d5184: [Syntax] Test both the default and windows target platforms in unittests (authored by hlopko, committed by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[clang] 45a9945 - [ARM, MVE] Add ACLE intrinsics for the vminv/vmaxv family.

2020-03-20 Thread Simon Tatham via cfe-commits
Author: Simon Tatham Date: 2020-03-20T15:42:33Z New Revision: 45a9945b9ea95bd065d3c4e08d9089a309b24a23 URL: https://github.com/llvm/llvm-project/commit/45a9945b9ea95bd065d3c4e08d9089a309b24a23 DIFF: https://github.com/llvm/llvm-project/commit/45a9945b9ea95bd065d3c4e08d9089a309b24a23.diff LOG:

[clang] 1adfa4c - [ARM, MVE] Add ACLE intrinsics for the vaddv/vaddlv family.

2020-03-20 Thread Simon Tatham via cfe-commits
Author: Simon Tatham Date: 2020-03-20T15:42:33Z New Revision: 1adfa4c99169733dedb67b4f7ab03d2fbb196162 URL: https://github.com/llvm/llvm-project/commit/1adfa4c99169733dedb67b4f7ab03d2fbb196162 DIFF: https://github.com/llvm/llvm-project/commit/1adfa4c99169733dedb67b4f7ab03d2fbb196162.diff LOG:

[clang] ffcc076 - [[Clang CallGraph]] CallGraph should still record calls to decls.

2020-03-20 Thread Erich Keane via cfe-commits
Author: Erich Keane Date: 2020-03-20T08:55:23-07:00 New Revision: ffcc076a2b23363025de2f67243086963f235b20 URL: https://github.com/llvm/llvm-project/commit/ffcc076a2b23363025de2f67243086963f235b20 DIFF: https://github.com/llvm/llvm-project/commit/ffcc076a2b23363025de2f67243086963f235b20.diff L

[clang] ce5173c - Use FinishThunk to finish musttail thunks

2020-03-20 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2020-03-20T09:02:21-07:00 New Revision: ce5173c0e174870934d1b3a026f631d996136191 URL: https://github.com/llvm/llvm-project/commit/ce5173c0e174870934d1b3a026f631d996136191 DIFF: https://github.com/llvm/llvm-project/commit/ce5173c0e174870934d1b3a026f631d996136191.diff

[PATCH] D76504: [clang] Fix crash during template sema checking

2020-03-20 Thread Clement Courbet via Phabricator via cfe-commits
courbet added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:1655 +clang::Expr *SizeOp = TheCall->getArg(2); +// If any arg is instantiation dependent we bail out. +if (DstOp->isInstantiationDependent() || Are the first two necessary ? I

[PATCH] D76078: [AArch64][SVE] Add a pass for SVE intrinsic optimisations

2020-03-20 Thread Kerry McLaughlin via Phabricator via cfe-commits
kmclaughlin updated this revision to Diff 251643. kmclaughlin marked 13 inline comments as done. kmclaughlin added a comment. - Changed this from a function pass to a module pass & now check if any of the relevant SVE intrinsics are declared first before iterating over functions - Added more chec

[PATCH] D76078: [AArch64][SVE] Add a pass for SVE intrinsic optimisations

2020-03-20 Thread Kerry McLaughlin via Phabricator via cfe-commits
kmclaughlin added a comment. Thanks for reviewing this, @efriedma & @andwar! Comment at: llvm/lib/Target/AArch64/AArch64TargetMachine.cpp:441 + // Expand any SVE vector library calls that we can't code generate directly. + bool ExpandToOptimize = (TM->getOptLevel() != CodeGen

[PATCH] D76490: [ARM,MVE] Add ACLE intrinsics for the vminv/vmaxv family.

2020-03-20 Thread Simon Tatham via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG45a9945b9ea9: [ARM,MVE] Add ACLE intrinsics for the vminv/vmaxv family. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76490/new/

[PATCH] D76491: [ARM,MVE] Add ACLE intrinsics for the vaddv/vaddlv family.

2020-03-20 Thread Simon Tatham via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG1adfa4c99169: [ARM,MVE] Add ACLE intrinsics for the vaddv/vaddlv family. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76491/new/

[PATCH] D76435: [[Clang CallGraph]] CallGraph should still record calls to decls.

2020-03-20 Thread Erich Keane via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGffcc076a2b23: [[Clang CallGraph]] CallGraph should still record calls to decls. (authored by erichkeane). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Githu

[PATCH] D76444: Use FinishThunk to finish musttail thunks

2020-03-20 Thread Reid Kleckner via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGce5173c0e174: Use FinishThunk to finish musttail thunks (authored by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76444/new/ https://reviews.llvm.org

[clang] ededa65 - [analyzer] StdLibraryFunctionsChecker: Add NotNull Arg Constraint

2020-03-20 Thread Gabor Marton via cfe-commits
Author: Gabor Marton Date: 2020-03-20T17:34:29+01:00 New Revision: ededa65d559dac04ae50d3a33610875bb8f1a85e URL: https://github.com/llvm/llvm-project/commit/ededa65d559dac04ae50d3a33610875bb8f1a85e DIFF: https://github.com/llvm/llvm-project/commit/ededa65d559dac04ae50d3a33610875bb8f1a85e.diff

[PATCH] D76323: [AST] Fix handling of long double and bool in __builtin_bit_cast

2020-03-20 Thread JF Bastien via Phabricator via cfe-commits
jfb added a comment. Maybe you should test `nullptr` as well, given that it's all padding? Comment at: clang/test/SemaCXX/constexpr-builtin-bit-cast.cpp:407 + +constexpr bool test_bad_bool = bit_cast('A'); // expected-error {{must be initialized by a constant expression}} expe

[PATCH] D76504: [clang] Fix crash during template sema checking

2020-03-20 Thread Guillaume Chatelet via Phabricator via cfe-commits
gchatelet added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:1655 +clang::Expr *SizeOp = TheCall->getArg(2); +// If any arg is instantiation dependent we bail out. +if (DstOp->isInstantiationDependent() || courbet wrote: > Are the firs

[PATCH] D76509: [analyzer][NFC] Move the text output type to its own file, move code to PathDiagnosticConsumer creator functions

2020-03-20 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, baloghadamsoftware, martong, balazske, rnkovacs, dcoughlin, steakhal. Szelethus added a project: clang. Herald added subscribers: cfe-commits, ASDenysPetrov, usaxena95, Charusso, gamesh411, dkrupp, donat.nagy, kadircet, m

[PATCH] D76510: [analyzer] Change the default output type to PD_TEXT_MINIMAL, error if an output loc is missing for PathDiagConsumers that need it

2020-03-20 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, baloghadamsoftware, rnkovacs, martong, balazske, dcoughlin. Szelethus added a project: clang. Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sid

[PATCH] D75063: [analyzer] StdLibraryFunctionsChecker: Add NotNull Arg Constraint

2020-03-20 Thread Gabor Marton via Phabricator via cfe-commits
martong updated this revision to Diff 251674. martong marked 9 inline comments as done. martong added a comment. - Use report/bugpath verify prefixes in test - Address review nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75063/new/ https://rev

[PATCH] D76377: Correctly initialize the DW_AT_comp_dir attribute of Clang module skeleton CUs

2020-03-20 Thread Paul Robinson via Phabricator via cfe-commits
probinson added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2499 +DIB.createFile(Mod.getModuleName(), TheCU->getDirectory()), +TheCU->getProducer(), false, StringRef(), 0, Mod.getASTFile(), +llvm::DICompileUnit::FullDebug, Signature); --

[PATCH] D76435: [[Clang CallGraph]] CallGraph should still record calls to decls.

2020-03-20 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. Whoops, i did not see cfe-commits again got sidestepped. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76435/new/ https://reviews.llvm.org/D76435 ___ cfe-commits mailing lis

[PATCH] D76504: [clang] Fix crash during template sema checking

2020-03-20 Thread Guillaume Chatelet via Phabricator via cfe-commits
gchatelet updated this revision to Diff 251671. gchatelet marked an inline comment as done. gchatelet added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76504/new/ https://reviews.llvm.org/D76504 Files: clang/lib/Sem

[PATCH] D75063: [analyzer] StdLibraryFunctionsChecker: Add NotNull Arg Constraint

2020-03-20 Thread Gabor Marton via Phabricator via cfe-commits
martong added a comment. In D75063#1923780 , @NoQ wrote: > This is basically a shorthand for "outside [0, 0]", right? I don't mind ^.^ Yeah, and my first attempt was exactly to implement this with ranges. However, it failed when I realized that we canno

[PATCH] D76361: [Analyzer] Iterator Modeling - Model `std::advance()`, `std::prev()` and `std::next()`

2020-03-20 Thread Gabor Marton via Phabricator via cfe-commits
martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:221 +if (Handler) { + if (!C.wasInlined) { +if (Call.getNumArgs() > 1) { -

[PATCH] D75063: [analyzer] StdLibraryFunctionsChecker: Add NotNull Arg Constraint

2020-03-20 Thread Gabor Marton via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGededa65d559d: [analyzer] StdLibraryFunctionsChecker: Add NotNull Arg Constraint (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75063/ne

[clang] f59bb40 - Attempt to fix failing build-bot with [-Werror,-Wcovered-switch-default]

2020-03-20 Thread Gabor Marton via cfe-commits
Author: Gabor Marton Date: 2020-03-20T18:04:55+01:00 New Revision: f59bb40e361c061adaa19e988f1f5769d3b8fac7 URL: https://github.com/llvm/llvm-project/commit/f59bb40e361c061adaa19e988f1f5769d3b8fac7 DIFF: https://github.com/llvm/llvm-project/commit/f59bb40e361c061adaa19e988f1f5769d3b8fac7.diff

[PATCH] D76509: [analyzer][NFC] Move the text output type to its own file, move code to PathDiagnosticConsumer creator functions

2020-03-20 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:148 void DigestAnalyzerOptions() { -if (Opts->AnalysisDiagOpt != PD_NONE) { - // Create the PathDiagnosticConsumer. - C

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

2020-03-20 Thread Manoj Gupta via Phabricator via cfe-commits
manojgupta added a comment. Still causing a crash using a previously supplied test https://bugs.chromium.org/p/chromium/issues/detail?id=1061533#c7. Any reason this was not tested with a previous repro? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://reviews.llvm.org/

[PATCH] D52898: [Porting MergeSimilarFunctions 2/n] Changes to DataLayout

2020-03-20 Thread Vishal Chebrolu via Phabricator via cfe-commits
vish99 updated this revision to Diff 251696. vish99 added a comment. Changes to merge the 5 patches together Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52898/new/ https://reviews.llvm.org/D52898 Files: llvm/lib/Analysis/ModuleSummaryAnalysis.

[PATCH] D76377: Correctly initialize the DW_AT_comp_dir attribute of Clang module skeleton CUs

2020-03-20 Thread Adrian Prantl via Phabricator via cfe-commits
aprantl marked an inline comment as done. aprantl added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2499 +DIB.createFile(Mod.getModuleName(), TheCU->getDirectory()), +TheCU->getProducer(), false, StringRef(), 0, Mod.getASTFile(), +llvm::

[PATCH] D75661: Remove SequentialType from the type heirarchy.

2020-03-20 Thread Eli Friedman via Phabricator via cfe-commits
efriedma marked 2 inline comments as done. efriedma added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:1059 +llvm::Type *ElemTy = ArrayTy->getElementType(); +bool ZeroInitializer = constant->isNullValue(); llvm::Constant *OpValue, *PaddedOp;

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

2020-03-20 Thread Melanie Blower via Phabricator via cfe-commits
mibintc updated this revision to Diff 251699. mibintc retitled this revision from "Move FPFeatures from BinaryOperator bitfields to Trailing storage - preliminary" to "Move FPFeatures from BinaryOperator bitfields to Trailing storage". mibintc added a comment. This revision has been rebased, the

[PATCH] D76504: [clang] Fix crash during template sema checking

2020-03-20 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. Please post patches against master, not previous versions of the patch. I think you want to check isValueDependent(); isInstantiationDependent() includes some other stuff that isn't relevant here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

2020-03-20 Thread Fady Ghanim via Phabricator via cfe-commits
fghanim added a comment. My comments were nits so. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75591/new/ https://reviews.llvm.org/D75591 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

2020-03-20 Thread Melanie Blower via Phabricator via cfe-commits
mibintc marked 3 inline comments as done. mibintc added a comment. In D76384#1929774 , @mibintc wrote: > There's a bug in this patch that i haven't solved yet. I think it's just 1 > bug. The bug is that the AST statement visitor is going to the "fallback"

[PATCH] D76395: [clang-tidy] Merge common code between llvmlibc-restrict-system-libc-headers and portability-restrict-system-includes

2020-03-20 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some small nits! Comment at: clang-tools-extra/clang-tidy/llvmlibc/CMakeLists.txt:15 clangTooling + clangTidyPortabilityModule )

[PATCH] D75661: Remove SequentialType from the type heirarchy.

2020-03-20 Thread Christopher Tetreault via Phabricator via cfe-commits
ctetreau added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:1078 } + // FIXME: Do we need to handle tail padding in vectors? return constant; efriedma wrote: > ctetreau wrote: > > The fact that you have to ask this question tells me that you s

[PATCH] D31342: Add ParsedAttrInfo::handleDeclAttribute

2020-03-20 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31342/new/ https://reviews.llvm.org/D31342 ___ cfe-commits mailing lis

[PATCH] D31343: Add an attribute plugin example

2020-03-20 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/examples/Attribute/Attribute.cpp:35 +Spellings.push_back({ParsedAttr::AS_GNU, "example"}); +Spellings.push_back({ParsedAttr::AS_CXX11, "::example"}); +Spellings.push_back({ParsedAttr::AS_CXX11, "plugin::example"})

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

2020-03-20 Thread Vedant Kumar via Phabricator via cfe-commits
vsk added a comment. In D73534#1933988 , @djtodoro wrote: > In D73534#1933985 , @djtodoro wrote: > > > Oh sorry, I thought it all has been fixed, since all the tests pass. > > > > We should revert the D75036

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

2020-03-20 Thread Djordje Todorovic via Phabricator via cfe-commits
djtodoro added a comment. In D73534#1934105 , @vsk wrote: > In D73534#1933988 , @djtodoro wrote: > > > In D73534#1933985 , @djtodoro > > wrote: > > > > > Oh sorry, I thought

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

2020-03-20 Thread Djordje Todorovic via Phabricator via cfe-commits
djtodoro added a comment. In D73534#1933985 , @djtodoro wrote: > Oh sorry, I thought it all has been fixed, since all the tests pass. > > We should revert the D75036 until we fix > all the issues. @dstenb do you agree?

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

2020-03-20 Thread Djordje Todorovic via Phabricator via cfe-commits
djtodoro added a comment. Oh sorry, I thought it all has been fixed, since all the tests pass. We should revert the D75036 until we fix all the issues. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://reviews.llvm.org/D73534 ___

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

2020-03-20 Thread Vedant Kumar via Phabricator via cfe-commits
vsk added a comment. @manojgupta I apologize for not catching this earlier. The issue should really be fixed by 636665331bbd4c369a9f33c4d35fb9a863c94646 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ http

[clang] 06dea73 - [OPENMP50]Initial support for inclusive clause.

2020-03-20 Thread Alexey Bataev via cfe-commits
Author: Alexey Bataev Date: 2020-03-20T14:20:38-04:00 New Revision: 06dea73307e75f0227ba24cab2adf2e4dad62b88 URL: https://github.com/llvm/llvm-project/commit/06dea73307e75f0227ba24cab2adf2e4dad62b88 DIFF: https://github.com/llvm/llvm-project/commit/06dea73307e75f0227ba24cab2adf2e4dad62b88.diff

[PATCH] D76510: [analyzer] Change the default output type to PD_TEXT_MINIMAL, error if an output loc is missing for PathDiagConsumers that need it

2020-03-20 Thread Balogh, Ádám via Phabricator via cfe-commits
baloghadamsoftware accepted this revision. baloghadamsoftware added a comment. This revision is now accepted and ready to land. Basically LGTM, but please wait for @NoQ or someone for the compatibility questions. Comment at: clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.c

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

2020-03-20 Thread Manoj Gupta via Phabricator via cfe-commits
manojgupta added a comment. Thanks for the quick fix, verified that the crash is fixed on trunk. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://reviews.llvm.org/D73534 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D76395: [clang-tidy] Merge common code between llvmlibc-restrict-system-libc-headers and portability-restrict-system-includes

2020-03-20 Thread Paula Toth via Phabricator via cfe-commits
PaulkaToast added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76395/new/ https://reviews.llvm.org/D76395 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D76395: [clang-tidy] Merge common code between llvmlibc-restrict-system-libc-headers and portability-restrict-system-includes

2020-03-20 Thread Paula Toth via Phabricator via cfe-commits
PaulkaToast updated this revision to Diff 251713. PaulkaToast marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76395/new/ https://reviews.llvm.org/D76395 Files: clang-tools-extra/clang-tidy/llvmlibc/CMakeLists.txt

[PATCH] D72810: [LifetimeAnalysis] Add support for lifetime annotations on functions

2020-03-20 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/include/clang/AST/LifetimeAttr.h:163 +// Maps each annotated entity to a lifetime set. +using LifetimeContracts = std::map; + xazax.hun wrote: > aaron.ballman wrote: > > xazax.hun wrote: > > > gribozavr2 wrot

[PATCH] D76365: [cuda][hip] Add CUDA builtin surface/texture reference support.

2020-03-20 Thread Artem Belevich via Phabricator via cfe-commits
tra added inline comments. Comment at: clang/lib/CodeGen/CGCUDARuntime.h:51 +}; +unsigned Kind : 2; +unsigned Extern : 1; This should be `DeviceVarKind` Comment at: clang/lib/CodeGen/CGCUDARuntime.h:53 +unsigned Extern : 1; +

[PATCH] D76520: [CUDA][HIP] Add -Xarch_device and -Xarch_host options

2020-03-20 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added a reviewer: tra. Herald added a reviewer: jdoerfert. The argument after -Xarch_device will be added to the arguments for CUDA/HIP device compilation and will be removed for host compilation. The argument after -Xarch_host will be added to the arguments f

[clang] 9b95929 - [OPENMP50]Do not allow several scan directives in the same parent

2020-03-20 Thread Alexey Bataev via cfe-commits
Author: Alexey Bataev Date: 2020-03-20T15:45:31-04:00 New Revision: 9b95929a26e133bc3cae9f29f91e8e351d233840 URL: https://github.com/llvm/llvm-project/commit/9b95929a26e133bc3cae9f29f91e8e351d233840 DIFF: https://github.com/llvm/llvm-project/commit/9b95929a26e133bc3cae9f29f91e8e351d233840.diff

[PATCH] D76438: ConstantExpr cached APValues if present for constant evaluation

2020-03-20 Thread Wyatt Childers via Phabricator via cfe-commits
wchilders marked 2 inline comments as done. wchilders added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:7329 + if (Result.isLValue()) +return Success(Result, E); +} rsmith wrote: > wchilders wrote: > > rsmith wrote: > > > wchilder

[PATCH] D76452: Use LLD by default for Android.

2020-03-20 Thread Stephen Hines via Phabricator via cfe-commits
srhines accepted this revision. srhines added a comment. This revision is now accepted and ready to land. Thanks, Dan, for setting this up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76452/new/ https://reviews.llvm.org/D76452

[PATCH] D76438: ConstantExpr cached APValues if present for constant evaluation

2020-03-20 Thread Wyatt Childers via Phabricator via cfe-commits
wchilders updated this revision to Diff 251732. wchilders added a comment. Updated to assume LValue `ConstantExpr`s have LValue `APValue`s, with verification in debug mode. Additionally, added a missing LValue -> RValue conversion for `VerifyIntegerConstantExpression`. CHANGES SINCE LAST ACTIO

[PATCH] D76520: [CUDA][HIP] Add -Xarch_device and -Xarch_host options

2020-03-20 Thread Artem Belevich via Phabricator via cfe-commits
tra added a reviewer: echristo. tra added a comment. Does it handle options with values? E.g. if I want to pass `-mframe-pointer=none` ? I vaguely recall the current -Xarch_* implementation had some limitations. It may be worth adding a test for that. CHANGES SINCE LAST ACTION https://revie

[PATCH] D74387: [SYCL] Defer __float128 type usage diagnostics

2020-03-20 Thread Mariya Podchishchaeva via Phabricator via cfe-commits
Fznamznon updated this revision to Diff 251735. Fznamznon added a comment. Herald added a subscriber: mgorny. Added diagnosing of __float128 type usage. See the summary of revision for details. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74387/new

[PATCH] D73245: Depend stddef.h to provide max_align_t for C++11 and provide better fallback in

2020-03-20 Thread Joerg Sonnenberger via Phabricator via cfe-commits
joerg marked 5 inline comments as done. joerg added inline comments. Comment at: libcxx/include/stddef.h:58 !defined(__DEFINED_max_align_t) && !defined(__NetBSD__) typedef long double max_align_t; #endif ldionne wrote: > Why do we need this at all anymore?

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

2020-03-20 Thread Melanie Blower via Phabricator via cfe-commits
mibintc updated this revision to Diff 251746. mibintc added a comment. This revision fixes the clang-tidy,clang-format and removes the redundant accessors. Ready for your review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76384/new/ https://rev

[PATCH] D76438: ConstantExpr cached APValues if present for constant evaluation

2020-03-20 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/AST/ExprConstant.cpp:7325-7329 + // Override to perform additional checks to ensure the cached APValue + // is actually an LValue. + bool VisitCo

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

2020-03-20 Thread Zoe Carver via Phabricator via cfe-commits
zoecarver added a comment. In D76525 I've added a builtin that uses this API. We can use that builtin in libc++. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74918/new/ https://reviews.llvm.org/D74918

[PATCH] D76525: Expose cache line size in __builtin_get_cpu_cache_line_size

2020-03-20 Thread Zoe Carver via Phabricator via cfe-commits
zoecarver created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. zoecarver added reviewers: jfb, EricWF, efriedma, jyknight, echristo, __simt__. Herald added a subscriber: dexonsmith. This patch creates the __builtin_get_cpu_cache_line_size to wrap the cpu ca

[PATCH] D76527: Don't export symbols from clang/opt/llc if plugins are disabled.

2020-03-20 Thread Eli Friedman via Phabricator via cfe-commits
efriedma created this revision. efriedma added reviewers: MaskRay, serge-sans-paille, Meinersbur. Herald added subscribers: cfe-commits, dexonsmith, mgorny. Herald added a project: clang. The only reason we export symbols from these tools is to support plugins; if we don't have plugins, exporting

[clang] 079c6dd - Correctly initialize the DW_AT_comp_dir attribute of Clang module skeleton CUs

2020-03-20 Thread Adrian Prantl via cfe-commits
Author: Adrian Prantl Date: 2020-03-20T14:18:14-07:00 New Revision: 079c6ddaf5344eb501652c2a874e3e4e8c466c2b URL: https://github.com/llvm/llvm-project/commit/079c6ddaf5344eb501652c2a874e3e4e8c466c2b DIFF: https://github.com/llvm/llvm-project/commit/079c6ddaf5344eb501652c2a874e3e4e8c466c2b.diff

[clang] 97f490d - Don't set the isOptimized flag in module skeleton DICompileUnits.

2020-03-20 Thread Adrian Prantl via cfe-commits
Author: Adrian Prantl Date: 2020-03-20T14:18:15-07:00 New Revision: 97f490d87b226b1deade74ec93b4378fb28d26cc URL: https://github.com/llvm/llvm-project/commit/97f490d87b226b1deade74ec93b4378fb28d26cc DIFF: https://github.com/llvm/llvm-project/commit/97f490d87b226b1deade74ec93b4378fb28d26cc.diff

[clang] dc4259d - [c++20] Further extend the set of comparisons broken by C++20 that we

2020-03-20 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-03-20T14:22:48-07:00 New Revision: dc4259d5a38409e65b60266a7df0f03c3b91a151 URL: https://github.com/llvm/llvm-project/commit/dc4259d5a38409e65b60266a7df0f03c3b91a151 DIFF: https://github.com/llvm/llvm-project/commit/dc4259d5a38409e65b60266a7df0f03c3b91a151.diff

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

2020-03-20 Thread Zoe Carver via Phabricator via cfe-commits
zoecarver marked 2 inline comments as done. zoecarver added a comment. I've made the suggested changes. Is there a consensus that this should be moved to LLVM? I think it's fairly clang-specific (given the use case). We can also always move it to LLVM if the need arises in the future. Reposito

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

2020-03-20 Thread Zoe Carver via Phabricator via cfe-commits
zoecarver updated this revision to Diff 251758. zoecarver added a comment. Fix based on review: - update comments - return 64 for Core2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74918/new/ https://reviews.llvm.org/D74918 Files: clang/includ

[PATCH] D76438: ConstantExpr cached APValues if present for constant evaluation

2020-03-20 Thread Wyatt Childers via Phabricator via cfe-commits
wchilders marked 2 inline comments as done. wchilders added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:7325-7329 + // Override to perform additional checks to ensure the cached APValue + // is actually an LValue. + bool VisitConstantExpr(const ConstantExpr *E)

[PATCH] D76438: ConstantExpr cached APValues if present for constant evaluation

2020-03-20 Thread Wyatt Childers via Phabricator via cfe-commits
wchilders added a comment. I should note, I don't have commit access, so I'm unable to commit this myself. Attribution would be `Wyatt Childers ` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76438/new/ https://reviews.llvm.org/D76438 ___

[PATCH] D76528: [clang codegen] Clean up handling of vectors with trivial-auto-var-init.

2020-03-20 Thread Eli Friedman via Phabricator via cfe-commits
efriedma created this revision. efriedma added reviewers: glider, jfb. Herald added a subscriber: dexonsmith. Herald added a project: clang. The code was pretending to be doing something useful with vectors, but really it was doing nothing: the element type of a vector is always a scalar type, so

[PATCH] D76438: ConstantExpr cached APValues if present for constant evaluation

2020-03-20 Thread Wyatt Childers via Phabricator via cfe-commits
wchilders updated this revision to Diff 251763. wchilders marked an inline comment as done. wchilders added a comment. Dropped the override for constexpr evaluator, LValue evaluation base class CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76438/new/ https://reviews.llvm.org/D76438 Fil

[PATCH] D76377: Correctly initialize the DW_AT_comp_dir attribute of Clang module skeleton CUs

2020-03-20 Thread Adrian Prantl via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG079c6ddaf534: Correctly initialize the DW_AT_comp_dir attribute of Clang module skeleton CUs (authored by aprantl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D7637

[clang] fc8a009 - Clean up and simplify after collision of c48442c and 19fccc5, which

2020-03-20 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-03-20T14:53:09-07:00 New Revision: fc8a009bf39d74ce0ee3f586e0b4056035db30cb URL: https://github.com/llvm/llvm-project/commit/fc8a009bf39d74ce0ee3f586e0b4056035db30cb DIFF: https://github.com/llvm/llvm-project/commit/fc8a009bf39d74ce0ee3f586e0b4056035db30cb.diff

[PATCH] D76365: [cuda][hip] Add CUDA builtin surface/texture reference support.

2020-03-20 Thread Michael Liao via Phabricator via cfe-commits
hliao updated this revision to Diff 251777. hliao added a comment. Minor revising following reviewer's comment. Work on Sema checks and upload another review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76365/new/ https://reviews.llvm.org/D76365

[PATCH] D76365: [cuda][hip] Add CUDA builtin surface/texture reference support.

2020-03-20 Thread Michael Liao via Phabricator via cfe-commits
hliao marked 5 inline comments as done. hliao added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:701-713 + if (getLangOpts().CUDAIsDevice) { +// As CUDA builtin surface/texture types are replaced, skip generating TBAA +// access info. +if (AccessT

[PATCH] D76504: [clang] Fix crash during template sema checking

2020-03-20 Thread Guillaume Chatelet via Phabricator via cfe-commits
gchatelet updated this revision to Diff 251780. gchatelet added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76504/new/ https://reviews.llvm.org/D76504 Files: clang/lib/Sema/SemaChecking.cpp clang/test/Sema/builtin

[PATCH] D74619: [ARM] Enabling range checks on Neon intrinsics' lane arguments

2020-03-20 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan added a comment. Hi, a bisect seems to show https://reviews.llvm.org/rGf56550cf7f12b581a237b48a7f4d8b6682d45a09 is causing us to see the following error: error: argument value 1 is outside the valid range [0, 0] v2 = vdupq_lane_f64(vget_high_f64(a.v), 1); ^

[clang] 43580a5 - Allow remapping Clang module skeleton CU references with -fdebug-prefix-map

2020-03-20 Thread Adrian Prantl via cfe-commits
Author: Adrian Prantl Date: 2020-03-20T15:15:56-07:00 New Revision: 43580a5c5afc3cd935e4e3d67f285fe81dd7e8c5 URL: https://github.com/llvm/llvm-project/commit/43580a5c5afc3cd935e4e3d67f285fe81dd7e8c5 DIFF: https://github.com/llvm/llvm-project/commit/43580a5c5afc3cd935e4e3d67f285fe81dd7e8c5.diff

[clang] f75f19c - [Clang][test] Add .i files for test discovery

2020-03-20 Thread Sylvain Audi via cfe-commits
Author: Sylvain Audi Date: 2020-03-20T18:21:27-04:00 New Revision: f75f19c2374807247e779a1e00bfeabc337ee446 URL: https://github.com/llvm/llvm-project/commit/f75f19c2374807247e779a1e00bfeabc337ee446 DIFF: https://github.com/llvm/llvm-project/commit/f75f19c2374807247e779a1e00bfeabc337ee446.diff

[PATCH] D76533: [clangd] Skip ClangdVFSTest.TestStackOverflow when address sanitizer is used

2020-03-20 Thread Bjorn Pettersson via Phabricator via cfe-commits
bjope created this revision. bjope added reviewers: sammccall, Dmitry.Kozhevnikov. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. bjope added a comment. bjope added subscribers: uabelho, dstenb. I don't know if

[PATCH] D76534: [clang/docs] Fix various sphinx warnings/errors in docs.

2020-03-20 Thread Florian Hahn via Phabricator via cfe-commits
fhahn created this revision. fhahn added reviewers: jfb, Bigcheese, dexonsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. There are a few places with unexpected indents that trip over sphinx and other syntax errors. Also, the C++ syntax highlighting does not work for

[PATCH] D76504: [clang] Fix crash during template sema checking

2020-03-20 Thread Eli Friedman via Phabricator via cfe-commits
efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Sema/SemaChecking.cpp:1655 +// greater than 0. When `size` is value dependent we cannot evaluate its +// value so we bail<< out. +i

[PATCH] D76385: Allow remapping Clang module include paths

2020-03-20 Thread Adrian Prantl via Phabricator via cfe-commits
aprantl updated this revision to Diff 251789. aprantl added a comment. Rebased and addressed review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76385/new/ https://reviews.llvm.org/D76385 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/Modules/debug-info-moduleimport

[PATCH] D75853: [Clang][test] Add .i files for test discovery

2020-03-20 Thread Sylvain Audi via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGf75f19c23748: [Clang][test] Add .i files for test discovery (authored by saudi). Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D76533: [clangd] Skip ClangdVFSTest.TestStackOverflow when address sanitizer is used

2020-03-20 Thread Bjorn Pettersson via Phabricator via cfe-commits
bjope added a comment. I don't know if this is a good solution. But we've had problems with our downstream bots that builds llvm with asan, and runs check-all, for awhile (probably since we merged https://reviews.llvm.org/D50993). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D76383: Allow remapping Clang module skeleton CU references with -fdebug-prefix-map

2020-03-20 Thread Adrian Prantl via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG43580a5c5afc: Allow remapping Clang module skeleton CU references with -fdebug-prefix-map (authored by aprantl). Herald ad

[clang] 6725c48 - Allow remapping the sysroot with -fdebug-prefix-map.

2020-03-20 Thread Adrian Prantl via cfe-commits
Author: Adrian Prantl Date: 2020-03-20T15:52:39-07:00 New Revision: 6725c4836a5b3c11227869a6f456019a244aa29f URL: https://github.com/llvm/llvm-project/commit/6725c4836a5b3c11227869a6f456019a244aa29f DIFF: https://github.com/llvm/llvm-project/commit/6725c4836a5b3c11227869a6f456019a244aa29f.diff

[clang-tools-extra] 556b917 - [clang-tidy] Merge common code between llvmlibc-restrict-system-libc-headers and portability-restrict-system-includes

2020-03-20 Thread Paula Toth via cfe-commits
Author: Paula Toth Date: 2020-03-20T15:53:05-07:00 New Revision: 556b917fffcfaa15ea11a277e1b0d87b8d13e0f1 URL: https://github.com/llvm/llvm-project/commit/556b917fffcfaa15ea11a277e1b0d87b8d13e0f1 DIFF: https://github.com/llvm/llvm-project/commit/556b917fffcfaa15ea11a277e1b0d87b8d13e0f1.diff LO

  1   2   >