ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land.
LGTM at high level, but I'm not really familiar with the code. ================ Comment at: clang/lib/AST/ExprConstant.cpp:6365 + const llvm::fltSemantics &Semantics = Info.Ctx.getFloatTypeSemantics(Ty); + unsigned NumBits = APFloat::semanticsSizeInBits(Semantics); + assert(NumBits % 8 == 0); ---------------- `semanticsSizeInBits` is the number of bits actually used in the type? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76323/new/ https://reviews.llvm.org/D76323 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
