[PATCH] D66094: [CodeGen] Emit destructor calls for non-trivial C structs returned by function calls and loaded from volatile objects

ahatanak marked an inline comment as done. ahatanak added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:677 + E->getType().isDestructedType() == QualType::DK_nontrivial_c_struct) +Cleanup.setExprNeedsCleanups(true); + rjmccall wrote: > ahatana

[PATCH] D60748: Adds an option "malign-pass-aggregate" to make the alignment of the struct and union parameters compatible with the default gcc

LiuChen3 updated this revision to Diff 251290. LiuChen3 retitled this revision from " Fix i386 struct and union parameter alignment" to "Adds an option "malign-pass-aggregate" to make the alignment of the struct and union parameters compatible with the default gcc". LiuChen3 edited the summary of

[PATCH] D76392: [AST] Make Expr::setDependence protected and remove add/removeDependence. NFC

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/AST/Expr.h:2766 + void markDependentForPostponedNameLookup() { +setDependence(getDependence() | ExprDependence::TypeValueInstantiat

[clang] 4b0f1e1 - [AST] Add a flag indicating if any subexpression had errors

Author: Haojian Wu Date: 2020-03-19T08:56:10+01:00 New Revision: 4b0f1e12c243dd4c42665df0e2eab61f2fc4d237 URL: https://github.com/llvm/llvm-project/commit/4b0f1e12c243dd4c42665df0e2eab61f2fc4d237 DIFF: https://github.com/llvm/llvm-project/commit/4b0f1e12c243dd4c42665df0e2eab61f2fc4d237.diff LO

[PATCH] D65591: [AST] Add a flag indicating if any subexpression had errors

hokein added inline comments. Comment at: clang/lib/AST/ComputeDependence.cpp:174 ExprDependence clang::computeDependence(NoInitExpr *E) { return toExprDependence(E->getType()->getDependence()) & ExprDependence::Instantiation; sammccall wrote: > hok

[PATCH] D65591: [AST] Add a flag indicating if any subexpression had errors

hokein updated this revision to Diff 251299. hokein marked 2 inline comments as done. hokein added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65591/new/ https://reviews.llvm.org/D65591 Files: clang/include/clang/AS

[PATCH] D65591: [AST] Add a flag indicating if any subexpression had errors

This revision was automatically updated to reflect the committed changes. Closed by commit rG4b0f1e12c243: [AST] Add a flag indicating if any subexpression had errors (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65591/new/ htt

[PATCH] D65592: [Parser] Avoid spurious 'missing template' error in presence of typos

hokein updated this revision to Diff 251303. hokein added a comment. rebase to master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65592/new/ https://reviews.llvm.org/D65592 Files: clang/include/clang/Parse/Parser.h clang/lib/Parse/ParseDecl

[PATCH] D75682: [Analyzer][StreamChecker] Introduction of stream error handling.

baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:29 + assert(SS->isOpened() && \ + "Create of error node failed (only way to get this state)?"); + --

[PATCH] D76418: [Syntax] Build template declaration nodes

hlopko created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Rollforward of https://reviews.llvm.org/rGdd12826808f9079e164b82e64b0697a077379241 after temporarily adding -fno-delayed-template-parsing to the TreeTest. Original summary: > Copy of https://revi

[clang] 981f080 - [SVE] Generate overloaded functions for ACLE intrinsics.

Author: Sander de Smalen Date: 2020-03-19T09:36:23Z New Revision: 981f0802b37597975606d2b5f5bbc25974c4c3df URL: https://github.com/llvm/llvm-project/commit/981f0802b37597975606d2b5f5bbc25974c4c3df DIFF: https://github.com/llvm/llvm-project/commit/981f0802b37597975606d2b5f5bbc25974c4c3df.diff L

[PATCH] D76396: Allow immediate invocation of constructors

Tyker added a comment. thanks for the the patch, but I have already a patch aiming to do the same thing. D74007 > Provide improvements which allow the cached values of ConstantExpr to be used > by both the constant evaluator and code gen this is definitely som

[PATCH] D76420: Prevent IR-gen from emitting consteval declarations

Tyker created this revision. Tyker added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. Tyker added a parent revision: D74130: [clang] fix consteval call in default arguements . with this patch instead of emitting calls to consteval function. the IR-gen

[PATCH] D75861: [SVE] Generate overloaded functions for ACLE intrinsics.

This revision was automatically updated to reflect the committed changes. sdesmalen marked 4 inline comments as done. Closed by commit rG981f0802b375: [SVE] Generate overloaded functions for ACLE intrinsics. (authored by sdesmalen). Changed prior to commit: https://reviews.llvm.org/D75861?vs=24

[PATCH] D75861: [SVE] Generate overloaded functions for ACLE intrinsics.

sdesmalen added a comment. Addressed review comments before commititng. Thanks for the review @miyuki and @SjoerdMeijer! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75861/new/ https://reviews.llvm.org/D75861 _

[PATCH] D76367: [clang-format] Handle C# generic type constraints

krasimir requested changes to this revision. krasimir added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:326 +void UnwrappedLineParser::parseCSharpGenericTypeConstraint(bool ConsumeBrace) { + do {

[PATCH] D76238: [SveEmitter] Implement builtins for contiguous loads/stores

SjoerdMeijer added a comment. Some nits inlined Comment at: clang/include/clang/Basic/AArch64SVETypeFlags.h:72 + bool isStructStore() const { return Flags & IsStructStore; } + bool isZxtReturn() const { return Flags & IsZxtReturn; } + nit: this one is non obv

[PATCH] D76422: Testing presubmits

hlopko created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ignore me Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D76422 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Syntax/BuildTree.cpp clang/lib/Tooling/

[PATCH] D76379: [Analyzer] IteratorRangeChecker verify `std::advance()`, `std::prev()` and `std::next()`

baloghadamsoftware updated this revision to Diff 251320. baloghadamsoftware added a comment. Updated according to the comments and automatic formatting suggestions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76379/new/ https://reviews.llvm.org/D76379 Files: clang/lib/StaticAnalyze

[PATCH] D76379: [Analyzer] IteratorRangeChecker verify `std::advance()`, `std::prev()` and `std::next()`

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added a comment. In D76379#1929698 , @Szelethus wrote: > The patch looks great, though I'd kindly ask you to wait a bit for someone > with a bit more experience on `SVal`-smithing ;)

[PATCH] D76424: [AST] Use TypeDependence bitfield to calculate dependence on Types. NFC

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. sammccall added a comment. This mostly corresponds to the Expr refactoring in ec3060c72de6ab6992269318d92764199856e5fe

[PATCH] D76424: [AST] Use TypeDependence bitfield to calculate dependence on Types. NFC

sammccall added a comment. This mostly corresponds to the Expr refactoring in ec3060c72de6ab6992269318d92764199856e5fe , without the followup moving it to ComputeDependence yet. I used a constructor param to assist in the ref

[PATCH] D76062: [PATCH] [ARM] ARMv8.6-a command-line + BFloat16 Asm Support

stuij marked an inline comment as done. stuij added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:184 + // Also include the Armv8.5 defines + // FIXME: Armv8.6 makes some extensions mandatory. Handle them here. + getTargetDefinesARMV85A(Opts, Builder); -

[PATCH] D76094: [clangd] Change line break behaviour for hoverinfo

lolleko updated this revision to Diff 251334. lolleko edited the summary of this revision. lolleko added a comment. Addressed review. Paragraphs (lines separated by a double line break `\n\n`) are currently not retained. Because the current implementation of markup::Paragraph only appends a sin

[PATCH] D76062: [PATCH] [ARM] ARMv8.6-a command-line + BFloat16 Asm Support

stuij updated this revision to Diff 251336. stuij marked 3 inline comments as done. stuij added a comment. addressing Sjoerd's comments on mandatory defines and rewording Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76062/new/ https://reviews.llvm

[PATCH] D76392: [AST] Make Expr::setDependence protected and remove add/removeDependence. NFC

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang/include/clang/AST/Expr.h:2766 + void markDependentForPostponedNameLookup() { +setDependence(getDependence() | ExprDependence::TypeValueInstantiation); hokein wro

[PATCH] D76392: [AST] Make Expr::setDependence protected and remove add/removeDependence. NFC

sammccall updated this revision to Diff 251337. sammccall added a comment. Add comment on markDependentForPostponedNameLookup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76392/new/ https://reviews.llvm.org/D76392 Files: clang/include/clang/AST

[PATCH] D76238: [SveEmitter] Implement builtins for contiguous loads/stores

sdesmalen marked 2 inline comments as done. sdesmalen added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:7467 + + return IsZxtReturn ? Builder.CreateZExt(Load, VectorTy) + : Builder.CreateSExt(Load, VectorTy); SjoerdMeijer wro

[PATCH] D65592: [Parser] Avoid spurious 'missing template' error in presence of typos

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice! I don't love adding those overloads, but not clear there's something better. Comment at: clang/lib/Parse/ParseExprCXX.cpp:2973 +bool Parser::ParseUnqualifiedId

[PATCH] D73891: [RISCV] Support experimental/unratified extensions

lenary accepted this revision. lenary added a comment. I'm happy with the approach here. At some point we should put version numbers into the target features, but I think that can wait until we know how to cope with how the `G` extension expands into its other extensions (this has some open que

[clang] dade859 - [ARM] Setting missing isLaneQ attribute on Neon Intrisics definitions

Author: Lucas Prates Date: 2020-03-19T12:04:14Z New Revision: dade859b58827eaddc88f820c5dd5a28cf3532f3 URL: https://github.com/llvm/llvm-project/commit/dade859b58827eaddc88f820c5dd5a28cf3532f3 DIFF: https://github.com/llvm/llvm-project/commit/dade859b58827eaddc88f820c5dd5a28cf3532f3.diff LOG:

[clang] d427116 - [ARM] Creating 'call_mangled' for Neon intrinsics definitions

Author: Lucas Prates Date: 2020-03-19T12:05:55Z New Revision: d42711625af8188edb15c8ddad8c861fbca89c17 URL: https://github.com/llvm/llvm-project/commit/d42711625af8188edb15c8ddad8c861fbca89c17 DIFF: https://github.com/llvm/llvm-project/commit/d42711625af8188edb15c8ddad8c861fbca89c17.diff LOG:

[clang] d4ad386 - [ARM] Fixing range checks for Neon's vqdmulhq_lane and vqrdmulhq_lane intrinsics

Author: Lucas Prates Date: 2020-03-19T12:08:12Z New Revision: d4ad386ee1955ceb63fc616b3e30abb553e0685f URL: https://github.com/llvm/llvm-project/commit/d4ad386ee1955ceb63fc616b3e30abb553e0685f DIFF: https://github.com/llvm/llvm-project/commit/d4ad386ee1955ceb63fc616b3e30abb553e0685f.diff LOG:

[PATCH] D75682: [Analyzer][StreamChecker] Introduction of stream error handling.

balazske added a comment. Adding special test functions is not as easy, then `StreamState` should be accessible from another checker. It could be added to the same file, or new file but then moving the data structures into header is needed. At least for short-term it is more simple to add a str

[PATCH] D76367: [clang-format] Handle C# generic type constraints

jbcoe updated this revision to Diff 251349. jbcoe added a comment. Address review comments to move deleted test and remove redundant code. Redundant call to `parseCSharpGenericTypeConstraint` was used for free functions which are not legal in C#. CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D76238: [SveEmitter] Implement builtins for contiguous loads/stores

SjoerdMeijer added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:7467 + + return IsZxtReturn ? Builder.CreateZExt(Load, VectorTy) + : Builder.CreateSExt(Load, VectorTy); sdesmalen wrote: > SjoerdMeijer wrote: > > nit: and now l

[PATCH] D74766: [ARM] Fixing range checks for Neon's vqdmulhq_lane and vqrdmulhq_lane intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rGd4ad386ee195: [ARM] Fixing range checks for Neon's vqdmulhq_lane and vqrdmulhq_lane intrinsics (authored by pratlucas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D76062: [PATCH] [ARM] ARMv8.6-a command-line + BFloat16 Asm Support

SjoerdMeijer added a comment. Besides the irrelevant formatting nits, one minor question about the clang test. Comment at: clang/test/Driver/aarch64-cpus.c:622 + +// The BFloat16 extension is a mandatory component of the Armv8.6-A extensions, but is permitted as an +// optiona

[PATCH] D74618: [ARM] Creating 'call_mangled' for Neon intrinsics definitions

This revision was automatically updated to reflect the committed changes. Closed by commit rGd42711625af8: [ARM] Creating 'call_mangled' for Neon intrinsics definitions (authored by pratlucas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74618/new/

[PATCH] D74616: [ARM] Setting missing isLaneQ attribute on Neon Intrisics definitions

This revision was automatically updated to reflect the committed changes. Closed by commit rGdade859b5882: [ARM] Setting missing isLaneQ attribute on Neon Intrisics definitions (authored by pratlucas). Herald added a subscriber: danielkiss. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

RE: [PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

If it Is not updated can you update the OpenMP feature tracking doc. https://clang.llvm.org/docs/OpenMPSupport.html Thanks Ravi -Original Message- From: Michael Kruse via Phabricator Sent: Tuesday, March 17, 2020 8:34 PM To: a.bat...@hotmail.com; jdoerf...@anl.gov; hfin...@anl.gov; Wilm

[PATCH] D76367: [clang-format] Handle C# generic type constraints

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76367/new/ https://reviews.llvm.org/D76367 ___ cfe-commits mailing list cfe

[clang] dcbcec4 - [clang-format] Handle C# generic type constraints

Author: Jonathan Coe Date: 2020-03-19T12:56:08Z New Revision: dcbcec4822f47ec5b638dd9c20dcebd464569dae URL: https://github.com/llvm/llvm-project/commit/dcbcec4822f47ec5b638dd9c20dcebd464569dae DIFF: https://github.com/llvm/llvm-project/commit/dcbcec4822f47ec5b638dd9c20dcebd464569dae.diff LOG:

[clang] d9b9621 - Reland D73534: [DebugInfo] Enable the debug entry values feature by default

Author: Djordje Todorovic Date: 2020-03-19T13:57:30+01:00 New Revision: d9b962100942c71a4c26debaa716f7ab0c4ea8a1 URL: https://github.com/llvm/llvm-project/commit/d9b962100942c71a4c26debaa716f7ab0c4ea8a1 DIFF: https://github.com/llvm/llvm-project/commit/d9b962100942c71a4c26debaa716f7ab0c4ea8a1.d

[PATCH] D73891: [RISCV] Support experimental/unratified extensions

asb accepted this revision. asb added a comment. LGTM, thanks Simon! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73891/new/ https://reviews.llvm.org/D73891 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D76367: [clang-format] Handle C# generic type constraints

This revision was automatically updated to reflect the committed changes. Closed by commit rGdcbcec4822f4: [clang-format] Handle C# generic type constraints (authored by Jonathan Coe ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D76424: [AST] Use TypeDependence bitfield to calculate dependence on Types. NFC

hokein added inline comments. Comment at: clang/include/clang/AST/Type.h:2882 - Pointee->isInstantiationDependentType()), - Pointee->isVariablyModifiedType(), - (Cls->containsUnexpandedParameterPack() || we have behavior chang

[PATCH] D76429: [clangd] Fix elog message when preamble build fails.

adamcz created this revision. adamcz added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. sammccall accepted this revision. This revision is now accepted and ready to land. Repository:

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

apazos added a comment. Thanks Shiva, making it alias of -G makes sense, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57497/new/ https://reviews.llvm.org/D57497 ___ cfe-commits mailing list cfe-

[clang-tools-extra] 55b92dc - [clangd] Fix elog message when preamble build fails.

Author: Adam Czachorowski Date: 2020-03-19T15:09:46+01:00 New Revision: 55b92dcb35a0758bea294ab6e42f9954ac06cac3 URL: https://github.com/llvm/llvm-project/commit/55b92dcb35a0758bea294ab6e42f9954ac06cac3 DIFF: https://github.com/llvm/llvm-project/commit/55b92dcb35a0758bea294ab6e42f9954ac06cac3.d

[clang] cf1f8f9 - [OPENMP][DOCS]Update list of constructs and status, NFC.

Author: Alexey Bataev Date: 2020-03-19T10:20:29-04:00 New Revision: cf1f8f9bec220fcbefe0cff835ab9f8c6291cfc6 URL: https://github.com/llvm/llvm-project/commit/cf1f8f9bec220fcbefe0cff835ab9f8c6291cfc6 DIFF: https://github.com/llvm/llvm-project/commit/cf1f8f9bec220fcbefe0cff835ab9f8c6291cfc6.diff

[PATCH] D76094: [clangd] Change line break behaviour for hoverinfo

sammccall added a comment. Thanks, this fits in a lot better! I think there's some more details that could be handled, e.g. if a line is much shorter than the max line length, then that probably implies it's a "real" break. But if we get the code structure right, these should be easy to plug in

[PATCH] D76429: [clangd] Fix elog message when preamble build fails.

This revision was automatically updated to reflect the committed changes. Closed by commit rG55b92dcb35a0: [clangd] Fix elog message when preamble build fails. (authored by adamcz, committed by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. Re-enabled with the d9b962100942 . If we face a failure again, since this enables the whole feature, I recommend reverting smaller pieces of the feature that was causing the problem, rather than reve

[clang] 5d67fb3 - [AST][NFCi] Make CXXBasePaths::Origin const

Author: Jan Korous Date: 2020-03-19T07:54:05-07:00 New Revision: 5d67fb3eccc7884e52d5252379456b87b14ce58b URL: https://github.com/llvm/llvm-project/commit/5d67fb3eccc7884e52d5252379456b87b14ce58b DIFF: https://github.com/llvm/llvm-project/commit/5d67fb3eccc7884e52d5252379456b87b14ce58b.diff LO

[PATCH] D65592: [Parser] Avoid spurious 'missing template' error in presence of typos

hokein updated this revision to Diff 251379. hokein added a comment. address review comments, remove the overload. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65592/new/ https://reviews.llvm.org/D65592 Files: clang/include/clang/Parse/Parser.h

[clang] 6cff2e9 - [Analyzer] Bugfix for CheckerRegistry

Author: Adam Balogh Date: 2020-03-19T16:06:42+01:00 New Revision: 6cff2e9f7884690d480b961f78806cbb91773b34 URL: https://github.com/llvm/llvm-project/commit/6cff2e9f7884690d480b961f78806cbb91773b34 DIFF: https://github.com/llvm/llvm-project/commit/6cff2e9f7884690d480b961f78806cbb91773b34.diff L

[PATCH] D76422: Testing presubmits

hlopko updated this revision to Diff 251387. hlopko added a comment. Removing fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76422/new/ https://reviews.llvm.org/D76422 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Synt

[PATCH] D76432: [clangd] Add a tweak for adding "using" statement.

adamcz created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, mgrang, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. This triggers on types and function calls with namespace qualifiers. The action is to remove the qualifier and instea

[clang] 0dd0b10 - [Parser] Avoid spurious 'missing template' error in presence of typos.

Author: Haojian Wu Date: 2020-03-19T16:15:27+01:00 New Revision: 0dd0b1017c807e7a803e69be7bdc5c0ac7b469d8 URL: https://github.com/llvm/llvm-project/commit/0dd0b1017c807e7a803e69be7bdc5c0ac7b469d8 DIFF: https://github.com/llvm/llvm-project/commit/0dd0b1017c807e7a803e69be7bdc5c0ac7b469d8.diff LO

[PATCH] D76433: [Syntax] Make TreeTest independent from the host platform.

hlopko created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. hlopko added a parent revision: D76366: [Syntax] Split syntax tests. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D76433 Files: clang/unittests/Tooling/Syntax/TreeTest.cpp I

[PATCH] D49074: [Analyzer] Basic support for multiplication and division in the constraint manager

baloghadamsoftware updated this revision to Diff 251391. baloghadamsoftware added a comment. Herald added a reviewer: Szelethus. Herald added subscribers: ASDenysPetrov, steakhal. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49074/new/ https://reviews.llvm.org/D49074 Files:

[PATCH] D50256: [Analyzer] Basic support for multiplication and division in the constraint manager (for == and != only)

baloghadamsoftware updated this revision to Diff 251389. baloghadamsoftware marked an inline comment as done. baloghadamsoftware added a comment. Herald added a reviewer: Szelethus. Herald added subscribers: ASDenysPetrov, martong, steakhal. Rebased. CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D69330: [AST] Add RecoveryExpr to retain expressions on semantic errors

hokein updated this revision to Diff 251393. hokein added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69330/new/ https://reviews.llvm.org/D69330 Files: clang/include/clang/AST/ComputeDependence.h clang/include/clang/AST/Exp

[PATCH] D65592: [Parser] Avoid spurious 'missing template' error in presence of typos

This revision was automatically updated to reflect the committed changes. Closed by commit rG0dd0b1017c80: [Parser] Avoid spurious 'missing template' error in presence of typos. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6559

[PATCH] D75842: [Analyzer] Bugfix for CheckerRegistry

This revision was automatically updated to reflect the committed changes. Closed by commit rG6cff2e9f7884: [Analyzer] Bugfix for CheckerRegistry (authored by baloghadamsoftware). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75842/new/ https://revie

[PATCH] D60748: Adds an option "malign-pass-aggregate" to make the alignment of the struct and union parameters compatible with the default gcc

jyknight added a comment. Since the ABI this is trying to match is not documented literally anywhere, I think we need to have some confidence that what this implements is actually the same as what GCC does. While I wrote up what I think the algorithm is, without some sort of script to allow tes

[PATCH] D69330: [AST] Add RecoveryExpr to retain expressions on semantic errors

hokein added a comment. all prerequisite patches have been landed, it is time to land this patch now. Would be nice to have a second look before committing it +@sammccall. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69330/new/ https://reviews.ll

[PATCH] D76433: [Syntax] Make TreeTest independent from the host platform.

hlopko updated this revision to Diff 251399. hlopko added a comment. Reformat Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76433/new/ https://reviews.llvm.org/D76433 Files: clang/unittests/Tooling/Syntax/TreeTest.cpp Index: clang/unittests/To

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

zoecarver marked 3 inline comments as done. zoecarver added a comment. @lebedev.ri LLVM may be better, I'm not sure. If you feel strongly I can move it. @jyknight I'm planning on adding a builtin that uses this method. I can put the patch up for that first if you would like.

[clang] 88bf9b3 - [Syntax] Build template declaration nodes

Author: Marcel Hlopko Date: 2020-03-19T17:43:07+01:00 New Revision: 88bf9b3d26f06eaf33972d1f371edc4cb187ff1a URL: https://github.com/llvm/llvm-project/commit/88bf9b3d26f06eaf33972d1f371edc4cb187ff1a DIFF: https://github.com/llvm/llvm-project/commit/88bf9b3d26f06eaf33972d1f371edc4cb187ff1a.diff

[PATCH] D76418: [Syntax] Build template declaration nodes

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG88bf9b3d26f0: [Syntax] Build template declaration nodes (authored by hlopko, committed by gribozavr). Changed prior to co

[PATCH] D73307: Unique Names for Functions with Internal Linkage

tmsriram updated this revision to Diff 251409. tmsriram marked 2 inline comments as done. tmsriram added a comment. Address reviewer comments. Fix test and delete blank line. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73307/new/ https://reviews.llvm.org/D73307 Files: clang/includ

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

ZarkoCA updated this revision to Diff 251407. ZarkoCA marked 3 inline comments as done. ZarkoCA added a comment. Changed comments per suggestions. Added `va_copy` in test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76360/new/ https://reviews.llvm.org/D76360 Files: clang/lib/

[PATCH] D76396: Allow immediate invocation of constructors

wchilders abandoned this revision. wchilders added a comment. In D76396#1930773 , @Tyker wrote: > I have already a patch aiming to do the same thing. D74007 > Oof, okay, sounds good. I was not aware of this patch, it lo

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

ZarkoCA marked 8 inline comments as done. ZarkoCA added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4175 namespace { /// PPC32_SVR4_ABIInfo - The 32-bit PowerPC ELF (SVR4) ABI information. class PPC32_SVR4_ABIInfo : public DefaultABIInfo { sf

[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX

ZarkoCA updated this revision to Diff 251408. ZarkoCA marked 11 inline comments as done. ZarkoCA added a comment. Addressed code comments, working on adding and fixing tests for further clarity. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76130/ne

[PATCH] D76385: Allow remapping Clang module include paths

aprantl updated this revision to Diff 251411. aprantl added a comment. Don't try to be too clever. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76385/new/ https://reviews.llvm.org/D76385 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/Modules/debug-info-moduleimport.m Index:

[PATCH] D76393: Allow remapping the sysroot with -fdebug-prefix-map.

aprantl updated this revision to Diff 251412. aprantl added a comment. Herald added a subscriber: hiraditya. Don't try to be too clever with the strings. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76393/new/ https://reviews.llvm.org/D76393 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D66094: [CodeGen] Emit destructor calls for non-trivial C structs returned by function calls and loaded from volatile objects

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:677 + E->getType().isDestructedType() == QualType::DK_nontrivial_c_struct) +Cleanup.setExprNeedsCleanups(true); + ahatanak wrote: > rjmccall wrote: > > ahatanak wrote: > > > rjmccall

[PATCH] D76396: Allow immediate invocation of constructors

rsmith added a comment. In D76396#1930773 , @Tyker wrote: > I have already a patch aiming to do the same thing. D74007 > Thanks. Sorry I dropped the ball on that one. =/ Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D73307: Unique Names for Functions with Internal Linkage

MaskRay added inline comments. Comment at: clang/test/CodeGen/unique-internal-funcnames.c:3 + +// RUN: %clang -target x86_64 -S -o - %s | FileCheck %s --check-prefix=PLAIN +// RUN: %clang -target x86_64 -S -funique-internal-funcnames -o - %s | FileCheck %s --check-prefix=UNIQUE

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

hubert.reinterpretcast added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4176 +/// PPC32_SVR4_ABIInfo - The 32-bit PowerPC ABI information, used by PowerPC ELF +/// (SVR4), Darwin and AIX. class PPC32_SVR4_ABIInfo : public DefaultABIInfo { I w

[PATCH] D76098: [clangd] Do not trigger go-to-def textual fallback inside string literals

nridge updated this revision to Diff 251418. nridge added a comment. Take a blacklisting approach Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76098/new/ https://reviews.llvm.org/D76098 Files: clang-tools-extra/clangd/XRefs.cpp clang-tools-ex

[PATCH] D76438: ConstantExpr cached APValues if present for constant evaluation

wchilders created this revision. wchilders added reviewers: Tyker, rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch allows the constant evaluator to use `APValueResult`s from `ConstantExpr`s. There are some outstanding concerns I'll mark with inline comme

[PATCH] D76438: ConstantExpr cached APValues if present for constant evaluation

wchilders added inline comments. Comment at: clang/lib/AST/Expr.cpp:2875 - else if (auto *CE = dyn_cast(E)) -return CE->getSubExpr(); - return E; } `IgnoreParensSingleStep` for some reason has been unwrapping `ConstantExpr`s. This results in the const

[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX

ZarkoCA added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:7076 +static const MCPhysReg GPR_64[] = {PPC::X3, PPC::X4, PPC::X5, PPC::X6, + PPC::X7, PPC::X8, PPC::X9, PPC::X10}; +unsigned const NumGPArgRegs =

[PATCH] D76416: [ASan] Apply -ffile-prefix-map mappings to ASan instrumentation

leonardchan updated this revision to Diff 251421. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76416/new/ https://reviews.llvm.org/D76416 Files: clang/include/clang/Basic/CodeGenOptions.h clang/lib/CodeGen/ModuleBuilder.cpp clang/lib/CodeGen/

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

lebedev.ri added a comment. In D74918#1931488 , @zoecarver wrote: > @lebedev.ri LLVM may be better, I'm not sure. If you feel strongly I can move > it. I do think that it makes much more sense somewhere closer to the backend > @jyknight I'm planning on

[PATCH] D73307: Unique Names for Functions with Internal Linkage

lebedev.ri added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1129 + // should get unique names. Use the hash of module name to get a unique + // identifier and this is a best effort. + if (getCodeGenOpts().UniqueInternalFuncNames && maybe

[PATCH] D76238: [SveEmitter] Implement builtins for contiguous loads/stores

efriedma added inline comments. Comment at: clang/include/clang/Basic/AArch64SVETypeFlags.h:72 + bool isStructStore() const { return Flags & IsStructStore; } + bool isZxtReturn() const { return Flags & IsZxtReturn; } + SjoerdMeijer wrote: > nit: this one is non

[PATCH] D73307: Unique Names for Functions with Internal Linkage

davidxl added a comment. As far as I understand, this is not a propeller specific patch, but it fixes a general problem in AFDO as well. Perhaps change the summary to reflect that? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73307/new/ https://reviews.llvm.org/D73307 _

[clang] a983562 - Precommit test for clang::CallGraph declared functions.

Author: Erich Keane Date: 2020-03-19T12:00:30-07:00 New Revision: a983562b23458777a7226ec6cfe41cbeb9d291de URL: https://github.com/llvm/llvm-project/commit/a983562b23458777a7226ec6cfe41cbeb9d291de DIFF: https://github.com/llvm/llvm-project/commit/a983562b23458777a7226ec6cfe41cbeb9d291de.diff L

[PATCH] D73307: Unique Names for Functions with Internal Linkage

davidxl added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1129 + // should get unique names. Use the hash of module name to get a unique + // identifier and this is a best effort. + if (getCodeGenOpts().UniqueInternalFuncNames && lebedev.

[PATCH] D76443: Use ConstantExpr cached APValues if present for code generation

wchilders created this revision. wchilders added reviewers: void, Tyker, rsmith. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. wchilders added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:1095 +// preventing the cached results from be

[PATCH] D76443: Use ConstantExpr cached APValues if present for code generation

wchilders added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:1095 +// preventing the cached results from being used. +if (!isa(fe)) { + enterFullExpression(fe); This one is a bit weird, I think the comment explains it well, but I feel th

[PATCH] D76444: Use FinishThunk to finish musttail thunks

rnk created this revision. rnk added reviewers: hans, rjmccall. Herald added a project: clang. FinishThunk, and the invariant of setting and then unsetting CurCodeDecl, was added in 7f416cc42638 (2015). The invariant didn't exist when I added this musttail codepath in ab2090d10765 (2014). Recently

[clang] 430c9a8 - [Hexagon] Enable linux #defines

Author: Sid Manning Date: 2020-03-19T14:33:49-05:00 New Revision: 430c9a80c17b00ec65b8254810e3c9e122d13f98 URL: https://github.com/llvm/llvm-project/commit/430c9a80c17b00ec65b8254810e3c9e122d13f98 DIFF: https://github.com/llvm/llvm-project/commit/430c9a80c17b00ec65b8254810e3c9e122d13f98.diff L

[PATCH] D76310: [Hexagon] Add linux #defines when linux triple is selected

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG430c9a80c17b: [Hexagon] Enable linux #defines (authored by sidneym). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D76140: [InlineFunction] update attributes during inlining

anna updated this revision to Diff 251447. anna added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. fixed clang tests. rot-intrinsics.c testcase has 5 different RUNs with 3 prefixes. Depending on target-triple, the attribute is added to the caller, so I've dis

  1   2   >