hokein added inline comments.
================
Comment at: clang/include/clang/AST/Type.h:2882
- Pointee->isInstantiationDependentType()),
- Pointee->isVariablyModifiedType(),
- (Cls->containsUnexpandedParameterPack() ||
----------------
we have behavior change for VariableModified bit, now it is `Cls|Pointee` vs
`Pointee` before
================
Comment at: clang/include/clang/AST/TypeProperties.td:457
+ if (dependent)
+
const_cast<Type*>(result.getTypePtr())->addDependence(TypeDependence::DependentInstantiation);
return result;
----------------
nit: the line length seems > 80 columns.
================
Comment at: clang/lib/AST/Type.cpp:3036
- if (epi.ExceptionSpec.NoexceptExpr->isValueDependent() ||
- epi.ExceptionSpec.NoexceptExpr->isInstantiationDependent())
----------------
when converting an ExprDep to TypeDep, we simply drop the value-dependent bit,
so here we will not set the instantiation-bit for typeDep if NoexceptExpr is
value dependent but not instantiation-dependent.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76424/new/
https://reviews.llvm.org/D76424
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
