[PATCH] D76098: [WIP] [clangd] Do not trigger go-to-def textual fallback inside string literals

kadircet added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:380 + TokenFlavor Flavor = getTokenFlavor(Loc, SM, AST.getLangOpts()); + // Only consider comment and (raw) identifier tokens. you can rather use `AST.getTokens().spelledTokenAt(Lo

[PATCH] D75745: [clang-tidy] Added AllowMissingMoveFunctionsWhenCopyIsDeleted flag to cppcoreguidelines-special-member-functions

pbaran added a comment. Thank you! Could you please integrate it for me? I do not have access rights Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75745/new/ https://reviews.llvm.org/D75745 ___ cfe-com

[PATCH] D76084: [Sema][SVE] Reject subscripts on pointers to sizeless types

rsandifo-arm added a comment. In D76084#1920103 , @efriedma wrote: > I'm not sure we actually want to reject this; let's discuss on the review for > D76086 , since subscripting is sort of a > special case of arithmetic.

[PATCH] D75682: [Analyzer][StreamChecker] Introduction of stream error handling.

balazske marked 6 inline comments as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:88 struct FnDescription; using FnCheck = std::function; NoQ wrote: > `llvm::function_ref`? `function_ref`'s documentation

[PATCH] D76218: [Sema][SVE] Reject "new" with sizeless types

rsandifo-arm created this revision. rsandifo-arm added reviewers: sdesmalen, efriedma, rovka, rjmccall. Herald added subscribers: cfe-commits, psnobl, rkruppe, tschuett. Herald added a reviewer: rengolin. Herald added a project: clang. rsandifo-arm added a parent revision: D76090: [Sema][SVE] Don't

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

lenary accepted this revision. lenary added a comment. In D57497#1923615 , @shiva0217 wrote: > In D57497#1921497 , @lenary wrote: > > > How hard would it be to use the `-msmall-data-threshold` flag work if a > > `-

[PATCH] D76219: [Sema][SVE] Reject "delete" with sizeless types

rsandifo-arm created this revision. rsandifo-arm added reviewers: sdesmalen, efriedma, rovka, rjmccall. Herald added subscribers: cfe-commits, psnobl, rkruppe, tschuett. Herald added a reviewer: rengolin. Herald added a project: clang. rsandifo-arm added a parent revision: D76218: [Sema][SVE] Rejec

[clang] 8b409ea - [SVE] Auto-generate builtins and header for svld1.

Author: Sander de Smalen Date: 2020-03-16T10:52:37Z New Revision: 8b409eabaf755c88a7d652fe99d3ad858a4fe82a URL: https://github.com/llvm/llvm-project/commit/8b409eabaf755c88a7d652fe99d3ad858a4fe82a DIFF: https://github.com/llvm/llvm-project/commit/8b409eabaf755c88a7d652fe99d3ad858a4fe82a.diff L

[PATCH] D75514: [Analyzer] Only add container note tags to the operations of the affected container

Szelethus accepted this revision. Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/DebugContainerModeling.cpp:32 template void analyzerContainerDataField(const CallExpr *CE, CheckerContext &C, NoQ wrote: > `llvm::function_re

[PATCH] D72089: [Syntax] Build declarator nodes

hlopko added a comment. I'm taking over of this patch (with a kind permission from Ilya :) I've replied to comments here, but let's continue the review over at https://reviews.llvm.org/D76220. Thanks :) Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:395 } + /// FI

[PATCH] D76220: Build declarator nodes

hlopko created this revision. hlopko added a reviewer: gribozavr2. Herald added a project: clang. Herald added a subscriber: cfe-commits. Copy of https://reviews.llvm.org/D72089 with Ilya's permission. See https://reviews.llvm.org/D72089 for the first batch of comments. Repository: rG LLVM Git

[PATCH] D76221: [Sema][SVE] Flip default RequireCompleteType behavior for sizeless types

rsandifo-arm created this revision. rsandifo-arm added reviewers: sdesmalen, efriedma, rovka, rjmccall. Herald added subscribers: cfe-commits, danielkiss, psnobl, jfb, rkruppe, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: clang. rsandifo-arm added a parent re

[PATCH] D75360: [analyzer][NFC] Tie CheckerRegistry to CheckerManager, allow CheckerManager to be constructed for non-analysis purposes

Szelethus marked 3 inline comments as done. Szelethus added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Frontend/AnalyzerHelpFlags.h:1-10 +//===-- CheckerRegistration.h - Checker Registration Function ---*- C++ -*-===// +// +// Part of the LLVM Project, under

[PATCH] D75470: [SVE] Auto-generate builtins and header for svld1.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b409eabaf75: [SVE] Auto-generate builtins and header for svld1. (authored by sdesmalen). Changed prior to commit: https://reviews.llvm.org/D75470?vs=249312&id=250509#toc Repository: rG LLVM Github M

[PATCH] D76098: [WIP] [clangd] Do not trigger go-to-def textual fallback inside string literals

sammccall added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:360 + +TokenFlavor getTokenFlavor(SourceLocation Loc, const SourceManager &SM, + const LangOptions &LangOpts) { I don't think we need this function, which ju

[PATCH] D73638: [AST] Move dependence computations into a separate file

hokein added inline comments. Comment at: clang/include/clang/AST/Expr.h:4081 -: Expr(ConvertVectorExprClass, DstType, VK, OK, - DstType->isDependentType(), - DstType->isDependentType() || SrcExpr->isValueDependent(), sammccall wrote: > ho

[PATCH] D71524: [analyzer] Support tainted objects in GenericTaintChecker

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:139 + /// Add taint sources for extraction operator on pre-visit. + bool addOverloadedOpPre(const CallExpr *CE, CheckerContext &C) const; steakhal wrote: >

[PATCH] D64991: [analyzer][WIP] Implement a primitive reaching definitions analysis

Szelethus updated this revision to Diff 250517. Szelethus edited the summary of this revision. Szelethus added a comment. Upload final version. This revision stays here for archaeological purposes, as I'll split this up into manageable pieces. CHANGES SINCE LAST ACTION https://reviews.llvm.or

[clang-tools-extra] 2f20417 - Add AllowMissingMoveFunctionsWhenCopyIsDeleted flag to cppcoreguidelines-special-member-functions

Author: Paweł Barań Date: 2020-03-16T08:14:48-04:00 New Revision: 2f20417ef04781cd5019b9a99b85df4790bdf525 URL: https://github.com/llvm/llvm-project/commit/2f20417ef04781cd5019b9a99b85df4790bdf525 DIFF: https://github.com/llvm/llvm-project/commit/2f20417ef04781cd5019b9a99b85df4790bdf525.diff L

[PATCH] D75745: [clang-tidy] Added AllowMissingMoveFunctionsWhenCopyIsDeleted flag to cppcoreguidelines-special-member-functions

aaron.ballman closed this revision. aaron.ballman added a comment. In D75745#1923913 , @pbaran wrote: > Thank you! Could you please integrate it for me? I do not have access rights Happy to do so; I've commit in 2f20417ef04781cd5019b9a99b85df4790bdf525

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

DmitryPolukhin added a comment. @alexfh could you please take another look to the diff? All comments resolved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75184/new/ https://reviews.llvm.org/D75184 _

[PATCH] D75068: libclang: Add static build support for Windows

cristian.adam added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75068/new/ https://reviews.llvm.org/D75068 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[clang] 67d2591 - [AST] rename DependencyFlags.h => DependenceFlags.h, NFC

Author: Haojian Wu Date: 2020-03-16T13:54:21+01:00 New Revision: 67d25914b2a42cef88124fe267c7a89cce9e7987 URL: https://github.com/llvm/llvm-project/commit/67d25914b2a42cef88124fe267c7a89cce9e7987 DIFF: https://github.com/llvm/llvm-project/commit/67d25914b2a42cef88124fe267c7a89cce9e7987.diff LO

[PATCH] D76229: [clang-tidy] Added PlacementNewStorageCheck

f00kat created this revision. f00kat added reviewers: aaron.ballman, alexfh. f00kat added projects: clang, clang-tools-extra. Herald added subscribers: cfe-commits, xazax.hun, mgorny. Added new checker 'cert-mem54-cpp' that checks for CERT rule MEM54-CPP. I have troubles writing English descripti

[PATCH] D76083: [clang-tidy] Expand the list of functions in bugprone-unused-return-value

jranieri-grammatech added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UnusedReturnValueCheck.cpp:57 + "::std::map::lower_bound;" + "::std::move;" + "::std:

[PATCH] D76083: [clang-tidy] Expand the list of functions in bugprone-unused-return-value

jranieri-grammatech updated this revision to Diff 250545. jranieri-grammatech marked an inline comment as done. jranieri-grammatech added a comment. Removing std::move. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76083/new/ https://reviews.llvm.o

[PATCH] D76196: [ASTMatchers] Extend hasReturnValue to GNU StmtExpr

aaron.ballman added a comment. In D76196#1923597 , @njames93 wrote: > In D76196#1923524 , @aaron.ballman > wrote: > > > I don't think this is a natural fit for the functionality. A statement > > expression doesn't

[PATCH] D75685: Add MS Mangling for OpenCL Pipe types, add mangling test.

erichkeane added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75685/new/ https://reviews.llvm.org/D75685 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D72089: [Syntax] Build declarator nodes

gribozavr2 added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:1210 + `-; + )txt"}, }; hlopko wrote: > gribozavr2 wrote: > > A few complex tests that combine multiple declarators would be nice > > (especially to test that the

[PATCH] D75470: [SVE] Auto-generate builtins and header for svld1.

thakis added inline comments. Comment at: clang/include/clang/Basic/CMakeLists.txt:44 # ARM NEON and MVE clang_tablegen(arm_neon.inc -gen-arm-neon-sema Update comment to also say "SVE" and "CDE" (or just say "# ARM builtin headers") Comment

[PATCH] D76196: [ASTMatchers] Extend hasReturnValue to GNU StmtExpr

njames93 added a comment. In D76196#1924393 , @aaron.ballman wrote: > I'm still not understanding your use case, so it's a bit hard for me to tell > whether this approach is good or not. Do you have a situation where you > cannot match on the expression

[PATCH] D75470: [SVE] Auto-generate builtins and header for svld1.

thakis added inline comments. Comment at: clang/utils/TableGen/SveEmitter.cpp:32 #include "llvm/TableGen/Error.h" +#include "clang/Basic/AArch64SVETypeFlags.h" #include Including stuff from `clang/Basic` in clang/utils/TableGen is conceptually a layering viol

[PATCH] D75682: [Analyzer][StreamChecker] Introduction of stream error handling.

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:88 struct FnDescription; using FnCheck = std::function; balazske wrote: > NoQ wrote: > > `llvm::function_ref`? > `function_ref`'s documentation says: > > This class does

[PATCH] D76229: [clang-tidy] Added PlacementNewStorageCheck

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/PlacementNewStorageCheck.cpp:19 + +namespace { +const ValueDecl *getDescendantValueDecl(const Stmt *TheStmt) { Please use static instead of anonymous namespaces for functions. See

[PATCH] D75446: [clang][Syntax] Handle macro arguments in spelledForExpanded

sammccall added a comment. I think per offline discussion, this was going to have some additional docs clarifying the contracts of this function, and maybe extra tests? The conclusion IIRC was that this function is designed to find the text that you could replace in order to replace an AST node

[PATCH] D76229: [clang-tidy] Added PlacementNewStorageCheck

f00kat updated this revision to Diff 250556. f00kat added a comment. Fix 'const auto*' in function getDescendantValueDecl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76229/new/ https://reviews.llvm.org/D76229 Files: clang-tools-extra/clang-tid

[PATCH] D76229: [clang-tidy] Added PlacementNewStorageCheck

f00kat updated this revision to Diff 250555. f00kat added a comment. 1. Static functions instead of anonymous namespaces. 2. const auto*. 3. Added double back-ticks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76229/new/ https://reviews.llvm.org/

[PATCH] D76094: [clangd] Change line break behaviour for hoverinfo

sammccall added a comment. I understand the main goal here is preserving intended line breaks in documentation comments? Thanks for tackling this problem! A design goal here is that the markup objects are the source of truth about the document structure. So if we've decided we want a comment to

[PATCH] D71524: [analyzer] Support tainted objects in GenericTaintChecker

steakhal added a comment. In D71524#1917251 , @Szelethus wrote: > Are we sure this is what we want? If this is a heuristic, we should document > it well, and even then I'm not sure whether we want it. I'm also pretty sure > this would make the eventual c

[PATCH] D76122: [ARM,MVE] Add intrinsics and isel for MVE integer VMLA.

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. LGTM Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:14289-14292 case Intrinsic::arm_neon_vqrshifts: case Intrinsic::arm_neon_vqrshiftu: // No immediate vers

[PATCH] D76229: [clang-tidy] Added PlacementNewStorageCheck

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/PlacementNewStorageCheck.cpp:43 +} + + Unnecessary empty line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76229/new/ https://r

[PATCH] D75470: [SVE] Auto-generate builtins and header for svld1.

sdesmalen marked 2 inline comments as done. sdesmalen added inline comments. Comment at: clang/utils/TableGen/SveEmitter.cpp:32 #include "llvm/TableGen/Error.h" +#include "clang/Basic/AArch64SVETypeFlags.h" #include thakis wrote: > Including stuff from `clang/

[PATCH] D75470: [SVE] Auto-generate builtins and header for svld1.

teemperor added a comment. This patch broke the Clang build with enabled modules (which is used by the LLDB bot, but every other bot is also dead: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/ ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D76220: [Syntax] Build declarator nodes

gribozavr2 added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:519 + +/// Parameter list for a function type. +/// E.g.: ... and a trailing return type, if the function has one. Comment at: clang/include/clang/Tooling/

[clang] 6ce537c - Revert "[SVE] Auto-generate builtins and header for svld1."

Author: Sander de Smalen Date: 2020-03-16T15:22:15Z New Revision: 6ce537ccfcfc9262ecb8472f7f3c86285b7198fb URL: https://github.com/llvm/llvm-project/commit/6ce537ccfcfc9262ecb8472f7f3c86285b7198fb DIFF: https://github.com/llvm/llvm-project/commit/6ce537ccfcfc9262ecb8472f7f3c86285b7198fb.diff L

[PATCH] D71018: [ASTImporter] Improved import of TypeSourceInfo (TypeLoc)

martong updated this revision to Diff 250568. martong added a comment. - Remove redundant VisitQualifiedTypeLoc and VisitAttributedTypeLoc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71018/new/ https://reviews.llvm.org/D71018 Files: clang/lib/

[PATCH] D71018: [ASTImporter] Improved import of TypeSourceInfo (TypeLoc)

martong updated this revision to Diff 250570. martong added a comment. - Fix the base commit of this patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71018/new/ https://reviews.llvm.org/D71018 Files: clang/lib/AST/ASTImporter.cpp clang/unit

[PATCH] D76196: [ASTMatchers] Extend hasReturnValue to GNU StmtExpr

njames93 updated this revision to Diff 250569. njames93 added a comment. - Rename matcher to hasFinalExpr - Don't review it yet Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76196/new/ https://reviews.llvm.org/D76196 Files: clang/docs/LibASTMatc

[PATCH] D76229: [clang-tidy] Added PlacementNewStorageCheck

njames93 added a comment. Also fix the test case, premerge found a failure Comment at: clang-tools-extra/clang-tidy/cert/PlacementNewStorageCheck.cpp:23 + + for (const Stmt *Child : TheStmt->children()) { +if (const auto *TheDeclRefExpr = dyn_cast(Child))

[PATCH] D71018: [ASTImporter] Improved import of TypeSourceInfo (TypeLoc)

martong added a comment. In D71018#1924604 , @martong wrote: > - Remove redundant VisitQualifiedTypeLoc and VisitAttributedTypeLoc I realized that the mentioned functions are redundant, because we have a while loop which iterates over all related typelo

[clang] 8a593e2 - [AST] Correct the CXXOperatorCallExpr source range.

Author: Haojian Wu Date: 2020-03-16T16:51:10+01:00 New Revision: 8a593e29ab9b2799ded3d85a8110d51d4283f128 URL: https://github.com/llvm/llvm-project/commit/8a593e29ab9b2799ded3d85a8110d51d4283f128 DIFF: https://github.com/llvm/llvm-project/commit/8a593e29ab9b2799ded3d85a8110d51d4283f128.diff LO

[PATCH] D76184: [OpenMP][NFC] Remove the need to include `OpenMPClause.h`

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76184/new/ https://reviews.llvm.org/D76184

[PATCH] D76220: [Syntax] Build declarator nodes

hlopko updated this revision to Diff 250574. hlopko marked 8 inline comments as done. hlopko added a comment. Resolving comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76220/new/ https://reviews.llvm.org/D76220 Files: clang/include/clang

[PATCH] D76220: [Syntax] Build declarator nodes

hlopko added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:522 +/// `(volatile int a)` in `int foo(volatile int a);` +/// `(int&& a)` in `int foo(int&& a);` +/// `() -> int` in `auto foo() -> int;` gribozavr2 wrote: > I meant: > > `i

[PATCH] D75470: [SVE] Auto-generate builtins and header for svld1.

thakis added inline comments. Comment at: clang/utils/TableGen/SveEmitter.cpp:32 #include "llvm/TableGen/Error.h" +#include "clang/Basic/AArch64SVETypeFlags.h" #include sdesmalen wrote: > thakis wrote: > > Including stuff from `clang/Basic` in clang/utils/Tabl

[PATCH] D76125: [clangd] Decouple preambleworker from astworker, NFCI

sammccall added inline comments. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:155 namespace { +/// Responsible for building and providing access to the preamble of a TU. This +/// worker doesn't guarantee that each preamble request will be built, in case

[PATCH] D76128: [AST] Correct the CXXOperatorCallExpr source range.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8a593e29ab9b: [AST] Correct the CXXOperatorCallExpr source range. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76128/new/ https://rev

[PATCH] D73638: [AST] Move dependence computations into a separate file

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. (I do think there are ways we could write the dependency computations more clearly, but don't want to diverge further from the existing code) Comment at: clang/include

[PATCH] D76234: clang: Simplify implementation of Type::isXXXType()

yannic created this revision. yannic added reviewers: klimek, rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D76234 Files: clang/include/clang/AST/Type.h Index: clang/include/clang/AST/Type.h =

[PATCH] D60748: Fix i386 struct and union parameter alignment

rjmccall added a comment. Oh, I see you just updated your patch months ago without ever mentioning that it was ready for review. It sounds to me like GCC retroactively added a switch specifying which version of the ABI to follow on this point, somewhat confusingly called `-malign-data`. That'

[PATCH] D75063: [analyzer] StdLibraryFunctionsChecker: Add NotNull Arg Constraint

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:189 +ValueConstraintPtr negate() const override { + NotNullConstraint tmp(*this); + tmp.CannotBeNull = !this->CannotBeNull; Is `Tmp` better

[PATCH] D75682: [Analyzer][StreamChecker] Introduction of stream error handling.

balazske updated this revision to Diff 250588. balazske marked 2 inline comments as done. balazske added a comment. Addressed some comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75682/new/ https://reviews.llvm.org/D75682 Files: clang/li

[PATCH] D75682: [Analyzer][StreamChecker] Introduction of stream error handling.

balazske marked 3 inline comments as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:88 struct FnDescription; using FnCheck = std::function; NoQ wrote: > balazske wrote: > > NoQ wrote: > > > `llvm::function_

[PATCH] D76122: [ARM,MVE] Add intrinsics and isel for MVE integer VMLA.

simon_tatham marked an inline comment as done. simon_tatham added inline comments. Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:14289-14292 case Intrinsic::arm_neon_vqrshifts: case Intrinsic::arm_neon_vqrshiftu: // No immediate versions of these to check for.

[PATCH] D76220: [Syntax] Build declarator nodes

hlopko updated this revision to Diff 250591. hlopko added a comment. Fix clang tidy warning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76220/new/ https://reviews.llvm.org/D76220 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/T

[PATCH] D76062: [PATCH] [ARM] ARMv8.6-a command-line + BFloat16 Asm Support

stuij commandeered this revision. stuij added a reviewer: LukeGeeson. stuij added a comment. Commandeered because Luke is on vacation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76062/new/ https://reviews.llvm.org/D76062 _

[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX.

sfertile added a comment. As a first step, I suggest we break the clang changes and the LLVM changes into 2 separate patches. Repository: rZORG LLVM Github Zorg CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76130/new/ https://reviews.llvm.org/D76130 __

[PATCH] D76218: [Sema][SVE] Reject "new" with sizeless types

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76218/new/ https://reviews.llvm.org/D76218 ___

[PATCH] D75010: [OpenMP] Adding InaccessibleMemOnly and InaccessibleMemOrArgMemOnly for runtime calls.

sstefan1 updated this revision to Diff 250599. sstefan1 added a comment. more tests couldn't get `update_test_checks.py` to update function signatures, even with the flag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75010/new/ https://reviews.l

[clang] 7d382dc - [Syntax] Build declarator nodes

Author: Marcel Hlopko Date: 2020-03-16T19:13:59+01:00 New Revision: 7d382dcd46a18c23a01e3754807f577598a9bc84 URL: https://github.com/llvm/llvm-project/commit/7d382dcd46a18c23a01e3754807f577598a9bc84 DIFF: https://github.com/llvm/llvm-project/commit/7d382dcd46a18c23a01e3754807f577598a9bc84.diff

[PATCH] D76220: [Syntax] Build declarator nodes

gribozavr2 accepted this revision. gribozavr2 added a comment. BTW, would be also nice to have tests for trailing return types not at the top level -- in a follow-up: `auto x(char a, auto (*b)(int) -> short) -> void;` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D72089: [Syntax] Build declarator nodes

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. Superseded by https://reviews.llvm.org/D76220. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72089/new/ https://reviews.llvm.org/D72089

[PATCH] D76086: [Sema][SVE] Reject arithmetic on pointers to sizeless types

efriedma added a comment. I don't think there's really any reason to force the user into this sort of thing... but again, we can relax this later, so I'm not that concerned about it at the moment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7608

[PATCH] D76220: [Syntax] Build declarator nodes

This revision was automatically updated to reflect the committed changes. Closed by commit rG7d382dcd46a1: [Syntax] Build declarator nodes (authored by hlopko, committed by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76220/new/ https:/

[PATCH] D76084: [Sema][SVE] Reject subscripts on pointers to sizeless types

efriedma added a comment. We already support sizeof expressions where the result can't be computed at compile-time. For example: `int f(int n, int (*p)[n]) { return sizeof(*p); }`. (For constant contexts specifically, see HandleSizeof() in ExprConstant.cpp.) I think any argument that it woul

[PATCH] D76084: [Sema][SVE] Reject subscripts on pointers to sizeless types

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. This patch LGTM, at least for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76084/new/ https://reviews.llvm.org/D76084 _

[PATCH] D75579: [WIP] Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by libraries

serge-sans-paille added a comment. @MaskRay gentle up :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75579/new/ https://reviews.llvm.org/D75579 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D75811: [CUDA] Choose default architecture based on CUDA installation

tra added a comment. In D75811#1923281 , @tambre wrote: > Your help here and over on CMake's side has been very helpful. Thank you! > I'll @ you on CMake's side if I need any help while working on CUDA support. > Hopefully you won't mind. :) No problem

[PATCH] D76219: [Sema][SVE] Reject "delete" with sizeless types

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76219/new/ https://reviews.llvm.org/D76219 ___

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

erichkeane added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73967/new/ https://reviews.llvm.org/D73967 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D76078: [AArch64][SVE] Add a pass for SVE intrinsic optimisations

andwar added a comment. Cheers for working on this @kmclaughlin ! Have you considered adding an interface for the new PM? You could check this for reference: https://reviews.llvm.org/rGd6de5f12d485a85504bc99d384a85634574a27e2 (also implements a FunctionPass). Comment at: llv

[PATCH] D73720: [Analyzer] Use note tags to track container begin and and changes

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp:713 + StringRef Name; + if (const auto *DRE = dyn_cast(ContE->IgnoreParenCasts())) { +Name = DRE->getDecl()->ge

[PATCH] D73720: [Analyzer] Use note tags to track container begin and and changes

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp:713 + StringRef Name; + if (const auto *DRE = dyn_cast(ContE->IgnoreParenCasts())) { +Name = DRE->getDecl()->ge

[PATCH] D75514: [Analyzer] Only add container note tags to the operations of the affected container

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/DebugContainerModeling.cpp:32 template void analyzerContainerDataField(const CallExpr *CE, CheckerContext &C, Sze

[PATCH] D76229: [clang-tidy] Added PlacementNewStorageCheck

aaron.ballman added a comment. Have you considered making this a static analyzer check as opposed to a clang-tidy check? I think using dataflow analysis will really reduce the false positives because it will be able to track the allocation and alignment data across control flow. Repository:

[PATCH] D75687: [clangd] Only minimally escape text when rendering to markdown.

sammccall added a comment. Sorry for the slow turnaround, bit off more than I could chew on a few fronts :-( Comment at: clang-tools-extra/clangd/FormattedString.cpp:69 +return false; + if (Contents.front() == '!' || Contents.front() == '?' || + Contents.front() == '

[PATCH] D75687: [clangd] Only minimally escape text when rendering to markdown.

sammccall updated this revision to Diff 250624. sammccall marked 10 inline comments as done. sammccall added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75687/new/ https://reviews.llvm.org/D75687 Files: clang

[PATCH] D75579: [WIP] Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by libraries

MaskRay accepted this revision. MaskRay added a comment. The title still says this is a WIP.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75579/new/ https://reviews.llvm.org/D75579 ___ cfe-commits ma

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo marked an inline comment as done. oontvoo added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:1266 + if (PP.isIncludeVisibleInLocalModule(File, M)) return false; + else PP.setIncludeVisibleForHeader(File, M); +} else { jyknigh

[PATCH] D76229: [clang-tidy] Added PlacementNewStorageCheck

lebedev.ri requested changes to this revision. lebedev.ri added a comment. This revision now requires changes to proceed. This seems to be already handled by clang static analyzer? (`clang-analyzer-cplusplus.PlacementNew`) :19:5: warning: Storage provided to placement new is only 2 bytes, whe

[PATCH] D76229: [clang-tidy] Added PlacementNewStorageCheck

f00kat added a comment. In D76229#1925268 , @aaron.ballman wrote: > Have you considered making this a static analyzer check as opposed to a > clang-tidy check? I think using dataflow analysis will really reduce the > false positives because it will be a

[PATCH] D76062: [PATCH] [ARM] ARMv8.6-a command-line + BFloat16 Asm Support

stuij updated this revision to Diff 250630. stuij edited the summary of this revision. stuij added a comment. Updating D76062 : [PATCH] [ARM] ARMv8.6-a command-line + BFloat16 Asm Support follow changes in patch: [TableGen] Support combining AssemblerPredicates w

[PATCH] D76229: [clang-tidy] Added PlacementNewStorageCheck

f00kat added a comment. In D76229#1925360 , @lebedev.ri wrote: > This seems to be already handled by clang static analyzer? > (`clang-analyzer-cplusplus.PlacementNew`) > > :19:5: warning: Storage provided to placement new is only 2 bytes, > whereas the

[PATCH] D75579: Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by runtime-registration

serge-sans-paille added a comment. @MaskRay no longer a WIP ;-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75579/new/ https://reviews.llvm.org/D75579 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D75579: Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by runtime-registration

serge-sans-paille updated this revision to Diff 250631. serge-sans-paille added a comment. Renamed registration constructor to use a more llvm-ish name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75579/new/ https://reviews.llvm.org/D75579 Files

[PATCH] D76229: [clang-tidy] Added PlacementNewStorageCheck

f00kat added a comment. In D76229#1925360 , @lebedev.ri wrote: > This seems to be already handled by clang static analyzer? > (`clang-analyzer-cplusplus.PlacementNew`) > > :19:5: warning: Storage provided to placement new is only 2 bytes, > whereas the

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo marked an inline comment as done and an inline comment as not done. oontvoo added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:1266 + if (PP.isIncludeVisibleInLocalModule(File, M)) return false; + else PP.setIncludeVisibleForHeader(File, M); +

[PATCH] D76030: [CUDA] Warn about unsupported CUDA SDK version only if it's used.

tra added a subscriber: hans. tra added a comment. @hans -- this should be cherry-picked into 10 if it's not too late yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76030/new/ https://reviews.llvm.org/D76030

[PATCH] D76096: [clang] allow const structs to be constant expressions in initializer lists

rsmith added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1013 + if (V->hasInit()) +return Visit(V->getInit(), V->getType()); +return nullptr; nickdesaulniers wrote: > efriedma wrote: > > You need to be more careful here; we

[clang] 2a3723e - [memtag] Plug in stack safety analysis.

Author: Evgenii Stepanov Date: 2020-03-16T16:35:25-07:00 New Revision: 2a3723ef114d467179d463539dd73974b87ccf85 URL: https://github.com/llvm/llvm-project/commit/2a3723ef114d467179d463539dd73974b87ccf85 DIFF: https://github.com/llvm/llvm-project/commit/2a3723ef114d467179d463539dd73974b87ccf85.di

  1   2   >