balazske marked 3 inline comments as done.
balazske added inline comments.
================
Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:88
struct FnDescription;
using FnCheck = std::function<void(const StreamChecker *, const FnDescription
*,
const CallEvent &, CheckerContext &)>;
----------------
NoQ wrote:
> balazske wrote:
> > NoQ wrote:
> > > `llvm::function_ref`?
> > `function_ref`'s documentation says:
> > > This class does not own the callable, so it is not in general safe to
> > > store a function_ref.
> > The `FnDescription` stores these functions so it is not safe to use
> > `llvm::function_ref`?
> >
> >
> >
> I think you're using it only for global function pointers, no?
Probably can work but I tried it and got compile errors.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75682/new/
https://reviews.llvm.org/D75682
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
