thakis added inline comments.
================ Comment at: clang/include/clang/Basic/CMakeLists.txt:44 # ARM NEON and MVE clang_tablegen(arm_neon.inc -gen-arm-neon-sema ---------------- Update comment to also say "SVE" and "CDE" (or just say "# ARM builtin headers") ================ Comment at: clang/utils/TableGen/TableGen.cpp:196 + clEnumValN(GenArmSveCodeGenMap, "gen-arm-sve-codegenmap", + "Generate arm_sve_codegenmap.inc for clang"), clEnumValN(GenArmMveHeader, "gen-arm-mve-header", ---------------- Any reason these aren't called `-gen-arm-sve-builtin-def` and `-gen-arm-sve-builtin-codegen` for consistency with CDE and MVE? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75470/new/ https://reviews.llvm.org/D75470 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits