[PATCH] D74814: IR printing for single function with the new pass manager.

wenlei added a comment. Thanks for fixing this. Could you use `.ll` IR file as test case and place it alongside with `test/Other/module-pass-printer.ll` or just reuse that one? We can also use `opt` to invoke new pass manager, so it doesn't need to be a clang test. Repository: rG LLVM Githu

[clang-tools-extra] 4921e79 - Fix build after D74606

Author: Kirill Bobyrev Date: 2020-02-19T09:19:15+01:00 New Revision: 4921e7919223a785081a13c8a08063e91bae0db8 URL: https://github.com/llvm/llvm-project/commit/4921e7919223a785081a13c8a08063e91bae0db8 DIFF: https://github.com/llvm/llvm-project/commit/4921e7919223a785081a13c8a08063e91bae0db8.diff

[PATCH] D73138: [libcxx] [test] Correct asserted type in subspan test; subspan with count should never produce dynamic_extent

miscco added a comment. Ah sorry about that, I overlooked that we had special cased tests without count. Thanks Billy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73138/new/ https://reviews.llvm.org/D73138 _

[PATCH] D73186: [AST] Add fixed-point multiplication constant evaluation.

ebevhan added inline comments. Comment at: clang/lib/Basic/FixedPoint.cpp:242 + } else +Overflowed = Result < Min || Result > Max; + rjmccall wrote: > ebevhan wrote: > > rjmccall wrote: > > > leonardchan wrote: > > > > ebevhan wrote: > > > > > rjmccall wrote

[clang-tools-extra] fa6aef4 - [clang-tidy] Added a case to UnconventionalAssignOperatorCheck.

Author: Balázs Kéri Date: 2020-02-19T10:07:34+01:00 New Revision: fa6aef44277230adecb541c78a71978172accd5c URL: https://github.com/llvm/llvm-project/commit/fa6aef44277230adecb541c78a71978172accd5c DIFF: https://github.com/llvm/llvm-project/commit/fa6aef44277230adecb541c78a71978172accd5c.diff L

[PATCH] D74529: [clang-tidy] Added a case to UnconventionalAssignOperatorCheck.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfa6aef442772: [clang-tidy] Added a case to UnconventionalAssignOperatorCheck. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74529/new

[PATCH] D74801: [ADT][NFC] SCCIterator: Change hasLoop() to hasCycle()

lebedev.ri accepted this revision. lebedev.ri added a comment. lg CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74801/new/ https://reviews.llvm.org/D74801 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[clang] faff707 - Reland "[DebugInfo] Enable the debug entry values feature by default"

Author: Djordje Todorovic Date: 2020-02-19T11:12:26+01:00 New Revision: faff707db82d7db12fcd9f7826b8741261230e63 URL: https://github.com/llvm/llvm-project/commit/faff707db82d7db12fcd9f7826b8741261230e63 DIFF: https://github.com/llvm/llvm-project/commit/faff707db82d7db12fcd9f7826b8741261230e63.d

[PATCH] D74769: [AArch64][SVE] Add SVE2 intrinsics for polynomial arithmetic

This revision was automatically updated to reflect the committed changes. Closed by commit rG63236078d243: [AArch64][SVE] Add SVE2 intrinsics for polynomial arithmetic (authored by kmclaughlin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74769/new

[PATCH] D74806: [analyzer] NFCi: Refactor CStringChecker: use strongly typed internal API

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. This is fantastic, i love it! > all tests are preserved and passing; only *the message changed at some > places*. In my opinion, these messages are holding the same information. You make it sound l

[PATCH] D69782: Summary: Instead of dropping all the ranges associated with a Diagnostic when converting them to a ClangTidy error, instead attach them to the ClangTidyError, so they can be consumed b

alexfh added inline comments. Comment at: include/clang/Tooling/Core/Diagnostic.h:51 +/// Represents a single source ranges to be associated with a diagnostic. +struct DiagnosticAssociatedRange { + DiagnosticAssociatedRange() = default; This comment was lost by

[clang] 78654e8 - Revert "Reland D74436 "Change clang option -ffp-model=precise to select ffp-contract=on"""

Author: Oliver Stannard Date: 2020-02-19T12:03:27Z New Revision: 78654e8511cf16d49f6680d782f3771a767ba942 URL: https://github.com/llvm/llvm-project/commit/78654e8511cf16d49f6680d782f3771a767ba942 DIFF: https://github.com/llvm/llvm-project/commit/78654e8511cf16d49f6680d782f3771a767ba942.diff LO

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader updated this revision to Diff 245373. bader marked 12 inline comments as done. bader added a comment. Rebase to ToT and address comments from Ronan. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72857/new/ https://reviews.llvm.org/D72857 Fil

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader marked an inline comment as done. bader added inline comments. Comment at: clang/include/clang/Driver/Options.td:3419 +def sycl_std_EQ : Joined<["-"], "sycl-std=">, Group, Flags<[CC1Option, NoArgumentUnused, CoreOption]>, + HelpText<"SYCL language standard to compile for.

[clang] 49b307e - [AArch64][SVE] CodeGen of ACLE Builtin Types

Author: Sander de Smalen Date: 2020-02-19T12:10:47Z New Revision: 49b307e96d47a74e4aa8f60f3d493eac10849d4b URL: https://github.com/llvm/llvm-project/commit/49b307e96d47a74e4aa8f60f3d493eac10849d4b DIFF: https://github.com/llvm/llvm-project/commit/49b307e96d47a74e4aa8f60f3d493eac10849d4b.diff L

[PATCH] D74724: [AArch64][SVE] CodeGen of ACLE Builtin Types

This revision was automatically updated to reflect the committed changes. Closed by commit rG49b307e96d47: [AArch64][SVE] CodeGen of ACLE Builtin Types (authored by sdesmalen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74724/new/ https://reviews

[PATCH] D74787: [IRBuilder] Always respect inserter/folder

nhaehnle accepted this revision. nhaehnle added a comment. This revision is now accepted and ready to land. LGTM. I think it's a pretty reasonable idea to add this threshold check to track down things that should be minor, but can add up in terms of compile-time performance. Repository: rG L

[PATCH] D74757: Fix compiler extension in standalone mode

Keruspe accepted this revision. Keruspe added a comment. This revision is now accepted and ready to land. Works fine with 10.0.0rc2 and related patches applied, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74757/new/ https://reviews.llvm.o

[PATCH] D74806: [analyzer] NFCi: Refactor CStringChecker: use strongly typed internal API

steakhal marked an inline comment as done. steakhal added a comment. In D74806#1882300 , @NoQ wrote: > This is fantastic, i love it! > > > all tests are preserved and passing; only *the message changed at some > > places*. In my opinion, these messages ar

[PATCH] D74564: libclang: Add static build support for Windows

cristian.adam added a comment. @mstorsjo can you help me with pushing this commit? Thank you in advance! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74564/new/ https://reviews.llvm.org/D74564 ___ cfe

[PATCH] D74801: [ADT][NFC] SCCIterator: Change hasLoop() to hasCycle()

baziotis added a comment. In D74801#1882155 , @lebedev.ri wrote: > lg Great! Just a note: I don't have commit access. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74801/new/ https://reviews.llvm.org/D74801 _

[PATCH] D74709: [clangd] Allow renaming class templates in cross-file rename.

kbobyrev added a comment. I think we might still give a warning of some sort that this is known to produce results that are not always correct. Otherwise it might feel like a bug/unknown behavior. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7470

[PATCH] D69746: [analyzer] FixItHint: Apply and test hints with the Clang Tidy's script

alexfh added a comment. Herald added subscribers: martong, steakhal. A few nits. Comment at: clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:93 + + bool IncludePath = false, ShouldEmitAsError = false, FixitsAsRemarks = false, + ApplyFixIts = false; ---

[PATCH] D72730: [clang-tidy] run-clang-tidy -export-fixes exports only fixes, not all warnings

alexfh added a comment. In D72730#1866043 , @AlexanderLanin wrote: > On second thought maybe this should be fixed in clang-tidy and not here? > Maybe besides `-export-fixes` there should be an `-export-warnings` or just > `-yaml-export`? I like the id

[PATCH] D74562: [OpenMP][OMPIRBuilder] Introducing the `OMPBuilderCBHelpers` helper class

fghanim added a comment. I am done updating this patch. I still don't have commit access, I'd appreciate it if you'd commit this for me when you get a chance. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74562/new/ https://reviews.llvm.org/D74562

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro updated this revision to Diff 245345. djtodoro added a comment. - Address the issue with ARM `describeLoadedValue()` (thanks to @vsk, I've reduced the test `llvm/test/DebugInfo/MIR/ARM/dbgcallsite-noreg-is-imm-check.mir`) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

dstenb added a comment. In D73534#1881353 , @nickdesaulniers wrote: > As a heads up, Linaro's ToolChain Working Group's Linux kernel CI lit up on > this change. I see it's been reverted (thank you). Please cc me on the > updated patch and I can help tes

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. In D73534#1882118 , @dstenb wrote: > In D73534#1881353 , @nickdesaulniers > wrote: > > > As a heads up, Linaro's ToolChain Working Group's Linux kernel CI lit up on > > this change. I see

[PATCH] D74829: [clang-rename] Add the USR of incomplete decl to the USRSet.

hokein created this revision. hokein added a reviewer: kbobyrev. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, ilya-biryukov. Herald added a project: clang. This fixes a clangd rename issue, which is missing the reference of an incomplete specialization. Unfortunately, I didn'

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

dstenb added a comment. In D73534#1882127 , @djtodoro wrote: > @dstenb No problem, we have already addressed the issue. Thanks to @vsk and > @nickdesaulniers! I'll update the patch. Great, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D74830: [clang][Index] Fix the incomplete instantiations in libindex.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, jkorous, ilya-biryukov. Herald added a project: clang. libindex will canonicalize references to template instantiations: - 1) reference to an explicit template specialization, report th

[clang] 81e8b60 - [OpenCL] Only declare _sat conversions for integer types

Author: Sven van Haastregt Date: 2020-02-19T13:52:58Z New Revision: 81e8b60b722e5494cb92b6b4ec03d4631028eece URL: https://github.com/llvm/llvm-project/commit/81e8b60b722e5494cb92b6b4ec03d4631028eece DIFF: https://github.com/llvm/llvm-project/commit/81e8b60b722e5494cb92b6b4ec03d4631028eece.diff

[PATCH] D74833: [AArch64][SVE] Add intrinsics for SVE2 cryptographic instructions

kmclaughlin created this revision. kmclaughlin added reviewers: sdesmalen, c-rhodes, dancgr, cameron.mcinally, efriedma. Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: LLVM. Implements the following SVE2 in

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

tnorth added a comment. Ping. I guess we need more approval to go forward? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/ https://reviews.llvm.org/D72326 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D74834: [clangd] Expose the rename LimitFiles option to the C++ API, NFC.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D74834 Files: clang-tools-extra/clangd/Clan

[PATCH] D68578: [HIP] Fix device stub name

rjmccall added inline comments. Comment at: clang/include/clang/AST/GlobalDecl.h:40 + Stub = 1, +}; + tra wrote: > rjmccall wrote: > > tra wrote: > > > rjmccall wrote: > > > > The attribute here is `CUDAGlobalAttr`; should this be named in terms > > > > of CUDA

[PATCH] D72231: [Sema] Adds the pointer-to-int-cast diagnostic

rjmccall added a comment. Okay. Can we raise this with the kernel folks instead of just assuming they'll be opposed? An obvious patch to fix a few dozen places where they're hit by a warning they intentionally enabled really doesn't seem like a burden. If they push back, fine, we can enable

[PATCH] D74116: [Sema][C++] Propagate conversion type in order to specialize the diagnostics

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:14829 +if (getLangOpts().CPlusPlus) + isInvalid = true; break; Could you hoist this up to the place where we pick the diagnostic and then make it unconditional in the path that

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

ABataev added a comment. Herald added a subscriber: martong. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74144/new/ https://reviews.llvm.org/D74144 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D74838: [ARM,MVE] Fix predicate types of some intrinsics

miyuki created this revision. miyuki added reviewers: simon_tatham, dmgreen, ostannard, MarkMurrayARM. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. Some predicated MVE intrinsics return a vector with element size different from

[PATCH] D74838: [ARM,MVE] Fix predicate types of some intrinsics

MarkMurrayARM added a comment. Nice catch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74838/new/ https://reviews.llvm.org/D74838 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D74840: [AST matchers] Add basic matchers for googletest EXPECT/ASSERT calls.

ymandel created this revision. ymandel added a reviewer: gribozavr2. Herald added a subscriber: mgorny. Herald added a project: clang. This revision adds matchers that match calls to the gtest EXPECT and ASSERT macros almost like function calls. The matchers are placed in separate files (GtestMatc

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

lebedev.ri added inline comments. Comment at: include/clang/Format/Format.h:2341 /// directory if ``FileName`` is empty. +/// * "file=" to explicitly specify the configuration file to use. /// So is it `:` or `=`? Repository: rC Clang CHANGES SINCE LAST AC

[PATCH] D74813: [RFC] Add hash of block contents to function block names

vsk edited reviewers, added: ahatanak, erik.pilkington, dexonsmith; removed: vsk. vsk added a comment. At a high level the idea sounds good to me. For out OSes, symbol name instability results in serious performance regressions as this invalidates text/data orderfiles. Why shouldn’t this be on

[PATCH] D71092: [VFS] More consistent support for Windows

amccarth closed this revision. amccarth added a comment. This landed in da45bd232165eab5d6ec4f1f4f18db8644289142 It wasn't automatically closed because I misspelled "Differential Revision." CHANGES SINCE LAST ACTION https:

[PATCH] D74838: [ARM,MVE] Fix predicate types of some intrinsics

miyuki added a comment. The test failure is unrelated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74838/new/ https://reviews.llvm.org/D74838 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[clang] 461fd94 - [ARM,MVE] Fix predicate types of some intrinsics

Author: Mikhail Maltsev Date: 2020-02-19T16:24:54Z New Revision: 461fd94f004c78374fc7b0338d018f9610f2e5f5 URL: https://github.com/llvm/llvm-project/commit/461fd94f004c78374fc7b0338d018f9610f2e5f5 DIFF: https://github.com/llvm/llvm-project/commit/461fd94f004c78374fc7b0338d018f9610f2e5f5.diff LO

[PATCH] D74838: [ARM,MVE] Fix predicate types of some intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rG461fd94f004c: [ARM,MVE] Fix predicate types of some intrinsics (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74838/new/ https://review

[PATCH] D74790: [Sema][CodeComplete] Handle symlinks for include code completion

dgoldman updated this revision to Diff 245415. dgoldman added a comment. - Fixes for Sam's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74790/new/ https://reviews.llvm.org/D74790 Files: clang/lib/Sema/SemaCodeComplete.cpp clang/test/

[PATCH] D73916: [clang] Add `forceReload` clangd extension to 'textDocument/didChange'

dgoldman added a comment. In D73916#1881396 , @nridge wrote: > Which client(s) use or plan to use this extension? SourceKit-LSP https://github.com/apple/sourcekit-lsp/pull/242 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D74790: [Sema][CodeComplete] Handle symlinks for include code completion

dgoldman marked 3 inline comments as done. dgoldman added a comment. In D74790#1881827 , @sammccall wrote: > Thanks! I can't see this being a performance problem (famous last words...) Technically it is capped at 2500 symlinks =) fingers crossed Reposi

[PATCH] D74811: [Driver] Escape the program path for -frecord-command-line

scott.linder added a comment. This LGTM, but could you add a simple test with a command-line that needs the escaping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74811/new/ https://reviews.llvm.org/D74811 _

[PATCH] D74842: [clangd] Make use of syntax tokens in ReplayPreamble

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Replace usage of RawLexer with syntax tokens inside ReplayPreamble. Repository: rG LLVM Github Mono

[clang] f12fb2d - [IRBuilder] Always respect inserter/folder

Author: Nikita Popov Date: 2020-02-19T17:44:43+01:00 New Revision: f12fb2d99b8dd0dbef1c79f1d401200150f2d0bd URL: https://github.com/llvm/llvm-project/commit/f12fb2d99b8dd0dbef1c79f1d401200150f2d0bd DIFF: https://github.com/llvm/llvm-project/commit/f12fb2d99b8dd0dbef1c79f1d401200150f2d0bd.diff

[PATCH] D74787: [IRBuilder] Always respect inserter/folder

This revision was automatically updated to reflect the committed changes. Closed by commit rGf12fb2d99b8d: [IRBuilder] Always respect inserter/folder (authored by nikic). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74787/new/ https://reviews.llvm.

[clang] f50fe5e - [Sema][CodeComplete] Handle symlinks for include code completion

Author: David Goldman Date: 2020-02-19T11:45:58-05:00 New Revision: f50fe5eb6d2ec0adb5b2fd91a4023fc1573e061f URL: https://github.com/llvm/llvm-project/commit/f50fe5eb6d2ec0adb5b2fd91a4023fc1573e061f DIFF: https://github.com/llvm/llvm-project/commit/f50fe5eb6d2ec0adb5b2fd91a4023fc1573e061f.diff

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

erichkeane added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1514 + void visitUsedDecl(SourceLocation Loc, Decl *D) { +if (auto *TD = dyn_cast(D)) { + for (auto *DD : TD->decls()) { Note that when recommitting this (if you choose to), this need

[PATCH] D74790: [Sema][CodeComplete] Handle symlinks for include code completion

This revision was automatically updated to reflect the committed changes. Closed by commit rGf50fe5eb6d2e: [Sema][CodeComplete] Handle symlinks for include code completion (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74790/ne

[PATCH] D74814: IR printing for single function with the new pass manager.

hoyFB added a comment. In D74814#1882064 , @wenlei wrote: > Thanks for fixing this. Could you use `.ll` IR file as test case and place it > alongside with `test/Other/module-pass-printer.ll` or just reuse that one? We > can also use `opt` to invoke new p

[clang] b92b170 - Revert "[IRBuilder] Always respect inserter/folder"

Author: Nikita Popov Date: 2020-02-19T17:51:55+01:00 New Revision: b92b1701cd30d356fa3ac4da3d0dba20fa614e0b URL: https://github.com/llvm/llvm-project/commit/b92b1701cd30d356fa3ac4da3d0dba20fa614e0b DIFF: https://github.com/llvm/llvm-project/commit/b92b1701cd30d356fa3ac4da3d0dba20fa614e0b.diff

[PATCH] D74844: [clangd] Get rid of Lexer usage in CodeComplete

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D74844 Files: clang-tools-extra/clan

[PATCH] D74807: Add cl_khr_mipmap_image_writes as supported to AMDGPU

b-sumner accepted this revision. b-sumner added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74807/new/ https://reviews.llvm.org/D74807 ___ cfe-commits mailing list cfe-commi

RE: [PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

[AMD Official Use Only - Internal Distribution Only] Will do. Thanks. Sam -Original Message- From: Erich Keane via Phabricator Sent: Wednesday, February 19, 2020 8:52 AM To: Liu, Yaxun (Sam) ; t...@google.com; rjmcc...@gmail.com; rich...@metafoo.co.uk; jdoerf...@anl.gov; a.bat...@hotm

[PATCH] D74842: [clangd] Make use of syntax tokens in ReplayPreamble

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ParsedAST.cpp:138 + : Includes(Includes), Delegate(Delegate), SM(SM), PP(PP) { +MainFileTokens = syntax::tokenize(SM.getMainFileID(), SM, LangOpts); + } tokenizing the whole file an e

[PATCH] D74845: [ARM,MVE] Add vqdmull[b,t]q intrinsic families

miyuki created this revision. miyuki added reviewers: simon_tatham, MarkMurrayARM, dmgreen, ostannard. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. This patch adds two families of ACLE intrinsics: vqdmullbq and vqdmulltq (includ

[clang] a54d81f - [analyzer] CERT: POS34-C

Author: Zurab Tsinadze Date: 2020-02-19T18:12:19+01:00 New Revision: a54d81f597963b8768ce2b94a8ef570f9eaaac25 URL: https://github.com/llvm/llvm-project/commit/a54d81f597963b8768ce2b94a8ef570f9eaaac25 DIFF: https://github.com/llvm/llvm-project/commit/a54d81f597963b8768ce2b94a8ef570f9eaaac25.diff

[PATCH] D71433: [analyzer] CERT: POS34-C

This revision was automatically updated to reflect the committed changes. Closed by commit rGa54d81f59796: [analyzer] CERT: POS34-C (authored by zukatsinadze). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71433/new/ https://reviews.llvm.org/D71433

[PATCH] D74846: fix -fcodegen-modules code when used with PCH (PR44958)

llunak created this revision. llunak added reviewers: hans, dblaikie. llunak added a project: clang. Herald added a subscriber: cfe-commits. In D69778 I incorrectly handled two cases (checking for -building-pch-with-obj without also checking -fmodules-codegen).

[PATCH] D68578: [HIP] Fix device stub name

tra added inline comments. Comment at: clang/include/clang/AST/GlobalDecl.h:40 + Stub = 1, +}; + rjmccall wrote: > tra wrote: > > rjmccall wrote: > > > tra wrote: > > > > rjmccall wrote: > > > > > The attribute here is `CUDAGlobalAttr`; should this be named in t

[PATCH] D74844: [clangd] Get rid of Lexer usage in CodeComplete

sammccall added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:593 + llvm::StringRef SpelledSpecifier = + syntax::FileRange(CCSema.SourceMgr, SemaSpecifier->getBeginLoc(), +SemaSpecifier->getEndLoc()) what if

[PATCH] D74015: [AIX][Frontend] C++ ABI customizations for AIX boilerplate

sfertile added a comment. Patch LGTM as far a formatting/naming/testing etc. C++ specifics is outside my wheelhouse though, so I can't confirm things like the tail padding rules are correct for AIX. Because of that I'm not comfortable being the one to accept the patch. CHANGES SINCE LAST ACTI

[PATCH] D74845: [ARM,MVE] Add vqdmull[b,t]q intrinsic families

MarkMurrayARM accepted this revision. MarkMurrayARM added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74845/new/ https://reviews.llvm.org/D74845

[PATCH] D74847: [CodeGen][RISCV] Fix clang/test/CodeGen/atomic_ops.c for RISC-V

luismarques created this revision. luismarques added reviewers: jyknight, eli.friedman, lenary. Herald added subscribers: cfe-commits, evandro, sameer.abuasal, s.egerton, Jim, benna, psnobl, PkmX, jfb, rkruppe, rogfer01, shiva0217, kito-cheng, simoncook. Herald added a project: clang. By default

[PATCH] D74784: [driver][darwin] Don't use -platform_version flag by default

steven_wu added a comment. I forgot if there is reason to use the option by default at all time (I did ask that in the previous review but Alex might have given more context offline). You should definitely add test for this change. The fact that you change all `-mlinker-version=400` to `-mlinke

[PATCH] D74784: [driver][darwin] Don't use -platform_version flag by default

dmajor added a comment. In D74784#1882974 , @steven_wu wrote: > I forgot if there is reason to use the option by default at all time (I did > ask that in the previous review but Alex might have given more context > offline). I would really like to hear

[PATCH] D74847: [CodeGen][RISCV] Fix clang/test/CodeGen/atomic_ops.c for RISC-V

efriedma added a comment. I'm not really a big fan of running tests with the host target triple, anyway; it seems to create work with almost no benefit. I'd be happy to just run the test with one target that has native atomics, and one target that doesn't. (The relevant code is all target-ind

[PATCH] D74847: [CodeGen][RISCV] Fix clang/test/CodeGen/atomic_ops.c for RISC-V

efriedma added a comment. On a side-note, we could enhance the test runner to support "XFAIL: riscv32-default-target" if we thought it would be useful. But again, I'm not a fan of tests that depend on the default target in the first place. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

nickdesaulniers added a comment. In D73534#1882136 , @djtodoro wrote: > - Address the issue with ARM `describeLoadedValue()` (thanks to @vsk, I've > reduced the test > `llvm/test/DebugInfo/MIR/ARM/dbgcallsite-noreg-is-imm-check.mir`) I'd like to help t

[PATCH] D74850: [clangd] Migrate Lexer usages in TypeHierarchy to TokenBuffers

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Also fixes a bug, resulting from directly using ND.getEndLoc() for end location of the range. As ND.get

[PATCH] D74814: IR printing for single function with the new pass manager.

wenlei added a comment. > Sounds good. I was trying to figure out how to invoke the new pass manager > with OPT. Is there a command line switch to do that? If you just do `opt -passes=`, it will invoke new pass manager for `opt`. See https://reviews.llvm.org/D66560 for example - that was for

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

rjmccall added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1514 + void visitUsedDecl(SourceLocation Loc, Decl *D) { +if (auto *TD = dyn_cast(D)) { + for (auto *DD : TD->decls()) { erichkeane wrote: > Note that when recommitting this (if you cho

[PATCH] D74811: [Driver] Escape the program path for -frecord-command-line

ravi-ramaseshan updated this revision to Diff 245456. ravi-ramaseshan added a comment. Add a simple test with a command-line that needs the escaping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74811/new/ https://reviews.llvm.org/D74811 Files:

[PATCH] D74811: [Driver] Escape the program path for -frecord-command-line

ravi-ramaseshan added a comment. In D74811#1882783 , @scott.linder wrote: > This LGTM, but could you add a simple test with a command-line that needs the > escaping? Done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

hliao updated this revision to Diff 245461. hliao added a comment. Rebase to the latest trunk code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71227/new/ https://reviews.llvm.org/D71227 Files: clang/include/clang/Sema/Sema.h clang/lib/Parse

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

erichkeane added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1514 + void visitUsedDecl(SourceLocation Loc, Decl *D) { +if (auto *TD = dyn_cast(D)) { + for (auto *DD : TD->decls()) { rjmccall wrote: > erichkeane wrote: > > Note that when recommi

[PATCH] D69868: Allow "callbr" to return non-void values

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. This code has now been tested on a running Linux kernel making use of the feature. I still would like @jyknight to clarify his comments, consider explicitly requesting chang

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

rjmccall added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1514 + void visitUsedDecl(SourceLocation Loc, Decl *D) { +if (auto *TD = dyn_cast(D)) { + for (auto *DD : TD->decls()) { erichkeane wrote: > rjmccall wrote: > > erichkeane wrote: > > >

[PATCH] D74814: IR printing for single function with the new pass manager.

hoyFB updated this revision to Diff 245474. hoyFB added a comment. Updating D74814 : IR printing for single function with the new pass manager. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74814/new/ https://revie

[PATCH] D74814: IR printing for single function with the new pass manager.

wenlei accepted this revision. wenlei added a comment. This revision is now accepted and ready to land. Thanks for the making the changes, it would be nice to have some consistency (the same structure) between test cases for legacy PM and new PM, e.g. `EMPTY` is only tested for legacy PM, but no

[PATCH] D74813: [RFC] Add hash of block contents to function block names

alexbdv added a subscriber: vsk. alexbdv added a comment. @vsk - sure will add tests when removing from RFC. As for making it default - would rather have this under a flag as hashing the block contents does have some overhead and I imagine this feature wouldn't be beneficial in most scenarios.

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

nickdesaulniers added a comment. In D73534#1883048 , @djtodoro wrote: > I’ve already pushed this. Please rebase on the latest commits. Ah faff707db82d7db12fcd9f7826b8741261230e63 . Coo

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. In D73534#1883022 , @nickdesaulniers wrote: > In D73534#1882136 , @djtodoro wrote: > > > - Address the issue with ARM `describeLoadedValue()` (thanks to @vsk, I've > > reduced the test >

[PATCH] D74814: IR printing for single function with the new pass manager.

hoyFB updated this revision to Diff 245484. hoyFB added a comment. Updating D74814 : IR printing for single function with the new pass manager. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74814/new/ https://revie

[PATCH] D72231: [Sema] Adds the pointer-to-int-cast diagnostic

Mordante added a comment. In D72231#1882658 , @rjmccall wrote: > Okay. Can we raise this with the kernel folks instead of just assuming > they'll be opposed? An obvious patch to fix a few dozen places where they're > hit by a warning they intentionally

[PATCH] D73186: [AST] Add fixed-point multiplication constant evaluation.

leonardchan added inline comments. Comment at: clang/lib/Basic/FixedPoint.cpp:242 + } else +Overflowed = Result < Min || Result > Max; + ebevhan wrote: > rjmccall wrote: > > ebevhan wrote: > > > rjmccall wrote: > > > > leonardchan wrote: > > > > > ebevhan wr

[clang] f6875c4 - Reapply [IRBuilder] Always respect inserter/folder

Author: Nikita Popov Date: 2020-02-19T20:51:38+01:00 New Revision: f6875c434ec20eb4f24495317592f64334347784 URL: https://github.com/llvm/llvm-project/commit/f6875c434ec20eb4f24495317592f64334347784 DIFF: https://github.com/llvm/llvm-project/commit/f6875c434ec20eb4f24495317592f64334347784.diff

[PATCH] D73186: [AST] Add fixed-point multiplication constant evaluation.

rjmccall added inline comments. Comment at: clang/lib/Basic/FixedPoint.cpp:242 + } else +Overflowed = Result < Min || Result > Max; + leonardchan wrote: > ebevhan wrote: > > rjmccall wrote: > > > ebevhan wrote: > > > > rjmccall wrote: > > > > > leonardchan w

[clang] ba3f863 - [OpenMP][OMPIRBuilder] Introducing the `OMPBuilderCBHelpers` helper class

Author: Fady Ghanim Date: 2020-02-19T14:11:17-06:00 New Revision: ba3f863dfb9c5f9bf5e6fdca2198b609df3b7761 URL: https://github.com/llvm/llvm-project/commit/ba3f863dfb9c5f9bf5e6fdca2198b609df3b7761 DIFF: https://github.com/llvm/llvm-project/commit/ba3f863dfb9c5f9bf5e6fdca2198b609df3b7761.diff L

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

rjmccall added inline comments. Comment at: clang/include/clang/Sema/Sema.h:11442 + ContextDecl = getCUDACurrentNonLocalVariable(); +return ContextDecl; + } This is tricky because we could be in a nested context, not just the initializer, and that cont

[PATCH] D74116: [Sema][C++] Propagate conversion type in order to specialize the diagnostics

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:14829 +if (getLangOpts().CPlusPlus) + isInvalid = true; break; rjmccall wrote: > Could you hoist this up to the place where we pick

  1   2   >