NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
This is fantastic, i love it!
> all tests are preserved and passing; only *the message changed at some
> places*. In my opinion, these messages are holding the same information.
You make it sound like an accident; i encourage you to have a closer look to
make sure that there are no other effects than the ones observed on tests.
================
Comment at: clang/test/Analysis/string.c:454
if (strlen(y) == 4)
- strcat(x, y); // expected-warning{{String copy function overflows
destination buffer}}
+ strcat(x, y); // expected-warning{{String concatenation function overflows
the destination buffer}}
}
----------------
Nice catch indeed!~
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74806/new/
https://reviews.llvm.org/D74806
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
