rjmccall added inline comments.
================
Comment at: clang/lib/Sema/SemaExpr.cpp:14829
+ if (getLangOpts().CPlusPlus)
+ isInvalid = true;
break;
----------------
Could you hoist this up to the place where we pick the diagnostic and then make
it unconditional in the path that always selects an error?
That's a general comment: we should be setting `isInvalid` for all the places
below where we select an error diagnostic.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74116/new/
https://reviews.llvm.org/D74116
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
