[PATCH] D49530: [libc++] Implement Directory Entry Caching -- Sort of.

BillyONeal added a comment. Herald added subscribers: libcxx-commits, dexonsmith. > @BillyONeal has proposed a more reasonable set of requirements I believe that was you. I wanted the throws/fails behavior. Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49530/n

[PATCH] D72998: [IR] Attribute/AttrBuilder: use Value::MaximumAlignment magic constant

gchatelet added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72998/new/ https://reviews.llvm.org/D72998 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

kbobyrev updated this revision to Diff 239498. kbobyrev added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72746/new/ https://reviews.llvm.org/D72746 Files: clang-tools-extra/clangd/index/Ref.h clang-tools-e

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

kbobyrev planned changes to this revision. kbobyrev added a comment. Will put a TODO and revert helpers back to use plain binary search over the tokens. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72746/new/ https://reviews.llvm.org/D72746 __

[PATCH] D73106: [Alignment][NFC] Use Align with CreateMaskedStore

gchatelet updated this revision to Diff 239501. gchatelet marked an inline comment as done. gchatelet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73106/new/ https://reviews.llvm.org/D73106 Files: clang/lib/C

[PATCH] D73106: [Alignment][NFC] Use Align with CreateMaskedStore

gchatelet marked 2 inline comments as done. gchatelet added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:2907 Value *Addr = I.getArgOperand(1); -const MaybeAlign Alignment( +const Align Alignment( cast(I.getArgOperand(

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

kbobyrev updated this revision to Diff 239502. kbobyrev added a comment. Actually, this approach might be more generic (i.e. not relying on implementation too much). Added the FIXME. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72746/new/ https://

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

kbobyrev updated this revision to Diff 239503. kbobyrev added a comment. Move added rename unit test to the end of the list. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72746/new/ https://reviews.llvm.org/D72746 Files: clang-tools-extra/clangd

[clang] de51559 - [Concepts] Fix incorrect recovery in TryAnnotateTypeConstraint

Author: Saar Raz Date: 2020-01-22T10:50:53+02:00 New Revision: de51559fa68049da73b696a4e89468154b12852a URL: https://github.com/llvm/llvm-project/commit/de51559fa68049da73b696a4e89468154b12852a DIFF: https://github.com/llvm/llvm-project/commit/de51559fa68049da73b696a4e89468154b12852a.diff LOG:

[PATCH] D73109: [clang][index] Index the injected class name types.

hokein updated this revision to Diff 239504. hokein added a comment. clang-format the code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73109/new/ https://reviews.llvm.org/D73109 Files: clang/lib/Index/IndexTypeSourceInfo.cpp clang/unittests

[PATCH] D73109: [clang][index] Index the injected class name types.

hokein added a comment. In D73109#1831399 , @kadircet wrote: > Have you checked if this class is missing any other typelocs? I haven't checked it in details, but the injected class name is an obvious missing case. Repository: rG LLVM Github Monorepo

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61855 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[clang] a133cba - [clang][index] Index the injected class name types.

Author: Haojian Wu Date: 2020-01-22T10:07:54+01:00 New Revision: a133cbaad5b292aab7134e3a91e80c5b2dddbe7e URL: https://github.com/llvm/llvm-project/commit/a133cbaad5b292aab7134e3a91e80c5b2dddbe7e DIFF: https://github.com/llvm/llvm-project/commit/a133cbaad5b292aab7134e3a91e80c5b2dddbe7e.diff LO

[PATCH] D73109: [clang][index] Index the injected class name types.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa133cbaad5b2: [clang][index] Index the injected class name types. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73109/new/ https://rev

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61855 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73106: [Alignment][NFC] Use Align with CreateMaskedStore

courbet accepted this revision. courbet added inline comments. This revision is now accepted and ready to land. Comment at: llvm/docs/LangRef.rst:14945 -The first operand is the base pointer for the load. The second operand is the alignment of the source location. It must be a

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61855 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[clang-tools-extra] 5d4e899 - [clangd] Handle the missing injectedClassNameType in targetDecl.

Author: Haojian Wu Date: 2020-01-22T10:13:39+01:00 New Revision: 5d4e89975714875a86cb8e62b60d93eebefa4029 URL: https://github.com/llvm/llvm-project/commit/5d4e89975714875a86cb8e62b60d93eebefa4029 DIFF: https://github.com/llvm/llvm-project/commit/5d4e89975714875a86cb8e62b60d93eebefa4029.diff LO

[PATCH] D73102: [clangd] Handle the missing injectedClassNameType in targetDecl.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5d4e89975714: [clangd] Handle the missing injectedClassNameType in targetDecl. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73102/new/

[clang] 45538b5 - [Concepts] Fix bug when referencing function parameters in instantiated function template requires clause

Author: Saar Raz Date: 2020-01-22T11:25:27+02:00 New Revision: 45538b5fb280e5b2903f7924fd4fa5b07a6dd3ea URL: https://github.com/llvm/llvm-project/commit/45538b5fb280e5b2903f7924fd4fa5b07a6dd3ea DIFF: https://github.com/llvm/llvm-project/commit/45538b5fb280e5b2903f7924fd4fa5b07a6dd3ea.diff LOG:

[PATCH] D71966: [Wdocumentation][RFC] Improve identifier's of \param

gribozavr2 added inline comments. Comment at: clang/include/clang-c/Documentation.h:383 CINDEX_LINKAGE -CXString clang_ParamCommandComment_getParamName(CXComment Comment); Mordante wrote: > gribozavr2 wrote: > > Please don't modify existing APIs in libclang --

[PATCH] D73109: [clang][index] Index the injected class name types.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62058 tests passed, 0 failed and 784 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73162: [test] Avoid loop-unroll.c test getting confused by fadd in git revision

russell.gallop created this revision. russell.gallop added a reviewer: asbirlea. Herald added a subscriber: zzheng. Herald added a project: clang. Saw this test failing as it was matching fadd in a (local) git revision: F:\git\llvm-project\clang\test\CodeGen\loop-unroll.c:38:30: error: CHECK-D

[PATCH] D73106: [Alignment][NFC] Use Align with CreateMaskedStore

gchatelet updated this revision to Diff 239513. gchatelet marked an inline comment as done. gchatelet added a comment. - Reverting LangRef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73106/new/ https://reviews.llvm.org/D73106 Files: clang/lib/

[PATCH] D72932: [ARM] Follow AACPS standard for volatile bit-fields access width

dnsampaio added a comment. In D72932#1829716 , @ostannard wrote: > Why are you doing this in CodeGen, rather than adjusting the existing layout > code in CGRecordLowering? Doing it this way will result in > AdjustAAPCSBitfieldLValue being called for ever

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

hokein added a comment. the scope of this patch is not very clear, the changes touch two different code parts `SymbolCollector`, and `Rename`, and we are lacking tests for `SymbolCollector`. I'd suggest spliting this patch into smaller patches: - a patch that adds a new kind to the ref, and upd

[PATCH] D73106: [Alignment][NFC] Use Align with CreateMaskedStore

gchatelet marked an inline comment as done. gchatelet added inline comments. Comment at: llvm/docs/LangRef.rst:14945 -The first operand is the base pointer for the load. The second operand is the alignment of the source location. It must be a constant integer value. The third

[PATCH] D72932: [ARM] Follow AACPS standard for volatile bit-fields access width

dnsampaio added a comment. In D72932#1829716 , @ostannard wrote: > Why are you doing this in CodeGen, rather than adjusting the existing layout > code in CGRecordLowering? Doing it this way will result in > AdjustAAPCSBitfieldLValue being called for ever

[clang] 0957233 - [Alignment][NFC] Use Align with CreateMaskedStore

Author: Guillaume Chatelet Date: 2020-01-22T11:04:39+01:00 New Revision: 0957233320eb0096bbb7665e0762a13bad1e7cb8 URL: https://github.com/llvm/llvm-project/commit/0957233320eb0096bbb7665e0762a13bad1e7cb8 DIFF: https://github.com/llvm/llvm-project/commit/0957233320eb0096bbb7665e0762a13bad1e7cb8.

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/Ref.h:34 + Spelled = 1 << 3, + All = Declaration | Definition | Reference | Spelled, }; hokein wrote: > The `All` now indicates all spelled refs. I think `All` should include both > no

[PATCH] D73106: [Alignment][NFC] Use Align with CreateMaskedStore

This revision was automatically updated to reflect the committed changes. Closed by commit rG0957233320eb: [Alignment][NFC] Use Align with CreateMaskedStore (authored by gchatelet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73106/new/ https://re

[PATCH] D72867: [clangd] Support renaming designated initializers

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:566 TU.ExtraArgs.push_back("-fno-delayed-template-parsing"); -TU.ExtraArgs.push_back("-std=c++17"); +TU.ExtraArgs.push_back

[PATCH] D72647: [clangd] Only re-open files if their flags changed

sammccall added a comment. Let's make the minimal change here and land this. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1126 + std::set ModifiedFiles; + auto Sub = + CDB->watch([&ModifiedFiles](const std::vector Changes) { dgoldman wrote: >

[clang] 7b81c3f - Revert "[Concepts] Fix bug when referencing function parameters in instantiated function template requires clause"

Author: Saar Raz Date: 2020-01-22T12:16:35+02:00 New Revision: 7b81c3f8793d30a4285095a9b67dcfca2117916c URL: https://github.com/llvm/llvm-project/commit/7b81c3f8793d30a4285095a9b67dcfca2117916c DIFF: https://github.com/llvm/llvm-project/commit/7b81c3f8793d30a4285095a9b67dcfca2117916c.diff LOG:

[PATCH] D73166: [ASTImporter] Properly delete decls from SavedImportPaths

jarin created this revision. jarin added reviewers: martong, teemperor. Herald added subscribers: cfe-commits, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. We see a significant regression (~40% slower on large codebases) in expressio

[clang-tools-extra] 9570f1e - [clangd] Do not duplicate TemplatedDecls in findExplicitReferences

Author: Kadir Cetinkaya Date: 2020-01-22T11:43:53+01:00 New Revision: 9570f1e5a612348e92c2f149f5073ef06f9e5da5 URL: https://github.com/llvm/llvm-project/commit/9570f1e5a612348e92c2f149f5073ef06f9e5da5 DIFF: https://github.com/llvm/llvm-project/commit/9570f1e5a612348e92c2f149f5073ef06f9e5da5.dif

[PATCH] D73101: [clangd] Do not duplicate TemplatedDecls in findExplicitReferences

kadircet updated this revision to Diff 239523. kadircet marked 2 inline comments as done. kadircet added a comment. - Update comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73101/new/ https://reviews.llvm.org/D73101 Files: clang-tools-ext

[PATCH] D73101: [clangd] Do not duplicate TemplatedDecls in findExplicitReferences

This revision was automatically updated to reflect the committed changes. Closed by commit rG9570f1e5a612: [clangd] Do not duplicate TemplatedDecls in findExplicitReferences (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73101/

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

hokein added inline comments. Comment at: clang-tools-extra/clangd/index/Ref.h:34 + Spelled = 1 << 3, + All = Declaration | Definition | Reference | Spelled, }; kadircet wrote: > hokein wrote: > > The `All` now indicates all spelled refs. I think `All` should

[PATCH] D72959: Relative VTables ABI on Fuchsia

peter.smith added a comment. In D72959#1832011 , @pcc wrote: > > On Aarch64, right now only CALL26 and JUMP26 instructions generate PLT > > relocations, so we manifest them with stubs that are just jumps to the > > original function. > > I think it would

[PATCH] D73101: [clangd] Do not duplicate TemplatedDecls in findExplicitReferences

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62094 tests passed, 0 failed and 785 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72373: [clang-tidy] extend misc-misplaced-const to detect using besides typedef

AlexanderLanin added a comment. ping > Could someone commit this? As I can not. > Alexander Lanin CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72373/new/ https://reviews.llvm.org/D72373 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D73025: [AArch64][SVE] Add first-faulting load intrinsic

sdesmalen accepted this revision. sdesmalen added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:11248 -static SDValue performLDNF1Combine(SDNode *N, SelectionDAG &DAG) { +static SDValue performLDNF1

[PATCH] D72097: [LifetimeAnalysis] Do not forbid void deref type in gsl::Pointer/gsl::Owner annotations

gribozavr2 added a comment. Sorry, just getting back to this review. Your justification makes sense, and the patch LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72097/new/ https://reviews.llvm.org/D72097 __

[PATCH] D71698: [AArch64][SVE] Add intrinsic for non-faulting loads

This revision was automatically updated to reflect the committed changes. Closed by commit rGcdcc4f2a44b5: [AArch64][SVE] Add intrinsic for non-faulting loads (authored by kmclaughlin). Changed prior to commit: https://reviews.llvm.org/D71698?vs=239144&id=239531#toc Repository: rG LLVM Githu

[PATCH] D31338: Move ParsedAttrInfos into a registry and point to one in ParsedAttr

john.brawn updated this revision to Diff 239536. john.brawn added a comment. Updated to match latest changes to D31337 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31338/new/ https://reviews.llvm.org/D31338 Files: clang/include/clang/Sema/CMakeList

[PATCH] D31337: Use virtual functions in ParsedAttrInfo instead of function pointers

john.brawn updated this revision to Diff 239535. john.brawn added a comment. Update based on review comments. Also fix warnings due to missing virtual destructor that I hadn't noticed before. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31337/new/ https://reviews.llvm.org/D31337 File

[clang-tools-extra] 201c646 - Remove extra '; ' to fix Wpedantic. NFCI.

Author: Simon Pilgrim Date: 2020-01-22T12:08:57Z New Revision: 201c646b2b9988cdebf6e95d523283009ae2e5ba URL: https://github.com/llvm/llvm-project/commit/201c646b2b9988cdebf6e95d523283009ae2e5ba DIFF: https://github.com/llvm/llvm-project/commit/201c646b2b9988cdebf6e95d523283009ae2e5ba.diff LOG:

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

kbobyrev updated this revision to Diff 239544. kbobyrev marked 7 inline comments as done. kbobyrev added a comment. Address review comments, add implicit references filter for SymbolCollector, test changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:599 +const auto Tokens = FilesToTokensCache[MainFileID]; +for (auto &DeclAndRef : DeclRefs) { + if (auto ID = getSymbolID(DeclAndRef.first)) { hokein wrote

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

kbobyrev updated this revision to Diff 239545. kbobyrev added a comment. Attempt to drop collected reference before doing more computation to improve performance. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72746/new/ https://reviews.llvm.org/D72

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61857 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61857 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

evgeny777 added inline comments. Comment at: clang/test/CodeGenCXX/lto-visibility-inference.cpp:73 c1->f(); - // ITANIUM-NOT: type.test{{.*}}!"_ZTS2C2" + // ITANIUM: type.test{{.*}}!"_ZTS2C2" // MS: type.test{{.*}}!"?AUC2@@" tejohnson wrote: > evgeny777 w

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader marked 2 inline comments as done. bader added a comment. > Maybe we should use the year of issue (2015 instead of 1.2.1) for the > -sycl-std version? That would be more stable for the upcoming SYCL versions, > and match somehow the C++ versioning. Sounds good to me. I'll update the patch.

[PATCH] D73177: [clang][CodeComplete] Make completion work after initializer lists

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. CodeCompletion was not being triggered after successfully parsed initializer lists, e.g. cpp void foo(int, bool); void bar() { foo({1}^, false);

[PATCH] D73177: [clang][CodeComplete] Make completion work after initializer lists

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62094 tests passed, 0 failed and 785 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73166: [ASTImporter] Properly delete decls from SavedImportPaths

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Thanks for the fix! Looks good to me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73166/new/ https://reviews.llvm.org/D73166

[clang-tools-extra] ecc7dae - Extend misc-misplaced-const to detect using declarations as well as typedef

Author: Alexander Lanin Date: 2020-01-22T08:45:20-05:00 New Revision: ecc7dae50c41bc8a129a158ecf0ae0270126505c URL: https://github.com/llvm/llvm-project/commit/ecc7dae50c41bc8a129a158ecf0ae0270126505c DIFF: https://github.com/llvm/llvm-project/commit/ecc7dae50c41bc8a129a158ecf0ae0270126505c.dif

[PATCH] D73177: [clang][CodeComplete] Make completion work after initializer lists

kadircet updated this revision to Diff 239555. kadircet added a comment. - Add comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73177/new/ https://reviews.llvm.org/D73177 Files: clang/lib/Parse/ParseExpr.cpp clang/test/CodeCompletion/cal

[PATCH] D72373: [clang-tidy] extend misc-misplaced-const to detect using besides typedef

aaron.ballman closed this revision. aaron.ballman added a comment. I've commit on your behalf in ecc7dae50c41bc8a129a158ecf0ae0270126505c . Sorry about the delay in committing and thank you for the patch! CHANGES SINCE LAST A

[PATCH] D72373: [clang-tidy] extend misc-misplaced-const to detect using besides typedef

thakis added a comment. Looks like this breaks tests: http://45.33.8.238/linux/8102/step_8.txt CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72373/new/ https://reviews.llvm.org/D72373 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D73177: [clang][CodeComplete] Make completion work after initializer lists

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62094 tests passed, 0 failed and 785 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73166: [ASTImporter] Properly delete decls from SavedImportPaths

jarin added a comment. Thanks for the review! I am not a committer; could you land the fix for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73166/new/ https://reviews.llvm.org/D73166 ___ cfe-comm

[clang-tools-extra] e3b15ed - Revert "Extend misc-misplaced-const to detect using declarations as well as typedef"

Author: Aaron Ballman Date: 2020-01-22T09:06:24-05:00 New Revision: e3b15ed376f3753d2a4e16281f8230e4ffed41ba URL: https://github.com/llvm/llvm-project/commit/e3b15ed376f3753d2a4e16281f8230e4ffed41ba DIFF: https://github.com/llvm/llvm-project/commit/e3b15ed376f3753d2a4e16281f8230e4ffed41ba.diff

[PATCH] D72373: [clang-tidy] extend misc-misplaced-const to detect using besides typedef

aaron.ballman added a comment. In D72373#1833569 , @thakis wrote: > Looks like this breaks tests: http://45.33.8.238/linux/8102/step_8.txt I reverted in e3b15ed376f3753d2a4e16281f8230e4ffed41ba

[clang] 4481eef - [ASTImporter] Properly delete decls from SavedImportPaths

Author: Jaroslav Sevcik Date: 2020-01-22T15:20:06+01:00 New Revision: 4481eefbe8425c63289186dd13319aaa7043e67f URL: https://github.com/llvm/llvm-project/commit/4481eefbe8425c63289186dd13319aaa7043e67f DIFF: https://github.com/llvm/llvm-project/commit/4481eefbe8425c63289186dd13319aaa7043e67f.dif

[PATCH] D73182: [CodeGen] Emit IR for fixed-point multiplication and division.

ebevhan created this revision. ebevhan added reviewers: rjmccall, leonardchan. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73182 Files: clang/lib/CodeGen/CGExprScalar.cpp clang/test/Frontend/fixed_poin

[PATCH] D73166: [ASTImporter] Properly delete decls from SavedImportPaths

teemperor added a comment. I can land it, seems to pass all LLDB tests too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73166/new/ https://reviews.llvm.org/D73166 ___ cfe-commits mailing list cfe-com

[PATCH] D73183: [CodeGen] Emit IR for fixed-point unary operators.

ebevhan created this revision. ebevhan added reviewers: rjmccall, leonardchan. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73183 Files: clang/lib/CodeGen/CGExprScalar.cpp clang/test/Frontend/fixed_poin

[PATCH] D73184: [CodeGen] Emit IR for compound assignment with fixed-point operands.

ebevhan created this revision. ebevhan added reviewers: rjmccall, leonardchan. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73184 Files: clang/lib/CodeGen/CGExprScalar.cpp clang/lib/Sema/SemaExpr.cpp

[PATCH] D73185: [AST] Add fixed-point subtraction constant evaluation.

ebevhan created this revision. ebevhan added reviewers: rjmccall, leonardchan. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73185 Files: clang/include/clang/Basic/FixedPoint.h clang/lib/AST/ExprConstant

[PATCH] D73166: [ASTImporter] Properly delete decls from SavedImportPaths

This revision was automatically updated to reflect the committed changes. Closed by commit rG4481eefbe842: [ASTImporter] Properly delete decls from SavedImportPaths (authored by jarin, committed by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D73187: [AST] Add fixed-point division constant evaluation.

ebevhan created this revision. ebevhan added reviewers: rjmccall, leonardchan, bjope. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73187 Files: clang/include/clang/Basic/FixedPoint.h clang/lib/AST/ExprC

[PATCH] D73186: [AST] Add fixed-point multiplication constant evaluation.

ebevhan created this revision. ebevhan added reviewers: rjmccall, leonardchan, bjope. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73186 Files: clang/include/clang/Basic/FixedPoint.h clang/lib/AST/ExprC

[PATCH] D73188: [AST] Improve overflow diagnostics for fixed-point constant evaluation.

ebevhan created this revision. ebevhan added reviewers: rjmccall, leonardchan, bjope. Herald added a project: clang. Herald added a subscriber: cfe-commits. Diagnostics for overflow were not being produced for fixed-point evaluation. This patch refactors a bit of the evaluator and adds a proper di

[PATCH] D73189: [AST] Fix certain consteval assignment and comma operator issues with fixed-point types.

ebevhan created this revision. ebevhan added reviewers: rjmccall, leonardchan, bjope. Herald added a project: clang. Herald added a subscriber: cfe-commits. Assignment and comma operators for fixed-point types were being constevaled as other binary operators, but they need special treatment. Re

[PATCH] D72144: Treat C# `using` as a control statement

jbcoe marked 2 inline comments as done. jbcoe added inline comments. Comment at: clang/unittests/Format/FormatTestCSharp.cpp:259 + + verifyFormat("using (StreamWriter sw = new StreamWriter(filenameB)) {}", + Style); krasimir wrote: > Can this appea

[PATCH] D72144: Treat C# `using` as a control statement

jbcoe updated this revision to Diff 239574. jbcoe added a comment. Handle `using` case where SpaceBeforeParensOptions is set to SBPO_NonEmptyParentheses CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72144/new/ https://reviews.llvm.org/D72144 Files: clang/lib/Format/TokenAnnotator.cp

[PATCH] D73098: [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions

aaron.ballman added a comment. In D73098#1832489 , @njames93 wrote: > In D73098#1832131 , @Mordante wrote: > > > Would it make sense to also allow wmain with wchar_t? > > https://docs.microsoft.com/en-us/cpp/cpp/ma

[clang] 968561b - Unconditionally enable lvalue function designators; NFC

Author: Aaron Ballman Date: 2020-01-22T09:54:34-05:00 New Revision: 968561bcdc34c7d74482fe3bb69a045abf08d2c1 URL: https://github.com/llvm/llvm-project/commit/968561bcdc34c7d74482fe3bb69a045abf08d2c1 DIFF: https://github.com/llvm/llvm-project/commit/968561bcdc34c7d74482fe3bb69a045abf08d2c1.diff

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

hokein added inline comments. Comment at: clang-tools-extra/clangd/index/Ref.h:32 + // + // class Foo {}; + // ^ Foo declaration could you confirm with it? this looks like a `Foo` class definition. Comment at: clang-tools-extra/clangd

[PATCH] D73199: [clangd] Errors in TestTU cause test failures unless suppressed with error-ok.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. The historic behavior of TestTU is to gather diagnostics and otherwise ignore them. So if a test has a

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille updated this revision to Diff 239598. serge-sans-paille added a comment. - extra test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72829/new/ https://reviews.llvm.org/D72829 Files: clang/include/clang/Basic/LangOptions.d

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille added a comment. > I tried modifying `GlobalValue::maybeSetDsoLocal`: `setDSOLocal(true)` for > ExternalLinkage. Unfortunately that will break 1337 tests. If not so many > tests need fixing, I wish we can place `getParent() && > getParent()->getSemanticInterposition()` logic i

[PATCH] D73199: [clangd] Errors in TestTU cause test failures unless suppressed with error-ok.

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `git-clang-format HEAD^` or applying this pat

[PATCH] D50360: [Concepts] Requires Expressions

thakis added a comment. I figured out the incremental build test problem, see D73202 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50360/new/ https://reviews.llvm.org/D50360 ___

[PATCH] D73202: Make AST reading work better with LLVM_APPEND_VC_REV=NO

thakis marked an inline comment as done. thakis added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3645 // CityHash, but this will do for now. hash_code code = hash_value(getClangFullRepositoryVersion()); Arguably, we should omit

[PATCH] D73202: Make AST reading work better with LLVM_APPEND_VC_REV=NO

thakis created this revision. thakis added reviewers: saar.raz, rsmith. thakis marked an inline comment as done. thakis added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3645 // CityHash, but this will do for now. hash_code code = hash_value(getCl

[PATCH] D73203: [clang-tidy] Prevent a remove only fixit causing a conflict when enclosed by another fixit

njames93 created this revision. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73203 Files: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp Index: clang-tools-extra/clang-tidy/ClangT

[PATCH] D72578: [compiler-rt] [builtins] Fix clear_cache_test to work with MPROTECT

This revision was automatically updated to reflect the committed changes. Closed by commit rG3215f7c7a81f: [compiler-rt] [builtins] Fix clear_cache_test to work with MPROTECT (authored by mgorny). Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. Repository: rG LLVM Git

[PATCH] D67537: [clangd] Client-side support for inactive regions

hokein added a comment. sorry for the looong delay, I was OOO for a few weeks before. The patch looks fine, my concern is that how do we support this `line` extension when LSP provides a standard implementation -- there is some significant progress about semantic highlighting on VSCode, VSCode

[PATCH] D73203: [clang-tidy] Prevent a remove only fixit causing a conflict when enclosed by another fixit

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62056 tests passed, 0 failed and 783 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73098: [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions

njames93 marked an inline comment as done. njames93 added a comment. In D73098#1833736 , @aaron.ballman wrote: > In D73098#1832489 , @njames93 wrote: > > > In D73098#1832131

[PATCH] D72996: [Sema] Attempt to perform call-size-specific `__attribute__((alloc_align(param_idx)))` validation

jdoerfert added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:4489 +// Alignment calculations can wrap around if it's greater than 2**29. +unsigned MaximumAlignment = 536870912; +if (I > MaximumAlignment) hfinkel wrote: > jd

[PATCH] D68520: [cmake] Fix clang builds with BUILD_SHARED=ON and CLANG_LINK_CLANG_DYLIB=ON

beanz accepted this revision. beanz added a comment. Seems reasonable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68520/new/ https://reviews.llvm.org/D68520 ___ cfe-commits mailing list cfe-commits@

[PATCH] D72144: Treat C# `using` as a control statement

krasimir accepted this revision. krasimir added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Format/FormatTestCSharp.cpp:259 + + verifyFormat("using (StreamWriter sw = new StreamWriter(filenameB)) {}", + Style);

[PATCH] D72829: Implement -fsemantic-interposition

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62107 tests passed, 0 failed and 808 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72114: [MS] Overhaul how clang passes overaligned args on x86_32

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72114/new/ https://reviews.llvm.org/D72114 ___

[PATCH] D72934: [ARM,MVE] Support immediate vbicq,vorrq,vmvnq intrinsics.

simon_tatham updated this revision to Diff 239609. simon_tatham marked an inline comment as done. simon_tatham edited the summary of this revision. simon_tatham added a comment. I've revised the MC representations of VBIC and VORR as suggested, but that was a big enough patch that I've done it se

  1   2   3   >