This revision was automatically updated to reflect the committed changes. Closed by commit rG4481eefbe842: [ASTImporter] Properly delete decls from SavedImportPaths (authored by jarin, committed by teemperor).
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73166/new/ https://reviews.llvm.org/D73166 Files: clang/lib/AST/ASTImporter.cpp Index: clang/lib/AST/ASTImporter.cpp =================================================================== --- clang/lib/AST/ASTImporter.cpp +++ clang/lib/AST/ASTImporter.cpp @@ -8253,7 +8253,7 @@ // FIXME Should we remove these Decls from the LookupTable, // and from ImportedFromDecls? } - SavedImportPaths[FromD].clear(); + SavedImportPaths.erase(FromD); // Do not return ToDOrErr, error was taken out of it. return make_error<ImportError>(ErrOut); @@ -8286,7 +8286,7 @@ Imported(FromD, ToD); updateFlags(FromD, ToD); - SavedImportPaths[FromD].clear(); + SavedImportPaths.erase(FromD); return ToDOrErr; }
Index: clang/lib/AST/ASTImporter.cpp =================================================================== --- clang/lib/AST/ASTImporter.cpp +++ clang/lib/AST/ASTImporter.cpp @@ -8253,7 +8253,7 @@ // FIXME Should we remove these Decls from the LookupTable, // and from ImportedFromDecls? } - SavedImportPaths[FromD].clear(); + SavedImportPaths.erase(FromD); // Do not return ToDOrErr, error was taken out of it. return make_error<ImportError>(ErrOut); @@ -8286,7 +8286,7 @@ Imported(FromD, ToD); updateFlags(FromD, ToD); - SavedImportPaths[FromD].clear(); + SavedImportPaths.erase(FromD); return ToDOrErr; }
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits