hokein added inline comments.
================ Comment at: clang-tools-extra/clangd/index/Ref.h:34 + Spelled = 1 << 3, + All = Declaration | Definition | Reference | Spelled, }; ---------------- kadircet wrote: > hokein wrote: > > The `All` now indicates all spelled refs. I think `All` should include both > > non-spelled and spell refs, which should be `declaration | Definition | > > Reference`. > I don't follow the argument here ,`All` is rather a bitmask that should be > `OR`d with a `RefKindSet`. > It is not like we were saying only the references that are both declarations > and definitions were acceptable before, we were saying All implies either a > declaration, definition or a reference in here. So the logic seems to be > correct. ah, you are right, I misthought about that, thanks for the clarification. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72746/new/ https://reviews.llvm.org/D72746 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
