[PATCH] D72874: [clangd] Add a textual fallback for go-to-definition

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:203 + if (!Symbols) { +elog("Workspace symbols failed", Symbols.takeError()); + } (There should be a return here, will fix locally.) Repo

[PATCH] D72722: [FPEnv] [SystemZ] Platform-specific builtin constrained FP enablement

uweigand accepted this revision. uweigand added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72722/new/ https://reviews.llvm.org/D72722 ___ cfe-commits mailing list

[clang] a688301 - [Clang] Un-break scan-build after integrated-cc1 change

Author: Alexandre Ganea Date: 2020-01-21T11:58:24-05:00 New Revision: a6883017ea9af529e89d7f89af2477378b6eafca URL: https://github.com/llvm/llvm-project/commit/a6883017ea9af529e89d7f89af2477378b6eafca DIFF: https://github.com/llvm/llvm-project/commit/a6883017ea9af529e89d7f89af2477378b6eafca.dif

[PATCH] D72982: [Clang] Un-break scan-build after integrated-cc1 change

This revision was automatically updated to reflect the committed changes. Closed by commit rGa6883017ea9a: [Clang] Un-break scan-build after integrated-cc1 change (authored by aganea). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72982/new/ https:/

[PATCH] D73097: [AArch64][SVE] Add intrinsics for FFR manipulation

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM I think it's fairly likely that we'll eventually decide that the correct model of the FFR register doesn't require these intrinsics at all. They're just register copies, which is no

[PATCH] D73060: [Clang] Fix expansion of response files in -Wp after integrated-cc1 change

hans added inline comments. Comment at: clang/tools/driver/driver.cpp:338 + static unsigned ReenteranceCount; + if (ReenteranceCount++) +llvm::cl::ResetAllOptionOccurrences(); This looks pretty hacky. Can you explain more what the current problem is and ho

[PATCH] D72982: [Clang] Un-break scan-build after integrated-cc1 change

hans added a comment. Wait, do we really want the "(in-process)" marker to be written to a separate line? I'm not sure that we do. The change description doesn't explain how scan-build was broken or how this fixes it. And, maybe most importantly, it seems scan-build doesn't have any tests that

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

smeenai added a subscriber: plotfi. smeenai added a comment. CC @plotfi for the InterfaceStubs failures Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69825/new/ https://reviews.llvm.org/D69825 ___ cfe-

[PATCH] D73108: [docs][mips] 10.0 Release notes

hans added a comment. Thanks for writing release notes! Go ahead and push directly to the release/10.x branch when you're ready. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73108/new/ https://reviews.llvm.org/D73108 __

[PATCH] D72982: [Clang] Un-break scan-build after integrated-cc1 change

xazax.hun added a comment. In D72982#1831595 , @hans wrote: > Wait, do we really want the "(in-process)" marker to be written to a separate > line? I'm not sure that we do. Since the `-###` command had this property of emitting copy pastable `-cc1` inv

[PATCH] D73060: [Clang] Fix expansion of response files in -Wp after integrated-cc1 change

aganea marked an inline comment as done. aganea added inline comments. Comment at: clang/tools/driver/driver.cpp:338 + static unsigned ReenteranceCount; + if (ReenteranceCount++) +llvm::cl::ResetAllOptionOccurrences(); hans wrote: > This looks pretty hacky.

[PATCH] D72903: [HIP] use GetProgramPath for executable discovery

This revision was automatically updated to reflect the committed changes. Closed by commit rG24d7a0935bea: [HIP] use GetProgramPath for executable discovery (authored by DieGoldeneEnte, committed by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[clang] 2e667d0 - [FPEnv][SystemZ] Platform-specific builtin constrained FP enablement

Author: Kevin P. Neal Date: 2020-01-21T12:44:39-05:00 New Revision: 2e667d07c773f684ea893b9ce5d9b73e9f23b438 URL: https://github.com/llvm/llvm-project/commit/2e667d07c773f684ea893b9ce5d9b73e9f23b438 DIFF: https://github.com/llvm/llvm-project/commit/2e667d07c773f684ea893b9ce5d9b73e9f23b438.diff

[PATCH] D72722: [FPEnv] [SystemZ] Platform-specific builtin constrained FP enablement

This revision was automatically updated to reflect the committed changes. Closed by commit rG2e667d07c773: [FPEnv][SystemZ] Platform-specific builtin constrained FP enablement (authored by kpn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72722/new

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

plotfi added a comment. In D69825#1831611 , @smeenai wrote: > CC @plotfi for the InterfaceStubs failures Thanks In D69825#1831611 , @smeenai wrote: > CC @plotfi for the InterfaceStubs failures @smeenai thanks

[PATCH] D72982: [Clang] Un-break scan-build after integrated-cc1 change

aganea added a comment. In D72982#1831595 , @hans wrote: > Wait, do we really want the "(in-process)" marker to be written to a separate > line? I'm not sure that we do. Do you see value in keeping "(in-process)" at all? I added it in the first place f

[PATCH] D72793: [clang-format] Expand the SpacesAroundConditions option to include catch statements

hans added a comment. In D72793#1828870 , @MyDeveloperDay wrote: > In D72793#1828625 , @timwoj wrote: > > > I know that 10.0 was branch recently. Any chance this can make it over? > > > I don't personally ever do t

[PATCH] D72635: Allow arbitrary capability name in Thread Safety Analysis

eti-p-doray updated this revision to Diff 239362. eti-p-doray added a comment. Added test with custom capability name. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72635/new/ https://reviews.llvm.org/D72635 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/Diagnos

[PATCH] D72903: [HIP] use GetProgramPath for executable discovery

tra added a subscriber: hans. tra added a comment. I've landed the change. As for backporting, I'll leave it up to AMD folks. If @yaxunl and the team deem it appropriate, they should talk to @hans about cherry-picking the change into particular releases. Repository: rG LLVM Github Monorepo

[PATCH] D72903: [HIP] use GetProgramPath for executable discovery

hans added a comment. In D72903#1831716 , @tra wrote: > I've landed the change. As for backporting, I'll leave it up to AMD folks. If > @yaxunl and the team deem it appropriate, they should talk to @hans about > cherry-picking the change into particular

[PATCH] D72848: Remove some SVN-specific code.

hans added inline comments. Comment at: clang/lib/Basic/Version.cpp:33 #else - StringRef URL(""); + return ""; #endif Eugene.Zelenko wrote: > hans wrote: > > Eugene.Zelenko wrote: > > > return {} should be better. > > Why? I think "" is clearer for a string.

[PATCH] D71714: [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item

ilya marked 2 inline comments as done. ilya added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:13384 case Stmt::MemberExprClass: { expr = cast(expr)->getBase(); break; ebevhan wrote: > ilya wrote: > > rsmith wrote: > > > i

[PATCH] D73104: [Attr][Doc][NFC] Fix code snippet formatting for attribute documentation

Fznamznon accepted this revision. Fznamznon added a comment. This revision is now accepted and ready to land. Thank you for this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73104/new/ https://reviews.llvm.org/D73104 __

[clang] 372cb38 - [Codegen] Emit both AssumeAlignedAttr and AllocAlignAttr assumptions if they exist

Author: Roman Lebedev Date: 2020-01-21T21:18:27+03:00 New Revision: 372cb38f4510212f4bd21488b71620775d8d4fc2 URL: https://github.com/llvm/llvm-project/commit/372cb38f4510212f4bd21488b71620775d8d4fc2 DIFF: https://github.com/llvm/llvm-project/commit/372cb38f4510212f4bd21488b71620775d8d4fc2.diff

[PATCH] D72635: Allow arbitrary capability name in Thread Safety Analysis

eti-p-doray added a comment. Thanks! I don't I have commit access. Can you commit on my behalf? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72635/new/ https://reviews.llvm.org/D72635 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 6b2f820 - [NFC][Codegen] Use MaybeAlign + APInt::getLimitedValue() when creating Alignment attr

Author: Roman Lebedev Date: 2020-01-21T21:18:29+03:00 New Revision: 6b2f820221c78c05527d6edb756b4f1f44665968 URL: https://github.com/llvm/llvm-project/commit/6b2f820221c78c05527d6edb756b4f1f44665968 DIFF: https://github.com/llvm/llvm-project/commit/6b2f820221c78c05527d6edb756b4f1f44665968.diff

[PATCH] D73123: [CMake] Fixes for including LLVM into another CMake project

russell.gallop created this revision. russell.gallop added reviewers: chandlerc, dcoughlin, jroelofs, mgorny, pcc, tstellar, beanz, dsanders. Herald added subscribers: cfe-commits, Charusso. Herald added projects: clang, LLVM. This fixes a couple of paths to allow add_subdirectory(llvm) from a hi

[PATCH] D73090: [clang-tidy] Fix PR#44528 'modernize-use-using and enums'

njames93 added a comment. If you are using diff to create a patch, use `-U99` to get the full context of the patch Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-use-using.cpp:274 +// CHECK-FIXES: using EnumT = enum { ea, eb }; \ No newline at end of fil

[PATCH] D72982: [Clang] Un-break scan-build after integrated-cc1 change

hans added a comment. In D72982#1831648 , @xazax.hun wrote: > In D72982#1831595 , @hans wrote: > > > Wait, do we really want the "(in-process)" marker to be written to a > > separate line? I'm not sure that we do.

[PATCH] D72979: [Codegen] Emit both AssumeAlignedAttr and AllocAlignAttr assumptions if they exist

This revision was automatically updated to reflect the committed changes. Closed by commit rG372cb38f4510: [Codegen] Emit both AssumeAlignedAttr and AllocAlignAttr assumptions if they… (authored by lebedev.ri). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D72993: [NFC][Codegen] Use MaybeAlign + APInt::getLimitedValue() when creating Alignment attr

This revision was automatically updated to reflect the committed changes. Closed by commit rG6b2f820221c7: [NFC][Codegen] Use MaybeAlign + APInt::getLimitedValue() when creating… (authored by lebedev.ri). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D73124: [clangd] Add C++20 concepts support to FindTarget and semantic highlighting

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Fixes https://github.com/clangd/clangd/issues/259 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73124 Files:

[PATCH] D73060: [Clang] Fix expansion of response files in -Wp after integrated-cc1 change

hans added inline comments. Comment at: clang/tools/driver/driver.cpp:338 + static unsigned ReenteranceCount; + if (ReenteranceCount++) +llvm::cl::ResetAllOptionOccurrences(); aganea wrote: > hans wrote: > > This looks pretty hacky. > > > > Can you explain

[PATCH] D72903: [HIP] use GetProgramPath for executable discovery

DieGoldeneEnte added a comment. Thanks @tra! @hans: I would leave the decision to cherry-pick this into the 10 release to you. I think the change is nice to have, but once you know the problem, there exists an easy workaround (like symlinking the executables to the right directory). Reposito

[PATCH] D31337: Use virtual functions in ParsedAttrInfo instead of function pointers

john.brawn marked 4 inline comments as done. john.brawn added inline comments. Comment at: clang/lib/Sema/ParsedAttr.cpp:143 + // otherwise return a default ParsedAttrInfo. + const ParsedAttrInfo *Info = AttrInfoMap[A.getKind()]; + if (Info) erichkeane wrote:

[PATCH] D73104: [Attr][Doc][NFC] Fix code snippet formatting for attribute documentation

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73104/new/ https://reviews.llvm.org/D73104 ___ cfe-commits mailing list cfe-comm

[clang] dd18729 - [Attr][Doc][NFC] Fix code snippet formatting for attribute documentation

Author: Alexey Bader Date: 2020-01-21T18:30:56+03:00 New Revision: dd18729b2a7a23b76b8d74fbf4f4bb4efbe8aa97 URL: https://github.com/llvm/llvm-project/commit/dd18729b2a7a23b76b8d74fbf4f4bb4efbe8aa97 DIFF: https://github.com/llvm/llvm-project/commit/dd18729b2a7a23b76b8d74fbf4f4bb4efbe8aa97.diff

[PATCH] D31337: Use virtual functions in ParsedAttrInfo instead of function pointers

erichkeane added inline comments. Comment at: clang/utils/TableGen/ClangAttrEmitter.cpp:3400 -static std::string GenerateAppertainsTo(const Record &Attr, raw_ostream &OS) { +static void GenerateAppertainsTo(const Record &Attr, raw_ostream &SS, +

[PATCH] D72982: [Clang] Un-break scan-build after integrated-cc1 change

xazax.hun added a comment. In D72982#1831817 , @hans wrote: > In D72982#1831648 , @xazax.hun wrote: > > > In D72982#1831595 , @hans wrote: > > > > > Wait, do we really want t

[PATCH] D73072: [Driver][CodeGen] Support -fpatchable-function-entry=N,M where M>0

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. LGTM, thanks for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73072/new/ https://reviews.llvm.org/D73072 __

[PATCH] D73124: [clangd] Add C++20 concepts support to findExplicitReferences() and semantic highlighting

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62059 tests passed, 0 failed and 784 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73104: [Attr][Doc][NFC] Fix code snippet formatting for attribute documentation

This revision was automatically updated to reflect the committed changes. Closed by commit rGdd18729b2a7a: [Attr][Doc][NFC] Fix code snippet formatting for attribute documentation (authored by bader). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D731

Re: [clang] add2b7e - List implicit operator== after implicit destructors in a vtable.

Hello Richard, This commit broke test on the builder: http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/builds/3169 . . . Failing Tests (1): Clang :: CodeGenCXX/virtual-compare.cpp Please have a look ASAP? Thanks Galina On Sun, Jan 19, 2020 at 6:32 PM Richard Smith via cfe-commits

[clang] f63d763 - [TableGen] Use a table to lookup MVE intrinsic names

Author: Reid Kleckner Date: 2020-01-21T11:05:45-08:00 New Revision: f63d7637387995765e9ece0e10fe1b5a4f0612b5 URL: https://github.com/llvm/llvm-project/commit/f63d7637387995765e9ece0e10fe1b5a4f0612b5 DIFF: https://github.com/llvm/llvm-project/commit/f63d7637387995765e9ece0e10fe1b5a4f0612b5.diff

[PATCH] D72984: [TableGen] Use a table to lookup MVE intrinsic names

This revision was automatically updated to reflect the committed changes. Closed by commit rGf63d76373879: [TableGen] Use a table to lookup MVE intrinsic names (authored by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72984/new/ https://revie

[PATCH] D72874: [clangd] Add a textual fallback for go-to-definition

sammccall added a comment. I've tried this out locally and it's fun! As suspected on the bug though, IMO it's far from accurate enough. Examples from clangd/Compiler.cpp: - it triggers on almost every word, even words that plainly don't refer to any decl like `format [[lazily]], in case vlog is

[PATCH] D72982: [Clang] Un-break scan-build after integrated-cc1 change

hans added a comment. > Due to some unfortunate historical reasons fixing scan-build means fixing 3 > separate code bases. We have the original scan-build written in perl, a > python rewrite both checked-in in the LLVM repository, and on github. And the > two versions are not the same as the au

[PATCH] D72982: [Clang] Un-break scan-build after integrated-cc1 change

xazax.hun added a comment. In D72982#1831976 , @hans wrote: > Sigh, what a mess. I totally agree and sorry for that :( >> In case it is printed on a separate line the current parsing happens to work >> in all versions of scan-build and this seemed to b

[PATCH] D72959: Relative VTables ABI on Fuchsia

pcc added a subscriber: peter.smith. pcc added a comment. > On Aarch64, right now only CALL26 and JUMP26 instructions generate PLT > relocations, so we manifest them with stubs that are just jumps to the > original function. I think it would be worth considering defining a new relocation type f

[PATCH] D73128: [OPENMP][NVPTX]Add NVPTX specific definitions for new/delete operators.

ABataev created this revision. ABataev added a reviewer: hfinkel. Herald added subscribers: guansong, mgorny. Herald added a reviewer: jdoerfert. Herald added a project: clang. ABataev added a comment. A note: this header file requires to include stdlib.h too to see the declarations of malloc/fre

[PATCH] D72982: [Clang] Un-break scan-build after integrated-cc1 change

aganea added a comment. In D72982#1832000 , @xazax.hun wrote: > Thanks! Alternatively we could try to push the changes to all three versions > and revert this patch once all of them are accepted and a new pip package is > published. @xazax.hun In that

[PATCH] D73128: [OPENMP][NVPTX]Add NVPTX specific definitions for new/delete operators.

ABataev added a comment. A note: this header file requires to include stdlib.h too to see the declarations of malloc/free. Shall We include it here to fix it? otherwise the error is reported that malloc and free are declared. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D72982: [Clang] Un-break scan-build after integrated-cc1 change

xazax.hun added a comment. In D72982#1832029 , @aganea wrote: > In D72982#1832000 , @xazax.hun wrote: > > > Thanks! Alternatively we could try to push the changes to all three > > versions and revert this patch onc

[PATCH] D73007: [Sema] Avoid Wrange-loop-analysis false positives

Mordante added a comment. In D73007#1829709 , @xbolva00 wrote: > Yes, but minimal fix is better for release branch, so @hans should merge it. > > Handling your case probably needs more work and patches.. Agreed. Repository: rG LLVM Github Monorepo C

[PATCH] D73128: [OPENMP][NVPTX]Add NVPTX specific definitions for new/delete operators.

jdoerfert added a comment. In D73128#1832033 , @ABataev wrote: > A note: this header file requires to include stdlib.h too to see the > declarations of malloc/free. Shall We include it here to fix it? otherwise > the error is reported that malloc and fre

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15442-15443 + CurComponents.emplace_back(CurE, nullptr); +} else if (auto *CurE = dyn_cast(E)) { + E = CurE->getLHS()->IgnoreParenImpCasts(); } else {

[PATCH] D72903: [HIP] use GetProgramPath for executable discovery

yaxunl added a comment. Sorry for the delay. I have no objection to cherrypick this change to release 10. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72903/new/ https://reviews.llvm.org/D72903 _

[PATCH] D73128: [OPENMP][NVPTX]Add NVPTX specific definitions for new/delete operators.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. Some minor comments but other than that, LGTM. Nit: Clang format the file Comment at: clang/lib/Headers/openmp_wrappers/new:8 + *===---

[PATCH] D73007: [Sema] Avoid Wrange-loop-analysis false positives

Mordante added a comment. In D73007#1829597 , @aaron.ballman wrote: > LGTM! Do you think this should also be pushed onto the release branch? Thanks for the review. Yes the bug has been marked as a release blocker. Repository: rG LLVM Github Monorepo

[PATCH] D69933: [ASTImporter] Limit imports of structs

teemperor added a comment. I really don't think the ASTImporter should ever manipulate records in the source context (effectively the source context should be considered immutable). It also seems *very* wrong that what we import depends in any way on a previous expression so I agree we should f

[PATCH] D73128: [OPENMP][NVPTX]Add NVPTX specific definitions for new/delete operators.

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62080 tests passed, 1 failed and 784 were skipped. failed: Clang.Driver/cc-print-options.c {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artif

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc marked an inline comment as done. mibintc added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:2537 +if (!Actions.CurContext->isTranslationUnit()) { +//FIXME this seems to be the wrong way to check file-scope +//since the token immediately following a fu

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15442-15443 + CurComponents.emplace_back(CurE, nullptr); +} else if (auto *CurE = dyn_cast(E)) { + E = CurE->getLHS()->IgnoreParenImpCasts(); } else { cchen wrote: > cchen

[PATCH] D73007: [Sema] Avoid Wrange-loop-analysis false positives

Mordante marked 2 inline comments as done. Mordante added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:2703-2704 // suggest the const reference type that would do so. // For instance, given "for (const &Foo : Range)", suggest // "for (const Foo : Range)" to denote

[PATCH] D73062: [analyzer] Simplify BoolAssignmentChecker

mikhail.ramalho updated this revision to Diff 239397. mikhail.ramalho added a comment. Update the condition to flag an issue. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73062/new/ https://reviews.llvm.org/D73062 Files: clang/lib/StaticAnalyzer/Checkers/BoolAssignmentChecker.cpp I

[PATCH] D73128: [OPENMP][NVPTX]Add NVPTX specific definitions for new/delete operators.

ABataev added a comment. In D73128#1832061 , @jdoerfert wrote: > Some minor comments but other than that, LGTM. > > Nit: Clang format the file It is a formatted file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D73128: [OPENMP][NVPTX]Add NVPTX specific definitions for new/delete operators.

ABataev updated this revision to Diff 239399. ABataev added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73128/new/ https://reviews.llvm.org/D73128 Files: clang/lib/Headers/CMakeLists.txt clang/lib/Headers/openmp_w

[PATCH] D72829: Implement -fsemantic-interposition

MaskRay added inline comments. Comment at: llvm/lib/IR/Globals.cpp:101 +return true; + return isInterposableLinkage(getLinkage()); +} MaskRay wrote: > MaskRay wrote: > > Checking `isInterposableLinkage(getLinkage())` first may be more efficient. > `if (!isIn

[PATCH] D72982: [Clang] Un-break scan-build after integrated-cc1 change

NoQ added a comment. In D72982#1832058 , @xazax.hun wrote: > In D72982#1832029 , @aganea wrote: > > > In D72982#1832000 , @xazax.hun > > wrote: > > > > > Thanks! Alternative

[PATCH] D73007: [Sema] Avoid Wrange-loop-analysis false positives

This revision was automatically updated to reflect the committed changes. Mordante marked an inline comment as done. Closed by commit rG41fcd17250fa: [Sema] Avoid Wrange-loop-analysis false positives (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D73072: [Driver][CodeGen] Support -fpatchable-function-entry=N,M where M>0

MaskRay updated this revision to Diff 239400. MaskRay added a comment. Improve tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73072/new/ https://reviews.llvm.org/D73072 Files: clang/include/clang/Basic/AttrDocs.td clang/include/clang/Basi

[clang] 41fcd17 - [Sema] Avoid Wrange-loop-analysis false positives

Author: Mark de Wever Date: 2020-01-21T21:14:10+01:00 New Revision: 41fcd17250fa0526e4b7fd2c7df7721b0f79b683 URL: https://github.com/llvm/llvm-project/commit/41fcd17250fa0526e4b7fd2c7df7721b0f79b683 DIFF: https://github.com/llvm/llvm-project/commit/41fcd17250fa0526e4b7fd2c7df7721b0f79b683.diff

[PATCH] D72996: [Sema] Attempt to perform call-size-specific `__attribute__((alloc_align(param_idx)))` validation

jdoerfert added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:4489 +// Alignment calculations can wrap around if it's greater than 2**29. +unsigned MaximumAlignment = 536870912; +if (I > MaximumAlignment) erichkeane wrote: >

[PATCH] D73128: [OPENMP][NVPTX]Add NVPTX specific definitions for new/delete operators.

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62080 tests passed, 1 failed and 784 were skipped. failed: Clang.Driver/cc-print-options.c {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artif

[clang-tools-extra] 020ed67 - [clang-tidy] Fix check for Abseil internal namespace access

Author: Eric Fiselier Date: 2020-01-21T15:21:53-05:00 New Revision: 020ed6713d889a95f8c98d7725c87b458d99f6b3 URL: https://github.com/llvm/llvm-project/commit/020ed6713d889a95f8c98d7725c87b458d99f6b3 DIFF: https://github.com/llvm/llvm-project/commit/020ed6713d889a95f8c98d7725c87b458d99f6b3.diff

[PATCH] D73098: [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions

Mordante added a comment. Would it make sense to also allow wmain with wchar_t? https://docs.microsoft.com/en-us/cpp/cpp/main-function-command-line-args?view=vs-2019 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73098/new/ https://reviews.llvm.org

[PATCH] D73007: [Sema] Avoid Wrange-loop-analysis false positives

aaronpuchert added a comment. I also still think that `warn_for_range_copy` //should be// emitted even in templates. These aren't false positives in my opinion, especially since we're now pretty conservative about that warning. Comment at: clang/lib/Sema/SemaStmt.cpp:2703-27

[PATCH] D72484: [clang-tidy] Fix check for Abseil internal namespace access

EricWF closed this revision. EricWF added a comment. Committed in 020ed6713d889a95f8c98d7725c87b458d99f6b3 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72484/new/ https://reviews.llvm.org/D72484

[PATCH] D71907: [WPD/VFE] Always emit vcall_visibility metadata for -fwhole-program-vtables

tejohnson marked an inline comment as done. tejohnson added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:676 + bool ShouldEmitWPDInfo = CGM.getCodeGenOpts().WholeProgramVTables && + CGM.HasHiddenLTOVisibility(RD); llvm::Value *Vir

[PATCH] D72874: [clangd] Add a textual fallback for go-to-definition

nridge planned changes to this revision. nridge added a comment. Thanks for taking a look! In D72874#1831977 , @sammccall wrote: > - it triggers on almost every word, even words that plainly don't refer to > any decl like `format [[lazily]], in case vlog

[PATCH] D71907: [WPD/VFE] Always emit vcall_visibility metadata for -fwhole-program-vtables

tejohnson updated this revision to Diff 239406. tejohnson added a comment. Remove stale change that didn't belong here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71907/new/ https://reviews.llvm.org/D71907 Files: clang/lib/CodeGen/CGVTables.c

[PATCH] D73072: [Driver][CodeGen] Support -fpatchable-function-entry=N,M where M>0

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62081 tests passed, 2 failed and 784 were skipped. failed: Clang.Driver/cc-print-options.c failed: Clang.Driver/fpatchable-function-entry.c {icon question-circle color=gray} clang-tidy: unknown. {icon times-c

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc updated this revision to Diff 239409. mibintc added a comment. Respond to review from @sepavloff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72841/new/ https://reviews.llvm.org/D72841 Files: clang/docs/LanguageExtensions.rst clang/in

[clang] 5260bc2 - Allow arbitrary capability name in Thread Safety Analysis

Author: Etienne Pierre-Doray Date: 2020-01-21T15:43:17-05:00 New Revision: 5260bc2497bb593ed4a01de5cfe84ed6f7b529b1 URL: https://github.com/llvm/llvm-project/commit/5260bc2497bb593ed4a01de5cfe84ed6f7b529b1 DIFF: https://github.com/llvm/llvm-project/commit/5260bc2497bb593ed4a01de5cfe84ed6f7b529b

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15442-15443 + CurComponents.emplace_back(CurE, nullptr); +} else if (auto *CurE = dyn_cast(E)) { + E = CurE->getLHS()->IgnoreParenImpCasts(); } else {

[PATCH] D72635: Allow arbitrary capability name in Thread Safety Analysis

aaron.ballman closed this revision. aaron.ballman added a comment. In D72635#1831782 , @eti-p-doray wrote: > Thanks! > I don't I have commit access. Can you commit on my behalf? Happy to do so! I've commit on your behalf in 5260bc2497bb593ed4a01de5cfe8

[PATCH] D72982: [Clang] Un-break scan-build after integrated-cc1 change

phosek added a comment. We're seeing `Driver/cc-print-options.c` test failures after this change: TEST 'Clang :: Driver/cc-print-options.c' FAILED Script: -- : 'RUN: at line 1'; env CC_PRINT_OPTIONS=1 CC_PRINT_OPTIONS_FILE=/b/s/w/ir/k/rec

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc marked 5 inline comments as done. mibintc added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:13129 if (FunctionDecl *F = dyn_cast(CurContext)) { + // If the expression occurs inside an internal global_var_init_function + // then the FunctionDecl

[PATCH] D71911: [ThinLTO] Summarize vcall_visibility metadata

tejohnson updated this revision to Diff 239412. tejohnson added a comment. Address comment and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71911/new/ https://reviews.llvm.org/D71911 Files: clang/test/CodeGenCXX/vcall-visibility-metadata

[PATCH] D72897: List implicit operator== after implicit destructors in a vtable.

vvereschaka added a comment. Hi Richard, http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l builder has been broken by this patch during few days (failed "Clang::virtual-compare.cpp" test). Sorry, but I'm going to revert these changes. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D72982: [Clang] Un-break scan-build after integrated-cc1 change

aganea added a comment. In D72982#1832209 , @phosek wrote: > We're seeing `Driver/cc-print-options.c` test failures after this change: Yes, seeing it too, I will commit a fix in a minute! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15442-15443 + CurComponents.emplace_back(CurE, nullptr); +} else if (auto *CurE = dyn_cast(E)) { + E = CurE->getLHS()->IgnoreParenImpCasts(); } else { cchen wrote: > ABata

[clang] a8c2f76 - Removing an accidentally duplicated line of test code to fix bots.

Author: Aaron Ballman Date: 2020-01-21T16:03:22-05:00 New Revision: a8c2f76cd258ea03f82a1fc12953ca8af6b7832b URL: https://github.com/llvm/llvm-project/commit/a8c2f76cd258ea03f82a1fc12953ca8af6b7832b DIFF: https://github.com/llvm/llvm-project/commit/a8c2f76cd258ea03f82a1fc12953ca8af6b7832b.diff

[clang] b0b2b7e - Revert "[Clang] Un-break scan-build after integrated-cc1 change"

Author: Alexandre Ganea Date: 2020-01-21T16:06:36-05:00 New Revision: b0b2b7e09926cdde4d82978a7c14b5e2d38db35c URL: https://github.com/llvm/llvm-project/commit/b0b2b7e09926cdde4d82978a7c14b5e2d38db35c DIFF: https://github.com/llvm/llvm-project/commit/b0b2b7e09926cdde4d82978a7c14b5e2d38db35c.dif

[clang] 89e43f0 - Revert "List implicit operator== after implicit destructors in a vtable."

Author: Vladimir Vereschaka Date: 2020-01-21T13:07:56-08:00 New Revision: 89e43f04ba87a0da6e94863db149669c7536486b URL: https://github.com/llvm/llvm-project/commit/89e43f04ba87a0da6e94863db149669c7536486b DIFF: https://github.com/llvm/llvm-project/commit/89e43f04ba87a0da6e94863db149669c7536486b

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15442-15443 + CurComponents.emplace_back(CurE, nullptr); +} else if (auto *CurE = dyn_cast(E)) { + E = CurE->getLHS()->IgnoreParenImpCasts(); } else {

[PATCH] D72552: [Concepts] Constraint Satisfaction Caching

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Mechanically, this looks fine. There's an ongoing discussion in the committee as to whether this kind of caching is permissible. But if this is necessary for acceptable performance, let's tak

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15442-15443 + CurComponents.emplace_back(CurE, nullptr); +} else if (auto *CurE = dyn_cast(E)) { + E = CurE->getLHS()->IgnoreParenImpCasts(); } else {

[PATCH] D73060: [Clang] Fix expansion of response files in -Wp after integrated-cc1 change

aganea abandoned this revision. aganea added a comment. Abandoning this in favor of D73120 . Please take a look at the other patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73060/new/ https://reviews.llvm.org/

[PATCH] D72996: [Sema] Attempt to perform call-size-specific `__attribute__((alloc_align(param_idx)))` validation

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:4489 +// Alignment calculations can wrap around if it's greater than 2**29. +unsigned MaximumAlignment = 536870912; +if (I > MaximumAlignment) jdoerfert wrote: >

<    1   2   3   >