rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land.
Mechanically, this looks fine. There's an ongoing discussion in the committee as to whether this kind of caching is permissible. But if this is necessary for acceptable performance, let's take this for now and figure out how to invalidate the cache as necessary later. Perhaps a `-f` flag to turn this off would be useful, so we can demonstrate and measure the performance delta. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72552/new/ https://reviews.llvm.org/D72552 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits