hans added a comment.

Wait, do we really want the "(in-process)" marker to be written to a separate 
line? I'm not sure that we do.

The change description doesn't explain how scan-build was broken or how this 
fixes it.

And, maybe most importantly, it seems scan-build doesn't have any tests that 
catches this? Should it have one?

In D72982#1831138 <https://reviews.llvm.org/D72982#1831138>, @xazax.hun wrote:

> Do you have commit access or need someone to commit on your behalf? Also, in 
> case your change made it into the clang 10 release branch this will need to 
> be cherry picked there as well.


I've put it on my clang 10 todo list, but I'm also not sure this is the right 
fix, see above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72982/new/

https://reviews.llvm.org/D72982



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to