[PATCH] D71920: [AST] Refactor propagation of dependency bits. NFC

ilya-biryukov added a comment. Herald added a subscriber: rnkovacs. @rsmith, could you please take a look and let me know whether you think adding a new type for this makes sense? On one hand, I feel it's good to have a type to represent "dependencies" and it allow to write helper functions and

[PATCH] D71920: [AST] Refactor propagation of dependency bits. NFC

ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments. Comment at: clang-tools-extra/clang-tidy/hicpp/ExceptionBaseclassCheck.cpp:17 +using namespace clang::ast_matchers; + NOTE: We need this to fix compiler errors down below. Ther

[PATCH] D71920: [AST] Refactor propagation of dependency bits. NFC

ilya-biryukov added a comment. Also note that this change does not move any code around to make sure this change is easy to review and validate that the code is doing the same thing. I'm also planning to move all the code that computes dependencies into one place (it's currently scattered around

[PATCH] D71920: [AST] Refactor propagation of dependency bits. NFC

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61128 tests passed, 0 failed and 728 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `gi

[PATCH] D71911: [ThinLTO] Summarize vcall_visibility metadata

evgeny777 added inline comments. Comment at: llvm/include/llvm/IR/ModuleSummaryIndex.h:794 + } + GlobalObject::VCallVisibility vCallVisibility() const { +return (GlobalObject::VCallVisibility)VarFlags.VCallVisibility; getVCallVisibility() ? Repository:

[PATCH] D71907: [WPD/VFE] Always emit vcall_visibility metadata for -fwhole-program-vtables

evgeny777 added a comment. Looks good at first sight. Do you have linker patch for me to try this out? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71907/new/ https://reviews.llvm.org/D71907 ___ cfe-c

[PATCH] D71907: [WPD/VFE] Always emit vcall_visibility metadata for -fwhole-program-vtables

tejohnson added a comment. In D71907#1797218 , @evgeny777 wrote: > Looks good at first sight. Do you have linker patch for me to try this out? The linker changes are in D71913 . This one should be a noop by itself (other

[clang-tools-extra] f072233 - Allow newlines in AST Matchers in clang-query files

Author: Stephen Kelly Date: 2019-12-27T15:25:57Z New Revision: f0722333dd167245eb3c2b4263529a1ce3679b5c URL: https://github.com/llvm/llvm-project/commit/f0722333dd167245eb3c2b4263529a1ce3679b5c DIFF: https://github.com/llvm/llvm-project/commit/f0722333dd167245eb3c2b4263529a1ce3679b5c.diff LOG:

[PATCH] D71725: [OpenCL] Fix inconsistency between opencl and c11 atomic fetch max/min

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71725/new/ https://reviews.llvm.org/D71725 ___ cfe-commits mailing lis

[PATCH] D71460: [OpenCL] Fix support for cl_khr_mipmap_image_writes

Anastasia added inline comments. Comment at: clang/lib/Headers/opencl-c.h:14686 +#if defined(cl_khr_mipmap_image_writes) +#pragma OPENCL EXTENSION cl_khr_mipmap_image_writes : begin void __ovld write_imagef(write_only image1d_t image, int coord, int lod, float4 color);

[PATCH] D71939: clang-format: fix conflict between FormatStyle::BWACS_MultiLine and BeforeCatch/BeforeElse

pastey created this revision. pastey added a reviewer: MyDeveloperDay. Herald added a project: clang. Herald added a subscriber: cfe-commits. Hi, Found a bug introduced with BraceWrappingFlags AfterControlStatement MultiLine. This feature conflicts with the existing BeforeCatch and BeforeElse fl

[clang] 134ef0f - [OpenCL] Fix inconsistency between opencl and c11 atomic fetch max/min

Author: Yaxun (Sam) Liu Date: 2019-12-27T11:29:04-05:00 New Revision: 134ef0fb4b92718477a1dc9da0118f9b2dd77237 URL: https://github.com/llvm/llvm-project/commit/134ef0fb4b92718477a1dc9da0118f9b2dd77237 DIFF: https://github.com/llvm/llvm-project/commit/134ef0fb4b92718477a1dc9da0118f9b2dd77237.dif

[PATCH] D71725: [OpenCL] Fix inconsistency between opencl and c11 atomic fetch max/min

This revision was automatically updated to reflect the committed changes. Closed by commit rG134ef0fb4b92: [OpenCL] Fix inconsistency between opencl and c11 atomic fetch max/min (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71463: Implement VectorType conditional operator GNU extension.

Anastasia added a comment. It looks good, I was just thinking whether it would be possible to share more common infrastructure. There is `Sema::CheckVectorOperands` that corresponding OpenCL methods are using internally. Do you think it is possible to share the code more? Co

[clang] 752220e - [OpenCL] Fixed printing of __private in AMDGPU test

Author: Anastasia Stulova Date: 2019-12-27T17:08:42Z New Revision: 752220ea2664c814eb1eb046d755fe63ade9c32e URL: https://github.com/llvm/llvm-project/commit/752220ea2664c814eb1eb046d755fe63ade9c32e DIFF: https://github.com/llvm/llvm-project/commit/752220ea2664c814eb1eb046d755fe63ade9c32e.diff

[PATCH] D71463: Implement VectorType conditional operator GNU extension.

erichkeane marked 2 inline comments as done. erichkeane added a comment. In D71463#1797436 , @Anastasia wrote: > It looks good, I was just thinking whether it would be possible to share more > common infrastructure. There is `Sema::CheckVectorOperands` th

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

modocache marked an inline comment as done. modocache added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1227 + MPM.addPass(createModuleToPostOrderCGSCCPassAdaptor(CoroSplitPass())); + MPM.addPass(createModuleToFunctionPassAdaptor(CoroElidePas

[PATCH] D71512: [clang-format] Fix short block when braking after control statement

Bouska updated this revision to Diff 235435. Bouska added a comment. Set line length to column limit + 1 (41) in tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71512/new/ https://reviews.llvm.org/D71512 Files: clang/lib/Format/UnwrappedLineFormatter.cpp clang/unittests/Format/

[clang] 780d306 - [VFS] Don't run symlink test on Windows, it may pass or fail

Author: Reid Kleckner Date: 2019-12-27T10:39:47-08:00 New Revision: 780d30660e965992cf10d390e8ff102e4bf82aa4 URL: https://github.com/llvm/llvm-project/commit/780d30660e965992cf10d390e8ff102e4bf82aa4 DIFF: https://github.com/llvm/llvm-project/commit/780d30660e965992cf10d390e8ff102e4bf82aa4.diff

Re: [clang] ce1f95a - Reland "[clang] Remove the DIFlagArgumentNotModified debug info flag"

On Thu, Dec 26, 2019 at 11:58 PM Djordje Todorovic < djordje.todoro...@rt-rk.com> wrote: > Hi David, > > It's a good question. > > Current approach of the debug entry values will consider an entry value as > a valid value until the variable gets modified. > > Please consider this. > > void fn(int

[clang] d801823 - Revert "CWG2352: Allow qualification conversions during reference binding."

Author: David Blaikie Date: 2019-12-27T12:27:20-08:00 New Revision: d8018233d1ea4234de68d5b4593abd773db79484 URL: https://github.com/llvm/llvm-project/commit/d8018233d1ea4234de68d5b4593abd773db79484 DIFF: https://github.com/llvm/llvm-project/commit/d8018233d1ea4234de68d5b4593abd773db79484.diff

[PATCH] D71939: clang-format: fix conflict between FormatStyle::BWACS_MultiLine and BeforeCatch/BeforeElse

Bouska added a comment. Your code still breaks MultiLine [ RUN ] FormatTest.MultiLineControlStatements /home/pablomg/dev/llvm-project/clang/unittests/Format/FormatTest.cpp:1562: Failure Expected: "try {\n" " foo();\n" "} catch (\n" "Exception &bar)\n" "{\n" " baz();\n" "}

Re: [clang] de21704 - CWG2352: Allow qualification conversions during reference binding.

Sorry if this is expected behavior, but saw a regression that looks /plausibly/ correct & is rendered ambiguous by this change so I've gone ahead and reverted this patch in d8018233d1ea4234de68d5b4593abd773db79484 Comment from the original: Regressed/causes this to error due to ambiguity:

[PATCH] D71026: Fix LLVM_ENABLE_MODULES=ON + BUILD_SHARED_LIBS=ON build

dblaikie added a comment. In D71026#1785025 , @arichardson wrote: > If I build on macOS with `cmake -GNinja -DBUILD_SHARED_LIBS=ON > -DCMAKE_BUILD_TYPE=Debug > -DLLVM_ENABLE_PROJECTS=llvm;clang;lld;compiler-rt;libcxx;libcxxabi > -DBUILD_SHARED_LIBS=ON -

[PATCH] D57662: [clang-tidy] Parallelize clang-tidy-diff.py

derek added a comment. Herald added a subscriber: mgehre. @zinovy.nis @alexfh @JonasToth @MyDeveloperDay Hi folks, please correct me if I'm wrong but it appears that an effect of this change is that this script will no longer exit non-zero if `clang-tidy` discovers any errors, which was the pre

[PATCH] D71948: [OpenMP] Use the OpenMPIRBuilder for `cancel` directives

jdoerfert created this revision. jdoerfert added reviewers: kiranchandramohan, ABataev, RaviNarayanaswamy, gtbercea, grokos, sdmitriev, JonChesterfield, fghanim. Herald added subscribers: guansong, bollu, hiraditya. Herald added a project: LLVM. jdoerfert added a child revision: D70290: [OpenMP] U

[PATCH] D70290: [OpenMP] Use the OpenMPIRBuilder for "omp parallel"

jdoerfert updated this revision to Diff 235449. jdoerfert added a comment. Rebased on D71948 and combined with OpenMPIRBuilder cancel code gen Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70290/new/ https://revie

[PATCH] D70290: [OpenMP] Use the OpenMPIRBuilder for "omp parallel"

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : diff.

[PATCH] D71948: [OpenMP] Use the OpenMPIRBuilder for `cancel` directives

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 61126 tests passed, 1 failed and 728 were skipped. failed: libc++.std/thread/thread_mutex/thread_mutex_requirements/thread_mutex_requirements_mutex/thread_mutex_class/try_lock.pass.cpp {icon times-circle color=

[PATCH] D71939: clang-format: fix conflict between FormatStyle::BWACS_MultiLine and BeforeCatch/BeforeElse

Bouska requested changes to this revision. Bouska added a comment. This revision now requires changes to proceed. So, you are trying to fix the issue at the wrong place. Contrary from what we should expect from a UnwrappedLine, BWACS_Multiline works by always wrapping the brace in UnwrappedLineP

Re: [clang] d801823 - Revert "CWG2352: Allow qualification conversions during reference binding."

On Fri, 27 Dec 2019 at 12:27, David Blaikie via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: David Blaikie > Date: 2019-12-27T12:27:20-08:00 > New Revision: d8018233d1ea4234de68d5b4593abd773db79484 > > URL: > https://github.com/llvm/llvm-project/commit/d8018233d1ea4234de68d5b4593ab

[PATCH] D71659: [clang-format] Added new option to allow setting spaces before and after the operator

Bouska added a comment. Is there a reason why this option adds space before and after the tok::arrow token but not the tok::arrowstar token? That seems inconsistent to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71659/new/ https://reviews.ll

Re: [clang] d801823 - Revert "CWG2352: Allow qualification conversions during reference binding."

On Fri, Dec 27, 2019 at 3:48 PM Richard Smith wrote: > On Fri, 27 Dec 2019 at 12:27, David Blaikie via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> >> Author: David Blaikie >> Date: 2019-12-27T12:27:20-08:00 >> New Revision: d8018233d1ea4234de68d5b4593abd773db79484 >> >> URL: >> https:

[PATCH] D71953: [Tooling] Infer driver mode and target for FixedCompilationDatabase

de1acr0ix created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When creating FixedCompilationDatabase from command line, compiler command is often provided. This commit tries to infer driver mode and target from that so that clang tools does not need to spe

[PATCH] D71953: [Tooling] Infer driver mode and target for FixedCompilationDatabase

de1acr0ix planned changes to this revision. de1acr0ix added a comment. I realized an obvious problem: if the first argument is "-cc" or something compiler option ends with a possible driver mode suffix it would be treated as compiler binary name. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D71174: [clang-tidy] new check: bugprone-signed-char-misuse

ztamas marked an inline comment as done. ztamas added inline comments. Herald added a subscriber: whisperity. Comment at: clang-tools-extra/clang-tidy/bugprone/SignedCharMisuseCheck.cpp:43-44 + + const auto SignedCharType = expr(hasType(qualType( + allOf(isAnyCharacter(),

[PATCH] D71174: [clang-tidy] new check: bugprone-signed-char-misuse

ztamas added a comment. I added the above comments two weeks ago, I just forget to push the submit button. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71174/new/ https://reviews.llvm.org/D71174 ___

[clang-tools-extra] 14e1100 - [clangd] Fix crash in hover

Author: Ilya Biryukov Date: 2019-12-27T09:15:15+01:00 New Revision: 14e11005d1a6ac1fecb230c470e9011d6956b8e4 URL: https://github.com/llvm/llvm-project/commit/14e11005d1a6ac1fecb230c470e9011d6956b8e4 DIFF: https://github.com/llvm/llvm-project/commit/14e11005d1a6ac1fecb230c470e9011d6956b8e4.diff

[clang-tools-extra] e2d9f4e - [clangd] Reformat `HoverTests.cpp` NFC

Author: Ilya Biryukov Date: 2019-12-27T09:35:46+01:00 New Revision: e2d9f4e6a284992388a82df388e36f6491b9ec66 URL: https://github.com/llvm/llvm-project/commit/e2d9f4e6a284992388a82df388e36f6491b9ec66 DIFF: https://github.com/llvm/llvm-project/commit/e2d9f4e6a284992388a82df388e36f6491b9ec66.diff

[PATCH] D71920: [AST] Refactor propagation of dependency bits. NFC

ilya-biryukov created this revision. ilya-biryukov added a reviewer: rsmith. Herald added a reviewer: martong. Herald added a reviewer: shafik. Herald added a project: clang. This changes introduces an enum to represent dependencies as a bitmask and extract common patterns from code that computes