Author: Reid Kleckner Date: 2019-12-27T10:39:47-08:00 New Revision: 780d30660e965992cf10d390e8ff102e4bf82aa4
URL: https://github.com/llvm/llvm-project/commit/780d30660e965992cf10d390e8ff102e4bf82aa4 DIFF: https://github.com/llvm/llvm-project/commit/780d30660e965992cf10d390e8ff102e4bf82aa4.diff LOG: [VFS] Don't run symlink test on Windows, it may pass or fail This test was XFAILed because of symlinks, but some versions of ln -s seem to work on Windows, so the test was unexpectedly passing on our bot: http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/13233 Unexpected Passing Tests (1): Clang :: VFS/subframework-symlink.m I don't know how or why, but it seems dependent on system configuration, and is not something worth debugging. Avoid the problem by marking the test UNSUPPORTED: system-windows instead of XFAIL: system-windows. Added: Modified: clang/test/VFS/subframework-symlink.m Removed: ################################################################################ diff --git a/clang/test/VFS/subframework-symlink.m b/clang/test/VFS/subframework-symlink.m index 77e8572aa457..88946e86d43c 100644 --- a/clang/test/VFS/subframework-symlink.m +++ b/clang/test/VFS/subframework-symlink.m @@ -1,5 +1,5 @@ // FIXME: PR44221 -// XFAIL: system-windows +// UNSUPPORTED: system-windows // Test that when a subframework is a symlink to another framework, we don't // add it as a submodule to the enclosing framework. We also need to make clang _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
