[PATCH] D70693: [scan-build-py] Set of small fixes

xazax.hun added a comment. So after investigating the effects of this patch, the result is the following: Verbose mode (`-v`) that also prints findings to the command line will no longer be colored after the patch. If we do not want this regression there are two easy ways around it: 1. Make th

[PATCH] D70791: Workaround for MSVC 16.3.* pre-c++17 type trait linkage

rnk added a comment. My version of cl.exe claims to have version 19.23.28107 and my headers are in Tools/MSVC/14.23.28105/include, and I see that this is fixed in xtr1common. is_integral_v and the helpers are defined with implicit template instantiations. There are no fully specialized template

[PATCH] D70791: Workaround for MSVC 16.3.* pre-c++17 type trait linkage

erichkeane added a comment. In D70791#1762155 , @rnk wrote: > My version of cl.exe claims to have version 19.23.28107 and my headers are in > Tools/MSVC/14.23.28105/include, and I see that this is fixed in xtr1common. > is_integral_v and the helpers are

[PATCH] D65591: [AST] Add a flag indicating if any subexpression had errors

rsmith added a comment. In D65591#1625744 , @aaron.ballman wrote: > In D65591#1625228 , @ilya-biryukov > wrote: > > > We can also assume they're cheap, use the visitor-based implementation and > > later switch if

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:6524 + if (auto *PVD = dyn_cast(D)) { +if (PVD->getType()->isIntegerType()) { + S.Diag(AL.getLoc(), diag::err_attribute_output_parameter) ---

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

xazax.hun updated this revision to Diff 231307. xazax.hun marked 5 inline comments as done. xazax.hun added a comment. - Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70469/new/ https://reviews.llvm.org/D70469 Files: clang/include/clang/Basic/Attr.td clang/

[PATCH] D70779: AArch64: add support for newer Apple CPUs

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM, but it might be good to wait with committing until next week, so people in the US have a chance to take a look as well. Comment at: clang/lib/Driver/ToolChains/Arch/AArc

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

xazax.hun added inline comments. Comment at: clang/include/clang/Basic/Attr.td:3445 + let Spellings = [Clang<"acquire_handle">]; + let Subjects = SubjectList<[Function, ParmVar], ErrorDiag>; + let Documentation = [AcquireHandleDocs]; aaron.ballman wrote: > xaz

[clang] f584f04 - [ConstExprPreter] Removed the flag forcing the use of the interpreter

Author: Nandor Licker Date: 2019-11-27T20:07:19Z New Revision: f584f04dab69ab15c8942753a145f0c6e7693bcc URL: https://github.com/llvm/llvm-project/commit/f584f04dab69ab15c8942753a145f0c6e7693bcc DIFF: https://github.com/llvm/llvm-project/commit/f584f04dab69ab15c8942753a145f0c6e7693bcc.diff LOG:

[PATCH] D70071: [ConstExprPreter] Removed the flag forcing the use of the interpreter

This revision was automatically updated to reflect the committed changes. Closed by commit rGf584f04dab69: [ConstExprPreter] Removed the flag forcing the use of the interpreter (authored by nand). Changed prior to commit: https://reviews.llvm.org/D70071?vs=230791&id=231310#toc Repository: rG

[PATCH] D70094: [clang-tidy] new altera ID dependent backward branch check

ffrankies updated this revision to Diff 231309. ffrankies added a comment. Implemented changes requested by @Eugene.Zelenko Also changed for loop in `hasIdDepVar` and `hasIdDepField` to range-based for loops, and updated the license information in IdDependentBackwardBranchCheck.cpp CHANGES SIN

[PATCH] D70739: [OPENMP50]Add device/isa context selector support.

jdoerfert added inline comments. Comment at: clang/include/clang/Sema/Sema.h:9320 using OMPCtxSelectorData = - OpenMPCtxSelectorData, ExprResult>; + OpenMPCtxSelectorData, ExprResult>; ABataev wrote: > jdoerfert wrote: > > I would like to avoid the

[PATCH] D70739: [OPENMP50]Add device/isa context selector support.

ABataev marked an inline comment as done. ABataev added inline comments. Comment at: clang/include/clang/Sema/Sema.h:9320 using OMPCtxSelectorData = - OpenMPCtxSelectorData, ExprResult>; + OpenMPCtxSelectorData, ExprResult>; jdoerfert wrote: > ABat

[PATCH] D70764: build: reduce CMake handling for zlib

compnerd added a comment. @labath I think you are misunderstanding the patch. This is not autoselecting the dependencies. It is simply doing that based on an existing option that we have - `LLVM_ENABLE_ZLIB`. We could always search for zlib and override the results with `LLVM_ENABLE_ZLIB` as

[PATCH] D70094: [clang-tidy] new altera ID dependent backward branch check

Eugene.Zelenko added inline comments. Comment at: clang-tidy/altera/IdDependentBackwardBranchCheck.cpp:115 +IdDependentBackwardBranchCheck::hasIdDepField(const Expr *Expression) { + if (const MemberExpr *MemberExpression = dyn_cast(Expression)) { +const FieldDecl *CheckField

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:3445 + let Spellings = [Clang<"acquire_handle">]; + let Subjects = SubjectList<[Function, ParmVar], ErrorDiag>; + let Documentation = [AcquireHandleDocs]; xazax.hun wrote: > xaz

[PATCH] D70253: [AArch64][SVE2] Implement remaining SVE2 floating-point intrinsics

efriedma added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:898 + llvm_i32_ty], +[IntrNoMem]>; + kmclaughlin wrote: > sdesmalen wrote: > > I'd expect the `llvm_i32_ty` to be an immediate for these instruct

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

aaron.ballman accepted this revision. aaron.ballman added a comment. The attribute bits LGTM aside from a wording nit with the diagnostic; I have no opinion on the CodeGen question. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10080 + "template parameter of a

[PATCH] D70739: [OPENMP50]Add device/isa context selector support.

jdoerfert added inline comments. Comment at: clang/include/clang/Sema/Sema.h:9320 using OMPCtxSelectorData = - OpenMPCtxSelectorData, ExprResult>; + OpenMPCtxSelectorData, ExprResult>; ABataev wrote: > jdoerfert wrote: > > ABataev wrote: > > > jdoe

[PATCH] D70739: [OPENMP50]Add device/isa context selector support.

ABataev marked an inline comment as done. ABataev added inline comments. Comment at: clang/include/clang/Sema/Sema.h:9320 using OMPCtxSelectorData = - OpenMPCtxSelectorData, ExprResult>; + OpenMPCtxSelectorData, ExprResult>; jdoerfert wrote: > ABat

[PATCH] D70302: [CodeGen] Fix clang crash on aggregate initialization of array of labels

johannes updated this revision to Diff 231330. johannes edited the summary of this revision. johannes added a comment. update commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70302/new/ https://reviews.llvm.org/D70302 Files: clang/li

[clang] 1ac700c - [CodeGen] Fix clang crash on aggregate initialization of array of labels

Author: Johannes Altmanninger Date: 2019-11-28T00:59:25+01:00 New Revision: 1ac700cdef787383ad49a0e37d9894491ef19480 URL: https://github.com/llvm/llvm-project/commit/1ac700cdef787383ad49a0e37d9894491ef19480 DIFF: https://github.com/llvm/llvm-project/commit/1ac700cdef787383ad49a0e37d9894491ef194

[PATCH] D70302: [CodeGen] Fix clang crash on aggregate initialization of array of labels

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG1ac700cdef78: [CodeGen] Fix clang crash on aggregate initialization of array of labels (authored by johannes). Repository

[PATCH] D70302: [CodeGen] Fix clang crash on aggregate initialization of array of labels

johannes added a comment. Committed as 1ac700cdef787383ad49a0e37d9894491ef19480 - this should be a safe fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70302/new/ https://rev

[PATCH] D70302: [CodeGen] Fix clang crash on aggregate initialization of array of labels

xbolva00 added a comment. I think this was commited too soon. You should receive LGTM from clang maintainer(s). In D70302#1747372 , @nickie wrote: > LGTM, for all that it's worth. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D46234: Mark if a null statement is the result of constexpr folding

rsmith added a comment. In D46234#1762104 , @xazax.hun wrote: > Just a note for anyone willing to pick this up, PR32203 is also related. Further note: the right approach here would likely be to add a `DiscardedStmt` class deriving from `Stmt` that repre

[clang] 789a7aa - Properly disambiguate between array declarators and array subscript expressions.

Author: Richard Smith Date: 2019-11-27T17:54:26-08:00 New Revision: 789a7aa37d0cca70d6e48908ce3e8bb4e761e266 URL: https://github.com/llvm/llvm-project/commit/789a7aa37d0cca70d6e48908ce3e8bb4e761e266 DIFF: https://github.com/llvm/llvm-project/commit/789a7aa37d0cca70d6e48908ce3e8bb4e761e266.diff

[PATCH] D70411: [analyzer] CERT: StrChecker: 31.c

Charusso updated this revision to Diff 231341. Charusso added a comment. - Do not emit a report on re-binding a not null-terminated string, it may will be properly terminated (test added). - Added a test for the necessity of `SValVisitor` in this checker. - Some refactor. CHANGES SINCE LAST ACT

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

JonChesterfield added a comment. I'd very much like this to land soon. It's the prereq for a lot of other patches and the code looks good. It's tricky to test the infra before the users are landed so the unit test is particularly appreciated. Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D70411: [analyzer] CERT: StrChecker: 31.c

Charusso marked 2 inline comments as done. Charusso added a comment. The false positive suppression by going backwards on the bug-path of stored reports was a very simple concept, which turned out to be a useless one. The rough idea was that to invalidate every report in a path, and every other

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

vchuravy marked 4 inline comments as done. vchuravy added a comment. Rebased onto current master and added an initial test. (I will start adding more as I start integrating this with the rest of the toolchain) Comment at: llvm/lib/Object/WasmObjectFile.cpp:998 +if (Tables.

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

vchuravy updated this revision to Diff 231343. vchuravy marked 6 inline comments as done. vchuravy added a comment. - add test for passing anyref through a function - fix wrong name for funcref - fixes and formatting - fix error message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[clang-tools-extra] a7acba2 - Use InitLLVM in clang-tidy

Author: Rui Ueyama Date: 2019-11-28T13:50:35+09:00 New Revision: a7acba29c19ac67c77ed282ec9432602ae21268d URL: https://github.com/llvm/llvm-project/commit/a7acba29c19ac67c77ed282ec9432602ae21268d DIFF: https://github.com/llvm/llvm-project/commit/a7acba29c19ac67c77ed282ec9432602ae21268d.diff LO

[PATCH] D70694: Use InitLLVM in clang-tidy

This revision was automatically updated to reflect the committed changes. Closed by commit rGa7acba29c19a: Use InitLLVM in clang-tidy (authored by ruiu). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D69498: IR: Invert convergent attribute handling

mehdi_amini added a comment. Talked with Matt at the last social, they thought I was strongly opposed to this: I am not, and I told them I would clarify here: I don't buy the argument of "frontend projects have consistently run into problems related to this", I think this is not a good justific

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 updated this revision to Diff 231349. lh123 marked 3 inline comments as done. lh123 added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70769/new/ https://reviews.llvm.org/D70769 Files: llvm/include/llvm/Suppor

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

rogfer01 added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMPKinds.def:165 + +__OMP_RTL(__kmpc_barrier, false, Void, IdentPtr, Int32) +__OMP_RTL(__kmpc_cancel_barrier, false, Int32, IdentPtr, Int32) As we migrate, we will end with a significant nu

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 updated this revision to Diff 231353. lh123 added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70769/new/ https://reviews.llvm.org/D70769 Files: llvm/include/llvm/Support/CommandLine.h llvm/lib/Support/Comma

[PATCH] D70799: [OpenMP] Lower taskyield using OpenMP IR Builder

rogfer01 created this revision. rogfer01 added reviewers: jdoerfert, kiranchandramohan. Herald added subscribers: llvm-commits, cfe-commits, guansong, hiraditya. Herald added projects: clang, LLVM. rogfer01 added a parent revision: D69922: [OpenMP] Use the OpenMP-IR-Builder. This is similar to D69

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

lh123 updated this revision to Diff 231357. lh123 marked 6 inline comments as done. lh123 added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70222/new/ https://reviews.llvm.org/D70222 Files: clang/include/clang/Tool

<    1   2