ABataev marked an inline comment as done. ABataev added inline comments.
================ Comment at: clang/include/clang/Sema/Sema.h:9320 using OMPCtxSelectorData = - OpenMPCtxSelectorData<SmallVector<OMPCtxStringType, 4>, ExprResult>; + OpenMPCtxSelectorData<SmallVector<llvm::Any, 4>, ExprResult>; ---------------- jdoerfert wrote: > ABataev wrote: > > jdoerfert wrote: > > > ABataev wrote: > > > > jdoerfert wrote: > > > > > I would like to avoid the Any type here and I hope we can if we don't > > > > > allow "strings". See also my last comment. > > > > The only possible solution I see here is to convert kind/vendor strings > > > > into exprs and store all data as `Expr *` > > > Should we define a struct to be used as variant here maybe? If we only > > > have <5 different types we might not want to go to Any or Expr directly. > > What is the difference between using Any and a struct? > Any is generic (anything). > Having a variant (std::variant or self build struct with 2 constructors) > specifies what the components can be. > It is not quite so. Anyway, I'm going to switch to Expr* since it is the only possible way to represent traits as identifiers/string literals. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70739/new/ https://reviews.llvm.org/D70739 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
