rogfer01 added inline comments.
================ Comment at: llvm/include/llvm/Frontend/OpenMPKinds.def:165 + +__OMP_RTL(__kmpc_barrier, false, Void, IdentPtr, Int32) +__OMP_RTL(__kmpc_cancel_barrier, false, Int32, IdentPtr, Int32) ---------------- As we migrate, we will end with a significant number of interfaces here. @jdoerfert what do you think about adding a comment with their C prototype before each one like we do in `clang/lib/CodeGen/CGOpenMPRuntime.cpp`? Something like this ```lang=cpp // void __kmpc_barrier(ident_t *loc, kmp_int32 global_tid); __OMP_RTL(__kmpc_barrier, false, Void, IdentPtr, Int32) // kmp_int32 __kmpc_cancel_barrier(ident_t *loc, kmp_int32 // global_tid) __OMP_RTL(__kmpc_cancel_barrier, false, Int32, IdentPtr, Int32) ... ``` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69785/new/ https://reviews.llvm.org/D69785 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
