[PATCH] D70424: clang/AMDGPU: Fix default for frame-pointer attribute

arsenm added a comment. In D70424#1761298 , @arsenm wrote: > In D70424#1758902 , @yaxunl wrote: > > > LGTM. But I am wondering how it affects -g. Do we need to keep frame > > pointer when -g is specified? Should we

[PATCH] D70424: clang/AMDGPU: Fix default for frame-pointer attribute

arsenm added a comment. In D70424#1758902 , @yaxunl wrote: > LGTM. But I am wondering how it affects -g. Do we need to keep frame pointer > when -g is specified? Should we add a test for -O3 -g? It’s independent for every other target. This matches the

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 created this revision. lh123 added a reviewer: kadircet. Herald added subscribers: llvm-commits, cfe-commits, seiya, rupprecht, MaskRay, jakehehrlich, aheejin, hiraditya, arichardson, sbc100, emaste. Herald added a reviewer: espindola. Herald added a reviewer: alexshap. Herald added a review

[clang] e20a1e4 - clang-format-vs : Fix Unicode formatting

Author: Hans Wennborg Date: 2019-11-27T09:58:59+01:00 New Revision: e20a1e486e144c88188bc7b420885d5326b39088 URL: https://github.com/llvm/llvm-project/commit/e20a1e486e144c88188bc7b420885d5326b39088 DIFF: https://github.com/llvm/llvm-project/commit/e20a1e486e144c88188bc7b420885d5326b39088.diff

[PATCH] D70633: clang-format-vs : Fix Unicode formatting

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. >> empty2fill: Do you have an example input that I could use to hit the >> "Specified argument was out of the range of valid values." error? > > F10867463: Main.cpp

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

merge_guards_bot added a comment. Build result: pass - 60330 tests passed, 0 failed and 732 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70633: clang-format-vs : Fix Unicode formatting

This revision was automatically updated to reflect the committed changes. Closed by commit rGe20a1e486e14: clang-format-vs : Fix Unicode formatting (authored by hans). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70633/new/ https://reviews.llvm.org

[PATCH] D70773: [clangd] Handle the missing call expr in targetDecl.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D70773 Files: clang-tools-extra/clangd/Find

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

jhenderson added a comment. Are there any instances where we DON'T want to get the real file system? If not, could the `*llvm::vfs::getRealFileSystem()` call be put inside `cl::ExpandResponseFiles`? Comment at: llvm/include/llvm/Support/CommandLine.h:32 #include "llvm/Suppor

[PATCH] D70746: [clangd] Highlighting dependent types in more contexts

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:259 H.addToken(L.getNameLoc(), HighlightingKind::DependentType); +visitDependentTypesInQualifier(L.getQualifierLoc()); +return true; Instead of calling

[PATCH] D70773: [clangd] Handle the missing call expr in targetDecl.

merge_guards_bot added a comment. Build result: pass - 60325 tests passed, 0 failed and 732 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70740: [clangd] Find reference to template parameter in 'sizeof...' expression

ilya-biryukov added a comment. Thanks! Could you also handle this in `targetDecl` and add the corresponding test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70740/new/ https://reviews.llvm.org/D70740 _

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 added a comment. In D70769#1761394 , @jhenderson wrote: > Are there any instances where we DON'T want to get the real file system? If > not, could the `*llvm::vfs::getRealFileSystem()` call be put inside > `cl::ExpandResponseFiles`? This patch is

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

bader added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60455/new/ https://reviews.llvm.org/D60455 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

russell.gallop added a comment. In D69825#1760400 , @aganea wrote: > In D69825#1760373 , @russell.gallop > wrote: > > > It looks like the git apply didn't work, but the script continued so this > > was a duff expe

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

jhenderson added a comment. In D70769#1761428 , @lh123 wrote: > In D70769#1761394 , @jhenderson > wrote: > > > Are there any instances where we DON'T want to get the real file system? If > > not, could the `*llvm:

[PATCH] D70512: [clangd] Rethink how SelectionTree deals with macros and #includes.

sammccall updated this revision to Diff 231206. sammccall added a comment. Rewrote patch with a better approach (claiming expanded tokens rather than spelled). Added more tests, including one showing a problem with multiple arg expansion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

sammccall added a comment. In D70769#1761494 , @jhenderson wrote: > In D70769#1761428 , @lh123 wrote: > > > In D70769#1761394 , @jhenderson > > wrote: > > > > > Are there an

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

awpandey updated this revision to Diff 231208. awpandey marked 5 inline comments as done. awpandey added a comment. Hi @aprantl and @dblaikie. Currently, there is no test case for the unspecified type, so I have added that in the regression test suite. Also, I have incorporated all of your sugg

[PATCH] D70512: [clangd] Rethink how SelectionTree deals with macros and #includes.

merge_guards_bot added a comment. Build result: pass - 60302 tests passed, 0 failed and 732 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70684: [clangd] Shutdown cleanly on signals.

This revision was automatically updated to reflect the committed changes. Closed by commit rG19ac0eaf07e6: [clangd] Shutdown cleanly on signals. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70684/new/ https://reviews.llvm.o

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

jhenderson added a comment. In D70769#1761517 , @sammccall wrote: > It's not just unit-tests, in D70222 we will > ultimately use FSes other than getRealFilesystem() in clangd. I see, thank you. > Having non-VFS-clean v

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 updated this revision to Diff 231213. lh123 added a comment. Address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70769/new/ https://reviews.llvm.org/D70769 Files: clang/tools/driver/driver.cpp lld/COFF/DriverUtils.cpp lld/ELF/DriverUtils.cpp lld/MinGW/Driver.cp

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 updated this revision to Diff 231215. lh123 added a comment. address comments and delete unused code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70769/new/ https://reviews.llvm.org/D70769 Files: clang/tools/driver/driver.cpp lld/COFF/DriverUtils.cpp lld/ELF/DriverUtils.c

[PATCH] D70539: [clang][CodeGen] Implicit Conversion Sanitizer: handle increment/derement (PR44054)

This revision was automatically updated to reflect the committed changes. Closed by commit rG9872ea4ed1de: [clang][CodeGen] Implicit Conversion Sanitizer: handle increment/decrement… (authored by lebedev.ri). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[clang] 3edf2eb - [Frontend] Clean up some dead code in PrecompiledPreamble. NFC

Author: Sam McCall Date: 2019-11-27T13:44:14+01:00 New Revision: 3edf2eb897e4fe0795253e8e8c1e62b93bac60c9 URL: https://github.com/llvm/llvm-project/commit/3edf2eb897e4fe0795253e8e8c1e62b93bac60c9 DIFF: https://github.com/llvm/llvm-project/commit/3edf2eb897e4fe0795253e8e8c1e62b93bac60c9.diff LO

[clang] a29aa47 - [OpenCL] Move addr space deduction to Sema.

Author: Anastasia Stulova Date: 2019-11-27T12:44:42Z New Revision: a29aa47106205ec95c12e0ebac4260c5de878a6a URL: https://github.com/llvm/llvm-project/commit/a29aa47106205ec95c12e0ebac4260c5de878a6a DIFF: https://github.com/llvm/llvm-project/commit/a29aa47106205ec95c12e0ebac4260c5de878a6a.diff

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

lh123 updated this revision to Diff 231217. lh123 set the repository for this revision to rG LLVM Github Monorepo. lh123 added a comment. rebase to D70769 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70222/new/ ht

[PATCH] D65744: [PR42707][OpenCL] Fix addr space deduction for auto

This revision was automatically updated to reflect the committed changes. Closed by commit rGa29aa4710620: [OpenCL] Move addr space deduction to Sema. (authored by Anastasia). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D65744?vs=227841&id=231218#toc Reposi

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

merge_guards_bot added a comment. Build result: fail - 60341 tests passed, 3 failed and 732 were skipped. failed: Clang.CodeGen/catch-implicit-integer-sign-changes-incdec.c failed: Clang.CodeGen/catch-implicit-signed-integer-truncations-incdec.c failed: libc++.std/thread/futures/futures_asy

[clang] 870f354 - [CodeGen][UBSan] Relax newly-added verbose sanitization tests for inc/dec

Author: Roman Lebedev Date: 2019-11-27T16:05:34+03:00 New Revision: 870f3542d3e0d06d208442bdca6482866b59171b URL: https://github.com/llvm/llvm-project/commit/870f3542d3e0d06d208442bdca6482866b59171b DIFF: https://github.com/llvm/llvm-project/commit/870f3542d3e0d06d208442bdca6482866b59171b.diff

[PATCH] D70779: AArch64: add support for newer Apple CPUs

t.p.northover created this revision. t.p.northover added a reviewer: ab. Herald added subscribers: hiraditya, kristof.beyls, mcrosier. Herald added a project: LLVM. t.p.northover updated this revision to Diff 231220. t.p.northover added a comment. Test updates after switching arm64_32 default CPU

[PATCH] D70779: AArch64: add support for newer Apple CPUs

t.p.northover updated this revision to Diff 231220. t.p.northover added a comment. Test updates after switching arm64_32 default CPU to apple-s4. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70779/new/ https://reviews.llvm.org/D70779 Files: clang/lib/Driver/ToolChains/Arch/AArch64.c

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

merge_guards_bot added a comment. Build result: fail - 60344 tests passed, 2 failed and 732 were skipped. failed: Clang.CodeGen/catch-implicit-integer-sign-changes-incdec.c failed: Clang.CodeGen/catch-implicit-signed-integer-truncations-incdec.c Log files: console-log.txt

[PATCH] D70779: AArch64: add support for newer Apple CPUs

kristof.beyls added a comment. I agree the bare names could cause a lot of confusion, and that the naming scheme proposed in this patch resolves that potential confusion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70779/new/ https://reviews.llvm.org/D70779 ___

[clang] 9f15fcc - [ARM] Replace arm_neon_vqadds with sadd_sat

Author: David Green Date: 2019-11-27T13:32:29Z New Revision: 9f15fcc2718f95f1dac9e6e57aa93d84e9709930 URL: https://github.com/llvm/llvm-project/commit/9f15fcc2718f95f1dac9e6e57aa93d84e9709930 DIFF: https://github.com/llvm/llvm-project/commit/9f15fcc2718f95f1dac9e6e57aa93d84e9709930.diff LOG: [

[PATCH] D69350: [ARM] Replace arm_neon_vqadds with sadd_sat

This revision was automatically updated to reflect the committed changes. Closed by commit rG9f15fcc2718f: [ARM] Replace arm_neon_vqadds with sadd_sat (authored by dmgreen). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 updated this revision to Diff 231234. lh123 added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70769/new/ https://reviews.llvm.org/D70769 Files: llvm/include/llvm/Support/CommandLine.h llvm/lib/Support/Comma

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

lh123 updated this revision to Diff 231235. lh123 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70222/new/ https://reviews.llvm.org/D70222 Files: clang/include/clang/Tooling/CompilationDatabase.h clang/lib/Tooling/CMake

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

merge_guards_bot added a comment. Build result: FAILURE - Log files: console-log.txt , CMakeCache.txt Repository: rG LLV

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

jhenderson added a comment. Aside from one nit, this looks okay to me. I'd like someone else to look at it though too. I'm not at all familiar with the file system stuff to be confident to say everything there is good. Comment at: llvm/lib/Support/CommandLine.cpp:1148 +

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

kadircet added inline comments. Comment at: llvm/include/llvm/Support/CommandLine.h:47 +class FileSystem; +IntrusiveRefCntPtr getRealFileSystem(); + now that we are also pulling the the function, I think it is OK to include the header instead.

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

merge_guards_bot added a comment. Build result: FAILURE - Log files: console-log.txt , CMakeCache.txt Repository: rG LLV

[clang] cbfa237 - Revert "[clang][CodeGen] Implicit Conversion Sanitizer: handle increment/decrement (PR44054)"

Author: Roman Lebedev Date: 2019-11-27T17:05:21+03:00 New Revision: cbfa237892e55b7129a1178c9b03f26683d643af URL: https://github.com/llvm/llvm-project/commit/cbfa237892e55b7129a1178c9b03f26683d643af DIFF: https://github.com/llvm/llvm-project/commit/cbfa237892e55b7129a1178c9b03f26683d643af.diff

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

Alouest added a comment. Greetings, I stumbled upon a bug while toying with your example Bye.cpp. I modified your pass to make a ModulePass and while it works with /build/bin/opt -goodbye -wave-goodbye test.ll It's making clang crash with the command /build/bin/clang test.c I've included

[PATCH] D70539: [clang][CodeGen] Implicit Conversion Sanitizer: handle increment/derement (PR44054)

lebedev.ri updated this revision to Diff 231237. lebedev.ri added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70539/new/ https://reviews.llvm.org/D70539 Files: clang/docs/ReleaseNotes.rst clang/lib/CodeGen/CGExprScalar.cp

[PATCH] D70539: [clang][CodeGen] Implicit Conversion Sanitizer: handle increment/derement (PR44054)

lebedev.ri reopened this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Temporarily reverted in rG62098354ab1c6c0dd2cecc8ac526d411bfe8aa20 - the assertion does not hold, need to remove it likely. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D70780: [WebAssembly] Find wasm-opt with GetProgramPath

sunfish created this revision. sunfish added reviewers: dschuff, ilya-biryukov. Herald added subscribers: cfe-commits, aheejin, jgravelle-google, sbc100. Herald added a project: clang. Instead of just searching for wasm-opt in PATH, use `GetProgramPath`, which checks the `COMPILER_PATH` environme

[PATCH] D70500: [WebAssembly] Enable use of wasm-opt and LTO-enabled system libraries

sunfish added a comment. In D70500#1759831 , @ilya-biryukov wrote: > I'm not an expert in driver code and how it should behave, but being > consistent with how other tools are found definitely looks much better than > special-casing a single tool. > Un

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

ABataev added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2477 + if (LangOpts.SYCLIsDevice && Global->hasAttr()) { +// SYCL kernels can be templated and not called from anywhere in the Need to check if the decl must be emitted at all.

[PATCH] D70739: [OPENMP50]Add device/isa context selector support.

ABataev marked an inline comment as done. ABataev added inline comments. Comment at: clang/test/OpenMP/nvptx_declare_variant_device_isa_codegen.cpp:48 + +#pragma omp declare variant(foo) match(device = {isa("nvptx64")}) +int bar() { return 1; } jdoerfert wrote: >

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 updated this revision to Diff 231242. lh123 marked an inline comment as done. lh123 added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70769/new/ https://reviews.llvm.org/D70769 Files: llvm/include/llvm/Suppor

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 marked 3 inline comments as done. lh123 added inline comments. Comment at: llvm/include/llvm/Support/CommandLine.h:47 +class FileSystem; +IntrusiveRefCntPtr getRealFileSystem(); + kadircet wrote: > now that we are also pulling the the function, I think it i

[PATCH] D69938: [OpenCL] Use __generic addr space when generating internal representation of lambda

Anastasia updated this revision to Diff 231247. Anastasia added a comment. Added `getDefaultCXXMethodAddrSpace` helper to Sema CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69938/new/ https://reviews.llvm.org/D69938 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/Sema.cpp c

[clang] f59614d - [OPENMP50]Add if clause in parallel for simd directive.

Author: Alexey Bataev Date: 2019-11-27T09:56:25-05:00 New Revision: f59614d906b5428f3687a44ee018df5840b301dd URL: https://github.com/llvm/llvm-project/commit/f59614d906b5428f3687a44ee018df5840b301dd DIFF: https://github.com/llvm/llvm-project/commit/f59614d906b5428f3687a44ee018df5840b301dd.diff

[PATCH] D70512: [clangd] Rethink how SelectionTree deals with macros and #includes.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks, the patch looks good! please also update the patch description. Comment at: clang-tools-extra/clangd/Selection.cpp:63 + // Claims whichever expanded tokens in Source

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

merge_guards_bot added a comment. Build result: pass - 60338 tests passed, 0 failed and 732 were skipped. Log files: console-log.txt , CMakeCache.txt

[clang-tools-extra] 939544a - [clangd] Handle the missing call expr in targetDecl.

Author: Haojian Wu Date: 2019-11-27T16:22:20+01:00 New Revision: 939544add98ee6463d6abd6c28fa6c9ac4b6e104 URL: https://github.com/llvm/llvm-project/commit/939544add98ee6463d6abd6c28fa6c9ac4b6e104 DIFF: https://github.com/llvm/llvm-project/commit/939544add98ee6463d6abd6c28fa6c9ac4b6e104.diff LO

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

bader marked an inline comment as done. bader added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2477 + if (LangOpts.SYCLIsDevice && Global->hasAttr()) { +// SYCL kernels can be templated and not called from anywhere in the ABataev wrot

[PATCH] D70773: [clangd] Handle the missing call expr in targetDecl.

This revision was automatically updated to reflect the committed changes. Closed by commit rG939544add98e: [clangd] Handle the missing call expr in targetDecl. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70773/new/ https://re

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

ABataev added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2477 + if (LangOpts.SYCLIsDevice && Global->hasAttr()) { +// SYCL kernels can be templated and not called from anywhere in the bader wrote: > ABataev wrote: > > Need to check if

[PATCH] D70739: [OPENMP50]Add device/isa context selector support.

ABataev updated this revision to Diff 231265. ABataev added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70739/new/ https://reviews.llvm.org/D70739 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basi

[PATCH] D70739: [OPENMP50]Add device/isa context selector support.

ABataev marked 2 inline comments as done. ABataev added inline comments. Comment at: clang/include/clang/Sema/Sema.h:9320 using OMPCtxSelectorData = - OpenMPCtxSelectorData, ExprResult>; + OpenMPCtxSelectorData, ExprResult>; jdoerfert wrote: > I wo

[PATCH] D69221: [clang][darwin] Fix search path logic for C_INCLUDE_DIRS

mhinz updated this revision to Diff 231266. mhinz added a comment. Herald added subscribers: aheejin, jgravelle-google, sbc100, dschuff. Apply fix to all toolchains. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69221/new/ https://reviews.llvm.org/D69221 Files: clang/lib/Driver/ToolC

[PATCH] D69221: [clang][darwin] Fix search path logic for C_INCLUDE_DIRS

mhinz added a comment. I applied the fix to all toolchains now, but I'm unsure how to write a test for it. Neither could I find tests for similar options like `-DDEFAULT_SYSROOT`. My use case: I want to build a clang that has the same search path as the clang shipped with macOS. $ /usr/bin/c

[PATCH] D70787: [Syntax] Build SimpleDeclaration node that groups multiple declarators

ilya-biryukov created this revision. ilya-biryukov added a reviewer: gribozavr2. Herald added a project: clang. Also remove the temporary TopLevelDeclaration node and add UnknownDeclaration to represent other unknown nodes. See the follow-up change for building more top-level declarations. Adding

[PATCH] D70788: [Syntax] A tool to dump syntax tree and token buffer

ilya-biryukov added a comment. Would want to add some tests before landing this. But this is tool is generally useful to experiment with syntax trees, so posting it early (so that it doesn't get lost) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D70788: [Syntax] A tool to dump syntax tree and token buffer

ilya-biryukov created this revision. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. ilya-biryukov added a comment. ilya-biryukov planned changes to this revision. Would want to add some tests before landing this. But this is tool is generally useful to experiment wi

[PATCH] D70787: [Syntax] Build SimpleDeclaration node that groups multiple declarators

ilya-biryukov updated this revision to Diff 231269. ilya-biryukov added a comment. - Remove obsolete FIXME - Fix a typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70787/new/ https://reviews.llvm.org/D70787 Files: clang/include/clang/Tooling/S

[PATCH] D70739: [OPENMP50]Add device/isa context selector support.

merge_guards_bot added a comment. Build result: pass - 60340 tests passed, 0 failed and 732 were skipped. Log files: console-log.txt , CMakeCache.txt

[clang] f4bba07 - [ARM][MVE][Intrinsics] Add MVE VABD intrinsics. Add unit tests.

Author: Mark Murray Date: 2019-11-27T16:52:04Z New Revision: f4bba07b87ce7ad60d908d2fe02abe88d2d48fa4 URL: https://github.com/llvm/llvm-project/commit/f4bba07b87ce7ad60d908d2fe02abe88d2d48fa4 DIFF: https://github.com/llvm/llvm-project/commit/f4bba07b87ce7ad60d908d2fe02abe88d2d48fa4.diff LOG: [

[PATCH] D70765: LTOVisibility.rst: fix up syntax in example

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70765/new/ https://reviews.llvm.org/D70765 ___ cfe-c

[PATCH] D70545: [ARM][MVE][Intrinsics] Add MVE VABD intrinsics.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf4bba07b87ce: [ARM][MVE][Intrinsics] Add MVE VABD intrinsics. Add unit tests. (authored by MarkMurrayARM). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7054

[PATCH] D70546: [ARM][MVE][Intrinsics] Add MVE VMUL intrinsics.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe8a8dbe9c458: [ARM][MVE][Intrinsics] Add MVE VMUL intrinsics. Remove annoying "t1" from VMUL*… (authored by MarkMurrayARM). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D70547: [ARM][MVE][Intrinsics] Add MVE VAND/VORR/VORN/VEOR/VBIC intrinsics.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa048bf87fb65: [ARM][MVE][Intrinsics] Add MVE VAND/VORR/VORN/VEOR/VBIC intrinsics. Add unit… (authored by MarkMurrayARM). Changed prior to commit: https://reviews.llvm.org/D70547?vs=231057&id=231272#toc

[PATCH] D70788: [Syntax] A tool to dump syntax tree and token buffer

merge_guards_bot added a comment. Build result: pass - 60223 tests passed, 0 failed and 732 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70787: [Syntax] Build SimpleDeclaration node that groups multiple declarators

merge_guards_bot added a comment. Build result: pass - 60223 tests passed, 0 failed and 732 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70787: [Syntax] Build SimpleDeclaration node that groups multiple declarators

merge_guards_bot added a comment. Build result: pass - 60223 tests passed, 0 failed and 732 were skipped. Log files: console-log.txt , CMakeCache.txt

[clang] bcd0798 - [LifetimeAnalysis] Fix PR44150

Author: Gabor Horvath Date: 2019-11-27T09:15:14-08:00 New Revision: bcd0798c47ca865f95226859893016a17402441e URL: https://github.com/llvm/llvm-project/commit/bcd0798c47ca865f95226859893016a17402441e DIFF: https://github.com/llvm/llvm-project/commit/bcd0798c47ca865f95226859893016a17402441e.diff

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

bader marked an inline comment as done. bader added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2477 + if (LangOpts.SYCLIsDevice && Global->hasAttr()) { +// SYCL kernels can be templated and not called from anywhere in the ABataev wrot

[PATCH] D70755: [LifetimeAnalysis] Fix PR44150

This revision was automatically updated to reflect the committed changes. Closed by commit rGbcd0798c47ca: [LifetimeAnalysis] Fix PR44150 (authored by xazax.hun). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70755/new/ https://reviews.llvm.org/D707

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

kadircet added inline comments. Comment at: clang/lib/Tooling/ExpandResponseFilesCompilationDatabase.cpp:28 + llvm::IntrusiveRefCntPtr FS) + : Base(std::move(Base)), Tokenizer(Tokenizer), FS(FS) { +assert(this->Base != nullptr); nit: `FS(std::move(F

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

kadircet added inline comments. Comment at: llvm/lib/Support/CommandLine.cpp:1053 + llvm::ErrorOr CurrDir = FS.getCurrentWorkingDirectory(); + if (!CurrDir) +return false; this comment has moved into a irrelevant line and wasn't addressed, so re-stating it

[PATCH] D70605: [OpenCL] Fix address space for implicit conversion (PR43145)

svenvh updated this revision to Diff 231285. svenvh added a comment. Added test for references too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70605/new/ https://reviews.llvm.org/D70605 Files: clang/lib/Sema/SemaExprCXX.cpp clang/test/CodeGenOpenCLCXX/addrspace-derived-base.cl

[PATCH] D70791: Workaround for MSVC 16.3.* pre-c++17 type trait linkage

erichkeane created this revision. erichkeane added reviewers: rnk, rjmccall, majnemer. MSVC's type_trait header for the 16.3.* release in pre-c++17 mode exposes explicitly specialized constexpr variables for _Is_integral, is_void_v, and _Is_floating_point as not-inline (since that isn't available

[PATCH] D46027: [clang-tidy] Fix PR35824

JonasToth accepted this revision. JonasToth added a comment. This revision is now accepted and ready to land. Maybe a short notice in the release notes wouldn't hurt. Otherwise LGTM *EDIT*: Aaron commented as well. Plz let him react before committing :) CHANGES SINCE LAST ACTION https://revie

[PATCH] D70253: [AArch64][SVE2] Implement remaining SVE2 floating-point intrinsics

kmclaughlin added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:898 + llvm_i32_ty], +[IntrNoMem]>; + sdesmalen wrote: > I'd expect the `llvm_i32_ty` to be an immediate for these instructions, > right? If s

[PATCH] D46027: [clang-tidy] Fix PR35824

xazax.hun added a comment. Thanks! Updated context for this patch: A superior fix would be to follow through with the approach suggested by Richard in https://reviews.llvm.org/D46234 . However, since I do not have time to finish that and there are people complaining in the PR, I think it is be

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

probinson added a comment. In D49466#1761156 , @MaskRay wrote: > The ugly path separator pattern `{{(/|)}}` appears in 60+ tests. Can we > teach clang and other tools to > > 1. accept both `/` and `\` input In general they do, AFAIK, although it's n

[PATCH] D70693: [scan-build-py] Set of small fixes

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/tools/scan-build-py/libscanbuild/clang.py:47 cmd.insert(1, '-###') +cmd.append('-fno-color-diagnostics') phosek wrote: > Alternative would be to set `TERM=du

[PATCH] D46027: [clang-tidy] Fix PR35824

alexfh accepted this revision. alexfh added a comment. > This approach will also introduce false negatives. Could you add a test showing this with a FIXME comment? > A better approach would be to check if the null statement is the result of > folding an if constexpr. > The current AST API does

[PATCH] D70791: Workaround for MSVC 16.3.* pre-c++17 type trait linkage

rnk added a subscriber: thakis. rnk added a comment. I thought we agreed to remove the workaround that we had for this and just declare that the old MSVC STL release was buggy and users should update: https://bugs.llvm.org/show_bug.cgi?id=42027 It's a point release that preserves ABI compatibilit

[PATCH] D70791: Workaround for MSVC 16.3.* pre-c++17 type trait linkage

erichkeane added a comment. In D70791#1762081 , @rnk wrote: > I thought we agreed to remove the workaround that we had for this and just > declare that the old MSVC STL release was buggy and users should update: > https://bugs.llvm.org/show_bug.cgi?id=42

[PATCH] D69938: [OpenCL] Use __generic addr space when generating internal representation of lambda

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:892 +if (AS != LangAS::Default) + EPI.TypeQuals.addAddressSpace(getDefaultCXXMethodAddrSpace()); + This should just be `AS`. Could you go ahead and change the other, existing plac

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

ABataev added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2477 + if (LangOpts.SYCLIsDevice && Global->hasAttr()) { +// SYCL kernels can be templated and not called from anywhere in the bader wrote: > ABataev wrote: > > bader wrote: > >

[PATCH] D70605: [OpenCL] Fix address space for implicit conversion (PR43145)

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:4108 + NewToType = Context.getPointerType(NewToType); +} + Hmm, sorry, just noticed this. Could you write this so that it preserves the original kind of pointer of `ToType`? I

[clang-tools-extra] 5c5e860 - [clang-tidy] Fix PR35824

Author: Gabor Horvath Date: 2019-11-27T11:07:16-08:00 New Revision: 5c5e860535d8924a3d6eb950bb8a4945df01e9b7 URL: https://github.com/llvm/llvm-project/commit/5c5e860535d8924a3d6eb950bb8a4945df01e9b7 DIFF: https://github.com/llvm/llvm-project/commit/5c5e860535d8924a3d6eb950bb8a4945df01e9b7.diff

[PATCH] D46234: Mark if a null statement is the result of constexpr folding

xazax.hun added a comment. Herald added subscribers: Charusso, gamesh411, Szelethus. Herald added a project: clang. Just a note for anyone willing to pick this up, PR32203 is also related. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D46234/new/ https://reviews.l

[PATCH] D46027: [clang-tidy] Fix PR35824

This revision was automatically updated to reflect the committed changes. Closed by commit rG5c5e860535d8: [clang-tidy] Fix PR35824 (authored by xazax.hun). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D46027?vs=231078&id=231301#toc Repository: rG LLVM Git

[PATCH] D69746: [analyzer] FixItHint: Apply and test hints with the Clang Tidy's script

alexfh added a comment. In D69746#1756448 , @gribozavr2 wrote: > The only way I know people apply fixits is with the help of IDEs. This depends on the infrastructure available. Talking specifically about clang-tidy in our environment, I know of at least

  1   2   >