lh123 marked 3 inline comments as done. lh123 added inline comments.
================ Comment at: llvm/include/llvm/Support/CommandLine.h:47 +class FileSystem; +IntrusiveRefCntPtr<FileSystem> getRealFileSystem(); + ---------------- kadircet wrote: > now that we are also pulling the the function, I think it is OK to include > the header instead. Yes, we need to include `VirtualFileSystem.h`, `IntrusiveRefCntPtr` needs to know the complete definition of `FileSystem`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70769/new/ https://reviews.llvm.org/D70769 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
