jhenderson added a comment. Aside from one nit, this looks okay to me. I'd like someone else to look at it though too. I'm not at all familiar with the file system stuff to be confident to say everything there is good.
================ Comment at: llvm/lib/Support/CommandLine.cpp:1148 + SmallVector<char, 128> RHSPath; + if (FS.getRealPath(FName, LHSPath) || FS.getRealPath(RFile.File, RHSPath)) { + return false; ---------------- Has this been clang-formatted? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70769/new/ https://reviews.llvm.org/D70769 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits