[PATCH] D69498: IR: Invert convergent attribute handling

mehdi_amini added a comment. In D69498#1725867 , @jdoerfert wrote: > In D69498#1725819 , @mehdi_amini > wrote: > > > Maybe we can start by looking into the motivation for this patch: > > > > > There is a burden on

[PATCH] D68937: [clangd] Add parameter renaming to define-inline code action

kadircet updated this revision to Diff 227035. kadircet added a comment. - Add comments - Early return when generating edits fails Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68937/new/ https://reviews.llvm.org/D68937 Files: clang-tools-extra/

[PATCH] D68074: [clang-tidy] Add readability-make-member-function-const

mgehre added a comment. Friendly Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68074/new/ https://reviews.llvm.org/D68074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D68937: [clangd] Add parameter renaming to define-inline code action

merge_guards_bot added a comment. Build result: pass - 59704 tests passed, 0 failed and 762 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

kristof.beyls added inline comments. Comment at: docs/ReleaseNotes.rst:84 + In a future release of Clang, we intend to change the default to + ``-fno-lax-vector-conversions``. + efriedma wrote: > rsmith wrote: > > efriedma wrote: > > > And if you want to allow

[PATCH] D69608: [clangd] Helper for getting nested namespace qualification

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. Introduce a new helper for getting minimally required qualifiers necessary to spell a name at a point in a given De

[PATCH] D69033: [clangd] Improve symbol qualification in DefineInline code action

kadircet updated this revision to Diff 227040. kadircet added a comment. - Rebase - Move qualification logic into AST.h so that it can be used by define outline, see D69033 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D69577: [clang-format] [PR35518] C++17 deduction guides are wrongly formatted

MyDeveloperDay added a comment. In D69577#1726587 , @lichray wrote: > Should we find a way to set `->`'s type to `TT_TrailingReturnArrow`? that's possible then we might be able to use the existing spaces before rule if (Right.isOneOf(TT_TrailingReturn

[PATCH] D63607: [clang][driver] Add basic --driver-mode=flang support for fortran

peterwaller-arm added a comment. Revoking my previous request: I now have commit access and I intend to submit this shortly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63607/new/ https://reviews.llvm.org/D63607 ___ cfe-commits mailing l

[PATCH] D69318: [analyzer] Add SufficientSizeArrayIndexingChecker

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SufficientSizeArrayIndexingChecker.cpp:75 + // Should not warn on literal index expressions. + if (dyn_cast(Index->IgnoreParenCasts())) +return; Shoudn't we use `isa<>` if we don

[PATCH] D69520: [libc++] Disallow dynamic -> static span conversions

jdoerrie added a comment. Friendly Ping :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69520/new/ https://reviews.llvm.org/D69520 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[clang] 6bf5580 - [clang][driver] Add basic --driver-mode=flang support for fortran

Author: Peter Waller Date: 2019-10-30T10:42:22Z New Revision: 6bf55804924d5a1d902925ad080b1a2b57c5c75c URL: https://github.com/llvm/llvm-project/commit/6bf55804924d5a1d902925ad080b1a2b57c5c75c DIFF: https://github.com/llvm/llvm-project/commit/6bf55804924d5a1d902925ad080b1a2b57c5c75c.diff LOG:

[PATCH] D63607: [clang][driver] Add basic --driver-mode=flang support for fortran

peterwaller-arm closed this revision. peterwaller-arm added a comment. Submitted in 6bf55804924d5a1d902925ad080b1a2b57c5c75c . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63607/new/ https://reviews.llvm.org/D63607

[PATCH] D69378: [AArch64][SVE] Implement masked store intrinsics

kmclaughlin updated this revision to Diff 227061. kmclaughlin added a comment. - Improve CHECK lines used in sve-masked-ldst-nonext.ll & sve-masked-ldst-trunc.ll CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69378/new/ https://reviews.llvm.org/D69378 Files: llvm/lib/Target/AArch64/A

[PATCH] D69577: [clang-format] [PR35518] C++17 deduction guides are wrongly formatted

MyDeveloperDay updated this revision to Diff 227062. MyDeveloperDay added a reviewer: lichray. MyDeveloperDay added a comment. Detect deduction guides arrow as a TrailingReturn arrow, allowing use of existing space before/after rules CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69577/n

[PATCH] D69378: [AArch64][SVE] Implement masked store intrinsics

sdesmalen accepted this revision. sdesmalen added a comment. Nice one! LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69378/new/ https://reviews.llvm.org/D69378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D69567: [AArch64][SVE] Implement additional integer arithmetic intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rGe128c2086489: [AArch64][SVE] Implement additional integer arithmetic intrinsics (authored by kmclaughlin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6956

[PATCH] D69378: [AArch64][SVE] Implement masked store intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rG5c2c94648e42: [AArch64][SVE] Implement masked store intrinsics (authored by kmclaughlin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69378/new/ https://r

[PATCH] D63607: [clang][driver] Add basic --driver-mode=flang support for fortran

teemperor added a comment. Could we have the `clang/test/Driver/flang/flang.F90` and `clang/test/Driver/flang/flang.f90` files in different directories please? As macOS's FS is case-insensitive, those two files have the same path from macOS perspective which is causing a whole bunch of issues (

[PATCH] D69613: [libTooling] Simplify type structure of `Stencil`s.

ymandel created this revision. ymandel added a reviewer: gribozavr. Herald added a project: clang. Currently, stencils are defined as a sequence of `StencilParts`. This differentiation adds an unneeded layer of complexity to the definition of Stencils. This change significantly simplifies the type

[PATCH] D69498: IR: Invert convergent attribute handling

JonChesterfield added a comment. Requiring the presence of an attribute for correctness is a bad thing. OpenMP was missing this annotation in a number of places and is probably still missing it elsewhere. I wouldn't bet on handwritten bitcode libraries getting it right everywhere either. An opt

[PATCH] D63607: [clang][driver] Add basic --driver-mode=flang support for fortran

thakis added a comment. Sorry, I had missed the RfC, but it looks like there wasn't a lot of discussion on it anyways. Adding fortran support to clang's driver has been suggested and decided against before, see "[cfe-commits] [RFC and PATCH] Fortran" In D63607#1726895

[PATCH] D69613: [libTooling] Simplify type structure of `Stencil`s.

ymandel updated this revision to Diff 227072. ymandel added a comment. commented sequence operator Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69613/new/ https://reviews.llvm.org/D69613 Files: clang/include/clang/Tooling/Transformer/Stencil.h

[PATCH] D69573: [clang-format] [PR36294] AlwaysBreakAfterReturnType works incorrectly for some operator functions

sammccall added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2090 continue; + if (Next->isOneOf(tok::star, tok::arrow)) +continue; MyDeveloperDay wrote: > sammccall wrote: > > This seems like it's supposed to be handled b

[PATCH] D69615: [clangd] Implement a function to lex the file to find candidate occurrences.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. This will be used for incoming cross-file rename (to detect index staleness issue). Repository: rG LLVM Github Monorep

[clang] 6c0a160 - Rename a flang test case

Author: Jeremy Morse Date: 2019-10-30T13:29:47Z New Revision: 6c0a160c2d33e54aecf1538bf7c85d8da92051be URL: https://github.com/llvm/llvm-project/commit/6c0a160c2d33e54aecf1538bf7c85d8da92051be DIFF: https://github.com/llvm/llvm-project/commit/6c0a160c2d33e54aecf1538bf7c85d8da92051be.diff LOG:

Re: [PATCH] D63607: [clang][driver] Add basic --driver-mode=flang support for fortran

FYI, in llvmorg-10-init-8612-g6c0a160c2d3 [0] I've renamed one of the two files, Windows too has a case-insensitive filesystem layer and this broke our CI. (I think I've preserved the original intention of the tests). [0] https://github.com/llvm/llvm-project/commit/6c0a160c2d33e54aecf1538bf7c85d8

[PATCH] D69615: [clangd] Implement a function to lex the file to find candidate occurrences.

merge_guards_bot added a comment. Build result: pass - 59741 tests passed, 0 failed and 762 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D63607: [clang][driver] Add basic --driver-mode=flang support for fortran

peterwaller-arm added a comment. In D63607#1726895 , @teemperor wrote: > Could we have the `clang/test/Driver/flang/flang.F90` and > `clang/test/Driver/flang/flang.f90` files in different directories please? As > macOS's FS is case-insensitive, those two

[PATCH] D69573: [clang-format] [PR36294] AlwaysBreakAfterReturnType works incorrectly for some operator functions

MyDeveloperDay updated this revision to Diff 227083. MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added a comment. Extend this revision to cover additional https://bugs.llvm.org/show_bug.cgi?id=43783 issue (which has overlap) New revision correctly formats the following code:

[clang] ba7bde6 - [ASTImporter] Add support for BuiltinTemplateDecl

Author: Raphael Isemann Date: 2019-10-30T14:53:35+01:00 New Revision: ba7bde65dcfff543cefc1de9adcda7f503de URL: https://github.com/llvm/llvm-project/commit/ba7bde65dcfff543cefc1de9adcda7f503de DIFF: https://github.com/llvm/llvm-project/commit/ba7bde65dcfff543cefc1de9adcda7f503de.dif

[PATCH] D69566: [ASTImporter] Add support for BuiltinTemplateDecl

This revision was automatically updated to reflect the committed changes. Closed by commit rGba7bde65dcff: [ASTImporter] Add support for BuiltinTemplateDecl (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69566/new/ https://re

[PATCH] D69573: [clang-format] [PR36294] AlwaysBreakAfterReturnType works incorrectly for some operator functions

sammccall added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:955 CurrentToken->Previous->isOneOf(TT_BinaryOperator, TT_UnaryOperator, -tok::comma)) +tok::comm

[PATCH] D68845: Don't emit unwanted constructor calls in co_return statements

Quuxplusone added inline comments. Comment at: clang/lib/Sema/SemaCoroutine.cpp:896 + if (S.CanPerformCopyInitialization(Entity, &AsRvalue)) +return true; +} else if (auto *FTD = dyn_cast(D)) { aaronpuchert wrote: > Overlad resolution can actuall

[PATCH] D63607: [clang][driver] Add basic --driver-mode=flang support for fortran

teemperor added a comment. 6c0a160c2d33e54aecf1538bf7c85d8da92051be renamed the file (thanks Jeremy). In D63607#1726978 , @peterwaller-arm wrote: > In D63607#1726895

[PATCH] D69602: [analyzer] Test case for lambda capture by value modelling

gamesh411 updated this revision to Diff 227090. gamesh411 added a comment. - Add capture by reference test - Add another class to ensure reachability inside function call is independent from each other in the first 2 test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

hliao marked 3 inline comments as done. hliao added inline comments. Comment at: clang/include/clang/AST/MangleNumberingContext.h:57-58 + + /// Has device mangle numbering context. + virtual bool hasDeviceMangleNumberingContext() const { return false; } + rnk w

[PATCH] D69573: [clang-format] [PR36294] AlwaysBreakAfterReturnType works incorrectly for some operator functions

MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2090 continue; + if (Next->isOneOf(tok::star, tok::arrow)) +continue; sammccall wrote: > MyDeveloperDay wr

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

hliao updated this revision to Diff 227091. hliao added a comment. revise `MSHIPNumberingContext` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69322/new/ https://reviews.llvm.org/D69322 Files: clang/include/clang/AST/DeclCXX.h clang/include/c

[PATCH] D63607: [clang][driver] Add basic --driver-mode=flang support for fortran

peterwaller-arm added a comment. Thanks for chiming in. > Sorry, I had missed the RfC, but it looks like there wasn't a lot of > discussion on it anyways. Apologies @thakis - did I jump the gun? And if so, what could I have done differently? > Adding fortran support to clang's driver has been

[clang] 8aa7441 - [OPENMP][DOC]Update list of supported functions, NFC.

Author: Alexey Bataev Date: 2019-10-30T10:33:04-04:00 New Revision: 8aa74414bfb88e8745d5277cb7172efb67202099 URL: https://github.com/llvm/llvm-project/commit/8aa74414bfb88e8745d5277cb7172efb67202099 DIFF: https://github.com/llvm/llvm-project/commit/8aa74414bfb88e8745d5277cb7172efb67202099.diff

[PATCH] D67706: [clang][analyzer] Using CallDescription in StreamChecker.

balazske updated this revision to Diff 227093. balazske added a comment. - Redesign again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67706/new/ https://reviews.llvm.org/D67706 Files: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp clan

[PATCH] D69237: Refactor getDeclAtPosition() to use SelectionTree + targetDecl()

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG, just some style nits, thanks! Comment at: clang-tools-extra/clangd/XRefs.cpp:226 - // Emit all symbol locations (declaration or definition) from AST. - for (con

[clang] 37c8baf - [OPENMP][DOC]Provide correct info about supported features, NFC.

Author: Alexey Bataev Date: 2019-10-30T10:38:11-04:00 New Revision: 37c8baf821e8cb66a3d49e7b570970b2606983b2 URL: https://github.com/llvm/llvm-project/commit/37c8baf821e8cb66a3d49e7b570970b2606983b2 DIFF: https://github.com/llvm/llvm-project/commit/37c8baf821e8cb66a3d49e7b570970b2606983b2.diff

[PATCH] D68862: [ARM] Allocatable Global Register Variables for ARM

anwel updated this revision to Diff 227094. anwel marked 9 inline comments as done. anwel added a comment. Rebase and make some variables const CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68862/new/ https://reviews.llvm.org/D68862 Files: clang/docs/ClangCommandLineReference.rst c

[PATCH] D69498: IR: Invert convergent attribute handling

jdoerfert added a comment. In D69498#1726610 , @mehdi_amini wrote: > > The short version is the fact that most developers aren't aware of and > > don't understand the subtleties of convergence, and making sure the > > front-end does something in all cont

[PATCH] D68862: [ARM] Allocatable Global Register Variables for ARM

anwel added inline comments. Comment at: clang/lib/Basic/Targets/ARM.cpp:903-907 + for (std::string &Feature : Features) { +if (Feature.compare(SearchFeature) == 0) + return true; + } + return false; chill wrote: > This explicit loop can be written li

[PATCH] D69602: [analyzer] Test case for lambda capture by value modelling

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. LGTM, can we remove the open projects entry under the same breath? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69602/new/ https://review

[PATCH] D67706: [clang][analyzer] Using CallDescription in StreamChecker.

Szelethus added a comment. Its becoming a bit difficult to navigate inlines, could you please mark them as done as you address them? Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:61 + using FnCheck = bool (StreamChecker::*)(const CallEvent &, +

[PATCH] D69602: [analyzer] Test case for lambda capture by value modelling

gamesh411 updated this revision to Diff 227096. gamesh411 added a comment. - Remove link reference from commit message - Remove superfluous semicolons left in the code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69602/new/ https://reviews.llvm.or

[PATCH] D69308: [analyzer] Test cases for the unsupported features for Clang Static Analyzer

Szelethus added a comment. LGTM given that the inlines are fixed. In D69308#1722139 , @NoQ wrote: > Thanks for the tests! > > Both of these features are relatively hard. > > ... Would love to see this comment in its entirety on the open projects page :^

[PATCH] D65912: [clang-tidy] Add new check for math constants

Szelethus resigned from this revision. Szelethus added a comment. I have no authority in clang-tidy, but the idea is nice! You may wanna reupload with full context though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65912/new/ https://reviews.ll

[PATCH] D69298: [clangd] Define out-of-line initial apply logic

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:55 + // Include template parameter list. + if (auto *FTD = FD->getDescribedFunctionTemplate()) +return FTD->getBeginLoc(); hokein wrote: > Could you confi

[PATCH] D69298: [clangd] Define out-of-line initial apply logic

kadircet updated this revision to Diff 227108. kadircet marked 5 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69298/new/ https://reviews.llvm.org/D69298 Files: clang-tools-ex

[PATCH] D69573: [clang-format] [PR36294] AlwaysBreakAfterReturnType works incorrectly for some operator functions

MyDeveloperDay marked 4 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2626 + Left.Previous && Left.Previous->is(tok::kw_operator)) +// No space between the type and the * +// operator void*(), operator

[PATCH] D69573: [clang-format] [PR36294] AlwaysBreakAfterReturnType works incorrectly for some operator functions

MyDeveloperDay updated this revision to Diff 227109. MyDeveloperDay added a comment. Remove test regression CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69573/new/ https://reviews.llvm.org/D69573 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/FormatTest.cpp Ind

[PATCH] D67706: [clang][analyzer] Using CallDescription in StreamChecker.

balazske marked 22 inline comments as done and an inline comment as not done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:90-106 + FnCheck identifyCall(const CallEvent &Call, CheckerContext &C, + const Cal

[clang] 8dcf1c6 - Updating the documentation for the _Noreturn attribute; NFC.

Author: Aaron Ballman Date: 2019-10-30T11:42:18-04:00 New Revision: 8dcf1c654ed4e95a618868d4fab11af2068a1471 URL: https://github.com/llvm/llvm-project/commit/8dcf1c654ed4e95a618868d4fab11af2068a1471 DIFF: https://github.com/llvm/llvm-project/commit/8dcf1c654ed4e95a618868d4fab11af2068a1471.diff

[PATCH] D63607: [clang][driver] Add basic --driver-mode=flang support for fortran

thakis added a comment. > Interesting, I had missed that conversation! Google and DDG fail to find it > for me even quoting sentences out of it. Found it by wgetting the gzip > mailing list archives and grepping them - is there a better way? :) (If you want, I can forward you the thread. But as

[PATCH] D63607: [clang][driver] Add basic --driver-mode=flang support for fortran

thakis added a comment. In D63607#1727037 , @peterwaller-arm wrote: > Thanks for chiming in. > > > Sorry, I had missed the RfC, but it looks like there wasn't a lot of > > discussion on it anyways. > > Apologies @thakis - did I jump the gun? And if so, w

[PATCH] D63607: [clang][driver] Add basic --driver-mode=flang support for fortran

peterwaller-arm added a comment. @thakis: I found the thread at https://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20120430/057199.html @thakis: I can't make quick sense of the failure from those logs alone. I would appreciate it very much to see the output of the `clang -###` run lines t

[PATCH] D69573: [clang-format] [PR36294] AlwaysBreakAfterReturnType works incorrectly for some operator functions

MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:955 CurrentToken->Previous->isOneOf(TT_BinaryOperator, TT_UnaryOperator, -tok::comma))

[PATCH] D69620: Add AIX assembler support

stevewan created this revision. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. This is a follow on patch to D68340 . Given the AIX toolchain skeleton and system linker support introduced in D68340 , thi

[PATCH] D63607: [clang][driver] Add basic --driver-mode=flang support for fortran

thakis added a comment. > @thakis: I can't make quick sense of the failure from those logs alone. I > would appreciate it very much to see the output of the `clang -###` run lines > to see what's missing. It should be showing that it would invoke flang. It's the very first run line that's faili

[PATCH] D69577: [clang-format] [PR35518] C++17 deduction guides are wrongly formatted

klimek added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1400-1403 +} else if (Current.Previous && Current.Previous->is(tok::r_paren) && + Current.startsSequence(tok::arrow, tok::identifier, tok::less)) { + // Deduction guides trailing

[PATCH] D63607: [clang][driver] Add basic --driver-mode=flang support for fortran

peterwaller-arm added a comment. I've thought about it for a moment and I'm currently at a loss to quickly explain why this would only fail on darwin. In my patch, the change to LookupTypeForExtension should prevent clang from reaching this state where it complains about a preprocessed input.

[PATCH] D69577: [clang-format] [PR35518] C++17 deduction guides are wrongly formatted

lichray added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1400 Current.Type = TT_TrailingReturnArrow; +} else if (Current.Previous && Current.Previous->is(tok::r_paren) && + Current.startsSequence(tok::arrow, tok::identifier, tok::les

[PATCH] D69624: [clangd] Fix namespace aliases in findExplicitReferences

ilya-biryukov created this revision. ilya-biryukov added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69624 Files: clang-tools-extra/clangd/FindTarget.cpp

[PATCH] D69625: [libTooling] Support implicit coercions in Stencil's `access` combinator.

ymandel created this revision. ymandel added a reviewer: gribozavr. Herald added a project: clang. ymandel added a parent revision: D69613: [libTooling] Simplify type structure of `Stencil`s.. Changes `clang::transformer::access` to also support `RangeSelector` as the second argument. This chang

[PATCH] D69626: Fix Microsoft compatibility handling of commas in nested macro expansions.

epastor created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. epastor added reviewers: rnk, thakis. In Microsoft-compatibility mode, single commas from nested macro expansions should not be considered as argument separators; we emulate this by marking them t

[PATCH] D68862: [ARM] Allocatable Global Register Variables for ARM

carwil added a comment. Just want to double check with @efriedma, before we except this. I believe this patch now catches all the points you made on https://reviews.llvm.org/D56005. Anything we've missed? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68862/new/ https://reviews.llvm.or

[PATCH] D69577: [clang-format] [PR35518] C++17 deduction guides are wrongly formatted

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added a subscriber: hans. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1400-1403 +} else if (Current.Previous && Current.Previous->is(tok::r_paren) && + Curr

[clang] c75cd3c - [clang][driver][flang] Mark test as unsupported on darwin

Author: Peter Waller Date: 2019-10-30T17:01:59Z New Revision: c75cd3c7f0f924d53f07a9cce60c362751678e0c URL: https://github.com/llvm/llvm-project/commit/c75cd3c7f0f924d53f07a9cce60c362751678e0c DIFF: https://github.com/llvm/llvm-project/commit/c75cd3c7f0f924d53f07a9cce60c362751678e0c.diff LOG:

[PATCH] D69624: [clangd] Fix namespace aliases in findExplicitReferences

merge_guards_bot added a comment. Build result: pass - 59703 tests passed, 0 failed and 762 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D69577: [clang-format] [PR35518] C++17 deduction guides are wrongly formatted

MyDeveloperDay added a comment. Sorry ignore my last results, let me rerun, I was using the revision without the change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69577/new/ https://reviews.llvm.org/D69577 ___ cfe-commits mailing list

[PATCH] D63607: [clang][driver] Add basic --driver-mode=flang support for fortran

peterwaller-arm added a comment. @thakis: I've marked the test unsupported in c75cd3c7f0f . Hopefully that makes your builder happy! I'll figure out what is going on and fix it. CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D69577: [clang-format] [PR35518] C++17 deduction guides are wrongly formatted

lichray added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1400-1403 +} else if (Current.Previous && Current.Previous->is(tok::r_paren) && + Current.startsSequence(tok::arrow, tok::identifier, tok::less)) { + // Deduction guides trailin

[PATCH] D69628: [Clang] Pragma vectorize_width() implies vectorize(enable), take 3

SjoerdMeijer created this revision. SjoerdMeijer added reviewers: Meinersbur, fhahn, rupprecht. This got reverted because given the following source: void a() { #pragma clang loop vectorize(disable) for (;;) ; } it incorrectly enabled vectorisation and set metadata due to a lo

[PATCH] D69356: [NFC] Rename LLVM_NO_DEAD_STRIP

beanz added a comment. In D69356#1726527 , @hubert.reinterpretcast wrote: > For your second question: As the patch author indicated, the change to adjust > the behaviour on the affected platform is forthcoming. Your question seems > predicated upon that

[PATCH] D55793: [clang-tidy] Add duplicated access specifier readability check (PR25403)

aaron.ballman closed this revision. aaron.ballman added a comment. I've commit on your behalf in 29dc0b17de6b04afa6110a040053a19b02ca1a87 , thank you for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[clang-tools-extra] 29dc0b1 - Add the readability-redundant-access-specifiers check.

Author: Aaron Ballman Date: 2019-10-30T13:30:57-04:00 New Revision: 29dc0b17de6b04afa6110a040053a19b02ca1a87 URL: https://github.com/llvm/llvm-project/commit/29dc0b17de6b04afa6110a040053a19b02ca1a87 DIFF: https://github.com/llvm/llvm-project/commit/29dc0b17de6b04afa6110a040053a19b02ca1a87.diff

[PATCH] D69356: [NFC] Rename LLVM_NO_DEAD_STRIP

daltenty added a comment. In D69356#1726527 , @hubert.reinterpretcast wrote: > In D69356#1726354 , @beanz wrote: > > > If what you say is correct that "no dead strip" is harmful to plugins on > > some platforms it

[clang-tools-extra] 1caa66d - Fix a false positive in misc-redundant-expression check

Author: Aaron Ballman Date: 2019-10-30T13:38:25-04:00 New Revision: 1caa66d0759f6bd0851a40645afac8e8a7f84341 URL: https://github.com/llvm/llvm-project/commit/1caa66d0759f6bd0851a40645afac8e8a7f84341 DIFF: https://github.com/llvm/llvm-project/commit/1caa66d0759f6bd0851a40645afac8e8a7f84341.diff

[PATCH] D69498: IR: Invert convergent attribute handling

mehdi_amini added a comment. In D69498#1727080 , @jdoerfert wrote: > Let me quote @arsenm here because this is so important: "Basically no > frontend has gotten this right, including clang and non-clang frontends." For > me, that statement alone is reaso

[PATCH] D55125: [clang-tidy] Fix a false positive in misc-redundant-expression check

aaron.ballman closed this revision. aaron.ballman added a comment. In D55125#1717910 , @dkrupp wrote: > @aaron.ballman could you please check now? Thanks! Sorry for the delay, but I've committed this on your behalf in 1caa66d0759f6bd0851a40645afac8e8a7

[PATCH] D55793: [clang-tidy] Add duplicated access specifier readability check (PR25403)

Eugene.Zelenko added a comment. @aaron.ballman: Please move Release Notes entry to new checks section (in alphabetical order). Currently it's located in //Improvements to include-fixer//. Please also close PR. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[clang-tools-extra] 661d2ce - Fix modernize-use-nodiscard for classes marked [[nodiscard]]

Author: Aaron Ballman Date: 2019-10-30T13:45:37-04:00 New Revision: 661d2ce619e05dc47a9a232333c01dcba445cd13 URL: https://github.com/llvm/llvm-project/commit/661d2ce619e05dc47a9a232333c01dcba445cd13 DIFF: https://github.com/llvm/llvm-project/commit/661d2ce619e05dc47a9a232333c01dcba445cd13.diff

[clang-tools-extra] 0de262d - Move this release note to its appropriate location; NFC.

Author: Aaron Ballman Date: 2019-10-30T13:48:26-04:00 New Revision: 0de262d7189c68897e8328d891d3daaf3aab3156 URL: https://github.com/llvm/llvm-project/commit/0de262d7189c68897e8328d891d3daaf3aab3156 DIFF: https://github.com/llvm/llvm-project/commit/0de262d7189c68897e8328d891d3daaf3aab3156.diff

[PATCH] D69388: [clang-tidy] Fix modernize-use-nodiscard check for classes marked as [[nodiscard]]

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the patch, I've commit on your behalf in 661d2ce619e05dc47a9a232333c01dcba445cd13 Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTI

[PATCH] D55793: [clang-tidy] Add duplicated access specifier readability check (PR25403)

aaron.ballman added a comment. In D55793#1727423 , @Eugene.Zelenko wrote: > @aaron.ballman: Please move Release Notes entry to new checks section (in > alphabetical order). Currently it's located in //Improvements to > include-fixer//. Please also close

[PATCH] D55793: [clang-tidy] Add duplicated access specifier readability check (PR25403)

Eugene.Zelenko added a comment. In D55793#1727437 , @aaron.ballman wrote: > In D55793#1727423 , @Eugene.Zelenko > wrote: > > > @aaron.ballman: Please move Release Notes entry to new checks section (in > > alphabe

Re: [clang-tools-extra] 0de262d - Move this release note to its appropriate location; NFC.

Aren't include-fixer and clang-include-fixer the same thing? Why do we have to entries for it? On Wed, Oct 30, 2019 at 1:48 PM Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Aaron Ballman > Date: 2019-10-30T13:48:26-04:00 > New Revision: 0de262d7189c68897e8328d891d

[PATCH] D69356: [NFC] Rename LLVM_NO_DEAD_STRIP

daltenty added a comment. > I'm actually opposed to that happening, on two fronts. > (2) we already have `LLVM_ENABLE_PLUGINS` why do we also need > `LLVM_SUPPORT_PLUGINS` seems like duplication and bad design. As I understand it LLVM_ENABLE_PLUGINS is a user-facing option which indicates whet

[PATCH] D69498: IR: Invert convergent attribute handling

arsenm added a comment. In D69498#1727419 , @mehdi_amini wrote: > In D69498#1727080 , @jdoerfert wrote: > > > Let me quote @arsenm here because this is so important: "Basically no > > frontend has gotten this right

[PATCH] D69628: [Clang] Pragma vectorize_width() implies vectorize(enable), take 3

Meinersbur requested changes to this revision. Meinersbur added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/CodeGen/CGLoopInfo.cpp:272-277 + if (Attrs.VectorizeWidth > 1 && + Attrs.VectorizeEnable == LoopAttributes::Unspecified) +

[clang-tools-extra] 4de6b15 - Add an option to hicpp-signed-bitwise for positive integer literals.

Author: Vladimir Plyashkun Date: 2019-10-30T14:11:29-04:00 New Revision: 4de6b1586807285e20a5db6596519c2336a64568 URL: https://github.com/llvm/llvm-project/commit/4de6b1586807285e20a5db6596519c2336a64568 DIFF: https://github.com/llvm/llvm-project/commit/4de6b1586807285e20a5db6596519c2336a64568.

[PATCH] D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the patch! I've committed on your behalf in 4de6b1586807285e20a5db6596519c2336a64568 . Repository: rCTE Clang Tools Extra CHANGES SINCE LAST

[PATCH] D63607: [clang][driver] Add basic --driver-mode=flang support for fortran

thakis added a comment. Thanks! Looks like it's just the `-E` test that's causing problems; the test passes with that disabled: $ git diff diff --git a/clang/test/Driver/flang/flang.f90 b/clang/test/Driver/flang/flang.f90 index 97e4847f843..4cbc2cd8754 100644 --- a/clang/test/Driver/fl

[PATCH] D69356: [NFC] Rename LLVM_NO_DEAD_STRIP

beanz added a comment. In D69356#1727451 , @daltenty wrote: > The intention of LLVM_SUPPORT_PLUGINS was as an internal option set by tools > which may have plugins and need to be built in a specific way (such as > avoiding deadstriping) if plugins are en

[clang-tools-extra] e477988 - Fix readability-identifier-naming to prevent variables becoming keywords.

Author: Daniel Date: 2019-10-30T14:18:40-04:00 New Revision: e477988309dbde214a6d16ec690a416882714aac URL: https://github.com/llvm/llvm-project/commit/e477988309dbde214a6d16ec690a416882714aac DIFF: https://github.com/llvm/llvm-project/commit/e477988309dbde214a6d16ec690a416882714aac.diff LOG: F

  1   2   >