[PATCH] D69327: [Clang][ThinLTO] Add a cache for compile phase output.

ychen added a comment. In D69327#1719419 , @steven_wu wrote: > In D69327#1719411 , @ychen wrote: > > > Thanks for the inputs @steven_wu @tejohnson. Totally agree with the points > > you brought up. One last thing I

[PATCH] D69327: [Clang][ThinLTO] Add a cache for compile phase output.

ychen added a comment. Sorry for the confusion @steven_wu. By `stable` I mean the probability that the `-fthin-link-bitcode` option is replaced with some other thinlink mechanism under the distributed build environment. Since at least for ccache, the compilation output caching depends on the se

[PATCH] D67545: [clang-tidy] Added DefaultOperatorNewCheck.

balazske updated this revision to Diff 226206. balazske added a comment. - Improved check for C++17. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67545/new/ https://reviews.llvm.org/D67545 Files: clang-tools-extra/clang-tidy/cert/CERTTidyModule

[clang-tools-extra] bf71e4f - [clangd] Collect name references in the index.

Author: Haojian Wu Date: 2019-10-24T10:25:16+02:00 New Revision: bf71e4fe0a68085d29e9e883da1f17ae73945643 URL: https://github.com/llvm/llvm-project/commit/bf71e4fe0a68085d29e9e883da1f17ae73945643 DIFF: https://github.com/llvm/llvm-project/commit/bf71e4fe0a68085d29e9e883da1f17ae73945643.diff LO

[PATCH] D69338: [clangd] Collect name references in the index.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbf71e4fe0a68: [clangd] Collect name references in the index. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69338/new/ https://reviews.

[PATCH] D69263: [clangd] Implement cross-file rename.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:119 +llvm::Optional +renameableOutsideFile(const NamedDecl &RenameDecl, const SymbolIndex *Index) { hokein wrote: > ilya-biryukov wrote: > > So `llvm::None` means we d

[PATCH] D66647: [clangd] DefineInline action apply logic with fully qualified names

kadircet updated this revision to Diff 226209. kadircet marked 20 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66647/new/ https://reviews.llvm.org/D66647 Files: clang-tools-e

[PATCH] D66647: [clangd] DefineInline action apply logic with fully qualified names

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp:79 + Token CurToken; + while (!CurToken.is(tok::semi)) { +if (RawLexer.LexFromRawLexer(CurToken)) ilya-biryukov wrote: > What are the tokens we expect to s

[clang-tools-extra] 13fc899 - [clangd] Handle the missing constructor initializers in findExplicitReferences.

Author: Haojian Wu Date: 2019-10-24T10:38:37+02:00 New Revision: 13fc899cdecc85c944fc5b516a2bdfdd2f5f5903 URL: https://github.com/llvm/llvm-project/commit/13fc899cdecc85c944fc5b516a2bdfdd2f5f5903 DIFF: https://github.com/llvm/llvm-project/commit/13fc899cdecc85c944fc5b516a2bdfdd2f5f5903.diff LO

[PATCH] D69241: [clangd] Handle the missing constructor initializers in findExplicitReferences.

This revision was automatically updated to reflect the committed changes. Closed by commit rG13fc899cdecc: [clangd] Handle the missing constructor initializers in findExplicitReferences. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D66647: [clangd] DefineInline action apply logic with fully qualified names

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp:79 + Token CurToken; + while (!CurToken.is(tok::semi)) { +if (RawLexer.LexFromRawLexer(CurToken)) kadircet wrote: > ilya-biryukov wrote: > > What are

[PATCH] D69266: [clangd] Define out-of-line availability checks

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:77 +Source = getSelectedFunction(Sel.ASTSelection.commonAncestor()); +if (!Source || !Source->isThisDeclarationADefinition()) + return false; I think

[PATCH] D66647: [clangd] DefineInline action apply logic with fully qualified names

ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp:208 + + if (HadErrors) { +return llvm::createStringError( kadircet wrote: > ilya-biryukov wrote: > > NI

[PATCH] D67750: Allow additional file suffixes/extensions considered as source in main include grouping

furdyna added a comment. Hi, @krasimir @sylvestre.ledru , would you be able to help me with this patch? I am looking for anyone interested in reviewing this :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67750/new/ https://reviews.llvm.org/D67750 __

[PATCH] D66647: [clangd] DefineInline action apply logic with fully qualified names

ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. A few last NITs and one important comment about handling the case when function definition come from macro expansions Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp:323 + +

[PATCH] D69266: [clangd] Define out-of-line availability checks

hokein added inline comments. Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:1556 + +[[void [[Bar::[[b^a^z() [[{ + return; Sorry for not spotting it earlier. Moving out-of-line methods is different than general functions, `void Bar::

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

Typz updated this revision to Diff 226218. Typz marked 2 inline comments as done. Typz added a comment. Fix corner in previous rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50078/new/ https://reviews.llvm.org/D50078 Files: clang/lib/Forma

[PATCH] D69373: [Clang] Fix Sema class build fix

devnexen created this revision. devnexen added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. - DefaultedComparisonKind not being a classic enum, setting as a so small bitfield triggers gcc warning. Repository: rC Clang https://reviews.llvm.org/D69

[clang] 1ae8e8d - Don't add -fsplit-lto-unit for thin LTO builds with PS4 and Darwin toolchains

Author: evgeny Date: 2019-10-24T14:10:03+03:00 New Revision: 1ae8e8d25fd87048d3d8d7429308e52b236c79a1 URL: https://github.com/llvm/llvm-project/commit/1ae8e8d25fd87048d3d8d7429308e52b236c79a1 DIFF: https://github.com/llvm/llvm-project/commit/1ae8e8d25fd87048d3d8d7429308e52b236c79a1.diff LOG: D

[PATCH] D69173: [clang][ThinLTO][Legacy] Don't add -fsplit-lto-unit for legacy thin LTO builds

This revision was automatically updated to reflect the committed changes. Closed by commit rG1ae8e8d25fd8: Don't add -fsplit-lto-unit for thin LTO builds with PS4 and Darwin toolchains (authored by evgeny777). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

lenary added a comment. Ok, found a path forward for this patch. Notes inline: Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:1547 + else if (IsRV64) +MArch = "rv64i"; + else khchen wrote: > lenary wrote: > > I think this line is the issue: where someone

[PATCH] D66647: [clangd] DefineInline action apply logic with fully qualified names

kadircet updated this revision to Diff 226230. kadircet marked 15 inline comments as done. kadircet added a comment. - Improve macro handling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66647/new/ https://reviews.llvm.org/D66647 Files: clang-t

[PATCH] D69378: [AArch64][SVE] Implement masked store intrinsics

kmclaughlin created this revision. kmclaughlin added reviewers: huntergr, greened, dmgreen, rovka. Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a project: LLVM. Adds support for codegen of masked stores, with non-truncating and truncating variants.

[PATCH] D67159: [clang] New __attribute__((__clang_arm_mve_alias)).

simon_tatham updated this revision to Diff 226238. simon_tatham added a comment. (Rebased to current master; no change) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67159/new/ https://reviews.llvm.org/D67159 Files: clang/include/clang/Basic/Att

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50078/new/ https://reviews.llvm.org/D50078 ___ cfe-commits mailing list cfe-com

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

lenary added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:1547 + else if (IsRV64) +MArch = "rv64i"; + else lenary wrote: > khchen wrote: > > lenary wrote: > > > I think this line is the issue: where someone doesn't specify `-march`, > >

[PATCH] D69327: [Clang][ThinLTO] Add a cache for compile phase output.

tejohnson added a comment. We rely on the minimized bitcode from that option in our builds, so it won't be going away. We could add it as a driver option, but it doesn't sound like that will solve the ccache issue. I'm not very familiar with that cache support, or if there is a way to express o

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

Typz updated this revision to Diff 226245. Typz added a comment. Fix earlier error in patch upload. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50078/new/ https://reviews.llvm.org/D50078 Files: clang/lib/Format/ContinuationIndenter.cpp clang

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

Typz updated this revision to Diff 226246. Typz added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50078/new/ https://reviews.llvm.org/D50078 Files: clang/lib/Format/ContinuationIndenter.cpp clang/lib/Format/ContinuationIndenter.

[PATCH] D67750: Allow additional file suffixes/extensions considered as source in main include grouping

MyDeveloperDay requested changes to this revision. MyDeveloperDay marked an inline comment as done. MyDeveloperDay added a comment. This revision now requires changes to proceed. I think fundamentally this seems like a reasonable idea, for those that don't need they don't need to use it. =

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

Typz added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:5739 + " ? ccc\n" + " : ddd;"); verifyFormat("bool aa = a //\n" MyDeveloperDay w

[PATCH] D69382: [clangd] Do not insert parentheses when completing a using declaration

ilya-biryukov created this revision. ilya-biryukov added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. Would be nice to also fix this in clang, but that looks like more work if we want to preserve signatures in informative chu

[clang-tools-extra] ed913a2 - [clangd] Fix case of variables and functions in code complete tests. NFC

Author: Ilya Biryukov Date: 2019-10-24T15:41:50+02:00 New Revision: ed913a291532968c188909e932a94c5cc7b416be URL: https://github.com/llvm/llvm-project/commit/ed913a291532968c188909e932a94c5cc7b416be DIFF: https://github.com/llvm/llvm-project/commit/ed913a291532968c188909e932a94c5cc7b416be.diff

[PATCH] D69382: [clangd] Do not insert parentheses when completing a using declaration

ilya-biryukov updated this revision to Diff 226253. ilya-biryukov added a comment. - Fix name of a constructor parameter Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69382/new/ https://reviews.llvm.org/D69382 Files: clang-tools-extra/clangd/Cod

[PATCH] D69383: [RISCV] Match GCC `-march`/`-mabi` driver defaults

lenary created this revision. lenary added reviewers: asb, luismarques, rogfer01, kito-cheng, khchen. Herald added subscribers: cfe-commits, pzheng, s.egerton, Jim, benna, psnobl, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, edward-jones, zzheng, MaskRay, jrtc27, shiva0217, niosHD, s

[PATCH] D69383: [RISCV] Match GCC `-march`/`-mabi` driver defaults

lenary updated this revision to Diff 226252. lenary added a comment. - Correct code formatting issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69383/new/ https://reviews.llvm.org/D69383 Files: clang/lib/Driver/ToolChains/Arch/RISCV.cpp cla

[PATCH] D69382: [clangd] Do not insert parentheses when completing a using declaration

merge_guards_bot added a comment. Build result: fail - 59611 tests passed, 1 failed and 763 were skipped. failed: libc++.libcxx/thread/thread_threads/thread_thread_this/sleep_for.pass.cpp Log files: cmake-log.txt , ninja_chec

[PATCH] D69382: [clangd] Do not insert parentheses when completing a using declaration

merge_guards_bot added a comment. Build result: fail - 59587 tests passed, 1 failed and 805 were skipped. failed: LLVM.tools/llvm-ar/mri-utf8.test Log files: cmake-log.txt , ninja_check_all-log.txt

[PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

This revision was automatically updated to reflect the committed changes. Closed by commit rG4b63ca1379a8: [Mips] Use appropriate private label prefix based on Mips ABI (authored by mbrkusanin). Changed prior to commit: https://reviews.llvm.org/D66795?vs=224603&id=226112#toc Repository: rG L

[PATCH] D68340: Add AIX toolchain and basic linker functionality

jasonliu accepted this revision. jasonliu added a comment. This revision is now accepted and ready to land. Aside from the nit comment that can be addressed when checkin. LGTM. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:59 + + auto getCrt0Basename = [&IsArch32Bit, &Args]

[PATCH] D68720: Support -fstack-clash-protection for x86

sylvestre.ledru added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:1901 + +Instrument stack allocation to prevent stack clash attacks. + Maybe add that it is Linux only? :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/ne

[PATCH] D69378: [AArch64][SVE] Implement masked store intrinsics

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Looks good to me. (Stores are easier than loads) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69378/new/ https://reviews.llvm.org/D69378 _

[PATCH] D67159: [clang] New __attribute__((__clang_arm_mve_alias)).

This revision was automatically updated to reflect the committed changes. Closed by commit rG7c11da0cfd33: [clang] New __attribute__((__clang_arm_mve_alias)). (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67159/new/ https

[PATCH] D69388: [clang-tidy] Fix modernize-use-nodiscard check for classes marked as [[nodiscard]]

sedykh.eugene created this revision. sedykh.eugene added reviewers: MyDeveloperDay, JonasToth. sedykh.eugene added a project: clang-tools-extra. Herald added subscribers: cfe-commits, mgehre, xazax.hun. Herald added a project: clang. Current implementation suggests to add [[nodiscard]] to methods

[PATCH] D63607: [clang][driver] Add basic --driver-mode=flang support for fortran

peterwaller-arm updated this revision to Diff 226270. peterwaller-arm added a comment. I have rebased the patch for conflicts to master and all the tests are passing. While doing so, I discovered that the test for flang-not-installed was not fit for purpose, because clang actually doesn't first

[PATCH] D63607: [clang][driver] Add basic --driver-mode=flang support for fortran

peterwaller-arm marked 2 inline comments as done. peterwaller-arm added inline comments. Comment at: clang/test/Driver/flang/flang-not-installed.f90:11 +! shell syntax. +! UNSUPPORTED: windows + hfinkel wrote: > I believe that you can write: > > REQUIRES: shel

[PATCH] D69327: [Clang][ThinLTO] Add a cache for compile phase output.

steven_wu added a comment. `ccache` does not have the support for this, I am just saying that this can be easily implemented in `ccache` and that would be much better than the proposed solution here. If we need to add a clang driver flag so build system can better support to detect thin bitcod

[PATCH] D69389: [hip] Relax an allow the declaration of functions with variadic arguments in HIP.

hliao created this revision. hliao added reviewers: jlebar, tra, yaxunl. Herald added a project: clang. Herald added a subscriber: cfe-commits. - As variadic parameters have the lowest rank in overload resolution, without real usage of `va_arg`, they are commonly used as the catch-all fallbacks i

[PATCH] D69391: Add #pragma clang loop ivdep

YashasAndaluri created this revision. YashasAndaluri added reviewers: hfinkel, Meinersbur, rscottmanley, DTharun. YashasAndaluri created this object with edit policy "Administrators". YashasAndaluri added a project: clang. Herald added subscribers: cfe-commits, zzheng. YashasAndaluri edited the sum

[PATCH] D69383: [RISCV] Match GCC `-march`/`-mabi` driver defaults

rogfer01 added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:475 + +if (MArch.startswith_lower("rv32")) { + if (MArch.substr(4).contains_lower("d") || `llvm::StringSwitch` has a method `StartsWithLower` which might help make the

[PATCH] D69382: [clangd] Do not insert parentheses when completing a using declaration

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp:463 + // Check all-scopes completions too. + Opts.AllScopes = true; + Results = completions(R"cpp( I believe `AllScopes` and this feature is orthogonal what ex

[PATCH] D69393: [RFC][DebugInfo] emit user specified address_space in dwarf

yonghong-song created this revision. yonghong-song added reviewers: arsenm, aprantl, Anastasia, ast. yonghong-song added a project: debug-info. Herald added subscribers: cfe-commits, wdng. Herald added a project: clang. The RFC intends to kick off the discussion on how to support user defined addr

[PATCH] D69383: [RISCV] Match GCC `-march`/`-mabi` driver defaults

lenary marked an inline comment as done. lenary added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:475 + +if (MArch.startswith_lower("rv32")) { + if (MArch.substr(4).contains_lower("d") || rogfer01 wrote: > `llvm::StringSwitch`

[PATCH] D67161: [clang,ARM] Initial ACLE intrinsics for MVE.

Yi-Hong.Lyu added a comment. Seems this commit broke the build http://lab.llvm.org:8011/builders/ppc64le-lld-multistage-test/builds/6794/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67161/new/ https://reviews.llvm.org/D67161 _

[PATCH] D69382: [clangd] Do not insert parentheses when completing a using declaration

ilya-biryukov marked 3 inline comments as done. ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp:463 + // Check all-scopes completions too. + Opts.AllScopes = true; + Results = completions(R"cpp( kadirce

[PATCH] D69382: [clangd] Do not insert parentheses when completing a using declaration

ilya-biryukov updated this revision to Diff 226293. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - Use the same CodeCompletionContext Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69382/new/ https://reviews.llvm.or

[PATCH] D69388: [clang-tidy] Fix modernize-use-nodiscard check for classes marked as [[nodiscard]]

MyDeveloperDay added a comment. Thank you for the patch, I wrote this checker originally and this LGTM. I'm not sure if others have any objections to using "using clang::attr::WarnUnusedResult" in the body of the function, I couldn't see this pattern used elsewhere in clang-tidy, all I've seen

[PATCH] D69389: [hip] Allow the declaration of functions with variadic arguments in HIP.

hliao updated this revision to Diff 226301. hliao added a comment. revise commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69389/new/ https://reviews.llvm.org/D69389 Files: clang/lib/CodeGen/TargetInfo.cpp clang/lib/Driver/ToolChai

[PATCH] D68835: [clang-scan-deps] Add basic support for Clang modules.

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. @Bigcheese I don't have time right now to do the build experiments, so I'll leave it as follow-up for me to resolve later. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6883

[PATCH] D69382: [clangd] Do not insert parentheses when completing a using declaration

merge_guards_bot added a comment. Build result: pass - 59630 tests passed, 0 failed and 763 were skipped. Log files: cmake-log.txt , ninja_check_all-log.txt

[PATCH] D69383: [RISCV] Match GCC `-march`/`-mabi` driver defaults

khchen added inline comments. Herald added a subscriber: sameer.abuasal. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:537 + if (Triple.getArch() == llvm::Triple::riscv32) +return "rv32gc"; else Why do you set rv32gc and rv64gc as default march?

[clang] ec66603 - [clang-format] Remove the dependency on frontend

Author: paulhoad Date: 2019-10-24T19:03:57+01:00 New Revision: ec66603ac7ea655be5c2c5f508c5bf0d5eaeb65b URL: https://github.com/llvm/llvm-project/commit/ec66603ac7ea655be5c2c5f508c5bf0d5eaeb65b DIFF: https://github.com/llvm/llvm-project/commit/ec66603ac7ea655be5c2c5f508c5bf0d5eaeb65b.diff LOG:

[PATCH] D68969: [clang-format] Remove the dependency on frontend

This revision was automatically updated to reflect the committed changes. MyDeveloperDay marked an inline comment as done. Closed by commit rGec66603ac7ea: [clang-format] Remove the dependency on frontend (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D69383: [RISCV] Match GCC `-march`/`-mabi` driver defaults

lenary marked an inline comment as done. lenary added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:537 + if (Triple.getArch() == llvm::Triple::riscv32) +return "rv32gc"; else khchen wrote: > Why do you set rv32gc and rv64gc as d

[PATCH] D68340: Add AIX toolchain and basic linker functionality

stevewan updated this revision to Diff 226304. stevewan added a comment. Capture local variable IsArch32Bit by value. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68340/new/ https://reviews.llvm.org/D68340 Files: clang/lib/Driver/CMakeLists.txt

[PATCH] D69122: Add support to find out resource dir and add it as compilation args

Bigcheese added a reviewer: klimek. Bigcheese added a comment. I've added Manuel as a reviewer as this patch is also changing the tooling APIs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69122/new/ https://reviews.llvm.org/D69122

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

khchen added a comment. Herald added a subscriber: sameer.abuasal. @lenary You patch is very useful to look up the default march, thanks! But there is some issue if we set the default rv32 march as `rv32gc`. Because the default multilib does not include `rv32gc`/`lp32d` in riscv gnu toolchain,

[PATCH] D68340: Add AIX toolchain and basic linker functionality

stevewan marked 2 inline comments as done. stevewan added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:59 + + auto getCrt0Basename = [&IsArch32Bit, &Args] { +// Enable gprofiling when "-pg" is specified. jasonliu wrote: > nit: There is no

[PATCH] D67161: [clang,ARM] Initial ACLE intrinsics for MVE.

dmgreen added a comment. Hmm.. Let me take a look. There's a different error on the same build now, but I think it's just hiding this one. I'll also try and fix the tests that are failing in places too, if I can. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[clang] 7b3de1e - [ARM] Attempt to fixup MveEmitter warnings

Author: David Green Date: 2019-10-24T19:43:15+01:00 New Revision: 7b3de1e811972b874d91554642ccb2ef5b32eed6 URL: https://github.com/llvm/llvm-project/commit/7b3de1e811972b874d91554642ccb2ef5b32eed6 DIFF: https://github.com/llvm/llvm-project/commit/7b3de1e811972b874d91554642ccb2ef5b32eed6.diff L

[clang] bb6a27f - Add AIX toolchain and basic linker functionality

Author: stevewan Date: 2019-10-24T14:47:57-04:00 New Revision: bb6a27fc257faac1339e79c20ae807db70a31ebd URL: https://github.com/llvm/llvm-project/commit/bb6a27fc257faac1339e79c20ae807db70a31ebd DIFF: https://github.com/llvm/llvm-project/commit/bb6a27fc257faac1339e79c20ae807db70a31ebd.diff LOG:

[PATCH] D68340: Add AIX toolchain and basic linker functionality

This revision was automatically updated to reflect the committed changes. Closed by commit rGbb6a27fc257f: Add AIX toolchain and basic linker functionality (authored by stevewan, committed by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6

[PATCH] D69145: Give readability-redundant-member-init an option IgnoreBaseInCopyConstructors to avoid breaking code with gcc -Werror=extra

poelmanc added a comment. What do @malcolm.parsons, @alexfh, @hokein, @aaron.ballman, @lebedev.ri think of @mgehre's suggestion to enable `IgnoreBaseInCopyConstructors` as the default setting, so gcc users won't experience build errors and think "clang-tidy broke my code!" I could go either wa

[clang] 78700ef - [ARM] Fixup MVE intrinsic tests with no assert builds

Author: David Green Date: 2019-10-24T19:59:15+01:00 New Revision: 78700ef8866db7f5cea113fa81d810a28b5b7438 URL: https://github.com/llvm/llvm-project/commit/78700ef8866db7f5cea113fa81d810a28b5b7438 DIFF: https://github.com/llvm/llvm-project/commit/78700ef8866db7f5cea113fa81d810a28b5b7438.diff L

[PATCH] D67161: [clang,ARM] Initial ACLE intrinsics for MVE.

dmgreen added a comment. I've hopefully fixed the build in rG7b3de1e81197 , but it's hard to tell for sure with the other error. I also fixed the tests in rG78700ef8866d

[PATCH] D67787: Add 8548 CPU definition and attributes

jhibbits added a comment. In D67787#1719251 , @vit9696 wrote: > A side note regarding SPE support. I am currently upgrading to LLVM 9.0 and I > discovered that this patch was not committed anyhow at all: > https://reviews.llvm.org/D54583#1444288 Yeah,

[PATCH] D69122: Add support to find out resource dir and add it as compilation args

klimek added a comment. > since resource directory should be picked relative > to the path of the clang-compiler in the compilation command. The resource dir should be the resource dir that shipped with the clang source code that the *tool* was built with. We can think about the resource dir as

[clang] 8fa5e98 - [clang-format] Remove duplciate code from Invalid BOM detection

Author: paulhoad Date: 2019-10-24T20:24:44+01:00 New Revision: 8fa5e98fd191d02fc7e0e220d74af267b9140e6a URL: https://github.com/llvm/llvm-project/commit/8fa5e98fd191d02fc7e0e220d74af267b9140e6a DIFF: https://github.com/llvm/llvm-project/commit/8fa5e98fd191d02fc7e0e220d74af267b9140e6a.diff LOG:

[PATCH] D68914: [clang-format] Remove duplciate code from Invalid BOM detection

This revision was automatically updated to reflect the committed changes. Closed by commit rG8fa5e98fd191: [clang-format] Remove duplciate code from Invalid BOM detection (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D689

[PATCH] D69389: [hip] Allow the declaration of functions with variadic arguments in HIP.

tra added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:7764 + QualType Ty) const { + llvm_unreachable("AMDGPU does not support varargs"); +} llvm_unreachable() should be used to indicate an error in compiler's own

[PATCH] D69389: [hip] Allow the declaration of functions with variadic arguments in HIP.

hliao marked an inline comment as done. hliao added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:7764 + QualType Ty) const { + llvm_unreachable("AMDGPU does not support varargs"); +} tra wrote: > llvm_unreachable(

[PATCH] D69181: [clang-tidy] Adding misc-signal-terminated-thread check

steakhal added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/BadSignalToKillThreadCheck.cpp:28 + +static Preprocessor *PP; + Can't we place this `PP` variable to the checker class? Like the [[ https://github.com/llvm/llvm-project/blob/master/cla

[clang] 76ee21e - Namespace fixup for D68340 build on MSVC

Author: David Tenty Date: 2019-10-24T15:47:08-04:00 New Revision: 76ee21e1d09084288bbfee7f960ce0b9e4306d60 URL: https://github.com/llvm/llvm-project/commit/76ee21e1d09084288bbfee7f960ce0b9e4306d60 DIFF: https://github.com/llvm/llvm-project/commit/76ee21e1d09084288bbfee7f960ce0b9e4306d60.diff L

[PATCH] D31574: [clang-format] update documentation

MyDeveloperDay added a comment. When I land this change, I'll include the ClangFormatStyleOptions.rst to match (plus some minor NFC) in Format.h that are preventing dump_format_style.py from being rerun in a later commit I'll try and bring the Format.h and ClangFormaatStyleOptions.rst back in

[clang] 23b7836 - [clang-format] update documentation

Author: paulhoad Date: 2019-10-24T21:10:13+01:00 New Revision: 23b78364150cd946a8b111e87defdf179eecbc8f URL: https://github.com/llvm/llvm-project/commit/23b78364150cd946a8b111e87defdf179eecbc8f DIFF: https://github.com/llvm/llvm-project/commit/23b78364150cd946a8b111e87defdf179eecbc8f.diff LOG:

[PATCH] D31574: [clang-format] update documentation

This revision was automatically updated to reflect the committed changes. Closed by commit rG23b78364150c: [clang-format] update documentation (authored by MyDeveloperDay). Changed prior to commit: https://reviews.llvm.org/D31574?vs=223443&id=226316#toc Repository: rG LLVM Github Monorepo C

[PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

rnk added a comment. In D67723#1717468 , @aprantl wrote: > I agree that it would make sense to have a `-ginline-info-threshold=<#insns>` > or `-gno-small-inline-functions` with a hardcoded threshold to implement the > feature Paul described, and this pat

[PATCH] D69383: [RISCV] Match GCC `-march`/`-mabi` driver defaults

rogfer01 added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:475 + +if (MArch.startswith_lower("rv32")) { + if (MArch.substr(4).contains_lower("d") || lenary wrote: > rogfer01 wrote: > > `llvm::StringSwitch` has a method `Starts

[PATCH] D69356: [NFC] Rename LLVM_NO_DEAD_STRIP

daltenty updated this revision to Diff 226319. daltenty added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Address comments round 1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69356/new/ https://reviews.llvm.o

[PATCH] D68340: Add AIX toolchain and basic linker functionality

Yi-Hong.Lyu added a comment. Seems this commit broke the buildbot http://lab.llvm.org:8011/builders/ppc64le-lld-multistage-test/builds/6806 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68340/new/ https://reviews.llvm.org/D68340 ___

[PATCH] D67541: [ClangFormat] Future-proof Standard option, allow floating or pinning to arbitrary lang version

MyDeveloperDay added a comment. ClangFormatStyleOptions.rst and Format.h are inconsistent which means when clang/doc/tools/dump_format_style.py is run the rst file being generated is in danger of overwriting your changes (which I think you might have made by hand). I'm happy to try and fix this

[PATCH] D69363: [www] Change URLs to HTTPS.

STL_MSFT closed this revision. STL_MSFT added a comment. Committed: https://github.com/llvm/llvm-project/commit/2e4f1e112dfee1d16c138d42f2bc7ee639f9ae05 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69363/new/ https://reviews.llvm.org/D69363 _

[PATCH] D69356: [NFC] Rename LLVM_NO_DEAD_STRIP

stevewan accepted this revision. stevewan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69356/new/ https://reviews.llvm.org/D69356 ___

[clang] 126a72f - Fix MSVC "not all control paths return a value" warnings. NFCI.

Author: Simon Pilgrim Date: 2019-10-24T13:40:13-07:00 New Revision: 126a72fcbf7e5e4d958d3804033710c0a4efbe39 URL: https://github.com/llvm/llvm-project/commit/126a72fcbf7e5e4d958d3804033710c0a4efbe39 DIFF: https://github.com/llvm/llvm-project/commit/126a72fcbf7e5e4d958d3804033710c0a4efbe39.diff

[PATCH] D69171: [clang-fuzzer] Add new fuzzer target for Objective-C

gribozavr added a comment. Looks reasonable to me. The duplication is unfortunate, but it is reasonable while we have two binaries. However, you could explore reading the command line flags for HandleCXX in LLVMFuzzerInitialize from fuzzer's command line flags. Repository: rG LLVM Github Mo

[PATCH] D69404: [clang-format] [NFC] update the documentation in Format.h to allow dump_format_style.py to get a little closer to being correct.

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: klimek, mitchell-stellar, owenpan. MyDeveloperDay added projects: clang-format, clang. Running dump_format_style.py on the tip of the trunk causes ClangFormatStyleOptions.rst to have changes, which I think ideally it shouldn't.

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

tlively added a comment. It would be great to see some test .ll files here so we can get a better understanding for what is implemented here. I would also like to see tests of what happens if you try to do a `ptrtoint` or some other illegal operation on a reference type. Com

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

tlively added a comment. One other thought: Does the implementation in this diff care what type the reference type pointers are pointing to? It would be nice if we could enforce the use of an opaque pointee type to prevent the reference types from being dereferenced. Repository: rG LLVM Git

[clang] 201ed14 - Follow on to Namespace fixup for D68340

Author: David Tenty Date: 2019-10-24T17:01:17-04:00 New Revision: 201ed14aea8cd03e776dbe8484fa7de3ac94a3cf URL: https://github.com/llvm/llvm-project/commit/201ed14aea8cd03e776dbe8484fa7de3ac94a3cf DIFF: https://github.com/llvm/llvm-project/commit/201ed14aea8cd03e776dbe8484fa7de3ac94a3cf.diff L

[PATCH] D69327: [Clang][ThinLTO] Add a cache for compile phase output.

ychen added a comment. Thank you @steven_wu @tejohnson. I created D69406 to promote the flag to the driver. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69327/new/ https://reviews.llvm.org/D69327 _

  1   2   >