Re: Zorg migration to GitHub/monorepo

Hello build bot owners! The staging master is ready. Please feel free to use it to make sure your bots would work well with the monorepo and github. The following builders could be configured to build monorepo: * clang-atom-d525-fedora-rel * clang-native-arm-lnt-perf * clang-cmake-armv7-lnt * cl

[PATCH] D68590: [clangd] Improve hover support for Objective-C

kadircet added inline comments. Comment at: clangd/XRefs.cpp:461 + + OS << (Method->isInstanceMethod() ? '-' : '+') + << '[' << Class->getName(); it looks like `DeclPrinter::VisitObjCMethodDecl` already has a similar handling. would it provide value if you p

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

Tyker added a comment. ping @rsmith CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63960/new/ https://reviews.llvm.org/D63960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D67216: [cfi] Add flag to always generate .debug_frame

ostannard added a comment. How about `-f[no-]force-dwarf-frame`, which I think matches the spelling and behaviour of the existing `-fforce-enable-int128` and `-fforce-emit-vtables` options? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67216/new/ https://reviews.llvm.org/D67216 ___

[PATCH] D69043: [RFC] Adding time-trace to LLD?

russell.gallop added a comment. In D69043#1714060 , @ruiu wrote: > I applied this patch and built clang with ThinLTO. Here is the generated file: > This file seems much smaller than yours. What am I missing? I have seen some very empty looking traces wh

[PATCH] D68028: [clang] Add no_builtin attribute

gchatelet updated this revision to Diff 225575. gchatelet marked 3 inline comments as done. gchatelet added a comment. - Change NoBuiltin from InheritableAttr to Attr - Improve tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68028/new/ https://

[PATCH] D68539: [clang-tidy] fix for readability-identifier-naming incorrectly fixes variables which become keywords

Daniel599 marked an inline comment as done. Daniel599 added a comment. Hi, any updates regarding my patch? issues to fix? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68539/new/ https://reviews.llvm.org/D68539 __

[PATCH] D68028: [clang] Add no_builtin attribute

gchatelet updated this revision to Diff 225576. gchatelet marked an inline comment as done. gchatelet added a comment. - Improve tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68028/new/ https://reviews.llvm.org/D68028 Files: clang/include/

[PATCH] D69043: [RFC] Adding time-trace to LLD?

grimar added a comment. In D69043#1714134 , @russell.gallop wrote: > In D69043#1714060 , @ruiu wrote: > > > (I couldn't download your file because the server times out perhaps due to > > the file size.) > > > That

[PATCH] D68028: [clang] Add no_builtin attribute

gchatelet updated this revision to Diff 225578. gchatelet added a comment. - Reverting whole file formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68028/new/ https://reviews.llvm.org/D68028 Files: clang/include/clang/AST/Decl.h clang/i

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille updated this revision to Diff 225580. serge-sans-paille added a comment. Explicilty prefer existing mechanism for windows. Split loop/block allocation strategy to different functions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6

[PATCH] D67550: [AArch64][SVE] Implement unpack intrinsics

This revision was automatically updated to reflect the committed changes. kmclaughlin marked an inline comment as done. Closed by commit rG0c7cc383e5b8: [AArch64][SVE] Implement unpack intrinsics (authored by kmclaughlin). Herald added a subscriber: hiraditya. Herald added a project: LLVM. Change

[PATCH] D47987: Provide only one declaration of __throw_runtime_error

dim abandoned this revision. dim added a comment. Herald added a subscriber: libcxx-commits. Obsoleted by D58425 (and rCXX354515 ). Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47987/new/

[PATCH] D68720: Support -fstack-clash-protection for x86

sylvestre.ledru added a comment. You should also probably document the arg in clang/docs/ClangCommandLineReference.rst we have -fstack-protector-strong & co in the doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/new/ https://reviews.llvm.

[PATCH] D68977: [clangd] Report declaration references in findExplicitReferences.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:495 struct Visitor : TypeLocVisitor { -llvm::Optional Ref; +llvm::SmallVector Refs; Could we keep an `llvm::Optional<>` here in the visitor? The logic in `VisitE

[PATCH] D69162: [clangd] Remove using-namespace present inside a namespace.

usaxena95 created this revision. usaxena95 added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, mgrang, jkorous, MaskRay. Herald added a project: clang. This patch extends the removing using-namespace code action to remove using-namespace decl that are prese

[PATCH] D68028: [clang] Add no_builtin attribute

gchatelet updated this revision to Diff 225593. gchatelet added a comment. - Call sites to virtual functions are not annotated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68028/new/ https://reviews.llvm.org/D68028 Files: clang/include/clang/AS

[PATCH] D69162: [clangd] Remove using-namespace present inside a namespace.

merge_guards_bot added a comment. Build result: fail - 33547 tests passed, 1 failed and 464 were skipped. failed: LLVM.tools/llvm-ar/mri-utf8.test Log files: cmake-log.txt , ninja_check_all-log.txt

[PATCH] D69162: [clangd] Remove using-namespace present inside a namespace.

usaxena95 updated this revision to Diff 225596. usaxena95 added a comment. Added additional tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69162/new/ https://reviews.llvm.org/D69162 Files: clang-tools-extra/clangd/refactor/tweaks/RemoveUsi

[PATCH] D69162: [clangd] Remove using-namespace present inside a namespace.

merge_guards_bot added a comment. Build result: fail - 33547 tests passed, 1 failed and 464 were skipped. failed: LLVM.tools/llvm-ar/mri-utf8.test Log files: cmake-log.txt , ninja_check_all-log.txt

[PATCH] D68977: [clangd] Report declaration references in findExplicitReferences.

hokein updated this revision to Diff 225597. hokein marked 2 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68977/new/ https://reviews.llvm.org/D68977 Files: clang-tools-extra/cla

[PATCH] D68977: [clangd] Report declaration references in findExplicitReferences.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. Many thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68977/new/ https://reviews.llvm.org/D68977 ___

[clang-tools-extra] r375226 - [clangd] Report declaration references in findExplicitReferences.

Author: hokein Date: Fri Oct 18 05:07:19 2019 New Revision: 375226 URL: http://llvm.org/viewvc/llvm-project?rev=375226&view=rev Log: [clangd] Report declaration references in findExplicitReferences. Reviewers: ilya-biryukov Subscribers: MaskRay, jkorous, arphaman, kadircet, usaxena95, cfe-commit

[PATCH] D68977: [clangd] Report declaration references in findExplicitReferences.

merge_guards_bot added a comment. Build result: fail - 33449 tests passed, 2 failed and 463 were skipped. failed: LLVM.tools/llvm-ar/mri-utf8.test failed: LLVM.tools/llvm-objdump/X86/disassemble-functions.test Log files: cmake-log.txt

[PATCH] D68977: [clangd] Report declaration references in findExplicitReferences.

This revision was automatically updated to reflect the committed changes. Closed by commit rG65f61c0030c5: [clangd] Report declaration references in findExplicitReferences. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D68977?vs=225597&id=225601#toc Repository: rG L

[PATCH] D68028: [clang] Add no_builtin attribute

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:4407 +It accepts one or more strings corresponding to the name of the builtin +(e.g. "memcpy", "memset") or "*" which disables all builtins at once. + This mention of `*` is no

[PATCH] D69164: [clang-format] fix regression recognizing casts in Obj-C calls

krasimir created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. krasimir edited the summary of this revision. krasimir added a reviewer: MyDeveloperDay. r373922 added checks for a few tokens that, following an `)` make it unlikely that the `)` is the closing

[PATCH] D56924: Special case ObjCPropertyDecl for printing

gribozavr added inline comments. Comment at: lib/AST/Decl.cpp:1543 +Ctx = ID; + } Like you said in a private conversation, yes, support for `ObjCIvarDecl` also seems necessary. Comment at: unittests/AST/NamedDeclPrinterTest.cpp:220

[PATCH] D69165: [clangd] Store Index in Tweak::Selection

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. Incoming define out-of-line tweak requires access to index. This patch simply propogates the index in ClangdServer

[PATCH] D69164: [clang-format] fix regression recognizing casts in Obj-C calls

MyDeveloperDay added a comment. LGTM, thanks for the patch Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69164/new/ https://reviews.llvm.org/D69164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D68818: [hip][cuda] Fix the extended lambda name mangling issue.

hliao added a comment. PING for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68818/new/ https://reviews.llvm.org/D68818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D68528: [Implicit Modules] Add -cc1 option -fmodules-strict-hash which includes search paths and diagnostics.

bruno added a comment. > While adding the documentation I realized that a better name for this option > would be `-fmodules-strict-context-hash` to make it clear which hash it's > referring to. `-fmodules-strict-context-hash` SGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68528

[PATCH] D68885: Add a Ranges field to Diagnostic struct

gribozavr added a comment. Please upload patches with context in future (`arc diff` will do that for you). Please also merge this patch with the user, https://reviews.llvm.org/D68887. No need to add untested code. Comment at: include/clang/Tooling/Core/Diagnostic.h:88 + + +

[PATCH] D69155: [analyzer] Fix off-by-one in operator call parameter binding.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/CallEvent.cpp:325 if (getKind() != CE_CXXAllocator) if (isArgumentConstructedDirectly(Idx)) if (auto AdjIdx = getAdjustedParameterIndex(Idx)) --

[PATCH] D69155: [analyzer] Fix off-by-one in operator call parameter binding.

Charusso accepted this revision. Charusso marked an inline comment as done. Charusso added a comment. This revision is now accepted and ready to land. I think it will be a great educational material how to touch the core. Good luck! Comment at: clang/lib/StaticAnalyzer/Core/Ca

[PATCH] D68885: Add a Ranges field to Diagnostic struct

alexfh added inline comments. Comment at: include/clang/Tooling/Core/Diagnostic.h:93 + /// representation of the source code associated with the diagnostic. + ArrayRef Ranges; }; Please add YAML serialization/deserialization code for this. See include/clang/T

[PATCH] D69164: [clang-format] fix regression recognizing casts in Obj-C calls

rdwampler added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:1612 + Keywords.kw_final) || +isCpp11AttributeSpecifier(*Tok.Next)) return false; I think the issue r373922 was fixing is only related to the `delet

[PATCH] D68340: Add AIX toolchain and basic linker functionality

jasonliu added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.h:19 + +/// aix -- Directly call system default and linker. +// TODO: Enable direct call to system default assembler. remove "and". Comment at: clang/lib/Driver/ToolCha

[PATCH] D68028: [clang] Add no_builtin attribute

gchatelet marked 4 inline comments as done. gchatelet added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3609 + "'%0' is not a valid builtin name for %1">, + InGroup; // Which group should it be in? +def err_attribute_no_builtin_wildcard_or_buil

[PATCH] D68028: [clang] Add no_builtin attribute

gchatelet updated this revision to Diff 225618. gchatelet added a comment. - Fix documentation and Warning category Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68028/new/ https://reviews.llvm.org/D68028 Files: clang/include/clang/AST/Decl.h

[PATCH] D69124: [clang][driver] Print compilation phases with indentation.

hliao added a comment. In D69124#1713427 , @tra wrote: > This is... rather oddly-structured output. My brain refuses to accept that > the most-indented phase is the input. > Perhaps we should do `llvm::errs().indent(MaxIdent-Ident)`. This should give >

[PATCH] D69124: [clang][driver] Print compilation phases with indentation.

hliao updated this revision to Diff 225620. hliao added a comment. revise the output by drawing tree lines. now, the output looks like $ clang -x cuda -ccc-print-phases --cuda-gpu-arch=sm_30 --cuda-gpu-arch=sm_60 -c dummy.cpp +- 0: input, "/home/michliao/dummy.cpp", cuda, (host-c

[PATCH] D67545: [clang-tidy] Added DefaultOperatorNewCheck.

balazske updated this revision to Diff 225625. balazske added a comment. - Fixes from review comments, added C++ version test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67545/new/ https://reviews.llvm.org/D67545 Files: clang-tools-extra/clan

r375245 - [tooling] Relax an assert when multiple GPU targets are specified.

Author: hliao Date: Fri Oct 18 08:03:34 2019 New Revision: 375245 URL: http://llvm.org/viewvc/llvm-project?rev=375245&view=rev Log: [tooling] Relax an assert when multiple GPU targets are specified. Modified: cfe/trunk/lib/Tooling/Tooling.cpp Modified: cfe/trunk/lib/Tooling/Tooling.cpp URL:

[PATCH] D56924: Special case ObjCPropertyDecl for printing

dexonsmith added subscribers: jkorous, benlangmuir. dexonsmith added inline comments. Comment at: unittests/AST/NamedDeclPrinterTest.cpp:220 +"property", +"Obj::property")); +} gribozavr wrote: > I don't think that `Obj::property` is the preferred syntax.

[PATCH] D68340: Add AIX toolchain and basic linker functionality

stevewan updated this revision to Diff 225631. stevewan marked 25 inline comments as done. stevewan added reviewers: jasonliu, Xiangling_L. stevewan added a comment. Fix periods at the end of comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68

r375247 - [clang-format] fix regression recognizing casts in Obj-C calls

Author: krasimir Date: Fri Oct 18 08:21:06 2019 New Revision: 375247 URL: http://llvm.org/viewvc/llvm-project?rev=375247&view=rev Log: [clang-format] fix regression recognizing casts in Obj-C calls Summary: r373922 added checks for a few tokens that, following an `)` make it unlikely that the `)`

[PATCH] D69171: [clang-fuzzer] Add new fuzzer target for Objective-C

dgoldman created this revision. Herald added subscribers: cfe-commits, jfb, mgorny. Herald added a project: clang. - Similar to that of `clang-fuzzer` itself but instead only targets Objective-C source files via cc1 - Also adds an example corpus directory containing some input for Objective-C

[PATCH] D69164: [clang-format] fix regression recognizing casts in Obj-C calls

This revision was automatically updated to reflect the committed changes. Closed by commit rGeff2a2ab2b51: [clang-format] fix regression recognizing casts in Obj-C calls (authored by krasimir). Changed prior to commit: https://reviews.llvm.org/D69164?vs=225604&id=225635#toc Repository: rG LL

[PATCH] D69088: [Lex] #pragma clang transform

Meinersbur added a comment. In D69088#1714020 , @hsaito wrote: > Personally, I like the intent. I don't foresee a clear (enough) path to get > there. This leads to hesitation of adding a new non-experimental pragma and > present it to programmers. If you

[PATCH] D69171: [clang-fuzzer] Add new fuzzer target for Objective-C

sammccall added a comment. Rather than adding a new fuzzer binary, can we make the language an option? The whole implementation seems almost identical down to handleobjc/handlecxx... Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69171/new/ https://reviews.llvm.or

[PATCH] D56924: Special case ObjCPropertyDecl for printing

dgoldman added inline comments. Comment at: unittests/AST/NamedDeclPrinterTest.cpp:220 +"property", +"Obj::property")); +} dexonsmith wrote: > gribozavr wrote: > > I don't think that `Obj::property` is the preferred syntax. `Obj.property`? > > I'd want a

[PATCH] D69177: [clangd] Propogate FS into Tweak::Selection

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. kadircet added a parent revision: D69165: [clangd] Store Index in Tweak::Selection. Incoming define out-of-line co

Re: [PATCH] D55802: Change CGObjC to use objc intrinsics instead of runtime methods

I only got a chance to look more into this now. I can reproduce it with re-inserting the "static". The miscompile is not related to MemorySSA, i.e. disabling all uses of MemorySSA doesn't help. It appears to be a GVN bug, but I haven't tracked it further than this. To repro, see attached .ll file

r375224 - [ThinLTOCodeGenerator] Add support for index-based WPD

Author: evgeny777 Date: Fri Oct 18 04:58:21 2019 New Revision: 375224 URL: http://llvm.org/viewvc/llvm-project?rev=375224&view=rev Log: [ThinLTOCodeGenerator] Add support for index-based WPD This is clang part of the patch. It adds -flto-unit flag for thin LTO builds on Mac and PS4 Differential

[PATCH] D69179: [Format] Add format check for coroutine keywords with negative numbers

jonathoma created this revision. Herald added subscribers: cfe-commits, modocache. Herald added a project: clang. jonathoma retitled this revision from "[Format] Add format check for throwing negative numbers" to "[Format] Add format check for coroutine keywords with negative numbers". jonathoma

[PATCH] D69180: [Format] Add format check for coroutine keywords with negative numbers

jonathoma created this revision. jonathoma added reviewers: modocache, sammccall, Quuxplusone. Herald added a project: clang. Herald added a subscriber: cfe-commits. jonathoma planned changes to this revision. As a followup to D69144 , this diff fixes the coroutin

r375257 - [DOCS]Update list of implemented constructs, NFC.

Author: abataev Date: Fri Oct 18 09:53:54 2019 New Revision: 375257 URL: http://llvm.org/viewvc/llvm-project?rev=375257&view=rev Log: [DOCS]Update list of implemented constructs, NFC. Modified: cfe/trunk/docs/OpenMPSupport.rst Modified: cfe/trunk/docs/OpenMPSupport.rst URL: http://llvm.org/

LLVM buildmaster will be updated and restarted

Hello everyone, LLVM buildmaster will be updated and restarted in an hour. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r375258 - [Format] Add format check for throwing negative numbers

Author: modocache Date: Fri Oct 18 09:59:02 2019 New Revision: 375258 URL: http://llvm.org/viewvc/llvm-project?rev=375258&view=rev Log: [Format] Add format check for throwing negative numbers Summary: The code `throw -1;` is currently formatted by clang-format as `throw - 1;`. This diff adds a fi

[PATCH] D69144: [Format] Add format check for throwing negative numbers

This revision was automatically updated to reflect the committed changes. Closed by commit rG7f704320b058: [Format] Add format check for throwing negative numbers (authored by modocache). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69144/new/ http

[PATCH] D69171: [clang-fuzzer] Add new fuzzer target for Objective-C

dgoldman added a comment. In D69171#1714624 , @sammccall wrote: > Rather than adding a new fuzzer binary, can we make the language an option? > The whole implementation seems almost identical down to > handleobjc/handlecxx... It's similar at the moment

[PATCH] D69181: [clang-tidy] Adding misc-signal-terminated-thread check

abelkocsis created this revision. abelkocsis added reviewers: aaron.ballman, alexfh, JonasToth, steakhal, Charusso. abelkocsis added a project: clang-tools-extra. Herald added subscribers: cfe-commits, mgehre, jfb, dexonsmith, steven_wu, hiraditya, xazax.hun, mgorny, mehdi_amini. Herald added a r

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc added a comment. Ping. Hoping for code review so I can move this forward. Affirmative or negative, please let me know. Thank you! --Melanie Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731

[PATCH] D69184: [libTooling] Introduce general combinator for fixed-value `MatchConsumer`s.

ymandel created this revision. ymandel added a reviewer: gribozavr. Herald added a project: clang. This revision generalizes the (deprecated) `clang::tooling::text` combinator to a `value` combinator, which works for any type. Aside from being more general, it resolves the naming confict between `

[PATCH] D69186: Refactor DependencyScanningTool to its own file

kousikk updated this revision to Diff 225667. kousikk added a comment. Lint fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69186/new/ https://reviews.llvm.org/D69186 Files: clang/include/clang/Tooling/DependencyScanning/DependencyScanningTo

[PATCH] D69186: Refactor DependencyScanningTool to its own file

kousikk created this revision. kousikk added reviewers: arphaman, jkorous, Bigcheese, dexonsmith. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. kousikk updated this revision to Diff 225667. kousikk added a comment. Lint fixes There's no behavior change - just movi

[PATCH] D69180: [Format] Add format check for coroutine keywords with negative numbers

jonathoma updated this revision to Diff 225672. jonathoma added a comment. Rebase properly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69180/new/ https://reviews.llvm.org/D69180 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Form

[PATCH] D69180: [Format] Add format check for coroutine keywords with negative numbers

jonathoma updated this revision to Diff 225671. jonathoma added a comment. Rebase onto master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69180/new/ https://reviews.llvm.org/D69180 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/F

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

rjmccall added inline comments. Comment at: clang/docs/UsersManual.rst:1318 + mode informs the compiler that it must not assume any particular + rounding mode. + rjmccall wrote: > "represent *the* corresponding IEEE rounding rules" A few points about this doc

[PATCH] D69164: [clang-format] fix regression recognizing casts in Obj-C calls

krasimir marked an inline comment as done. krasimir added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:1612 + Keywords.kw_final) || +isCpp11AttributeSpecifier(*Tok.Next)) return false; rdwampler wrote: > I thi

[PATCH] D69171: [clang-fuzzer] Add new fuzzer target for Objective-C

dgoldman added a comment. Not sure who is best to review, feel free to add someone else instead. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69171/new/ https://reviews.llvm.org/D69171 ___ cfe-commits mailing list c

[PATCH] D69181: [clang-tidy] Adding misc-signal-terminated-thread check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/BadSignalToKillThreadCheck.cpp:28 + +namespace { +static Preprocessor *PP; static is enough, no need for anonymous namespace. Comment at: clang-tools-extra/clan

[PATCH] D69088: [Lex] #pragma clang transform

Meinersbur added a comment. In D69088#1713623 , @hsaito wrote: > @Meinersbur, if I remember correctly, there was an RFC discussion on this > topic, right? If yes, would you post the pointer to that? I need a refresher > on what has been discussed/settled

[PATCH] D68818: [hip][cuda] Fix the extended lambda name mangling issue.

hliao updated this revision to Diff 225678. hliao added a comment. minor test case revising. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68818/new/ https://reviews.llvm.org/D68818 Files: clang/include/clang/AST/DeclCXX.h clang/include/clang/

[PATCH] D69088: [Lex] #pragma clang transform

hsaito added a comment. In D69088#1714575 , @Meinersbur wrote: > In D69088#1714020 , @hsaito wrote: > > > Personally, I like the intent. I don't foresee a clear (enough) path to get > > there. This leads to hesitat

[libunwind] r375275 - [libunwind][Android] Fix findUnwindSections for ARM EHABI Bionic

Author: rprichard Date: Fri Oct 18 12:59:22 2019 New Revision: 375275 URL: http://llvm.org/viewvc/llvm-project?rev=375275&view=rev Log: [libunwind][Android] Fix findUnwindSections for ARM EHABI Bionic Summary: Fix the arm_section_length count. The meaning of the arm_section_length field changed f

[PATCH] D68818: [hip][cuda] Fix the extended lambda name mangling issue.

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/AST/DeclCXX.h:1713 + /// mangling number. + bool hasKnownInternalLinkage() const { +assert(isLambda() && "Not a lambda closure type!

[PATCH] D69150: [analyzer] Fix hidden node traversal in exploded graph dumps.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/test/Analysis/dump_egraph.c:46 // CHECK: \"pretty\": \"*x\", \"location\": \{ \"line\": 18, \"column\": 10, \"file\": \"{{(.+)}}dump_egraph.c\" \} Charusso wrote: > `\"file\"

r375278 - [analyzer] Fix hidden node traversal in exploded graph dumps.

Author: dergachev Date: Fri Oct 18 13:15:29 2019 New Revision: 375278 URL: http://llvm.org/viewvc/llvm-project?rev=375278&view=rev Log: [analyzer] Fix hidden node traversal in exploded graph dumps. The joined nodes now actually have the same state. That was intended from the start but the origina

r375280 - [analyzer] Drop the logic for collapsing the state if it's same as in preds.

Author: dergachev Date: Fri Oct 18 13:15:35 2019 New Revision: 375280 URL: http://llvm.org/viewvc/llvm-project?rev=375280&view=rev Log: [analyzer] Drop the logic for collapsing the state if it's same as in preds. One of the first attempts to reduce the size of the exploded graph dumps was to skip

r375282 - [analyzer] exploded-graph-rewriter: Rename Environment to Expressions.

Author: dergachev Date: Fri Oct 18 13:15:41 2019 New Revision: 375282 URL: http://llvm.org/viewvc/llvm-project?rev=375282&view=rev Log: [analyzer] exploded-graph-rewriter: Rename Environment to Expressions. It's less confusing for newcomers. Modified: cfe/trunk/test/Analysis/exploded-graph-r

r375281 - [analyzer] Fix FieldRegion dumps.

Author: dergachev Date: Fri Oct 18 13:15:39 2019 New Revision: 375281 URL: http://llvm.org/viewvc/llvm-project?rev=375281&view=rev Log: [analyzer] Fix FieldRegion dumps. The '->' thing has always been confusing; the actual operation '->' translates to a pointer dereference together with adding a

r375279 - [analyzer] exploded-graph-rewriter: Fix dump for state 0.

Author: dergachev Date: Fri Oct 18 13:15:32 2019 New Revision: 375279 URL: http://llvm.org/viewvc/llvm-project?rev=375279&view=rev Log: [analyzer] exploded-graph-rewriter: Fix dump for state 0. It shouldn't say "unspecified" when the state is specified to be empty. Modified: cfe/trunk/test/A

[PATCH] D69150: [analyzer] Fix hidden node traversal in exploded graph dumps.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7a17f197093a: [analyzer] Fix hidden node traversal in exploded graph dumps. (authored by dergachev.a). Changed prior to commit: https://reviews.llvm.org/D69150?vs=225547&id=225685#toc Repository: rG

r375286 - [analyzer] exploded-graph-rewriter: Unforget to censor stmt_ids in the test.

Author: dergachev Date: Fri Oct 18 13:48:21 2019 New Revision: 375286 URL: http://llvm.org/viewvc/llvm-project?rev=375286&view=rev Log: [analyzer] exploded-graph-rewriter: Unforget to censor stmt_ids in the test. They're not stable across machines. Fixes buildbots after r375278. Modified: c

[PATCH] D67647: [Consumed] Refactor handleCall to take function argument list. NFC.

dblaikie added a comment. In D67647#1713974 , @comex wrote: > So, I landed this patch but had to revert it as it broke the build on MSVC > (and only MSVC). That was almost a month ago, but I haven't gotten back > around to this until now – sorry :| > >

[PATCH] D69194: build: add clang-cl and clang++ symlinks in the build tree

compnerd created this revision. compnerd added reviewers: xiaobai, beanz, smeenai. Herald added a subscriber: mgorny. Herald added a project: clang. This adds the clang-cl and clang++ symlinks. Since there are no targets to depend on for this, we cannot force the creation of the symlinks. Furth

[PATCH] D69194: build: add clang-cl and clang++ symlinks in the build tree

smeenai added a comment. > Furthermore, the current build only installs the symbolic links in the > install tree, not the build tree This isn't right ... if I look at my LLVM build tree, I have clang, clang++ and clang-cl symlinks, all pointing to the actual clang-10 binary. Where are you seei

Re: Zorg migration to GitHub/monorepo

On Mon, Oct 14, 2019 at 6:16 PM Galina Kistanova via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hello everyone, > > > > We are in the middle of porting the majority of zorg to > GitHub/monorepo. The following build factories will be ported and if you > use one of those for your bots, you a

[PATCH] D69088: [Lex] #pragma clang transform

Meinersbur added a comment. In D69088#1715038 , @hsaito wrote: > If there is a precedence, just follow that. Else, how to spell an > experimental clang pragma would be a good discussion topic by itself. If I > need to provide a discussion starter, I'd sa

[PATCH] D69184: [libTooling] Introduce general combinator for fixed-value `MatchConsumer`s.

gribozavr added a comment. What are the use cases for non-text values? I like the name `text` much better... If the name conflict is the issue, I think you could rename it to `toText` -- it would even read more fluently `change(toText("abc"))`, also making it obvious that we are not changing *t

[PATCH] D69088: [Lex] #pragma clang transform

hsaito added a comment. In D69088#1715210 , @Meinersbur wrote: > I'd rather just enable them with a command-line switch, such as > `-fexperimental-transform`. This direction works for me. `-fexperimental-transform-pragma` might be better, though. Rep

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

dblaikie added a subscriber: rsmith. dblaikie added a comment. In D68117#1714091 , @SouraVX wrote: > Hi @probinson @dblaikie @aprantl , I've was investigating and working on > your inputs regarding the problem with DW_at_defaulted once. I think clang >

[PATCH] D66437: Sema: Create a no-op implicit cast for lvalue function conversions.

pcc added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66437/new/ https://reviews.llvm.org/D66437 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D69090: [Try 2] Include sanitize blacklist and other extra deps as part of scan-deps output

dexonsmith added a comment. In D69090#1713983 , @kousikk wrote: > Thanks for the comment @jkorous. > > > I think you could've just used CHECK-DAG to fix the tests. It *might* be a > > bit more robust. Although just reordering checks seems perfectly fine t

[PATCH] D66983: [WebAssembly] Add wasm-specific vector shuffle builtin and intrinsic

aheejin added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsWebAssembly.td:117 + llvm_i32_ty, llvm_i32_ty, llvm_i32_ty, llvm_i32_ty, llvm_i32_ty, + llvm_i32_ty, llvm_i32_ty, llvm_i32_ty, llvm_i32_ty], +[IntrNoMem, IntrSpeculatable

[PATCH] D69124: [clang][driver] Print compilation phases with indentation.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Neat. I like the visual cues showing what gets passed on to the next processing stage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69124/new/ https

r375301 - [profile] Do not cache __llvm_profile_get_filename result

Author: vedantk Date: Fri Oct 18 16:33:40 2019 New Revision: 375301 URL: http://llvm.org/viewvc/llvm-project?rev=375301&view=rev Log: [profile] Do not cache __llvm_profile_get_filename result When the %m filename pattern is used, the filename is unique to each image, so the cached value is wrong.

[PATCH] D69171: [clang-fuzzer] Add new fuzzer target for Objective-C

morehouse added inline comments. Comment at: tools/clang-fuzzer/ClangObjectiveCFuzzer.cpp:19 + +extern "C" int LLVMFuzzerInitialize(int *argc, char ***argv) { return 0; } + Nit: Since it does nothing, let's omit the `LLVMFuzzerInitialize` definition. =

  1   2   >