gchatelet marked 4 inline comments as done. gchatelet added inline comments.
================ Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3609 + "'%0' is not a valid builtin name for %1">, + InGroup<IgnoredAttributes>; // Which group should it be in? +def err_attribute_no_builtin_wildcard_or_builtin_name : Error< ---------------- aaron.ballman wrote: > Hmm, I thought there was a way you could do: > ``` > InGroup<DiagGroup<"invalid-no-builtin-names", IgnoredAttributes>>; > ``` > but it seems I've got the order reversed and you'd have to add a new > diagnostic group that `IgnoredAttributes` could subsume. We don't do that for > other attributes, so I think you should just do: > ``` > InGroup<DiagGroup<"invalid-no-builtin-names">>; > ``` > (Feel free to pick a better diagnostic group name if you have a better idea, > I'm not tied to my suggestion.) `"invalid-no-builtin-names"` LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68028/new/ https://reviews.llvm.org/D68028 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
