r372814 - [Driver] Always use -z separate-loadable-segments with lld on Fuchsia

Author: maskray Date: Wed Sep 25 00:06:50 2019 New Revision: 372814 URL: http://llvm.org/viewvc/llvm-project?rev=372814&view=rev Log: [Driver] Always use -z separate-loadable-segments with lld on Fuchsia The option was added to lld in D67481/372807. Reviewed By: phosek Differential Revision: ht

[PATCH] D68009: [Driver] Always use -z separate-loadable-segments with lld on Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rL372814: [Driver] Always use -z separate-loadable-segments with lld on Fuchsia (authored by MaskRay, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL

[PATCH] D44609: [Clang-Format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style)

MyDeveloperDay added a comment. Thanks for the patch, so sorry its taking a long time, its patches like this why I'm about to make a phabricator project for #clang-format alone so that we can ensure all clang-format patches can be see in isolation. I think we need to get this patches rebased to

[PATCH] D67826: [clangd] A helper to find explicit references and their names

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang-tools-extra/clangd/FindTarget.h:103 +llvm::function_ref Out); +void findExplicitReferences(Decl *S, +

[PATCH] D66937: [clangd] Fix the stale documentation about background indexing.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/docs/clangd/Installation.rst:364 + amount of cores by passing the `-j=` flag; +- the index is saved to the ``.clangd/index``

[PATCH] D67960: [clangd] Move the existing heder-source-switch implemenation out of clangdServer.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/HeaderSourceSwitch.cpp:21 +llvm::IntrusiveRefCntPtr VFS) { + // FIXME: move the file heuristic to HeaderSourceSwit

[clang-tools-extra] r372825 - [clangd] Fix the stale documentation about background indexing.

Author: hokein Date: Wed Sep 25 01:26:32 2019 New Revision: 372825 URL: http://llvm.org/viewvc/llvm-project?rev=372825&view=rev Log: [clangd] Fix the stale documentation about background indexing. Reviewers: kadircet Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, cfe-commits Tags: #cla

[PATCH] D66937: [clangd] Fix the stale documentation about background indexing.

hokein updated this revision to Diff 221687. hokein marked an inline comment as done. hokein added a comment. Fix a typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66937/new/ https://reviews.llvm.org/D66937 Files: clang-tools-extra/docs/clan

[PATCH] D66937: [clangd] Fix the stale documentation about background indexing.

This revision was automatically updated to reflect the committed changes. Closed by commit rL372825: [clangd] Fix the stale documentation about background indexing. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D60199: [clang-format] Do not emit replacements while regrouping if Cpp includes are OK

MyDeveloperDay added a comment. Possible fix for PR43372 (https://bugs.llvm.org/show_bug.cgi?id=43372) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60199/new/ https://reviews.llvm.org/D60199 ___ cfe-commits mailing

[PATCH] D67901: [clangd] Improve semantic highlighting in dependent contexts (fixes #154)

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:181 + addToken(E->getMemberLoc(), E->getQualifier() + ? HighlightingKind::StaticField + : Highlighting

[PATCH] D67973: [libTooling][NFC] Switch StencilTest.cpp to use EXPECT_THAT_EXPECTED

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67973/new/ https://reviews.llvm.org/D67973 _

[PATCH] D67774: [Mangle] Add flag to asm labels to disable '\01' prefixing

rjmccall added a comment. Thanks. One last and minor request: please mention in the comment on IsLiteralLabel that non-literal labels are used by some external AST sources like LLDB. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67774/new/ https://reviews.llvm.org/D67774 __

[PATCH] D67774: [Mangle] Add flag to asm labels to disable '\01' prefixing

teemperor resigned from this revision. teemperor added a comment. This LGTM modulo rjmccall's comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67774/new/ https://reviews.llvm.org/D67774 ___ cfe-commits mailing list cfe-commits@lists.l

r372833 - [OpenCL] Add image query builtin functions

Author: svenvh Date: Wed Sep 25 02:12:59 2019 New Revision: 372833 URL: http://llvm.org/viewvc/llvm-project?rev=372833&view=rev Log: [OpenCL] Add image query builtin functions Add the image query builtin functions from the OpenCL C specification. Patch by Pierre Gondois and Sven van Haastregt.

[PATCH] D67713: [OpenCL] Add image query builtin functions

This revision was automatically updated to reflect the committed changes. Closed by commit rL372833: [OpenCL] Add image query builtin functions (authored by svenvh, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.ll

[PATCH] D67992: [Sema] Add FunctionTypeUnwrapper

dim added a comment. This works for me, and also for the original test case from https://bugs.freebsd.org/240764. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67992/new/ https://reviews.llvm.org/D67992 _

[PATCH] D67901: [clangd] Improve semantic highlighting in dependent contexts (fixes #154)

hokein added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:181 + addToken(E->getMemberLoc(), E->getQualifier() + ? HighlightingKind::StaticField + : HighlightingKind::F

[PATCH] D67960: [clangd] Move the existing heder-source-switch implemenation out of clangdServer.

hokein updated this revision to Diff 221703. hokein marked 3 inline comments as done. hokein added a comment. Herald added a subscriber: mgorny. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67960/new/ https://reviews.llvm.org/D67

[clang-tools-extra] r372841 - [clangd] Move the existing heder-source-switch implemenation out of clangdServer.

Author: hokein Date: Wed Sep 25 03:30:22 2019 New Revision: 372841 URL: http://llvm.org/viewvc/llvm-project?rev=372841&view=rev Log: [clangd] Move the existing heder-source-switch implemenation out of clangdServer. Summary: This is a NFC change. Reviewers: kadircet Reviewed By: kadircet Subsc

[PATCH] D67960: [clangd] Move the existing heder-source-switch implemenation out of clangdServer.

This revision was automatically updated to reflect the committed changes. Closed by commit rL372841: [clangd] Move the existing heder-source-switch implemenation out of… (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to co

r372844 - Revert r370850 "Re-commit r363191 "[MS] Pretend constexpr variable template specializations are inline""

Author: hans Date: Wed Sep 25 04:09:46 2019 New Revision: 372844 URL: http://llvm.org/viewvc/llvm-project?rev=372844&view=rev Log: Revert r370850 "Re-commit r363191 "[MS] Pretend constexpr variable template specializations are inline"" This work-around was necessary to handle standard library he

[PATCH] D63082: [Diagnostics] Added support for -Wint-in-bool-context

thakis added a comment. It looks like bits of this landed recently. I don't know which of the commits it was, so I'm commenting here: The -Wint-in-bool context that clang emits are very useful and have found several bugs in Chromium, with just one false positive (which was in confusing code, so

r372846 - Add a release note for r372844

Author: hans Date: Wed Sep 25 04:53:17 2019 New Revision: 372846 URL: http://llvm.org/viewvc/llvm-project?rev=372846&view=rev Log: Add a release note for r372844 Modified: cfe/trunk/docs/ReleaseNotes.rst Modified: cfe/trunk/docs/ReleaseNotes.rst URL: http://llvm.org/viewvc/llvm-project/cfe/

[PATCH] D67907: [clangd] Implement a smart version of HeaderSource switch.

hokein updated this revision to Diff 221724. hokein added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67907/new/ https://reviews.llvm.org/D67907 Files: clang-tools-extra/clangd/HeaderSourceSwitch.cpp clang-tools-extra/clang

[PATCH] D67961: [libTooling] Introduce the MatchConsumer abstraction

gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Tooling/Refactoring/MatchConsumer.h:9 +/// +/// /file This file defines the *MatchConsumer* abstraction: a computation over +/// mat

[PATCH] D67826: [clangd] A helper to find explicit references and their names

ilya-biryukov updated this revision to Diff 221728. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - s/Decl* S/Decl* D/g Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67826/new/ https://reviews.llvm.org/D67826 Files

[clang-tools-extra] r372859 - [clangd] A helper to find explicit references and their names

Author: ibiryukov Date: Wed Sep 25 05:40:22 2019 New Revision: 372859 URL: http://llvm.org/viewvc/llvm-project?rev=372859&view=rev Log: [clangd] A helper to find explicit references and their names Summary: Allows to simplify pending code tweaks: - the upcoming DefineInline tweak (D66647) - r

[PATCH] D67826: [clangd] A helper to find explicit references and their names

This revision was automatically updated to reflect the committed changes. Closed by commit rL372859: [clangd] A helper to find explicit references and their names (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit

[PATCH] D63607: [clang][driver] Add basic --driver-mode=flang support for fortran

peterwaller-arm added a comment. Hi All, I'm going on leave for two weeks, returning October 14th. I can plausibly respond to comments until 14:00 UTC tomorrow (Thu 25th Sept). As a quick note, another piece of the puzzle has been submitted for review at https://github.com/flang-compiler/f18/pu

[PATCH] D67969: [libTooling] Add `run` combinator to Stencils.

gribozavr added inline comments. Comment at: clang/include/clang/Tooling/Refactoring/Stencil.h:181 +/// This supports user-defined extensions to the Stencil language. +StencilPart run(MatchConsumer C); + We could reimplement all other stencils through `run()` and

[clang-tools-extra] r372860 - [clangd] Add missing header guard, NFC.

Author: hokein Date: Wed Sep 25 05:54:53 2019 New Revision: 372860 URL: http://llvm.org/viewvc/llvm-project?rev=372860&view=rev Log: [clangd] Add missing header guard, NFC. Modified: clang-tools-extra/trunk/clangd/FindTarget.h clang-tools-extra/trunk/clangd/HeaderSourceSwitch.h Modified:

[PATCH] D67969: [libTooling] Add `run` combinator to Stencils.

ymandel marked an inline comment as done. ymandel added inline comments. Comment at: clang/include/clang/Tooling/Refactoring/Stencil.h:181 +/// This supports user-defined extensions to the Stencil language. +StencilPart run(MatchConsumer C); + gribozavr wrote: >

[PATCH] D67961: [libTooling] Introduce the MatchConsumer abstraction

ymandel updated this revision to Diff 221733. ymandel marked 3 inline comments as done. ymandel added a comment. addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67961/new/ https://reviews.llvm.org/D67961 Files: clang/include/cl

[PATCH] D67961: [libTooling] Introduce the MatchConsumer abstraction

ymandel marked an inline comment as done. ymandel added inline comments. Comment at: clang/include/clang/Tooling/Refactoring/MatchConsumer.h:27 + +/// A central abstraction of the Transformer framework is computation over the +/// results of a match (represented by \c MatchFinder

r372863 - [AST] Extract Decl::printNestedNameSpecifier helper from Decl::printQualifiedName

Author: ibiryukov Date: Wed Sep 25 06:09:10 2019 New Revision: 372863 URL: http://llvm.org/viewvc/llvm-project?rev=372863&view=rev Log: [AST] Extract Decl::printNestedNameSpecifier helper from Decl::printQualifiedName Summary: To be used in clangd, e.g. in D66647. Currently the alternative to th

[PATCH] D67825: [AST] Extract Decl::printNestedNameSpecifier helper from Decl::printQualifiedName

This revision was automatically updated to reflect the committed changes. Closed by commit rL372863: [AST] Extract Decl::printNestedNameSpecifier helper from Decl… (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commi

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

hfinkel added a comment. This LGTM. I'm happy that this is a design improvement over the current scheme. @JonChesterfield , @ABataev , any further comments? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64943/new/ https://reviews.llvm.org/D64943 _

r372870 - [libTooling] Introduce the MatchConsumer abstraction

Author: ymandel Date: Wed Sep 25 06:34:04 2019 New Revision: 372870 URL: http://llvm.org/viewvc/llvm-project?rev=372870&view=rev Log: [libTooling] Introduce the MatchConsumer abstraction Summary: This revision introduces a separate (small) library for the `MatchConsumer` abstraction: computations

[PATCH] D67961: [libTooling] Introduce the MatchConsumer abstraction

This revision was automatically updated to reflect the committed changes. Closed by commit rL372870: [libTooling] Introduce the MatchConsumer abstraction (authored by ymandel, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

JonChesterfield added a comment. In D64943#1682452 , @hfinkel wrote: > This LGTM. I'm happy that this is a design improvement over the current > scheme. @JonChesterfield , @ABataev , any further comments? This patch mixes two concerns. 1/ Remove the li

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

ABataev added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3125 +ActionList DeviceAL; +for (auto *SB : SpecializedBuilders) { + if (!SB->isValid()) User real type instead of `auto *` Comment at: clang/lib/Driver/Driver.

[PATCH] D68020: [clangd] Fix parseNamespaceEvents to parse the last token

kadircet created this revision. kadircet added reviewers: hokein, ilya-biryukov. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68020 Files: clang-tools-extra/clangd/So

[PATCH] D63082: [Diagnostics] Added support for -Wint-in-bool-context

xbolva00 added a comment. Happy to hear :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63082/new/ https://reviews.llvm.org/D63082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D68020: [clangd] Fix parseNamespaceEvents to parse the last token

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/SourceCodeTests.cpp:429 +// Parse until EOF +namespace bar{})cpp", + {""}, ---

[PATCH] D68021: [IntrinsicEmitter] Add overloaded type VecOfBitcastsToInt for SVE intrinsics

kmclaughlin created this revision. kmclaughlin added reviewers: c-rhodes, sdesmalen, rovka. Herald added subscribers: jdoerfert, hiraditya, tschuett. Herald added a project: LLVM. This allows intrinsics such as the following to be defined: - declare @llvm.something.nxv4f32(, , ) ...where is de

[PATCH] D68020: [clangd] Fix parseNamespaceEvents to parse the last token

kadircet updated this revision to Diff 221759. kadircet added a comment. - Add empty string testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68020/new/ https://reviews.llvm.org/D68020 Files: clang-tools-extra/clangd/SourceCode.cpp clang-

[clang-tools-extra] r372875 - [clangd] Fix parseNamespaceEvents to parse the last token

Author: kadircet Date: Wed Sep 25 07:12:05 2019 New Revision: 372875 URL: http://llvm.org/viewvc/llvm-project?rev=372875&view=rev Log: [clangd] Fix parseNamespaceEvents to parse the last token Reviewers: hokein, ilya-biryukov Subscribers: MaskRay, jkorous, arphaman, usaxena95, cfe-commits Tags:

[PATCH] D68020: [clangd] Fix parseNamespaceEvents to parse the last token

This revision was automatically updated to reflect the committed changes. Closed by commit rL372875: [clangd] Fix parseNamespaceEvents to parse the last token (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: h

[PATCH] D68023: [AArch64][SVE] Implement int_aarch64_sve_cnt intrinsic

kmclaughlin created this revision. kmclaughlin added reviewers: c-rhodes, sdesmalen, rovka. Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a project: LLVM. kmclaughlin added a parent revision: D68021: [IntrinsicEmitter] Add overloaded type VecOfBitcasts

Re: r372863 - [AST] Extract Decl::printNestedNameSpecifier helper from Decl::printQualifiedName

Is it possible that this broke Tooling/clang-diff-ast.cpp http://lab.llvm.org:8011/builders/clang-cmake-x86_64-avx2-linux/builds/11395/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Aclang-diff-ast.cpp ? On Wed, Sep 25, 2019 at 9:07 AM Ilya Biryukov via cfe-commits < cfe-commits@lists.llvm.org>

[PATCH] D68024: [clangd] Implement GetEligibleRegions

kadircet created this revision. kadircet added reviewers: hokein, ilya-biryukov. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. This is an helper for incoming move definition out-of-line action to figure out possible insertion locations

[PATCH] D68026: [clangd] Add missing header guard, NFC.

hokein created this revision. hokein added a reviewer: gribozavr. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. [clang-tidy] Make llvm-header-guard work on llvm git monorepo. Repository: rG LLVM Github Monorepo https:

[PATCH] D68026: [clangd] Add missing header guard, NFC.

hokein updated this revision to Diff 221765. hokein added a comment. upload correct diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68026/new/ https://reviews.llvm.org/D68026 Files: clang-tools-extra/clang-tidy/llvm/HeaderGuardCheck.cpp cl

[PATCH] D68027: [clangd] Change constness of parameters to findExplicitRefs

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. Recursive AST requires non-const ast nodes, but it doesn't really mutate them. In addition to that, in clangd we mo

[PATCH] D68028: [clang] Add no_builtin attribute

gchatelet created this revision. gchatelet added reviewers: tejohnson, courbet, theraven, t.p.northover, jdoerfert. Herald added subscribers: cfe-commits, mgrang. Herald added a project: clang. This is a follow up on https://reviews.llvm.org/D61634 This patch is simpler and only adds the no_built

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema for arrays

ABataev added a comment. Definitely need positive tests with ast printing and codegen. Comment at: lib/Sema/SemaOpenMP.cpp:14751 +assert(Type->getAsArrayTypeUnsafe() && "Expect to get a valid array type"); +Type = Type->getAsArrayTypeUnsafe()->getElementType().getCanoni

[PATCH] D61634: [clang/llvm] Allow efficient implementation of libc's memory functions in C/C++

gchatelet added a comment. In D61634#1679331 , @tejohnson wrote: > In D61634#1635595 , @tejohnson wrote: > > > I had some time to work on this finally late last week. I decided the most > > straightforward thing wa

[PATCH] D67969: [libTooling] Add `run` combinator to Stencils.

gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Tooling/Refactoring/Stencil.h:181 +/// This supports user-defined extensions to the Stencil language. +StencilPart run(MatchConsumer

r372880 - Revert r372863: [AST] Extract Decl::printNestedNameSpecifier helper from Decl::printQualifiedName

Author: ibiryukov Date: Wed Sep 25 07:50:12 2019 New Revision: 372880 URL: http://llvm.org/viewvc/llvm-project?rev=372880&view=rev Log: Revert r372863: [AST] Extract Decl::printNestedNameSpecifier helper from Decl::printQualifiedName Reason: causes a test failure, will investigate and re-land wi

[PATCH] D67748: [clangd] Add a helper for extracting nonlocal decls in a FunctionDecl

kadircet updated this revision to Diff 221772. kadircet added a comment. - Use Decl overload of findExplicitReferences Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67748/new/ https://reviews.llvm.org/D67748 Files: clang-tools-extra/clangd/XRefs

r372884 - [NFC] Fix typo in `getPreviousDecl` comment.

Author: ymandel Date: Wed Sep 25 07:58:39 2019 New Revision: 372884 URL: http://llvm.org/viewvc/llvm-project?rev=372884&view=rev Log: [NFC] Fix typo in `getPreviousDecl` comment. Modified: cfe/trunk/include/clang/AST/DeclBase.h Modified: cfe/trunk/include/clang/AST/DeclBase.h URL: http://ll

[PATCH] D68029: [ThinLTO] Enable index-only WPD from clang

tejohnson created this revision. tejohnson added a reviewer: pcc. Herald added subscribers: arphaman, dexonsmith, steven_wu, inglorion, mehdi_amini. Herald added a project: clang. To trigger the index-only Whole Program Devirt support added to LLVM, we need to be able to specify -fno-split-lto-un

[PATCH] D68027: [clangd] Change constness of parameters to findExplicitRefs

ilya-biryukov added a comment. Who are the callers? Selection tree? FWIW, I'd rather pass non-const everywhere, the concept of const-ness is just not very useful for AST nodes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68027/new/ https://revie

[PATCH] D68030: [CUDA][HIP] Initial kernel return type relaxing.

hliao created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. hliao abandoned this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68030 Files: clang/lib/Sema/SemaDeclAttr.cpp clang/lib/Sema/SemaExpr.cpp clang/lib/Sema/SemaStm

[PATCH] D68028: [clang] Add no_builtin attribute

aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. Thank you for working on this! It looks like you're missing all of the sema tests that check that the attribute only appertains to functions, accepts the proper kind of arguments, etc. Comment at:

[PATCH] D68027: [clangd] Change constness of parameters to findExplicitRefs

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. @kadircet says we're using this pattern all over clangd. This somehow slipped my view before. LGTM to be consistent with the rest of clangd (and functions in `FindTarget.h`). I t

[PATCH] D68031: [CUDA][HIP] Enable kernel function return type deduction.

hliao created this revision. hliao added reviewers: tra, jlebar. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Even though only `void` is still accepted as the deduced return type, enabling deduction/instantiation on the return type allows more consistent coding. Rep

[clang-tools-extra] r372888 - [clangd] Change constness of parameters to findExplicitRefs

Author: kadircet Date: Wed Sep 25 08:44:26 2019 New Revision: 372888 URL: http://llvm.org/viewvc/llvm-project?rev=372888&view=rev Log: [clangd] Change constness of parameters to findExplicitRefs Summary: Recursive AST requires non-const ast nodes, but it doesn't really mutate them. In addition to

[PATCH] D68027: [clangd] Change constness of parameters to findExplicitRefs

This revision was automatically updated to reflect the committed changes. Closed by commit rL372888: [clangd] Change constness of parameters to findExplicitRefs (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r372889 - Re-land r372863: [AST] Extract Decl::printNestedNameSpecifier helper from Decl::printQualifiedName

Author: ibiryukov Date: Wed Sep 25 08:46:04 2019 New Revision: 372889 URL: http://llvm.org/viewvc/llvm-project?rev=372889&view=rev Log: Re-land r372863: [AST] Extract Decl::printNestedNameSpecifier helper from Decl::printQualifiedName Reverted in r372880 due to the test failure. Also contains a

Re: r372863 - [AST] Extract Decl::printNestedNameSpecifier helper from Decl::printQualifiedName

Reverted and re-landed with a fix to this. This should've been an NFC, but I missed one corner case. Sorry about that. On Wed, Sep 25, 2019 at 4:22 PM Nico Weber wrote: > Is it possible that this broke Tooling/clang-diff-ast.cpp > http://lab.llvm.org:8011/builders/clang-cmake-x86_64-avx2-linux/b

[PATCH] D63640: [clang] Improve Serialization/Imporing/Dumping of APValues

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/APValue.h:613 + /// in place as after importing/deserializating then. + void reserveVector(unsigned N) { +assert(isVector() && "Invalid accessor"); `ReserveVector` C

[PATCH] D67901: [clangd] Improve semantic highlighting in dependent contexts (fixes #154)

nridge marked 2 inline comments as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:181 + addToken(E->getMemberLoc(), E->getQualifier() + ? HighlightingKind::StaticField +

[PATCH] D67919: [Diagnostics] Warn if enumeration type mismatch in conditional expression

aaron.ballman added inline comments. Comment at: lib/Sema/SemaChecking.cpp:11264 + + const EnumType *LHSEnumType = LHSStrippedType->getAs(); + if (!LHSEnumType) `const auto *` (and below as well) since the type is spelled out in the initialization. =

[PATCH] D68031: [CUDA][HIP] Enable kernel function return type deduction.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Nice. I'd mention in the commit message that NVCC does not support deduced return type for kernel functions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

r372898 - [CUDA][HIP] Enable kernel function return type deduction.

Author: hliao Date: Wed Sep 25 09:51:45 2019 New Revision: 372898 URL: http://llvm.org/viewvc/llvm-project?rev=372898&view=rev Log: [CUDA][HIP] Enable kernel function return type deduction. Summary: - Even though only `void` is still accepted as the deduced return type, enabling deduction/insta

[PATCH] D68031: [CUDA][HIP] Enable kernel function return type deduction.

This revision was automatically updated to reflect the committed changes. Closed by commit rG24337db61666: [CUDA][HIP] Enable kernel function return type deduction. (authored by hliao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68031/new/ https:

[PATCH] D68031: [CUDA][HIP] Enable kernel function return type deduction.

hliao added a comment. In D68031#1682822 , @tra wrote: > Nice. I'd mention in the commit message that NVCC does not support deduced > return type for kernel functions. Just tried with NVCC from CUDA 10, except auto-based deduced type is not supported,

[PATCH] D67774: [Mangle] Add flag to asm labels to disable '\01' prefixing

vsk updated this revision to Diff 221801. vsk added a comment. - Add a comment describing where non-literal labels are used. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67774/new/ https://reviews.llvm.org/D67774 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/A

[PATCH] D67774: [Mangle] Add flag to asm labels to disable '\01' prefixing

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67774/new/ https://reviews.llvm.org/D67774 ___ cfe-commits mailing list

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67031/new/ https://reviews.llvm.org/D67031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r372903 - [Mangle] Add flag to asm labels to disable '\01' prefixing

Author: vedantk Date: Wed Sep 25 11:00:31 2019 New Revision: 372903 URL: http://llvm.org/viewvc/llvm-project?rev=372903&view=rev Log: [Mangle] Add flag to asm labels to disable '\01' prefixing LLDB synthesizes decls using asm labels. These decls cannot have a mangle different than the one specifi

[PATCH] D67774: [Mangle] Add flag to asm labels to disable '\01' prefixing

This revision was automatically updated to reflect the committed changes. Closed by commit rL372903: [Mangle] Add flag to asm labels to disable '\01' prefixing (authored by vedantk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: h

Re: r369999 - Don't lose the FoundDecl and template arguments for a DeclRefExpr in

Hi Richard, it looks like this commit caused an assertion failure on the following input: $ cat test2.ii # 2 "" 3 namespace a { enum { b }; } template void c() { auto d = [](auto) { using a::b; b; }; d(0); } void e() { c; } $ clang test2.ii clang: ../clang/lib/Sema/SemaTemplateInsta

[PATCH] D66437: Sema: Create a no-op implicit cast for lvalue function conversions.

pcc added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66437/new/ https://reviews.llvm.org/D66437 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

RE: r370123 - [preprocessor] Add an opportunity to retain excluded conditional blocks

-Original Message- From: cfe-commits On Behalf Of Evgeny Mankov via cfe-commits Sent: Tuesday, August 27, 2019 3:16 PM To: cfe-commits@lists.llvm.org Subject: [EXT] r370123 - [preprocessor] Add an opportunity to retain excluded conditional blocks Added: cfe/trunk/test/Index/retain-exclu

[PATCH] D67969: [libTooling] Add `run` combinator to Stencils.

ymandel marked 4 inline comments as done. ymandel added a comment. Thanks for the review! Comment at: clang/include/clang/Tooling/Refactoring/Stencil.h:181 +/// This supports user-defined extensions to the Stencil language. +StencilPart run(MatchConsumer C); +

r372917 - [OPENMP50]Parsing/sema support for 'implementation/vendor' context

Author: abataev Date: Wed Sep 25 12:43:37 2019 New Revision: 372917 URL: http://llvm.org/viewvc/llvm-project?rev=372917&view=rev Log: [OPENMP50]Parsing/sema support for 'implementation/vendor' context selector. Added basic parsing/semantic support for 'implementation={vendor()}' context selector.

r372918 - [libTooling][NFC] Switch StencilTest.cpp to use EXPECT_THAT_EXPECTED

Author: ymandel Date: Wed Sep 25 13:04:25 2019 New Revision: 372918 URL: http://llvm.org/viewvc/llvm-project?rev=372918&view=rev Log: [libTooling][NFC] Switch StencilTest.cpp to use EXPECT_THAT_EXPECTED Summary: Currently, some tests use homegrown matchers to handle `llvm::Expected` values. This

[PATCH] D67973: [libTooling][NFC] Switch StencilTest.cpp to use EXPECT_THAT_EXPECTED

This revision was automatically updated to reflect the committed changes. Closed by commit rL372918: [libTooling][NFC] Switch StencilTest.cpp to use EXPECT_THAT_EXPECTED (authored by ymandel, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to c

[PATCH] D68049: Propeller: Clang options for basic block sections

tmsriram created this revision. tmsriram added a reviewer: rnk. Herald added a project: clang. Options for basic block sections, unique internal linkage function names. This is part of the Propeller framework to do post link code layout optimizations. Please see the RFC here: https://groups.go

r372919 - [clang-format] Modified SortIncludes and IncludeCategories to priority for sorting #includes within the Group Category.

Author: paulhoad Date: Wed Sep 25 13:33:01 2019 New Revision: 372919 URL: http://llvm.org/viewvc/llvm-project?rev=372919&view=rev Log: [clang-format] Modified SortIncludes and IncludeCategories to priority for sorting #includes within the Group Category. Summary: This new Style rule is made as a

[PATCH] D64695: [clang-format] Modified SortIncludes and IncludeCategories to priority for sorting #includes within the Group Category.

This revision was automatically updated to reflect the committed changes. Closed by commit rL372919: [clang-format] Modified SortIncludes and IncludeCategories to priority for… (authored by paulhoad, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pr

[PATCH] D67837: [CUDA][HIP] Fix assertion in Sema::markKnownEmitted with -fopenmp

yaxunl updated this revision to Diff 221829. yaxunl edited the summary of this revision. yaxunl added a comment. Unify CUDA/HIP/OpenMP host/device check. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67837/new/ https://reviews.llvm.org/D67837 Files: include/clang/Sema/Sema.h lib/Se

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema for arrays

lildmh marked an inline comment as done. lildmh added a comment. HI Alexey, the ast print test is already there. Because I didn't check the mapper for array type before, such code will always not report any error, and ast print test is correct. Codegen test belongs to the other patch I released.

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema for arrays

ABataev added a comment. In D67978#1683146 , @lildmh wrote: > HI Alexey, the ast print test is already there. Because I didn't check the > mapper for array type before, such code will always not report any error, and > ast print test is correct. Codegen

[PATCH] D68052: [clang-scan-deps] Allow continuation line backslashes followed by whitespace in the dependency source minimizer

arphaman created this revision. arphaman added reviewers: dexonsmith, Bigcheese, kousikk, aganea. Herald added subscribers: ributzka, tschuett, jkorous. Herald added a project: clang. Clang allows continuations that have whitespace between the backslash and the newline. This patch ensures that th

[PATCH] D65744: [PR42707][OpenCL] Fix addr space deduction for auto

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:5998 +QualType Type = Var->getType(); +if (Type->isSamplerT() || Type->isVoidType()) + return; Anastasia wrote: > I don't seem to need a check for dependent or auto types because

  1   2   >