kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks, lgtm!
================
Comment at: clang-tools-extra/clangd/HeaderSourceSwitch.cpp:21
+ llvm::IntrusiveRefCntPtr<llvm::vfs::FileSystem> VFS) {
+ // FIXME: move the file heuristic to HeaderSourceSwitch.h.
+ llvm::StringRef SourceExtensions[] = {".cpp", ".c", ".cc", ".cxx",
----------------
this patch is fixing it ?
================
Comment at: clang-tools-extra/clangd/HeaderSourceSwitch.h:15
+/// Given a header file, returns a best matching source file, and vice visa.
+/// It only uses the filename heuristics to do the inference.
----------------
nit: s/a best/the best
================
Comment at: clang-tools-extra/clangd/HeaderSourceSwitch.h:21
+
/// Given a header file, returns a best matching source file, and vice visa.
/// The heuristics incorporate with the AST and the index (if provided).
----------------
nit: s/a best/the best
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67960/new/
https://reviews.llvm.org/D67960
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
