[PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

balazske added inline comments. Comment at: clang/unittests/AST/ASTImporterODRStrategiesTest.cpp:274 +// There may be a hidden fwd spec decl before a function spec decl. +if (auto *PrevF = dyn_cast(ImportedD)) { + if (PrevF->getTemplatedKind() == Thi

[PATCH] D67541: [ClangFormat] Future-proof Standard option, allow floating or pinning to arbitrary lang version

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67541/new/ https://reviews.llvm.org/D67541 ___ c

[PATCH] D67606: Change signature of __builtin_rotateright64 back to unsigned

Ka-Ka created this revision. Ka-Ka added a reviewer: efriedma. Herald added a subscriber: kristina. Herald added a project: clang. The signature of __builtin_rotateright64 was by misstake changed from unsigned to signed in r360863, this patch will change it back to unsigned as intended. This fixe

[PATCH] D67341: [clangd] Simplify semantic highlighting visitor

ilya-biryukov added a comment. @hokein, do you want to do another round or is this good to go? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67341/new/ https://reviews.llvm.org/D67341 ___ cfe-commits m

[PATCH] D67606: Change signature of __builtin_rotateright64 back to unsigned

hans added a comment. A simpler way to test this might be to check for conversion warnings in the existing clang/test/CodeGen/avr-builtins.c test, for example like as above. I think that's better since it covers more of the signatures, e.g. the rotateleft ones too. diff --git a/clang/test/Co

[PATCH] D67607: [clangd] Fix a crash when renaming operator.

hokein updated this revision to Diff 220289. hokein added a comment. Fix an accident change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67607/new/ https://reviews.llvm.org/D67607 Files: clang-tools-extra/clangd/refactor/Rename.cpp clang-too

[PATCH] D67607: [clangd] Fix a crash when renaming operator.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. hokein retitled this revision from "clangd] Fix a crash when renaming operator." to "[clangd] Fix a crash when renaming operator.". h

[PATCH] D67135: [clang-tidy] performance-inefficient-vector-operation: Support proto repeated field

This revision was automatically updated to reflect the committed changes. Closed by commit rL371963: [clang-tidy] performance-inefficient-vector-operation: Support proto repeated… (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[clang-tools-extra] r371963 - [clang-tidy] performance-inefficient-vector-operation: Support proto repeated field

Author: hokein Date: Mon Sep 16 01:54:10 2019 New Revision: 371963 URL: http://llvm.org/viewvc/llvm-project?rev=371963&view=rev Log: [clang-tidy] performance-inefficient-vector-operation: Support proto repeated field Summary: Finds calls that add element to protobuf repeated field in a loop with

[PATCH] D67358: [clangd] Implement semantic selections.

sammccall added a comment. In D67358#1670810 , @nridge wrote: > Which LSP feature is this related to? selectionRange: - https://github.com/microsoft/vscode-languageserver-node/blob/master/protocol/src/protocol.selectionRange.ts - https://github.com/mic

[PATCH] D67135: [clang-tidy] performance-inefficient-vector-operation: Support proto repeated field

hokein added a comment. In D67135#1669836 , @congliu wrote: > Could someone commit this for me? I failed to commit this change... Committed in rL371963 , just curious why you failed to commit? if you are using llvm git

[PATCH] D67607: [clangd] Fix a crash when renaming operator.

ilya-biryukov added a comment. LGTM to fix the crash. See the comment about more cases that could potentially break, though. Do we handle them gracefully now? Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:77 return ReasonToReject::UnsupportedSymbol; + if (cons

[PATCH] D67608: [ARM] Preserve fpu behaviour for '-crypto'

dnsampaio created this revision. dnsampaio added reviewers: peter.smith, labrinea. Herald added subscribers: cfe-commits, dmgreen, kristof.beyls. Herald added a project: clang. This patch restores the behaviour that -fpu overwrites the architecture obtained from -march or -mcpu flags, not enforcin

[PATCH] D66524: [SVE][Inline-Asm] Add constraints for SVE predicate registers

rovka accepted this revision. rovka added a comment. This revision is now accepted and ready to land. I think all the outstanding comments have been addressed. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66524/new/ https://reviews.llvm.org/D66524 _

[PATCH] D67606: Change signature of __builtin_rotateright64 back to unsigned

Ka-Ka updated this revision to Diff 220294. Ka-Ka added a comment. Herald added subscribers: Jim, dylanmckay. Update testcases according to review comment. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67606/new/ https://reviews.llvm.org/D67606 Files: include/

[PATCH] D67467: [ARM] Update clang for removal of vfp2d16 and vfp2d16sp

ostannard accepted this revision. ostannard added a comment. This revision is now accepted and ready to land. Herald added a subscriber: dmgreen. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67467/new/ https://reviews.llvm.org/D67467

[PATCH] D67606: Change signature of __builtin_rotateright64 back to unsigned

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Looks good to me! (with comment) Comment at: test/CodeGen/avr-builtins.c:3 +// Check that the parameter types match. +// RUN: %clang_cc1 -triple avr-unknown-unknown -Wconversio

[PATCH] D67368: [NFCI]Create CommonAttributeInfo Type as base type of *Attr and ParsedAttr.

SjoerdMeijer added a comment. I would have definitely preferred a revert much earlier, I guess it's too late now, but not having a build is really inconvenient. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67368/new/ https://reviews.llvm.org/D67368 __

[clang-tools-extra] r371968 - Fix the rst doc, unbreak buildbot.

Author: hokein Date: Mon Sep 16 02:46:53 2019 New Revision: 371968 URL: http://llvm.org/viewvc/llvm-project?rev=371968&view=rev Log: Fix the rst doc, unbreak buildbot. Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/performance-inefficient-vector-operation.rst Modified: clang-tool

[PATCH] D66524: [SVE][Inline-Asm] Add constraints for SVE predicate registers

This revision was automatically updated to reflect the committed changes. Closed by commit rL371967: [SVE][Inline-Asm] Add constraints for SVE predicate registers (authored by kmclaughlin, committed by ). Changed prior to commit: https://reviews.llvm.org/D66524?vs=219526&id=220299#toc Reposito

r371969 - Change signature of __builtin_rotateright64 back to unsigned

Author: karka Date: Mon Sep 16 02:52:23 2019 New Revision: 371969 URL: http://llvm.org/viewvc/llvm-project?rev=371969&view=rev Log: Change signature of __builtin_rotateright64 back to unsigned The signature of __builtin_rotateright64 was by misstake changed from unsigned to signed in r360863, thi

[PATCH] D67606: Change signature of __builtin_rotateright64 back to unsigned

This revision was automatically updated to reflect the committed changes. Closed by commit rL371969: Change signature of __builtin_rotateright64 back to unsigned (authored by karka, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: h

[PATCH] D67607: [clangd] Fix a crash when renaming operator.

hokein marked 2 inline comments as done. hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:77 return ReasonToReject::UnsupportedSymbol; + if (const auto *FD = llvm::dyn_cast(&RenameDecl)) { +if (FD->isOverloadedOperator()) --

[clang-tools-extra] r371971 - [clangd] Fix a crash when renaming operator.

Author: hokein Date: Mon Sep 16 03:16:56 2019 New Revision: 371971 URL: http://llvm.org/viewvc/llvm-project?rev=371971&view=rev Log: [clangd] Fix a crash when renaming operator. Summary: The renamelib uses a tricky way to calculate the end location by relying on decl name, this is incorrect for t

r371971 - [clangd] Fix a crash when renaming operator.

Author: hokein Date: Mon Sep 16 03:16:56 2019 New Revision: 371971 URL: http://llvm.org/viewvc/llvm-project?rev=371971&view=rev Log: [clangd] Fix a crash when renaming operator. Summary: The renamelib uses a tricky way to calculate the end location by relying on decl name, this is incorrect for t

[PATCH] D67607: [clangd] Fix a crash when renaming operator.

This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rGaf28bb65023e: [clangd] Fix a crash when renaming operator. (authored by hokein). Herald added a subscriber: usaxena95. Repository: rG LLVM Github Monorepo CHANG

[PATCH] D67358: [clangd] Implement semantic selections.

usaxena95 updated this revision to Diff 220303. usaxena95 marked 3 inline comments as done. usaxena95 added a comment. Resolved comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67358/new/ https://reviews.llvm.org/D67358 Files: clang-tools

[PATCH] D66716: [analyzer] PR43102: Fix an assertion and an out-of-bounds error for diagnostic location construction

TWeaver added a comment. Hi there, just checking in, is this patch still going ahead? thanks Tom W Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66716/new/ https://reviews.llvm.org/D66716 ___ cfe-com

[PATCH] D67358: [clangd] Implement semantic selections.

This revision was automatically updated to reflect the committed changes. Closed by commit rL371976: Implement semantic selections. (authored by usaxena95, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D6

[clang-tools-extra] r371976 - Implement semantic selections.

Author: usaxena95 Date: Mon Sep 16 04:29:35 2019 New Revision: 371976 URL: http://llvm.org/viewvc/llvm-project?rev=371976&view=rev Log: Implement semantic selections. Summary: For a given cursor position, it returns ranges that are interesting to the user. Currently the semantic ranges correspond

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

SouraVX created this revision. SouraVX added reviewers: aprantl, dblaikie. SouraVX added a project: debug-info. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch provides support for DW_LANG_C_plus_plus_11, DW_LANG_C_plus_plus_14 tags in clang C++ frontend. Repos

[PATCH] D66716: [analyzer] PR43102: Fix an assertion and an out-of-bounds error for diagnostic location construction

Szelethus added a comment. In D66716#1671105 , @TWeaver wrote: > Hi there, > > just checking in, is this patch still going ahead? > > thanks > Tom W Unfortunately, it seems like the correct solution is a bit more complex than these if branches, so it m

[PATCH] D66716: [analyzer] PR43102: Fix an assertion and an out-of-bounds error for diagnostic location construction

Szelethus added a comment. While we're there, could you please see whether the included test case (note how condition tracking is turned off) fails on your platform without the rest of the patch applied (it definitely does on mine, which is why I was surprised to see this bug report pop up only

[clang-tools-extra] r371980 - [clangd] Bump vscode-clangd v0.0.17

Author: hokein Date: Mon Sep 16 05:51:07 2019 New Revision: 371980 URL: http://llvm.org/viewvc/llvm-project?rev=371980&view=rev Log: [clangd] Bump vscode-clangd v0.0.17 CHANGELOG: - added semantic highlighting support (under the clangd.semanticHighlighting flag); - better error message when cla

[PATCH] D67368: [NFCI]Create CommonAttributeInfo Type as base type of *Attr and ParsedAttr.

erichkeane marked an inline comment as done. erichkeane added inline comments. Comment at: cfe/trunk/include/clang/Basic/AttributeCommonInfo.h:166 + ? SpellingIndex + : calculateAttributeSpellingListIndex(); + } plotfi wrote: > erichk

[PATCH] D67608: [ARM] Preserve fpu behaviour for '-crypto'

peter.smith added a comment. After retesting on a failing example and experimenting a bit, I think that we should only preserve +crypto with -fno-integrated-as. It would also be good to mention D66018 and maybe add the original author as a reviewer.

r371985 - Move some definitions from Sema to Basic to fix shared libs build

Author: erichkeane Date: Mon Sep 16 06:58:59 2019 New Revision: 371985 URL: http://llvm.org/viewvc/llvm-project?rev=371985&view=rev Log: Move some definitions from Sema to Basic to fix shared libs build r371875 moved some functionality around to a Basic header file, but didn't move its definition

[PATCH] D67368: [NFCI]Create CommonAttributeInfo Type as base type of *Attr and ParsedAttr.

erichkeane added a comment. Fixed in r371985. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67368/new/ https://reviews.llvm.org/D67368 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang-tools-extra] r371986 - [clangd][vscode] update the development doc.

Author: hokein Date: Mon Sep 16 07:03:06 2019 New Revision: 371986 URL: http://llvm.org/viewvc/llvm-project?rev=371986&view=rev Log: [clangd][vscode] update the development doc. Modified: clang-tools-extra/trunk/clangd/clients/clangd-vscode/DEVELOPING.md Modified: clang-tools-extra/trunk/cla

[PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

martong updated this revision to Diff 220338. martong marked 2 inline comments as done. martong added a comment. - PrevF->ImportedF, remove braces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66951/new/ https://reviews.llvm.org/D66951 Files: cl

[PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

martong added inline comments. Comment at: clang/unittests/AST/ASTImporterODRStrategiesTest.cpp:274 +// There may be a hidden fwd spec decl before a function spec decl. +if (auto *PrevF = dyn_cast(ImportedD)) { + if (PrevF->getTemplatedKind() == bala

[PATCH] D67621: [libTooling] Add `ifBound`, `elseBranch` RangeSelector combinators.

ymandel created this revision. ymandel added a reviewer: gribozavr. Herald added a project: clang. Adds two new combinators and corresponding tests to the RangeSelector library. - `ifBound` -- conditional evaluation of range-selectors, based on whether a given node id is bound in the match. - `e

[PATCH] D67545: [clang-tidy] Added DefaultOperatorNewCheck.

lebedev.ri added a comment. Some thoughts: 1. Docs missing 2. How does this play with C++17 aligned new? Assuming compiler/library support for that isn't broken ('bye, OSX!', ?), i'm not sure why it would be UB for C++17, see https://godbolt.org/z/kwxRbu vs https://godbolt.org/z/om-bR2 3. I'm n

[PATCH] D67545: [clang-tidy] Added DefaultOperatorNewCheck.

martong added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/DefaultOperatorNewCheck.cpp:26 + + if (NewExpr->getNumPlacementArgs() > 0) +return; Perhaps we should add in the docs that placement new is not supported. Or add a fixme here. Anyw

[PATCH] D67341: [clangd] Simplify semantic highlighting visitor

This revision was automatically updated to reflect the committed changes. Closed by commit rL372008: [clangd] Simplify semantic highlighting visitor (authored by ibiryukov, committed by ). Herald added subscribers: llvm-commits, usaxena95. Herald added a project: LLVM. Changed prior to commit:

[clang-tools-extra] r372008 - [clangd] Simplify semantic highlighting visitor

Author: ibiryukov Date: Mon Sep 16 09:16:03 2019 New Revision: 372008 URL: http://llvm.org/viewvc/llvm-project?rev=372008&view=rev Log: [clangd] Simplify semantic highlighting visitor Summary: - Functions to compute highlighting kinds for things are separated from the ones that add highlighting

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

jrtc27 added inline comments. Comment at: llvm/trunk/include/llvm/IR/DiagnosticInfo.h:79 + DK_FirstPluginKind, + DK_MisExpect }; Is this not going to clash with the first caller to `getNextAvailablePluginDiagnosticKind`? `DK_FirstPluginKind` is special and s

[PATCH] D67549: [IntrinsicEmitter] Add overloaded types for SVE intrinsics (Subdivide2 & Subdivide4)

rovka added inline comments. Comment at: include/llvm/IR/DerivedTypes.h:515 + else +VTy = VectorType::getTruncatedElementVectorType(VTy); +} Why not move this logic to getTruncatedElementVectorType and drop getNarrowerFpElementVectorType altoget

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

aprantl added inline comments. Comment at: include/clang/AST/DeclCXX.h:2931 +lang_cxx_11 = /* DW_LANG_C_plus_plus_11 */ 0x001a, +lang_cxx_14 = /* DW_LANG_C_plus_plus_14 */ 0x0021 }; I understand that DWARF does not define a C++17 language constant, but

[PATCH] D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage

mwyman added a comment. In D67567#1670264 , @NoQ wrote: > FTR, we already have a similar Static Analyzer check, eg.: > > https://github.com/llvm-mirror/clang/blob/release_80/test/Analysis/dispatch-once.m#L15 > > https://github.com/llvm-mirror/clang/blo

r372011 - [OPENMP]Fix parsing/sema for function templates with declare simd.

Author: abataev Date: Mon Sep 16 10:06:31 2019 New Revision: 372011 URL: http://llvm.org/viewvc/llvm-project?rev=372011&view=rev Log: [OPENMP]Fix parsing/sema for function templates with declare simd. Need to return original declaration group with FunctionTemplateDecl, not the inner FunctionDecl,

[PATCH] D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage

lebedev.ri added a comment. In D67567#1671499 , @mwyman wrote: > In D67567#1670264 , @NoQ wrote: > > > FTR, we already have a similar Static Analyzer check, eg.: > > > > https://github.com/llvm-mirror/clang/blob/r

[PATCH] D67247: Added missing unqualified name lookup of operator overloads for fold expressions

jonathanmeier added a comment. ping @rsmith Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67247/new/ https://reviews.llvm.org/D67247 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage

mwyman updated this revision to Diff 220357. mwyman edited the summary of this revision. mwyman added a comment. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous. Migrated check to new `darwin` module. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67567/new/ https://revi

r372014 - [Clang][Codegen] Relax available-externally-suppress.c test

Author: lebedevri Date: Mon Sep 16 10:46:01 2019 New Revision: 372014 URL: http://llvm.org/viewvc/llvm-project?rev=372014&view=rev Log: [Clang][Codegen] Relax available-externally-suppress.c test That test is broken by design. It depends on llvm middle-end behavior. No clang codegen test should b

r372015 - [Clang][Codegen] Disable arm_acle.c test.

Author: lebedevri Date: Mon Sep 16 10:46:08 2019 New Revision: 372015 URL: http://llvm.org/viewvc/llvm-project?rev=372015&view=rev Log: [Clang][Codegen] Disable arm_acle.c test. This test is broken by design. Clang codegen tests should not depend on llvm middle-end behaviour, they should *only* t

[PATCH] D67627: Clang-format: Add Whitesmiths indentation style

timwoj created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds support for the Whitesmiths indentation style to clang-format. It’s an update to a patch submitted in 2015 (D6833 ), but reworks it to use the newe

[PATCH] D41217: [Concepts] Concept Specialization Expressions

rsmith marked an inline comment as done. rsmith added inline comments. Comment at: include/clang/Sema/Sema.h:5904 + Expr *ConstraintExpr, + bool &IsSatisfied); + (Nit: please align th

Re: r372015 - [Clang][Codegen] Disable arm_acle.c test.

CodeGen/ARM/CGP/arm-gcp-casts.ll is broken too. On Mon, Sep 16, 2019 at 1:44 PM Roman Lebedev via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: lebedevri > Date: Mon Sep 16 10:46:08 2019 > New Revision: 372015 > > URL: http://llvm.org/viewvc/llvm-project?rev=372015&view=rev > Log: >

Re: r372015 - [Clang][Codegen] Disable arm_acle.c test.

Oh, that looked like it was due to r372012 but apparently it wasn't. Fixed in r372019. Sorry for the breakage. Roman On Mon, Sep 16, 2019 at 9:11 PM Nico Weber wrote: > > CodeGen/ARM/CGP/arm-gcp-casts.ll is broken too. > > On Mon, Sep 16, 2019 at 1:44 PM Roman Lebedev via cfe-commits > wrote:

[PATCH] D67590: Properly ignore mismatched exception specifiers in MSVC Compat mode.

rnk added inline comments. Comment at: lib/Sema/SemaDecl.cpp:3565-3572 +if (OldQTypeForComparison == NewQType || +// In Microsoft compatibility mode, the intent is to only warn on +// mismatched exception specifiers. By this point, that warning has +/

Re: r372015 - [Clang][Codegen] Disable arm_acle.c test.

Bots look happy again. Thanks for the quick fix :) On Mon, Sep 16, 2019 at 2:27 PM Roman Lebedev wrote: > Oh, that looked like it was due to r372012 but apparently it wasn't. > Fixed in r372019. > Sorry for the breakage. > > Roman > > On Mon, Sep 16, 2019 at 9:11 PM Nico Weber wrote: > > > > Co

[PATCH] D67590: Properly ignore mismatched exception specifiers in MSVC Compat mode.

alexfusco updated this revision to Diff 220367. alexfusco added a comment. Updated to unconditionally ignore the exception spec here, since it has already been compared. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67590/new/ https://reviews.llvm.org/D67590 Fi

r372026 - do not emit -Wunused-macros warnings in -frewrite-includes mode (PR15614)

Author: llunak Date: Mon Sep 16 12:18:37 2019 New Revision: 372026 URL: http://llvm.org/viewvc/llvm-project?rev=372026&view=rev Log: do not emit -Wunused-macros warnings in -frewrite-includes mode (PR15614) -frewrite-includes calls PP.SetMacroExpansionOnlyInDirectives() to avoid macro expansions

[PATCH] D53768: Add VerboseOutputStream to CompilerInstance

scott.linder updated this revision to Diff 220369. scott.linder edited the summary of this revision. scott.linder added reviewers: ddunbar, aprantl, cfang, dblaikie. scott.linder added a comment. Rebase and ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53768/new/ https://reviews.ll

[PATCH] D65371: do not emit -Wunused-macros warnings in -frewrite-includes mode (PR15614)

This revision was automatically updated to reflect the committed changes. Closed by commit rGa507a5ec8f1d: do not emit -Wunused-macros warnings in -frewrite-includes mode (PR15614) (authored by llunak). Changed prior to commit: https://reviews.llvm.org/D65371?vs=219370&id=220370#toc Repository

[PATCH] D67627: Clang-format: Add Whitesmiths indentation style

echristo added reviewers: mboehme, krasimir. echristo added a comment. Martin should know who should look at this... maybe Krasimir? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67627/new/ https://reviews.llvm.org/D67627 ___

[PATCH] D67590: Properly ignore mismatched exception specifiers in MSVC Compat mode.

rnk commandeered this revision. rnk edited reviewers, added: alexfusco; removed: rnk. rnk added a comment. Taking this to move the test around and try the other version... Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67590/new/ https://reviews.llvm.org/D67590

[PATCH] D67590: Properly ignore mismatched exception specifiers in MSVC Compat mode.

rnk updated this revision to Diff 220376. rnk added a comment. - move test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67590/new/ https://reviews.llvm.org/D67590 Files: clang/lib/Sema/SemaDecl.cpp clang/test/SemaCXX/ms-exception-spec.cpp I

[PATCH] D63508: make -frewrite-includes also rewrite conditions in #if/#elif

llunak updated this revision to Diff 220378. llunak added a comment. - updated to apply to current trunk - changed misleading condition in a test Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63508/new/ https://reviews.llvm.org/D63508 Files: clang/lib/Frontend

[PATCH] D67629: [clang-format] Fix C# breaking before function name when using Attributes

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: owenpan, klimek. MyDeveloperDay added a project: clang-tools-extra. Herald added a project: clang. This is a fix for https://bugs.llvm.org/show_bug.cgi?id=4 This comes with 3 main parts - C# attributes cause function name

[PATCH] D63508: make -frewrite-includes also rewrite conditions in #if/#elif

llunak added a comment. I've noticed that the Developer Policy says that it's actually allowed to commit patches without approval for parts "that you have contributed or maintain". Given that I'm the author of -rewrite-includes I take it that it's ok if I commit this if there are no further com

[PATCH] D67590: Properly ignore mismatched exception specifiers in MSVC Compat mode.

alexfusco added inline comments. Comment at: clang/test/SemaCXX/ms-exception-spec.cpp:2 +// RUN: %clang_cc1 -std=c++11 %s -fsyntax-only -verify -fms-compatibility -fexceptions -fcxx-exceptions +// RUN: %clang_cc1 -std=c++17 %s -fsyntax-only -verify -fms-compatibility -fexceptio

[PATCH] D59516: [analyzer] Add custom filter functions for GenericTaintChecker

boga95 updated this revision to Diff 220385. boga95 marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59516/new/ https://reviews.llvm.org/D59516 Files: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp clang/lib/StaticAnalyzer/Checkers/Taint.cpp

[PATCH] D67632: [libTooling] Introduce new library of source-code builders.

ymandel created this revision. ymandel added a reviewer: gribozavr. Herald added a subscriber: mgorny. Herald added a project: clang. Introduces facilities for easily building source-code strings, including idiomatic use of the address-of, dereference and member-access operators (dot and arrow) an

[PATCH] D67633: [libTooling] Add `access` and `ifBound` combinators to Stencil library.

ymandel created this revision. ymandel added a reviewer: gribozavr. Herald added a project: clang. ymandel added a parent revision: D67632: [libTooling] Introduce new library of source-code builders.. This revision add the `access` and `ifBound` combinators to the Stencil library: - `access` --

[PATCH] D67635: Fix for stringized function-macro args continued across lines

kousikk created this revision. kousikk added a reviewer: arphaman. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. In case of certain #define'd macros, there's a space just before line continuation that the minimized-source lexer was missing to include, resulting

[PATCH] D63508: make -frewrite-includes also rewrite conditions in #if/#elif

torarnv added a comment. Just for understanding what's going on here, I'm going to ask some stupid questions 😄 So, this will make `-frewrite-includes` do more work, to ensure that it not only covers the "top level" `#include` or `__has_include` case, but also `__has_include` in one or more lev

[PATCH] D66627: [clang-tidy] add checks to bugprone-posix-return

jcai19 updated this revision to Diff 220393. jcai19 added a comment. Thanks for the confirmation! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66627/new/ https://reviews.llvm.org/D66627 Files: clang-tools-extra/clang-tidy/bugprone/PosixReturnCh

[clang-tools-extra] r372037 - [clang-tidy] add checks to bugprone-posix-return

Author: jcai19 Date: Mon Sep 16 14:43:56 2019 New Revision: 372037 URL: http://llvm.org/viewvc/llvm-project?rev=372037&view=rev Log: [clang-tidy] add checks to bugprone-posix-return This check now also checks if any calls to pthread_* functions expect negative return values. These functions retu

[PATCH] D53768: Add VerboseOutputStream to CompilerInstance

scott.linder updated this revision to Diff 220396. scott.linder added a comment. Actually rebase this time CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53768/new/ https://reviews.llvm.org/D53768 Files: include/clang/Frontend/CompilerInstance.h lib/Frontend/CompilerInstance.cpp u

r372039 - [Modules][Objective-C] Use complete decl from module when diagnosing missing import

Author: bruno Date: Mon Sep 16 15:00:29 2019 New Revision: 372039 URL: http://llvm.org/viewvc/llvm-project?rev=372039&view=rev Log: [Modules][Objective-C] Use complete decl from module when diagnosing missing import Summary: Otherwise the definition (first found) for ObjCInterfaceDecl's might pr

[PATCH] D66982: [Modules][Objective-C] Use complete decl from module when diagnosing missing import

This revision was automatically updated to reflect the committed changes. Closed by commit rL372039: [Modules][Objective-C] Use complete decl from module when diagnosing missing… (authored by bruno, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pri

r372040 - [OPENMP]Fix the test, NFC.

Author: abataev Date: Mon Sep 16 15:17:10 2019 New Revision: 372040 URL: http://llvm.org/viewvc/llvm-project?rev=372040&view=rev Log: [OPENMP]Fix the test, NFC. Modified: cfe/trunk/test/OpenMP/parallel_for_codegen.cpp Modified: cfe/trunk/test/OpenMP/parallel_for_codegen.cpp URL: http://llvm

[PATCH] D67638: Improve __builtin_constant_p lowering

joerg created this revision. joerg added a reviewer: rsmith. Herald added subscribers: kristina, kbarton, nemanjai. Herald added a project: clang. Herald added a subscriber: wuzish. __builtin_constant_p used to be short-cut evaluated to false when building with -O0. This is undesirable as it mean

[PATCH] D67578: [clang-tidy] New check to warn when writing to a dispatch_once_t variable.

stephanemoore added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/misc-dispatch-once-assignment.rst:9 +and making such direct writes may potentially violate the run-once protections +intended by the library. Eugene.Zelenko wrote: > Does l

[PATCH] D67632: [libTooling] Introduce new library of source-code builders.

Eugene.Zelenko added inline comments. Comment at: clang/lib/Tooling/Refactoring/SourceCodeBuilders.cpp:77 + + if (Text.empty()) return std::string(); + // Add leading '*'. Could return {}. Same in other places. By the word, did you run Clang-format over code?

[PATCH] D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage

stephanemoore added a comment. In D67567#1670144 , @mwyman wrote: > In D67567#1670035 , @lebedev.ri > wrote: > > > In D67567#1670017 , @mwyman wrote: > > > > > In D67567#166

r372055 - [OPENMP] Fix the test, NFC

Author: abataev Date: Mon Sep 16 17:08:50 2019 New Revision: 372055 URL: http://llvm.org/viewvc/llvm-project?rev=372055&view=rev Log: [OPENMP] Fix the test, NFC Modified: cfe/trunk/test/OpenMP/parallel_for_codegen.cpp Modified: cfe/trunk/test/OpenMP/parallel_for_codegen.cpp URL: http://llvm

[PATCH] D65694: Properly instantiate a decltype in argument's default initializer

comex added a comment. Ping. I'm not qualified to review this myself but I'd like to see the bug fixed. :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65694/new/ https://reviews.llvm.org/D65694 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D38479: Make -mgeneral-regs-only more like GCC's

george.burgess.iv added a comment. Apologies for the latency of my updates. > Something I ran into when reviewing https://reviews.llvm.org/D62639 is that > on AArch64, for varargs functions, we emit floating-point stores when > noimplicitfloat is specified. That seems fine for -mno-implicit-flo

[PATCH] D38479: Make -mgeneral-regs-only more like GCC's

george.burgess.iv updated this revision to Diff 220416. george.burgess.iv marked 4 inline comments as done. george.burgess.iv added a reviewer: efriedma. george.burgess.iv added a comment. Chatted with Eli offline; updated here to reflect the conclusions of that. Importantly, this patch readds so

r372058 - Push lambda scope earlier when transforming lambda expression

Author: comex Date: Mon Sep 16 18:43:33 2019 New Revision: 372058 URL: http://llvm.org/viewvc/llvm-project?rev=372058&view=rev Log: Push lambda scope earlier when transforming lambda expression Differential Revision: https://reviews.llvm.org/D66067 Modified: cfe/trunk/lib/Sema/TreeTransform

[PATCH] D66067: Push lambda scope earlier when transforming lambda expression

This revision was automatically updated to reflect the committed changes. Closed by commit rL372058: Push lambda scope earlier when transforming lambda expression (authored by comex, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D66830: Consumed checker: various improvements

comex abandoned this revision. comex added a comment. Herald added a subscriber: dmgreen. Sounds good; I'll split this into a few separate patches. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66830/new/ https://reviews.llvm.org/D66830 ___

[PATCH] D65917: [clang-tidy] Added check for the Google style guide's category method naming rule.

stephanemoore requested changes to this revision. stephanemoore added inline comments. This revision now requires changes to proceed. Comment at: clang-tools-extra/clang-tidy/google/RequireCategoryMethodPrefixesCheck.cpp:23 + Finder->addMatcher(objcMethodDecl(hasDeclContext( +

[PATCH] D67647: [Consumed] Refactor handleCall to take function argument list. NFC.

comex created this revision. comex added a reviewer: dblaikie. Herald added subscribers: cfe-commits, dmgreen, kristof.beyls. Herald added a project: clang. Currently, `handleCall` takes a `CallExpr` as an argument and retrieves the arguments from there. This changes it to take the argument list

r372061 - Remove reliance on lax vector conversions from altivec.h in VSX mode.

Author: rsmith Date: Mon Sep 16 20:56:26 2019 New Revision: 372061 URL: http://llvm.org/viewvc/llvm-project?rev=372061&view=rev Log: Remove reliance on lax vector conversions from altivec.h in VSX mode. Modified: cfe/trunk/lib/Headers/altivec.h cfe/trunk/test/CodeGen/altivec-ct.c cfe/

r372063 - Fix reliance on -flax-vector-conversions in AVX intrinsics headers and

Author: rsmith Date: Mon Sep 16 20:56:30 2019 New Revision: 372063 URL: http://llvm.org/viewvc/llvm-project?rev=372063&view=rev Log: Fix reliance on -flax-vector-conversions in AVX intrinsics headers and corresponding tests. Modified: cfe/trunk/lib/Headers/avx512fintrin.h cfe/trunk/test/C

r372062 - Fix reliance on lax vector conversions in tests for x86 intrinsics.

Author: rsmith Date: Mon Sep 16 20:56:28 2019 New Revision: 372062 URL: http://llvm.org/viewvc/llvm-project?rev=372062&view=rev Log: Fix reliance on lax vector conversions in tests for x86 intrinsics. Modified: cfe/trunk/test/CodeGen/const-init.c cfe/trunk/test/CodeGen/ppc-smmintrin.c

  1   2   >