This revision was automatically updated to reflect the committed changes.
Closed by commit rL371969: Change signature of __builtin_rotateright64 back to
unsigned (authored by karka, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D67606?vs=220294&id=220300#toc
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67606/new/
https://reviews.llvm.org/D67606
Files:
cfe/trunk/include/clang/Basic/Builtins.def
cfe/trunk/test/CodeGen/avr-builtins.c
Index: cfe/trunk/include/clang/Basic/Builtins.def
===================================================================
--- cfe/trunk/include/clang/Basic/Builtins.def
+++ cfe/trunk/include/clang/Basic/Builtins.def
@@ -461,7 +461,7 @@
BUILTIN(__builtin_rotateright8, "UcUcUc", "nc")
BUILTIN(__builtin_rotateright16, "UsUsUs", "nc")
BUILTIN(__builtin_rotateright32, "UZiUZiUZi", "nc")
-BUILTIN(__builtin_rotateright64, "UWiUWiWi", "nc")
+BUILTIN(__builtin_rotateright64, "UWiUWiUWi", "nc")
// Random GCC builtins
BUILTIN(__builtin_constant_p, "i.", "nctu")
Index: cfe/trunk/test/CodeGen/avr-builtins.c
===================================================================
--- cfe/trunk/test/CodeGen/avr-builtins.c
+++ cfe/trunk/test/CodeGen/avr-builtins.c
@@ -1,5 +1,9 @@
// RUN: %clang_cc1 -triple avr-unknown-unknown -emit-llvm -o - %s | FileCheck
%s
+// Check that the parameter types match. This verifies pr43309.
+// RUN: %clang_cc1 -triple avr-unknown-unknown -Wconversion -verify %s
+// expected-no-diagnostics
+
unsigned char bitrev8(unsigned char data) {
return __builtin_bitreverse8(data);
}
Index: cfe/trunk/include/clang/Basic/Builtins.def
===================================================================
--- cfe/trunk/include/clang/Basic/Builtins.def
+++ cfe/trunk/include/clang/Basic/Builtins.def
@@ -461,7 +461,7 @@
BUILTIN(__builtin_rotateright8, "UcUcUc", "nc")
BUILTIN(__builtin_rotateright16, "UsUsUs", "nc")
BUILTIN(__builtin_rotateright32, "UZiUZiUZi", "nc")
-BUILTIN(__builtin_rotateright64, "UWiUWiWi", "nc")
+BUILTIN(__builtin_rotateright64, "UWiUWiUWi", "nc")
// Random GCC builtins
BUILTIN(__builtin_constant_p, "i.", "nctu")
Index: cfe/trunk/test/CodeGen/avr-builtins.c
===================================================================
--- cfe/trunk/test/CodeGen/avr-builtins.c
+++ cfe/trunk/test/CodeGen/avr-builtins.c
@@ -1,5 +1,9 @@
// RUN: %clang_cc1 -triple avr-unknown-unknown -emit-llvm -o - %s | FileCheck %s
+// Check that the parameter types match. This verifies pr43309.
+// RUN: %clang_cc1 -triple avr-unknown-unknown -Wconversion -verify %s
+// expected-no-diagnostics
+
unsigned char bitrev8(unsigned char data) {
return __builtin_bitreverse8(data);
}
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
