[PATCH] D67420: [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions.

gribozavr added a comment. `PathDiagnosticConsumerOptions` is pretty lightweight, and is not passed around in hot paths if I understand correctly. What do you think about passing it by value everywhere? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67420/new/ https://reviews.llvm.org/

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

gribozavr added inline comments. Comment at: clang/include/clang/Analysis/PathDiagnosticConsumers.def:23 +ANALYSIS_DIAGNOSTICS(PLIST_HTML, "plist-html", "Output analysis results using HTML wrapped with Plists", createPlistHTMLDiagnosticConsumer) +ANALYSIS_DIAGNOSTICS(SARIF, "sar

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

JonChesterfield added a comment. > Hm, I was not aware of this Linux linker feature, thanks a lot for the > explanation! I see only one problem with using it as a replacement for the > begin/end objects – it looks like `__start_name`/`__stop_name` symbols are > created with `default` visibility

[PATCH] D67421: [analyzer] NFC: Move IssueHash to libAnalysis.

gribozavr added inline comments. Comment at: clang/include/clang/Analysis/IssueHash.h:18 /// Get an MD5 hash to help identify bugs. /// Returns an opaque identifier for a diagnostic. This opaque identifier is intended to be stable even when the source code i

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

JonChesterfield added a comment. I'm on board with getting rid of the linker script. Gold's limited support for that seems conclusive. I believe the current script does two things: 1/ takes a binary and embeds it in a section named .omp_offloading.amdgcn-amd-amdhsa 2/ provides start/end symbols

[PATCH] D67452: [clang] [unittest] Import LLVMTestingSupport if necessary

gribozavr accepted this revision. gribozavr added a comment. This revision is now accepted and ready to land. Thanks for the fix! I'm not a fan of the complexity that standalone builds create, but if we are supporting them... oh well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67452/

[PATCH] D56661: [clang-tidy] Fix incorrect array name generation in cppcoreguidelines-pro-bounds-constant-array-index

JonasToth added a comment. Sorry for the long delay! I have one question about a slighty different code constellation. std::optional> my_array; for(int i = 0; i < 42; ++i) (*my_array)[i] = 42; Will this be fixed properly? for(int i = 0; i < 42; ++i) gsl::at(*my_array, i) =

r371719 - [clang-format] Add new style option IndentGotoLabels

Author: paulhoad Date: Thu Sep 12 03:07:14 2019 New Revision: 371719 URL: http://llvm.org/viewvc/llvm-project?rev=371719&view=rev Log: [clang-format] Add new style option IndentGotoLabels Summary: This option determines whether goto labels are indented according to scope. Setting this option to

[PATCH] D67037: [ClangFormat] Add new style option IndentGotoLabels

This revision was automatically updated to reflect the committed changes. Closed by commit rL371719: [clang-format] Add new style option IndentGotoLabels (authored by paulhoad, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:

[PATCH] D63932: [GlobalDCE] Dead Virtual Function Elimination

ostannard added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63932/new/ https://reviews.llvm.org/D63932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

r371720 - [clang-format] [PR43100] clang-format C# support does not add a space between "using" and paren

Author: paulhoad Date: Thu Sep 12 03:18:53 2019 New Revision: 371720 URL: http://llvm.org/viewvc/llvm-project?rev=371720&view=rev Log: [clang-format] [PR43100] clang-format C# support does not add a space between "using" and paren Summary: Addresses https://bugs.llvm.org/show_bug.cgi?id=43100

[PATCH] D66662: [clang-format] [PR43100] clang-format C# support does not add a space between "using" and paren

This revision was automatically updated to reflect the committed changes. Closed by commit rL371720: [clang-format] [PR43100] clang-format C# support does not add a space between… (authored by paulhoad, committed by ). Herald added a project: LLVM. Changed prior to commit: https://reviews.llvm

Re: r371663 - Start porting ivfsoverlay tests to Windows

Hi Reid, On Wed, Sep 11, 2019 at 9:55 PM Reid Kleckner via cfe-commits wrote: > +// XFAIL: windows Looks like this should be system-windows, the PS4 buildbots [0] have a windows host but target x86_64-scei-ps4, and croak on this change. Assuming no-one else is looking at this, I'll commit a fix

[PATCH] D67409: [RISCV] enable LTO support, pass some options to linker.

lenary added a comment. Can you add a test for `riscv64-unknown-linux-gnu`? I think RISCVToolchain.cpp is only used by the `riscv64-unknown-elf` target, but I could be wrong. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67409/new/ https://reviews.llvm.org/D6740

r371723 - Removed dead code from DiagnosticBuilder

Author: gribozavr Date: Thu Sep 12 03:39:53 2019 New Revision: 371723 URL: http://llvm.org/viewvc/llvm-project?rev=371723&view=rev Log: Removed dead code from DiagnosticBuilder Modified: cfe/trunk/include/clang/Basic/Diagnostic.h Modified: cfe/trunk/include/clang/Basic/Diagnostic.h URL: htt

[PATCH] D67490: [Clang][ASTImporter] Added visibility check for FunctionTemplateDecl.

balazske created this revision. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp. Herald added a reviewer: martong. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. ASTImporter makes now difference between function templates wit

[PATCH] D64146: [Clang Interpreter] Initial patch for the constexpr interpreter

RKSimon added a comment. Thanks - this builds cleanly on MSVC now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64146/new/ https://reviews.llvm.org/D64146 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D64146: [Clang Interpreter] Initial patch for the constexpr interpreter

nand added a comment. Thanks for looking into the problem - sorry for the delay! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64146/new/ https://reviews.llvm.org/D64146 ___ cfe-commits mailing list cf

r371726 - Switch "windows" to "system-windows" in some XFAILs

Author: jmorse Date: Thu Sep 12 04:19:12 2019 New Revision: 371726 URL: http://llvm.org/viewvc/llvm-project?rev=371726&view=rev Log: Switch "windows" to "system-windows" in some XFAILs The test failure mode appears to be due to the host machine rather than the target. The PS4 buildbots are window

[PATCH] D67491: Removed some questionable default arguments from setters

gribozavr created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. They can be confusing -- what does it mean to call a setter without a value? Also, some setters, like `setPrintTemplateTree` had `false` as the default value! The callers are largely not using

Re: r371663 - Start porting ivfsoverlay tests to Windows

On Thu, Sep 12, 2019 at 11:24 AM Jeremy Morse wrote: > Assuming no-one else is looking at this, I'll commit a fix in ~30 mins. r371726 -- Thanks, Jeremy ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D67460: clang-tidy: modernize-use-using work with multi-argument templates

jonathanmeier added a comment. Unfortunately, only considering parenthesis (`l_paren`, `r_paren`) is not sufficient. We need to consider all the nesting tokens, including brackets (`l_square`, `r_square`) and braces (`l_brace`, `r_brace`), since the Standard says (C++ 17 Draft N4659, Section 17

r371731 - Removed some questionable default arguments from setters

Author: gribozavr Date: Thu Sep 12 05:16:43 2019 New Revision: 371731 URL: http://llvm.org/viewvc/llvm-project?rev=371731&view=rev Log: Removed some questionable default arguments from setters Summary: They can be confusing -- what does it mean to call a setter without a value? Also, some setters

[PATCH] D67460: clang-tidy: modernize-use-using work with multi-argument templates

jonathanmeier added a comment. Also note that your enhanced version of my first example actually works with your initial patch, since the two comparison operators cancel each other out in the counting logic. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D67491: Removed some questionable default arguments from setters

This revision was automatically updated to reflect the committed changes. Closed by commit rL371731: Removed some questionable default arguments from setters (authored by gribozavr, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: h

[PATCH] D67091: Fix for headers having the same name as a directory

kousikk updated this revision to Diff 219891. kousikk added a comment. - Add validation inside the createFile() function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67091/new/ https://reviews.llvm.org/D67091 Files: clang/include/clang/Tooling/

[PATCH] D67091: Fix for headers having the same name as a directory

kousikk updated this revision to Diff 219890. kousikk added a comment. - Add validation inside the createFile() function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67091/new/ https://reviews.llvm.org/D67091 Files: clang/include/clang/Tooling/

[PATCH] D67066: [RISCV] Add option aliases: -mcmodel=medany and -mcmodel=medlow

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. Looks good to me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67066/new/ https://reviews.llvm.org/D67066 __

r371733 - [clang] [unittest] Import LLVMTestingSupport if necessary

Author: mgorny Date: Thu Sep 12 06:06:12 2019 New Revision: 371733 URL: http://llvm.org/viewvc/llvm-project?rev=371733&view=rev Log: [clang] [unittest] Import LLVMTestingSupport if necessary Add LLVMTestingSupport directory from LLVM_MAIN_SRC_DIR when building clang stand-alone and LLVMTestingSup

[PATCH] D67452: [clang] [unittest] Import LLVMTestingSupport if necessary

mgorny added a comment. Thanks. Could you also ack the backport in https://bugs.llvm.org/show_bug.cgi?id=43281? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67452/new/ https://reviews.llvm.org/D67452 ___ cfe-commits mailing list cfe-commi

[PATCH] D67452: [clang] [unittest] Import LLVMTestingSupport if necessary

This revision was automatically updated to reflect the committed changes. Closed by commit rL371733: [clang] [unittest] Import LLVMTestingSupport if necessary (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: htt

[PATCH] D67496: [clangd] Collect macros in the preamble region of the main file

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: kadircet, arphaman, mgrang, jkorous, MaskRay. Herald added a project: clang. - store all macro references in the ParsedAST, which also helps to implement find references for macros. - unify the two var

[PATCH] D65744: [PR42707][OpenCL] Fix addr space deduction for auto

Anastasia updated this revision to Diff 219903. Anastasia added a comment. - Move addr space deduction to a later phase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65744/new/ https://reviews.llvm.org/D65744 Files: clang/include/clang/AST/Type.h clang/include/clang/Sema/Sema.h

[PATCH] D64695: [clang-format] Modified SortIncludes and IncludeCategories to priority for sorting #includes within the Group Category.

MyDeveloperDay added a comment. Does this need landing? given that you have a number of patches in flight perhaps it would be good to request commit access Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64695/new/ https://reviews.llvm.org/D64695 __

[PATCH] D67496: [clangd] Collect macros in the preamble region of the main file

hokein updated this revision to Diff 219904. hokein added a comment. some cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67496/new/ https://reviews.llvm.org/D67496 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-tools-extra/clang

[PATCH] D64695: [clang-format] Modified SortIncludes and IncludeCategories to priority for sorting #includes within the Group Category.

Manikishan added a comment. >>! In D64695#1667696 , >>@MyDeveloperDay wrote: > Does this need landing? given that you have a number of patches in flight > perhaps it would be good to request commit access Yes, it would be good if it is landed. And can I

[PATCH] D65744: [PR42707][OpenCL] Fix addr space deduction for auto

Anastasia marked 2 inline comments as done. Anastasia added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:5998 +QualType Type = Var->getType(); +if (Type->isSamplerT() || Type->isVoidType()) + return; I don't seem to need a check for depen

[PATCH] D64695: [clang-format] Modified SortIncludes and IncludeCategories to priority for sorting #includes within the Group Category.

MyDeveloperDay added a comment. > Yes, it would be good if it is landed. And can I know the procedure for > getting commit access https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64695/new/ https

[PATCH] D67499: [Alignment] Move OffsetToAlignment to Alignment.h

gchatelet created this revision. gchatelet added a reviewer: courbet. Herald added subscribers: llvm-commits, cfe-commits, seiya, jsji, atanasyan, MaskRay, jrtc27, jakehehrlich, kbarton, hiraditya, nemanjai, sdardis. Herald added a reviewer: JDevlieghere. Herald added a reviewer: alexshap. Herald

[PATCH] D67091: Fix for headers having the same name as a directory

kousikk updated this revision to Diff 219917. kousikk added a comment. - Add tests and remove the fix inside createFile since it fails in other cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67091/new/ https://reviews.llvm.org/D67091 Files:

[PATCH] D67091: Fix for headers having the same name as a directory

kousikk updated this revision to Diff 219918. kousikk added a comment. - Add validation inside the createFile() function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67091/new/ https://reviews.llvm.org/D67091 Files: clang/include/clang/Tooling/

[PATCH] D67091: Fix for headers having the same name as a directory

kousikk added a comment. Sorry about the delay on this - I was OOO (back now). 1. I added tests. 2. I couldn't add isDirectory() check to createFile() since that resulted in failures to normal scenarios where it was previously passing. PTAL! Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D67501: [clang-tidy] Fix relative path in header-filter.

xyb created this revision. xyb added a reviewer: alexfh. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Clang-tidy supports output diagnostics from header files if user specifies --header-filter. But it can't handle relative path well. For example, the folder stru

[PATCH] D67499: [Alignment] Move OffsetToAlignment to Alignment.h

courbet added inline comments. Comment at: llvm/lib/Target/ARM/ARMConstantIslandPass.cpp:1024 NextBlockOffset = BBInfo[Water->getNumber()].postOffset(); -NextBlockLogAlignment = 0; +NextBlockAlignment = llvm::Align(); } else { this statement is no

[PATCH] D67499: [Alignment] Move OffsetToAlignment to Alignment.h

gchatelet updated this revision to Diff 219923. gchatelet marked an inline comment as done. gchatelet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67499/new/ https://reviews.llvm.org/D67499 Files: clang/lib/A

[PATCH] D67499: [Alignment] Move OffsetToAlignment to Alignment.h

This revision was automatically updated to reflect the committed changes. Closed by commit rL371742: [Alignment] Move OffsetToAlignment to Alignment.h (authored by gchatelet, committed by ). Herald added a subscriber: kristina. Changed prior to commit: https://reviews.llvm.org/D67499?vs=219923&

r371742 - [Alignment] Move OffsetToAlignment to Alignment.h

Author: gchatelet Date: Thu Sep 12 08:20:36 2019 New Revision: 371742 URL: http://llvm.org/viewvc/llvm-project?rev=371742&view=rev Log: [Alignment] Move OffsetToAlignment to Alignment.h Summary: This is patch is part of a series to introduce an Alignment type. See this thread for context: http:/

[PATCH] D52524: Add -Wpoison-system-directories warning

denik updated this revision to Diff 219924. denik added a comment. Combined two if into one. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52524/new/ https://reviews.llvm.org/D52524 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/lib/Frontend/InitHeaderSearch.cpp

[PATCH] D52524: Add -Wpoison-system-directories warning

denik marked 2 inline comments as done. denik added inline comments. Comment at: clang/lib/Frontend/InitHeaderSearch.cpp:141-143 + if (HasSysroot) { +if (MappedPathStr.startswith("/usr/include") || +MappedPathStr.startswith("/usr/local/include")) { a

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

sdmitriev added a comment. In D64943#1667469 , @JonChesterfield wrote: > I'm on board with getting rid of the linker script. Gold's limited support > for that seems conclusive. > > I believe the current script does two things: > 1/ takes a binary and em

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

JonChesterfield added a comment. >> Does this diff mix getting rid of the linker script with other changes? E.g. >> it looks like the metadata generation is moving from clang to the new tool, >> but that seems orthogonal to dropping the linker script. > > Metadata is still generated by the clan

[PATCH] D67409: [RISCV] enable LTO support, pass some options to linker.

khchen updated this revision to Diff 219941. khchen added a comment. @lenary Yes, you are right. add LTO support for Linux platform. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67409/new/ https://reviews.llvm.org/D67409 Files: clang/lib/Driver/ToolChains/Arch/RISCV.cpp clang/lib/

[PATCH] D67409: [RISCV] enable LTO support, pass some options to linker.

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:387 + +void riscv::addGoldOptions(const ToolChain &ToolChain, + const llvm::opt::ArgList &Args, gold doesn't support RISC-V, does it? CHANGES SINCE L

[PATCH] D67368: [NFCI]Create CommonAttributeInfo Type as base type of *Attr and ParsedAttr.

erichkeane marked an inline comment as done. erichkeane added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2266 let Spellings = [CXX11<"", "maybe_unused", 201603>, GCC<"unused">, - C2x<"", "maybe_unused">]; + C2x<"", "maybe

[PATCH] D67420: [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions.

Szelethus added a comment. In D67420#1666578 , @NoQ wrote: > In D67420#1666141 , @Szelethus wrote: > > > I do! > > > Hmm, it sounds like you want to force both Clang frontend and Clang-Tidy to > use the same set of

[PATCH] D64146: [Clang Interpreter] Initial patch for the constexpr interpreter

RKSimon added a comment. In D64146#1667567 , @nand wrote: > Thanks for looking into the problem - sorry for the delay! No problem, you still need a specialist to approve the patch though Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

r371749 - Don't warn about selectany on implicitly inline variables

Author: rnk Date: Thu Sep 12 10:55:48 2019 New Revision: 371749 URL: http://llvm.org/viewvc/llvm-project?rev=371749&view=rev Log: Don't warn about selectany on implicitly inline variables Summary: This avoids a -Wignored-attribute warning on the code pattern Microsoft recommends for integral cons

[PATCH] D67426: Don't warn about selectany on implicitly inline variables

This revision was automatically updated to reflect the committed changes. Closed by commit rGb00a49d1b3a1: Don't warn about selectany on implicitly inline variables (authored by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67426/new/ https://

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

sdmitriev added a comment. In D64943#1668006 , @JonChesterfield wrote: > >> Does this diff mix getting rid of the linker script with other changes? > >> E.g. it looks like the metadata generation is moving from clang to the new > >> tool, but that seems

r371751 - [clang-scan-deps] remove dots and dots dots from the reported file dependency paths

Author: arphaman Date: Thu Sep 12 11:03:24 2019 New Revision: 371751 URL: http://llvm.org/viewvc/llvm-project?rev=371751&view=rev Log: [clang-scan-deps] remove dots and dots dots from the reported file dependency paths This resolves differences observed on LLVM + Clang when running the compariso

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

JonChesterfield added a comment. > I see some problems with using llvm-objcopy for that. First issue is that > symbols created by llvm-objcopy for embedded data depend on the input file > name. As you know these symbols are referenced from the offload registration > code that is currently added

Re: r371663 - Start porting ivfsoverlay tests to Windows

Thanks, that seems like the correct fix. The property that makes them fail is the native system path style, not the default target. On Thu, Sep 12, 2019 at 5:03 AM Jeremy Morse wrote: > On Thu, Sep 12, 2019 at 11:24 AM Jeremy Morse > wrote: > > Assuming no-one else is looking at this, I'll comm

r371753 - [MS] Warn when shadowing template parameters under -fms-compatibility

Author: rnk Date: Thu Sep 12 11:26:34 2019 New Revision: 371753 URL: http://llvm.org/viewvc/llvm-project?rev=371753&view=rev Log: [MS] Warn when shadowing template parameters under -fms-compatibility Summary: C++ does not allow shadowing template parameters, but previously we allowed it under -fm

[PATCH] D67509: [CUDA][HIP] Diagnose defaulted constructor only if it is used

yaxunl created this revision. yaxunl added reviewers: tra, rjmccall. Clang infers defaulted ctor as `__device__ __host__` and virtual dtor as `__host__`. It diagnose the following code in device compilation as B() references ~A() implicitly. struct A { virtual ~A(); }; struct B: public A

[PATCH] D67463: [MS] Warn when shadowing template parameters under -fms-compatibility

This revision was automatically updated to reflect the committed changes. Closed by commit rL371753: [MS] Warn when shadowing template parameters under -fms-compatibility (authored by rnk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to comm

[PATCH] D67460: clang-tidy: modernize-use-using work with multi-argument templates

poelmanc updated this revision to Diff 219957. poelmanc added a comment. Thanks for the stressing test cases. I reverted to your original test case with a single >, added a separate one with a single <, and expanded the final case to have a non-balanced number of > and <. I added all your new ca

[PATCH] D67091: Fix for headers having the same name as a directory

arphaman added a subscriber: jkorous. arphaman added a comment. In D67091#1667821 , @kousikk wrote: > Sorry about the delay on this - I was OOO (back now). > > 1. I added tests. > 2. I couldn't add isDirectory() check to createFile() since that resulted in

r371756 - [analyzer] Don't run the analyzer for -analyzer-list-enabled-checkers

Author: szelethus Date: Thu Sep 12 11:53:48 2019 New Revision: 371756 URL: http://llvm.org/viewvc/llvm-project?rev=371756&view=rev Log: [analyzer] Don't run the analyzer for -analyzer-list-enabled-checkers Short and sweet. Whenever I use -analyzer-list-enabled-checkers, I'm only interested about

[PATCH] D66981: Fix driver tests when `LLVM_ENABLE_PER_TARGET_RUNTIME_DIR` is `ON`

broadwaylamb added a comment. In D66981#1651897 , @phosek wrote: > LGTM Can you please commit this? I don't have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66981/new/ https://reviews.llv

[PATCH] D66714: [analyzer] Don't run the analyzer for -analyzer-list-enabled-checkers

This revision was automatically updated to reflect the committed changes. Closed by commit rL371756: [analyzer] Don't run the analyzer for -analyzer-list-enabled-checkers (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior t

r371759 - NFC, add missing cl::cat option category to clang-scan-deps options to ensure they show up in -help

Author: arphaman Date: Thu Sep 12 12:00:32 2019 New Revision: 371759 URL: http://llvm.org/viewvc/llvm-project?rev=371759&view=rev Log: NFC, add missing cl::cat option category to clang-scan-deps options to ensure they show up in -help Modified: cfe/trunk/tools/clang-scan-deps/ClangScanDeps.c

r371760 - [analyzer][NFC] Fix inconsistent references to checkers as "checks"

Author: szelethus Date: Thu Sep 12 12:09:24 2019 New Revision: 371760 URL: http://llvm.org/viewvc/llvm-project?rev=371760&view=rev Log: [analyzer][NFC] Fix inconsistent references to checkers as "checks" Traditionally, clang-tidy uses the term check, and the analyzer uses checker, but in the very

[PATCH] D67140: [analyzer][NFC] Fix inconsistent references to checkers as "checks"

This revision was automatically updated to reflect the committed changes. Closed by commit rL371760: [analyzer][NFC] Fix inconsistent references to checkers as "checks" (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D67509: [CUDA][HIP] Diagnose defaulted constructor only if it is used

tra added a comment. Example of the actual error produced by clang: https://godbolt.org/z/Dl1FfC Ugh. Another corner case of the way we're dealing with implicit `__host__ __device__` functions. :-( LGTM for postponing the error until actual use. Comment at: test/SemaCUDA/defa

[PATCH] D67091: Fix for headers having the same name as a directory

kousikk updated this revision to Diff 219975. kousikk added a comment. - Add validation inside the createFile() function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67091/new/ https://reviews.llvm.org/D67091 Files: clang/include/clang/Tooling/

[PATCH] D67515: [Sema][Typo Correction] Fix potential infite loop on ambiguity checks

dgoldman created this revision. dgoldman added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes a bug introduced in D62648 , where Clang could infinite loop if it became stuck on a single TypoCorrection when it

[PATCH] D67091: Fix for headers having the same name as a directory

kousikk updated this revision to Diff 219976. kousikk added a comment. - Add validation inside the createFile() function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67091/new/ https://reviews.llvm.org/D67091 Files: clang/include/clang/Tooling/

[PATCH] D67091: Fix for headers having the same name as a directory

kousikk added a comment. > I was unable to reproduce the failures when I moved the check to createFile. > What kind of failures did you see? Did you move it right to the start of the > function? I would recommend rebasing the patch and retrying. I saw an assertion error - but I realize now that

[PATCH] D67515: [Sema][Typo Correction] Fix potential infite loop on ambiguity checks

dgoldman updated this revision to Diff 219978. dgoldman added a comment. - Fix method name in test Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67515/new/ https://reviews.llvm.org/D67515 Files: lib/Sema/SemaExprCXX.cpp test/Sema/typo-correction-ambiguity.cp

r371765 - [CFG] Add dumps for CFGElement and CFGElementRef

Author: szelethus Date: Thu Sep 12 12:52:34 2019 New Revision: 371765 URL: http://llvm.org/viewvc/llvm-project?rev=371765&view=rev Log: [CFG] Add dumps for CFGElement and CFGElementRef Seems like we never had these, so here we go! I also did some refactoring as I was chasing a bug unrelated to th

[PATCH] D66715: [CFG] Add dumps for CFGElement and CFGElementRef

This revision was automatically updated to reflect the committed changes. Closed by commit rL371765: [CFG] Add dumps for CFGElement and CFGElementRef (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

r371766 - [Clang][CodeGen] support alias attribute w/ gnu_inline

Author: nickdesaulniers Date: Thu Sep 12 12:53:35 2019 New Revision: 371766 URL: http://llvm.org/viewvc/llvm-project?rev=371766&view=rev Log: [Clang][CodeGen] support alias attribute w/ gnu_inline Summary: r369705 did not consider the addition of gnu_inline on function declarations of alias attri

[PATCH] D67455: [Clang][CodeGen] support alias attribute w/ gnu_inline

This revision was automatically updated to reflect the committed changes. Closed by commit rL371766: [Clang][CodeGen] support alias attribute w/ gnu_inline (authored by nickdesaulniers, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r371767 - Improve code generation for thread_local variables:

Author: rsmith Date: Thu Sep 12 13:00:24 2019 New Revision: 371767 URL: http://llvm.org/viewvc/llvm-project?rev=371767&view=rev Log: Improve code generation for thread_local variables: Summary: * Don't bother using a thread wrapper when the variable is known to have constant initialization.

[PATCH] D59516: [analyzer] Add custom filter functions for GenericTaintChecker

boga95 updated this revision to Diff 219981. boga95 marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59516/new/ https://reviews.llvm.org/D59516 Files: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp clang/lib/StaticAnalyzer/Checkers/Taint.cpp

[PATCH] D67429: Improve code generation for thread_local variables:

This revision was automatically updated to reflect the committed changes. Closed by commit rL371767: Improve code generation for thread_local variables: (authored by rsmith, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

[PATCH] D67135: [clang-tidy] performance-inefficient-vector-operation: Support proto repeated field

congliu updated this revision to Diff 219988. congliu marked an inline comment as done. congliu added a comment. Addressed Haojian's comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67135/new/ https://reviews.llvm.org/D67135 Files: clang-tools-extra/clang-tidy/performance/Ineff

[PATCH] D67460: clang-tidy: modernize-use-using work with multi-argument templates

jonathanmeier added a comment. Thanks, this looks much better now. I think there's no need to track nesting of parenthesis, brackets and braces separately, so we can collapse `ParenLevel`, `BraceLevel` and `SquareBracketLevel` into a single `NestingLevel`, which simplifies all the conditions qu

[PATCH] D59516: [analyzer] Add custom filter functions for GenericTaintChecker

NoQ added a comment. I'd like the test cases to actually demonstrate the correct use of the filters and the correct behavior of the Analyzer when the filters are annotated correctly, but it looks to me that they either demonstrate behavior when the annotation is //not// used correctly, or we di

[PATCH] D67516: [clang] Enable GNU Toolchain to find musl GCC installations

staticfloat created this revision. staticfloat added reviewers: rsmith, fedor.sergeev. staticfloat added a project: clang. Herald added a subscriber: cfe-commits. The GNU Toolchain GCCDetector misses GCC installations with the triplet `x86_64-linux-musl`, looking only instead for `x86_64-unknown-

[PATCH] D62731: [RFC] Add support for options -frounding-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc added a comment. In D62731#1663748 , @rjmccall wrote: > Hmm, you know, there are enough different FP options that I think we should > probably split them all out into their own section in the manual instead of > just listing them under "code gene

[PATCH] D67414: [AST] Treat "inline gnu_inline" the same way as "extern inline gnu_inline" in C++ mode

nickdesaulniers added inline comments. Comment at: lib/AST/Decl.cpp:3283 if (Context.getLangOpts().CPlusPlus) return false; I would have thought the existing case here would handle your change. If it doesn't, why not? Should your change also remove t

[PATCH] D67414: [AST] Treat "inline gnu_inline" the same way as "extern inline gnu_inline" in C++ mode

mstorsjo marked 2 inline comments as done. mstorsjo added inline comments. Comment at: lib/AST/Decl.cpp:3283 if (Context.getLangOpts().CPlusPlus) return false; nickdesaulniers wrote: > I would have thought the existing case here would handle your change

[PATCH] D67409: [RISCV] enable LTO support, pass some options to linker.

kito-cheng added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:387 + +void riscv::addGoldOptions(const ToolChain &ToolChain, + const llvm::opt::ArgList &Args, MaskRay wrote: > gold doesn't support RISC-V, does i

[PATCH] D67414: [AST] Treat "inline gnu_inline" the same way as "extern inline gnu_inline" in C++ mode

rsmith added a comment. Seems very surprising to me that the `gnu_inline` attribute has different behavior in their C and C++ frontends. That said, it looks like it's a behavior that they document; their documentation says "In C++, this attribute does not depend on extern in any way, but it sti

[PATCH] D67420: [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions.

NoQ added a comment. In D67420#1668099 , @Szelethus wrote: > ...and the second is similar in nature, but in the actual code -- it doesn't > doesn't feel natural to me that `AnalyzerOptions` is required to construct > this, while at the same time we're tr

[PATCH] D67414: [AST] Treat "inline gnu_inline" the same way as "extern inline gnu_inline" in C++ mode

mstorsjo added a comment. In D67414#1668443 , @rsmith wrote: > Seems very surprising to me that the `gnu_inline` attribute has different > behavior in their C and C++ frontends. That said, it looks like it's a > behavior that they document; their documen

[clang-tools-extra] r371773 - [ClangTidy] Adjust the name getCheckName to getCheckerName due to API change.

Author: timshen Date: Thu Sep 12 14:18:44 2019 New Revision: 371773 URL: http://llvm.org/viewvc/llvm-project?rev=371773&view=rev Log: [ClangTidy] Adjust the name getCheckName to getCheckerName due to API change. Modified: clang-tools-extra/trunk/clang-tidy/ClangTidy.cpp Modified: clang-tools

[PATCH] D67420: [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions.

Szelethus added a comment. In D67420#1668474 , @NoQ wrote: > It's not that `AnalyzerOptions` is //necessary// to construct this, it's more > like //sufficient//. *sudden enlightenment* Ah, okay, right, I'm a dummie, I think I got what's happening here!

[PATCH] D67140: [analyzer][NFC] Fix inconsistent references to checkers as "checks"

NoQ added a subscriber: timshen. NoQ added a comment. rL371773 - thanks @timshen! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67140/new/ https://reviews.llvm.org/D67140 ___ cfe-co

  1   2   >