arphaman added a subscriber: jkorous. arphaman added a comment. In D67091#1667821 <https://reviews.llvm.org/D67091#1667821>, @kousikk wrote:
> Sorry about the delay on this - I was OOO (back now). > > 1. I added tests. > 2. I couldn't add isDirectory() check to createFile() since that resulted in > failures to normal scenarios where it was previously passing. > > PTAL! I was unable to reproduce the failures when I moved the check to `createFile`. What kind of failures did you see? Did you move it right to the start of the function? I would recommend rebasing the patch and retrying. Also, could you please rename `headerwithdirname.cpp` to `headerwithdirname_input.cpp` when copying it to ensure FileCheck can match the filename without matching the temporary path (see https://reviews.llvm.org/D67379 for test fixes that @jkorous applied). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67091/new/ https://reviews.llvm.org/D67091 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
